sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Embeds: Adjust the iframe title attribute for improved accessibility.

Browse Source 
Changes the title attribute from `Embedded WordPress Post` to `"Post name" — site title`.

Props ramiy.
Fixes #35804.

git-svn-id: https://develop.svn.wordpress.org/trunk@36873 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Pascal Birchler 2016-03-07 09:59:02 +00:00
parent e9dbf32553
commit afdf1c9ec1
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/wp-includes/embed.php
View File

@ -490,7 +490,14 @@ JS;
esc_url( $embed_url ), esc_url( $embed_url ),
absint( $width ), absint( $width ),
absint( $height ), absint( $height ),
esc_attr__( 'Embedded WordPress Post' ) esc_attr(
sprintf(
/* translators: 1: post title, 2: site name */
__( '“%1$s” — %2$s' ),
get_the_title( $post ),
get_bloginfo( 'name' )
)
)
); );
/** /**

9
tests/phpunit/tests/oembed/template.php
View File

@ -242,8 +242,15 @@ class Tests_Embed_Template extends WP_UnitTestCase {
function test_get_post_embed_html() { function test_get_post_embed_html() {
$post_id = self::factory()->post->create(); $post_id = self::factory()->post->create();
$title = esc_attr(
sprintf(
__( '“%1$s” — %2$s' ),
get_the_title( $post_id ),
get_bloginfo( 'name' )
)
);
$expected = '<iframe sandbox="allow-scripts" security="restricted" src="' . esc_url( get_post_embed_url( $post_id ) ) . '" width="200" height="200" title="Embedded WordPress Post" frameborder="0" marginwidth="0" marginheight="0" scrolling="no" class="wp-embedded-content"></iframe>'; $expected = '<iframe sandbox="allow-scripts" security="restricted" src="' . esc_url( get_post_embed_url( $post_id ) ) . '" width="200" height="200" title="' . $title . '" frameborder="0" marginwidth="0" marginheight="0" scrolling="no" class="wp-embedded-content"></iframe>';
$this->assertStringEndsWith( $expected, get_post_embed_html( 200, 200, $post_id ) ); $this->assertStringEndsWith( $expected, get_post_embed_html( 200, 200, $post_id ) );
} }