sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Users: Empty sanitized usernames should be considered invalid when passed through validate_username().

Browse Source 
Adds tests.

Props gwinhlopez for the initial patch.
Props mordauk, chriscct7.
Fixes #24618.


git-svn-id: https://develop.svn.wordpress.org/trunk@34856 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Drew Jaynes 2015-10-06 05:34:47 +00:00
parent fabd554bb2
commit afe594bb7c
2 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/wp-includes/user-functions.php
View File

@ -1176,13 +1176,15 @@ function email_exists( $email ) {
* Checks whether a username is valid. * Checks whether a username is valid.
* *
* @since 2.0.1 * @since 2.0.1
* @since 4.4.0 Empty sanitized usernames are now considered invalid
* *
* @param string $username Username. * @param string $username Username.
* @return bool Whether username given is valid * @return bool Whether username given is valid
*/ */
function validate_username( $username ) { function validate_username( $username ) {
$sanitized = sanitize_user( $username, true ); $sanitized = sanitize_user( $username, true );
$valid = ( $sanitized == $username ); $valid = ( $sanitized == $username && ! empty( $sanitized ) );
/** /**
* Filter whether the provided username is valid or not. * Filter whether the provided username is valid or not.
* *

23
tests/phpunit/tests/user.php
View File

@ -599,6 +599,29 @@ class Tests_User extends WP_UnitTestCase {
} }
} }
/**
* @ticket 24618
*/
public function test_validate_username_string() {
$this->assertTrue( validate_username( rand_str() ) );
$this->assertTrue( validate_username( 'JohnDoe' ) );
$this->assertTrue( validate_username( 'test@test.com' ) );
}
/**
* @ticket 24618
*/
public function test_validate_username_empty() {
$this->assertFalse( validate_username( '' ) );
}
/**
* @ticket 24618
*/
public function test_validate_username_invalid() {
$this->assertFalse( validate_username( '@#&99sd' ) );
}
/** /**
* @ticket 29696 * @ticket 29696
*/ */