From b05a22066a5842a2ab652389f68ba5053f846f4c Mon Sep 17 00:00:00 2001 From: Joe McGill Date: Fri, 25 Aug 2017 16:15:27 +0000 Subject: [PATCH] Media: Prime post caches in 'wp_make_content_images_responsive()'. In [38296] we replaced `get_post_meta()` with `wp_get_attachment_metadata()` so that attachment metadata could be consistently filtered. However, this results in extra post queries which were previously avoided. This uses `_prime_post_caches()` instead of `update_meta_cache()` to improve post caching before looping through all images to retrieve attachment metadata. Props dlh. Fixes #40490. git-svn-id: https://develop.svn.wordpress.org/trunk@41315 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/media.php | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/wp-includes/media.php b/src/wp-includes/media.php index 15a608b0e5..3e3e38fe31 100644 --- a/src/wp-includes/media.php +++ b/src/wp-includes/media.php @@ -1335,12 +1335,10 @@ function wp_make_content_images_responsive( $content ) { if ( count( $attachment_ids ) > 1 ) { /* - * Warm object cache for use with 'get_post_meta()'. - * - * To avoid making a database call for each image, a single query - * warms the object cache with the meta information for all images. + * Warm the object cache with post and meta information for all found + * images to avoid making individual database calls. */ - update_meta_cache( 'post', array_keys( $attachment_ids ) ); + _prime_post_caches( array_keys( $attachment_ids ), false, true ); } foreach ( $selected_images as $image => $attachment_id ) {