From b07466c2bf851697d55408419a1739ed750c3463 Mon Sep 17 00:00:00 2001 From: Weston Ruter Date: Sat, 23 Jan 2016 23:14:10 +0000 Subject: [PATCH] Customizer: Use "(Untitled)" as site title if `blogname` is empty. Fixes a layout issue in the Customizer UI. Also de-duplicate title display logic, outputting "Loading..." as site title in PHP with actual title being set upon Customizer `ready`. Also update the site title in response to a `blogname` setting change as opposed to `input` DOM events on the control. Fixes #35579. git-svn-id: https://develop.svn.wordpress.org/trunk@36388 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/customize.php | 2 +- src/wp-admin/js/customize-controls.js | 8 ++++++-- src/wp-includes/script-loader.php | 1 + 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/wp-admin/customize.php b/src/wp-admin/customize.php index aa949e5440..1195e9ad5d 100644 --- a/src/wp-admin/customize.php +++ b/src/wp-admin/customize.php @@ -132,7 +132,7 @@ do_action( 'customize_controls_print_scripts' );
' . get_bloginfo( 'name' ) . '' ); + echo sprintf( __( 'You are customizing %s' ), '' . __( 'Loading…' ) . '' ); ?>
diff --git a/src/wp-admin/js/customize-controls.js b/src/wp-admin/js/customize-controls.js index a6ede2713e..0abfb775bd 100644 --- a/src/wp-admin/js/customize-controls.js +++ b/src/wp-admin/js/customize-controls.js @@ -3604,8 +3604,12 @@ // Bind site title display to the corresponding field. if ( title.length ) { - $( '#customize-control-blogname input' ).on( 'input', function() { - title.text( this.value ); + api( 'blogname', function( setting ) { + var updateTitle = function() { + title.text( $.trim( setting() ) || api.l10n.untitledBlogName ); + }; + setting.bind( updateTitle ); + updateTitle(); } ); } diff --git a/src/wp-includes/script-loader.php b/src/wp-includes/script-loader.php index 74035d9917..b717fd7fc3 100644 --- a/src/wp-includes/script-loader.php +++ b/src/wp-includes/script-loader.php @@ -443,6 +443,7 @@ function wp_default_scripts( &$scripts ) { 'loginIframeTitle' => __( 'Session expired' ), 'collapseSidebar' => __( 'Collapse Sidebar' ), 'expandSidebar' => __( 'Expand Sidebar' ), + 'untitledBlogName' => __( '(Untitled)' ), // Used for overriding the file types allowed in plupload. 'allowedFiles' => __( 'Allowed Files' ), ) );