From b121105f261ddf581bd7c1fb56be1d2dd1e2bdbf Mon Sep 17 00:00:00 2001 From: Boone Gorges Date: Sun, 8 Feb 2015 01:58:51 +0000 Subject: [PATCH] Late escaping in `get_terms()` and `WP_Tax_Query`. Props vortfu, dd32. git-svn-id: https://develop.svn.wordpress.org/trunk@31367 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/taxonomy.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wp-includes/taxonomy.php b/src/wp-includes/taxonomy.php index 142ef28c64..c804554882 100644 --- a/src/wp-includes/taxonomy.php +++ b/src/wp-includes/taxonomy.php @@ -1232,7 +1232,7 @@ class WP_Tax_Query { * matter because `sanitize_term_field()` ignores the $term_id param when the * context is 'db'. */ - $term = "'" . sanitize_term_field( $query['field'], $term, 0, $query['taxonomy'], 'db' ) . "'"; + $term = "'" . esc_sql( sanitize_term_field( $query['field'], $term, 0, $query['taxonomy'], 'db' ) ) . "'"; } $terms = implode( ",", $query['terms'] ); @@ -1842,7 +1842,7 @@ function get_terms( $taxonomies, $args = '' ) { if ( ! empty( $args['name'] ) ) { if ( is_array( $args['name'] ) ) { $name = array_map( 'sanitize_text_field', $args['name'] ); - $where .= " AND t.name IN ('" . implode( "', '", $name ) . "')"; + $where .= " AND t.name IN ('" . implode( "', '", array_map( 'esc_sql', $name ) ) . "')"; } else { $name = sanitize_text_field( $args['name'] ); $where .= $wpdb->prepare( " AND t.name = %s", $name );