From b450eb023f0174d3fb59cd1b2c511a2150469b9b Mon Sep 17 00:00:00 2001 From: Boone Gorges Date: Fri, 24 Oct 2014 12:18:44 +0000 Subject: [PATCH] Improve unit tests for `WP_User_Query` include param. git-svn-id: https://develop.svn.wordpress.org/trunk@30008 602fd350-edb4-49c9-b593-d223f7449a82 --- tests/phpunit/tests/user/query.php | 49 +++++++++++++++++++++++++----- 1 file changed, 41 insertions(+), 8 deletions(-) diff --git a/tests/phpunit/tests/user/query.php b/tests/phpunit/tests/user/query.php index 69c260a752..8f955d7dfa 100644 --- a/tests/phpunit/tests/user/query.php +++ b/tests/phpunit/tests/user/query.php @@ -34,15 +34,48 @@ class Tests_User_Query extends WP_UnitTestCase { $this->assertNull( $users->get( 'does-not-exist' ) ); } - function test_include() { - $users = new WP_User_Query(); - $users->set( 'fields', '' ); - $users->set( 'include', $this->user_id ); - $users->prepare_query(); - $users->query(); + public function test_include_single() { + $users = $this->factory->user->create_many( 2 ); + $q = new WP_User_Query( array( + 'fields' => '', + 'include' => $users[0], + ) ); + $ids = $q->get_results(); - $ids = $users->get_results(); - $this->assertEquals( array( $this->user_id ), $ids ); + $this->assertEquals( array( $users[0] ), $ids ); + } + + public function test_include_comma_separated() { + $users = $this->factory->user->create_many( 3 ); + $q = new WP_User_Query( array( + 'fields' => '', + 'include' => $users[0] . ', ' . $users[2], + ) ); + $ids = $q->get_results(); + + $this->assertEqualSets( array( $users[0], $users[2] ), $ids ); + } + + public function test_include_array() { + $users = $this->factory->user->create_many( 3 ); + $q = new WP_User_Query( array( + 'fields' => '', + 'include' => array( $users[0], $users[2] ), + ) ); + $ids = $q->get_results(); + + $this->assertEqualSets( array( $users[0], $users[2] ), $ids ); + } + + public function test_include_array_bad_values() { + $users = $this->factory->user->create_many( 3 ); + $q = new WP_User_Query( array( + 'fields' => '', + 'include' => array( $users[0], 'foo', $users[2] ), + ) ); + $ids = $q->get_results(); + + $this->assertEqualSets( array( $users[0], $users[2] ), $ids ); } function test_exclude() {