sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Date/Time: Simplify the date comparing logic in WP_Community_Events::trim_events().

Browse Source 
The Events API returns event date without timezone information, so trying to parse it into a timestamp and compare to a WP timestamp is pointless.

Props Rarst.
Fixes #47463.

git-svn-id: https://develop.svn.wordpress.org/trunk@45886 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2019-08-23 02:14:07 +00:00
parent ece257ffd0
commit b975a251ff
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/wp-admin/includes/class-wp-community-events.php
View File

@ -403,7 +403,7 @@ class WP_Community_Events {
protected function trim_events( $response_body ) { protected function trim_events( $response_body ) {
if ( isset( $response_body['events'] ) ) { if ( isset( $response_body['events'] ) ) {
$wordcamps = array(); $wordcamps = array();
$current_timestamp = current_time( 'timestamp' ); $today = current_time( 'Y-m-d' );
foreach ( $response_body['events'] as $key => $event ) { foreach ( $response_body['events'] as $key => $event ) {
/* /*
@ -415,9 +415,10 @@ class WP_Community_Events {
continue; continue;
} }
$event_timestamp = strtotime( $event['date'] ); // We don't get accurate time with timezone from API, so we only take the date part (Y-m-d).
$event_date = substr( $event['date'], 0, 10 );
if ( $current_timestamp > $event_timestamp && ( $current_timestamp - $event_timestamp ) > DAY_IN_SECONDS ) { if ( $today > $event_date ) {
unset( $response_body['events'][ $key ] ); unset( $response_body['events'][ $key ] );
} }
} }