sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Set default value of 'max_depth' in `get_comment_reply_link()`. 

Introduced in [8878].

Props d4z_c0nf.
Fixes #38170.

git-svn-id: https://develop.svn.wordpress.org/trunk@38669 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges 2016-09-28 04:19:46 +00:00
parent c286c27747
commit b9e342c2f4
2 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/wp-includes/comment-template.php
View File

@ -1576,7 +1576,8 @@ function comments_popup_link( $zero = false, $one = false, $more = false, $css_c
* Default 'respond'.
* @type string $reply_text The text of the Reply link. Default 'Reply'.
* @type string $login_text The text of the link to reply if logged out. Default 'Log in to Reply'.
* @type int $depth' The depth of the new comment. Must be greater than 0 and less than the value
* @type int $max_depth The max depth of the comment tree. Default 0.
* @type int $depth The depth of the new comment. Must be greater than 0 and less than the value
* of the 'thread_comments_depth' option set in Settings > Discussion. Default 0.
* @type string $before The text or HTML to add before the reply link. Default empty.
* @type string $after The text or HTML to add after the reply link. Default empty.
@ -1593,6 +1594,7 @@ function get_comment_reply_link( $args = array(), $comment = null, $post = null
'reply_text' => __( 'Reply' ),
'reply_to_text' => __( 'Reply to %s' ),
'login_text' => __( 'Log in to Reply' ),
'max_depth' => 0,
'depth' => 0,
'before' => '',
'after' => ''

29
tests/phpunit/tests/comment/getCommentReplyLink.php Normal file
View File

@ -0,0 +1,29 @@
<?php
/**
* @group comment
*/
class Tests_Comment_GetCommentReplyLink extends WP_UnitTestCase {
/**
* @ticket 38170
*/
public function test_should_return_null_when_max_depth_is_less_than_depth() {
$args = array(
'depth' => 5,
'max_depth' => 4,
);
$this->assertNull( get_comment_reply_link( $args ) );
}
/**
* @ticket 38170
*/
public function test_should_return_null_when_default_max_depth_is_less_than_depth() {
$args = array(
'depth' => 5,
);
$this->assertNull( get_comment_reply_link( $args ) );
}
}