sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Return an error when adding a term to a non-existent parent.

Browse Source 
Parallels the logic of wp_insert_term(), introduced in [29196].

Props jesin.
Fixes #29614.

git-svn-id: https://develop.svn.wordpress.org/trunk@29867 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges 2014-10-09 18:11:17 +00:00
parent cfac76a2cc
commit bce6d64d59
2 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/wp-includes/taxonomy.php
View File

@ -2933,6 +2933,10 @@ function wp_update_term( $term_id, $taxonomy, $args = array() ) {
if ( '' == trim($name) ) if ( '' == trim($name) )
return new WP_Error('empty_term_name', __('A name is required for this term')); return new WP_Error('empty_term_name', __('A name is required for this term'));
if ( $parsed_args['parent'] > 0 && ! term_exists( (int) $parsed_args['parent'] ) ) {
return new WP_Error( 'missing_parent', __( 'Parent term does not exist.' ) );
}
$empty_slug = false; $empty_slug = false;
if ( empty( $args['slug'] ) ) { if ( empty( $args['slug'] ) ) {
$empty_slug = true; $empty_slug = true;

26
tests/phpunit/tests/term.php
View File

@ -631,6 +631,32 @@ class Tests_Term extends WP_UnitTestCase {
$this->assertTrue( in_array( $found['term_id'], $cached_children[ $t ] ) ); $this->assertTrue( in_array( $found['term_id'], $cached_children[ $t ] ) );
} }
/**
* @ticket 29614
*/
function test_wp_update_term_parent_does_not_exist() {
register_taxonomy( 'wptests_tax', array(
'hierarchical' => true,
) );
$fake_term_id = 787878;
$this->assertNull( term_exists( $fake_term_id, 'wptests_tax' ) );
$t = $this->factory->term->create( array(
'taxonomy' => 'wptests_tax',
) );
$found = wp_update_term( $t, 'wptests_tax', array(
'parent' => $fake_term_id,
) );
$this->assertWPError( $found );
$this->assertSame( 'missing_parent', $found->get_error_code() );
$term = get_term( $t, 'wptests_tax' );
$this->assertEquals( 0, $term->parent );
}
public function test_wp_update_term_alias_of_no_term_group() { public function test_wp_update_term_alias_of_no_term_group() {
register_taxonomy( 'wptests_tax', 'post' ); register_taxonomy( 'wptests_tax', 'post' );
$t1 = $this->factory->term->create( array( $t1 = $this->factory->term->create( array(