sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

wpView: consolidate pausePlayers() and unsetPlayers(), they are almost the same. Prevent errors when instead of a player ME.js shows only a "Download File" placeholder (in IE). See #28905. 

git-svn-id: https://develop.svn.wordpress.org/trunk@29272 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Andrew Ozz 2014-07-22 21:48:41 +00:00
parent cce3bdf920
commit c2bd765b32
1 changed files with 16 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/wp-includes/js/mce-view.js
View File

@ -504,15 +504,15 @@ window.wp = window.wp || {};
this.shortcode = options.shortcode; this.shortcode = options.shortcode;
_.bindAll( this, 'setIframes', 'setNodes', 'fetch', 'pausePlayers' ); _.bindAll( this, 'setIframes', 'setNodes', 'fetch', 'stopPlayers' );
$( this ).on( 'ready', this.setNodes ); $( this ).on( 'ready', this.setNodes );
$( document ).on( 'media:edit', this.pausePlayers ); $( document ).on( 'media:edit', this.stopPlayers );
this.fetch(); this.fetch();
this.getEditors( function( editor ) { this.getEditors( function( editor ) {
editor.on( 'hide', self.pausePlayers ); editor.on( 'hide', self.stopPlayers );
}); });
}, },
@ -553,35 +553,30 @@ window.wp = window.wp || {};
} ); } );
}, },
pausePlayers: function() { stopPlayers: function( remove ) {
var rem = remove === 'remove';
this.getNodes( function( editor, node, content ) { this.getNodes( function( editor, node, content ) {
var p, win, var p, win,
iframe = $( 'iframe.wpview-sandbox', content ).get(0); iframe = $( 'iframe.wpview-sandbox', content ).get(0);
if ( iframe && ( win = iframe.contentWindow ) && win.mejs ) { if ( iframe && ( win = iframe.contentWindow ) && win.mejs ) {
// Sometimes ME.js may show a "Download File" placeholder and player.remove() doesn't exist there.
try {
for ( p in win.mejs.players ) { for ( p in win.mejs.players ) {
win.mejs.players[p].pause(); win.mejs.players[p].pause();
}
}
});
},
unsetPlayers: function() { if ( rem ) {
this.getNodes( function( editor, node, content ) {
var p, win,
iframe = $( 'iframe.wpview-sandbox', content ).get(0);
if ( iframe && ( win = iframe.contentWindow ) && win.mejs ) {
for ( p in win.mejs.players ) {
win.mejs.players[p].remove(); win.mejs.players[p].remove();
} }
} }
} catch( er ) {}
}
}); });
}, },
unbind: function() { unbind: function() {
this.pausePlayers(); this.stopPlayers( 'remove' );
this.unsetPlayers();
} }
}, },