sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

When creating a new post with an empty post_name and post_title, don't generate a post_name that conflicts with a date archive permalink.

Browse Source 
See #5305.

git-svn-id: https://develop.svn.wordpress.org/trunk@33261 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges 2015-07-14 12:27:03 +00:00
parent 7711b72639
commit c718849baa
2 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wp-includes/post.php
View File

@ -3451,7 +3451,7 @@ function wp_insert_post( $postarr, $wp_error = false ) {
}
if ( empty( $data['post_name'] ) && ! in_array( $data['post_status'], array( 'draft', 'pending', 'auto-draft' ) ) ) {
$data['post_name'] = sanitize_title( $data['post_title'], $post_ID );
$data['post_name'] = wp_unique_post_slug( sanitize_title( $data['post_title'], $post_ID ), $post_ID, $data['post_status'], $post_type, $post_parent );
$wpdb->update( $wpdb->posts, array( 'post_name' => $data['post_name'] ), $where );
}

23
tests/phpunit/tests/post.php
View File

@ -411,6 +411,29 @@ class Tests_Post extends WP_UnitTestCase {
$this->assertEquals(false, $this->_next_schedule_for_post('publish_future_post', $id));
}
/**
* @ticket 5305
*/
public function test_wp_insert_post_should_not_allow_a_bare_numeric_slug_that_might_conflict_with_a_date_archive_when_generating_from_an_empty_post_title() {
global $wp_rewrite;
$wp_rewrite->init();
$wp_rewrite->set_permalink_structure( '/%postname%/' );
$wp_rewrite->flush_rules();
$p = wp_insert_post( array(
'post_title' => '',
'post_content' => 'test',
'post_status' => 'publish',
'post_type' => 'post',
) );
$post = get_post( $p );
$wp_rewrite->set_permalink_structure( '' );
$this->assertEquals( "$p-2", $post->post_name );
}
/**
* @ticket 5364
*/