sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove "the hackiest hack that ever did hack" from add_user(). wp_insert_user()/edit_user() can deal with adding new users of any defined role. Fixes #18749.

Browse Source 
git-svn-id: https://develop.svn.wordpress.org/trunk@19686 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Jon Cave 2012-01-05 20:38:40 +00:00
parent 8c36bb6779
commit c90c0e8600
1 changed files with 1 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
wp-admin/includes/user.php
View File

@ -9,38 +9,12 @@
/** /**
* Creates a new user from the "Users" form using $_POST information. * Creates a new user from the "Users" form using $_POST information.
* *
* It seems that the first half is for backwards compatibility, but only
* has the ability to alter the user's role. WordPress core seems to
* use this function only in the second way, running edit_user() with
* no id so as to create a new user.
*
* @since 2.0 * @since 2.0
* *
* @param int $user_id Optional. User ID.
* @return null|WP_Error|int Null when adding user, WP_Error or User ID integer when no parameters. * @return null|WP_Error|int Null when adding user, WP_Error or User ID integer when no parameters.
*/ */
function add_user() { function add_user() {
if ( func_num_args() ) { // The hackiest hack that ever did hack return edit_user();
global $wp_roles;
$user_id = (int) func_get_arg( 0 );
if ( isset( $_POST['role'] ) ) {
$new_role = sanitize_text_field( $_POST['role'] );
// Don't let anyone with 'edit_users' (admins) edit their own role to something without it.
if ( $user_id != get_current_user_id() || $wp_roles->role_objects[$new_role]->has_cap( 'edit_users' ) ) {
// If the new role isn't editable by the logged-in user die with error
$editable_roles = get_editable_roles();
if ( empty( $editable_roles[$new_role] ) )
wp_die(__('You can’t give users that role.'));
$user = new WP_User( $user_id );
$user->set_role( $new_role );
}
}
} else {
add_action( 'user_register', 'add_user' ); // See above
return edit_user();
}
} }
/** /**