sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Themes: Update the unit tests to handle [39064] and #31550. 

`test_default_theme_in_default_theme_list()` was always being skipped after #31550, this causes it to once again check that the unit tests are up to date and include the latest default theme.
`test_default_themes_have_textdomain()` didn't play happy when a default theme wasn't installed on a site.

See #31550, #29925, #38551.


git-svn-id: https://develop.svn.wordpress.org/trunk@39065 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Dion Hulse 2016-11-01 03:13:27 +00:00
parent b92ebd9e2d
commit cacd16cf5d
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/phpunit/tests/theme.php
View File

@ -10,7 +10,7 @@ class Tests_Theme extends WP_UnitTestCase {
protected $theme_name = 'Twenty Eleven'; protected $theme_name = 'Twenty Eleven';
protected $default_themes = array( protected $default_themes = array(
'twentyten', 'twentyeleven', 'twentytwelve', 'twentythirteen', 'twentyten', 'twentyeleven', 'twentytwelve', 'twentythirteen',
'twentyfourteen', 'twentyfifteen', 'twentyfourteen', 'twentyfifteen', 'twentysixteen', 'twentyseventeen',
); );
function setUp() { function setUp() {
@ -187,16 +187,20 @@ class Tests_Theme extends WP_UnitTestCase {
* @ticket 29925 * @ticket 29925
*/ */
function test_default_theme_in_default_theme_list() { function test_default_theme_in_default_theme_list() {
if ( 'twenty' === substr( WP_DEFAULT_THEME, 0, 6 ) ) { $latest_default_theme = WP_Theme::get_core_default_theme();
$this->assertContains( WP_DEFAULT_THEME, $this->default_themes ); if ( ! $latest_default_theme->exists() || 'twenty' !== substr( $latest_default_theme->get_stylesheet(), 0, 6 ) ) {
$this->markTestSkipped( 'No Twenty* series default themes are installed' );
} }
$this->assertContains( $latest_default_theme->get_stylesheet(), $this->default_themes );
} }
function test_default_themes_have_textdomain() { function test_default_themes_have_textdomain() {
foreach ( $this->default_themes as $theme ) { foreach ( $this->default_themes as $theme ) {
if ( wp_get_theme( $theme )->exists() ) {
$this->assertEquals( $theme, wp_get_theme( $theme )->get( 'TextDomain' ) ); $this->assertEquals( $theme, wp_get_theme( $theme )->get( 'TextDomain' ) );
} }
} }
}
/** /**
* @ticket 20897 * @ticket 20897