sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Themes: Ensure that only privileged users can set a background image when a theme is using the deprecated custom background page.

Browse Source 
Props xknown, zieladam, peterwilsoncc, whyisjake.
Merges [49379] to trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@49388 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Jonathan Desrosiers 2020-10-29 18:06:18 +00:00
parent d5ddd6d4be
commit cbcc595974
3 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/js/_enqueues/admin/custom-background.js
View File

@ -126,11 +126,13 @@
frame.on( 'select', function() { frame.on( 'select', function() {
// Grab the selected attachment. // Grab the selected attachment.
var attachment = frame.state().get('selection').first(); var attachment = frame.state().get('selection').first();
var nonceValue = $( '#_wpnonce' ).val() || '';
// Run an Ajax request to set the background image. // Run an Ajax request to set the background image.
$.post( ajaxurl, { $.post( ajaxurl, {
action: 'set-background-image', action: 'set-background-image',
attachment_id: attachment.id, attachment_id: attachment.id,
_ajax_nonce: nonceValue,
size: 'full' size: 'full'
}).done( function() { }).done( function() {
// When the request completes, reload the window. // When the request completes, reload the window.

4
src/js/_enqueues/deprecated/media-gallery.js
View File

@ -11,7 +11,7 @@ jQuery(function($) {
* Adds a click event handler to the element with a 'wp-gallery' class. * Adds a click event handler to the element with a 'wp-gallery' class.
*/ */
$( 'body' ).bind( 'click.wp-gallery', function(e) { $( 'body' ).bind( 'click.wp-gallery', function(e) {
var target = $( e.target ), id, img_size; var target = $( e.target ), id, img_size, nonceValue;
if ( target.hasClass( 'wp-set-header' ) ) { if ( target.hasClass( 'wp-set-header' ) ) {
// Opens the image to preview it full size. // Opens the image to preview it full size.
@ -21,6 +21,7 @@ jQuery(function($) {
// Sets the image as background of the theme. // Sets the image as background of the theme.
id = target.data( 'attachment-id' ); id = target.data( 'attachment-id' );
img_size = $( 'input[name="attachments[' + id + '][image-size]"]:checked').val(); img_size = $( 'input[name="attachments[' + id + '][image-size]"]:checked').val();
nonceValue = $( '#_wpnonce' ).val() && '';
/** /**
* This Ajax action has been deprecated since 3.5.0, see custom-background.php * This Ajax action has been deprecated since 3.5.0, see custom-background.php
@ -28,6 +29,7 @@ jQuery(function($) {
jQuery.post(ajaxurl, { jQuery.post(ajaxurl, {
action: 'set-background-image', action: 'set-background-image',
attachment_id: id, attachment_id: id,
_ajax_nonce: nonceValue,
size: img_size size: img_size
}, function() { }, function() {
var win = window.dialogArguments || opener || parent || top; var win = window.dialogArguments || opener || parent || top;

2
src/wp-admin/includes/class-custom-background.php
View File

@ -581,6 +581,8 @@ class Custom_Background {
* @deprecated 3.5.0 * @deprecated 3.5.0
*/ */
public function wp_set_background_image() { public function wp_set_background_image() {
check_ajax_referer( 'custom-background' );
if ( ! current_user_can( 'edit_theme_options' ) || ! isset( $_POST['attachment_id'] ) ) { if ( ! current_user_can( 'edit_theme_options' ) || ! isset( $_POST['attachment_id'] ) ) {
exit; exit;
} }