sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Permalinks: In `get_page_uri()`, don't prepend a parent page slug if it's empty. 

Props inderpreet99, SergeyBiryukov.
Fixes #36174.

git-svn-id: https://develop.svn.wordpress.org/trunk@38145 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2016-07-23 10:04:20 +00:00
parent 299802bbb5
commit ccb70aee4b
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wp-includes/post.php
View File

@ -4333,7 +4333,7 @@ function get_page_uri( $page = 0 ) {
foreach ( $page->ancestors as $parent ) {
$parent = get_post( $parent );
if ( $parent ) {
if ( $parent && $parent->post_name ) {
$uri = $parent->post_name . '/' . $uri;
}
}

12
tests/phpunit/tests/post/getPageUri.php
View File

@ -46,6 +46,18 @@ class Tests_Post_getPageUri extends WP_UnitTestCase {
$this->assertEquals( 'child', get_page_uri( $child_id ) );
}
/**
* @ticket 36174
*/
function test_get_page_uri_with_a_draft_parent_with_empty_slug() {
$parent_id = self::factory()->post->create( array( 'post_name' => 'parent' ) );
$child_id = self::factory()->post->create( array( 'post_name' => 'child', 'post_parent' => $parent_id ) );
wp_update_post( array( 'ID' => $parent_id, 'post_name' => '', 'post_status' => 'draft' ) );
$this->assertEquals( 'child', get_page_uri( $child_id ) );
}
/**
* @ticket 26284
*/