Permalinks: In `get_page_uri()`, don't prepend a parent page slug if it's empty.
Props inderpreet99, SergeyBiryukov. Fixes #36174. git-svn-id: https://develop.svn.wordpress.org/trunk@38145 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
parent
299802bbb5
commit
ccb70aee4b
|
@ -4333,7 +4333,7 @@ function get_page_uri( $page = 0 ) {
|
||||||
|
|
||||||
foreach ( $page->ancestors as $parent ) {
|
foreach ( $page->ancestors as $parent ) {
|
||||||
$parent = get_post( $parent );
|
$parent = get_post( $parent );
|
||||||
if ( $parent ) {
|
if ( $parent && $parent->post_name ) {
|
||||||
$uri = $parent->post_name . '/' . $uri;
|
$uri = $parent->post_name . '/' . $uri;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -46,6 +46,18 @@ class Tests_Post_getPageUri extends WP_UnitTestCase {
|
||||||
$this->assertEquals( 'child', get_page_uri( $child_id ) );
|
$this->assertEquals( 'child', get_page_uri( $child_id ) );
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @ticket 36174
|
||||||
|
*/
|
||||||
|
function test_get_page_uri_with_a_draft_parent_with_empty_slug() {
|
||||||
|
$parent_id = self::factory()->post->create( array( 'post_name' => 'parent' ) );
|
||||||
|
$child_id = self::factory()->post->create( array( 'post_name' => 'child', 'post_parent' => $parent_id ) );
|
||||||
|
|
||||||
|
wp_update_post( array( 'ID' => $parent_id, 'post_name' => '', 'post_status' => 'draft' ) );
|
||||||
|
|
||||||
|
$this->assertEquals( 'child', get_page_uri( $child_id ) );
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @ticket 26284
|
* @ticket 26284
|
||||||
*/
|
*/
|
||||||
|
|
Loading…
Reference in New Issue