From d4a305292f07c314ea8ec1fa677bc78cef525130 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Wed, 14 Aug 2019 15:35:19 +0000 Subject: [PATCH] Users: Make `wp_list_authors()` unit tests more readable. See #23498. git-svn-id: https://develop.svn.wordpress.org/trunk@45795 602fd350-edb4-49c9-b593-d223f7449a82 --- tests/phpunit/tests/user/listAuthors.php | 100 ++++++++++++++++++----- 1 file changed, 78 insertions(+), 22 deletions(-) diff --git a/tests/phpunit/tests/user/listAuthors.php b/tests/phpunit/tests/user/listAuthors.php index 8dcfad8935..ccaa733551 100644 --- a/tests/phpunit/tests/user/listAuthors.php +++ b/tests/phpunit/tests/user/listAuthors.php @@ -75,12 +75,20 @@ class Tests_User_ListAuthors extends WP_UnitTestCase { } function test_wp_list_authors_default() { - $expected['default'] = '
  • bob
  • paul
  • zack
    • '; + $expected['default'] = + '
  • bob
    • ' . + '
  • paul
    • ' . + '
  • zack
    • '; + $this->AssertEquals( $expected['default'], wp_list_authors( array( 'echo' => false ) ) ); } function test_wp_list_authors_orderby() { - $expected['post_count'] = '
  • zack
  • bob
  • paul
    • '; + $expected['post_count'] = + '
  • zack
    • ' . + '
  • bob
    • ' . + '
  • paul
    • '; + $this->AssertEquals( $expected['post_count'], wp_list_authors( @@ -93,7 +101,11 @@ class Tests_User_ListAuthors extends WP_UnitTestCase { } function test_wp_list_authors_order() { - $expected['id'] = '
  • paul
  • bob
  • zack
    • '; + $expected['id'] = + '
  • paul
    • ' . + '
  • bob
    • ' . + '
  • zack
    • '; + $this->AssertEquals( $expected['id'], wp_list_authors( @@ -107,7 +119,11 @@ class Tests_User_ListAuthors extends WP_UnitTestCase { } function test_wp_list_authors_optioncount() { - $expected['optioncount'] = '
  • bob (2)
  • paul (3)
  • zack (1)
    • '; + $expected['optioncount'] = + '
  • bob (2)
    • ' . + '
  • paul (3)
    • ' . + '
  • zack (1)
    • '; + $this->AssertEquals( $expected['optioncount'], wp_list_authors( @@ -126,7 +142,13 @@ class Tests_User_ListAuthors extends WP_UnitTestCase { 'post_author' => 1, ) ); - $expected['exclude_admin'] = '
  • admin
  • bob
  • paul
  • zack
    • '; + + $expected['exclude_admin'] = + '
  • admin
    • ' . + '
  • bob
    • ' . + '
  • paul
    • ' . + '
  • zack
    • '; + $this->AssertEquals( $expected['exclude_admin'], wp_list_authors( @@ -139,7 +161,11 @@ class Tests_User_ListAuthors extends WP_UnitTestCase { } function test_wp_list_authors_show_fullname() { - $expected['show_fullname'] = '
  • bob reno
  • paul norris
  • zack moon
    • '; + $expected['show_fullname'] = + '
  • bob reno
    • ' . + '
  • paul norris
    • ' . + '
  • zack moon
    • '; + $this->AssertEquals( $expected['show_fullname'], wp_list_authors( @@ -152,8 +178,14 @@ class Tests_User_ListAuthors extends WP_UnitTestCase { } function test_wp_list_authors_hide_empty() { - $fred_id = self::$fred_id; - $expected['hide_empty'] = '
  • bob
  • fred
  • paul
  • zack
    • '; + $fred_id = self::$fred_id; + + $expected['hide_empty'] = + '
  • bob
    • ' . + '
  • fred
    • ' . + '
  • paul
    • ' . + '
  • zack
    • '; + $this->AssertEquals( $expected['hide_empty'], wp_list_authors( @@ -166,16 +198,25 @@ class Tests_User_ListAuthors extends WP_UnitTestCase { } function test_wp_list_authors_echo() { - $expected['echo'] = '
  • bob
  • paul
  • zack
    • '; + $expected['echo'] = + '
  • bob
    • ' . + '
  • paul
    • ' . + '
  • zack
    • '; + $this->expectOutputString( $expected['echo'] ); wp_list_authors( array( 'echo' => true ) ); } function test_wp_list_authors_feed() { - $url0 = get_author_feed_link( self::$user_ids[0] ); - $url1 = get_author_feed_link( self::$user_ids[1] ); - $url2 = get_author_feed_link( self::$user_ids[2] ); - $expected['feed'] = '
  • bob (link to feed)
  • paul (link to feed)
  • zack (link to feed)
    • '; + $url0 = get_author_feed_link( self::$user_ids[0] ); + $url1 = get_author_feed_link( self::$user_ids[1] ); + $url2 = get_author_feed_link( self::$user_ids[2] ); + + $expected['feed'] = + '
  • bob (link to feed)
    • ' . + '
  • paul (link to feed)
    • ' . + '
  • zack (link to feed)
    • '; + $this->AssertEquals( $expected['feed'], wp_list_authors( @@ -188,10 +229,15 @@ class Tests_User_ListAuthors extends WP_UnitTestCase { } function test_wp_list_authors_feed_image() { - $url0 = get_author_feed_link( self::$user_ids[0] ); - $url1 = get_author_feed_link( self::$user_ids[1] ); - $url2 = get_author_feed_link( self::$user_ids[2] ); - $expected['feed_image'] = '
  • bob
  • paul
  • zack
    • '; + $url0 = get_author_feed_link( self::$user_ids[0] ); + $url1 = get_author_feed_link( self::$user_ids[1] ); + $url2 = get_author_feed_link( self::$user_ids[2] ); + + $expected['feed_image'] = + '
  • bob
    • ' . + '
  • paul
    • ' . + '
  • zack
    • '; + $this->AssertEquals( $expected['feed_image'], wp_list_authors( @@ -207,10 +253,15 @@ class Tests_User_ListAuthors extends WP_UnitTestCase { * @ticket 26538 */ function test_wp_list_authors_feed_type() { - $url0 = get_author_feed_link( self::$user_ids[0], 'atom' ); - $url1 = get_author_feed_link( self::$user_ids[1], 'atom' ); - $url2 = get_author_feed_link( self::$user_ids[2], 'atom' ); - $expected['feed_type'] = '
  • bob (link to feed)
  • paul (link to feed)
  • zack (link to feed)
    • '; + $url0 = get_author_feed_link( self::$user_ids[0], 'atom' ); + $url1 = get_author_feed_link( self::$user_ids[1], 'atom' ); + $url2 = get_author_feed_link( self::$user_ids[2], 'atom' ); + + $expected['feed_type'] = + '
  • bob (link to feed)
    • ' . + '
  • paul (link to feed)
    • ' . + '
  • zack (link to feed)
    • '; + $this->AssertEquals( $expected['feed_type'], wp_list_authors( @@ -224,7 +275,11 @@ class Tests_User_ListAuthors extends WP_UnitTestCase { } function test_wp_list_authors_style() { - $expected['style'] = 'bob, paul, zack'; + $expected['style'] = + 'bob, ' . + 'paul, ' . + 'zack'; + $this->AssertEquals( $expected['style'], wp_list_authors( @@ -238,6 +293,7 @@ class Tests_User_ListAuthors extends WP_UnitTestCase { function test_wp_list_authors_html() { $expected['html'] = 'bob, paul, zack'; + $this->AssertEquals( $expected['html'], wp_list_authors(