sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Acessibility: Remove `title` attribute in `login_header()`. 

* Deprecate `login_headertitle` filter, introduce `login_headertext` as a replacement.
* For backwards compatibility, if a `login_headertitle` is set, it will be used as link text.
* Make the login header logo URL and text consistent between single site and Multisite.
* Avoid ambiguity of where the WordPress logo points to; link to WordPress.org by default.
* `login_headerurl` filter is still available to change the URL of the header logo.

Props afercia, pratikkry, chetan200891.
Fixes #42537.

git-svn-id: https://develop.svn.wordpress.org/trunk@44899 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2019-03-14 21:09:47 +00:00
parent 8ba2c45029
commit d52e37ea5e
1 changed files with 21 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
src/wp-login.php
View File

@ -113,13 +113,7 @@ function login_header( $title = 'Log In', $message = '', $wp_error = null ) {
*/ */
do_action( 'login_head' ); do_action( 'login_head' );
if ( is_multisite() ) { $login_header_url = __( 'https://wordpress.org/' );
$login_header_url = network_home_url();
$login_header_title = get_network()->site_name;
} else {
$login_header_url = __( 'https://wordpress.org/' );
$login_header_title = __( 'Powered by WordPress' );
}
/** /**
* Filters link URL of the header logo above login form. * Filters link URL of the header logo above login form.
@ -130,24 +124,34 @@ function login_header( $title = 'Log In', $message = '', $wp_error = null ) {
*/ */
$login_header_url = apply_filters( 'login_headerurl', $login_header_url ); $login_header_url = apply_filters( 'login_headerurl', $login_header_url );
$login_header_title = '';
/** /**
* Filters the title attribute of the header logo above login form. * Filters the title attribute of the header logo above login form.
* *
* @since 2.1.0 * @since 2.1.0
* @deprecated 5.2.0 Use login_headertext
* *
* @param string $login_header_title Login header logo title attribute. * @param string $login_header_title Login header logo title attribute.
*/ */
$login_header_title = apply_filters( 'login_headertitle', $login_header_title ); $login_header_title = apply_filters_deprecated(
'login_headertitle',
array( $login_header_title ),
'5.2.0',
'login_headertext',
__( 'Usage of the title attribute on the login logo is not recommended for accessibility reasons. Use the link text instead.' )
);
/* $login_header_text = empty( $login_header_title ) ? __( 'Powered by WordPress' ) : $login_header_title;
* To match the URL/title set above, Multisite sites have the blog name,
* while single sites get the header title. /**
* Filters the link text of the header logo above the login form.
*
* @since 5.2.0
*
* @param string $login_header_text The login header logo link text.
*/ */
if ( is_multisite() ) { $login_header_text = apply_filters( 'login_headertext', $login_header_text );
$login_header_text = get_bloginfo( 'name', 'display' );
} else {
$login_header_text = $login_header_title;
}
$classes = array( 'login-action-' . $action, 'wp-core-ui' ); $classes = array( 'login-action-' . $action, 'wp-core-ui' );
if ( is_rtl() ) { if ( is_rtl() ) {
@ -187,11 +191,8 @@ function login_header( $title = 'Log In', $message = '', $wp_error = null ) {
do_action( 'login_header' ); do_action( 'login_header' );
?> ?>
<div id="login"> <div id="login">
<h1><a href="<?php echo esc_url( $login_header_url ); ?>" title="<?php echo esc_attr( $login_header_title ); ?>"><?php echo $login_header_text; ?></a></h1> <h1><a href="<?php echo esc_url( $login_header_url ); ?>"><?php echo $login_header_text; ?></a></h1>
<?php <?php
unset( $login_header_url, $login_header_title );
/** /**
* Filters the message to display above the login form. * Filters the message to display above the login form.
* *