From d6b5ca5afc30e3510698834d05b19d5755ba0361 Mon Sep 17 00:00:00 2001 From: Dougal Campbell Date: Tue, 30 Dec 2003 16:02:27 +0000 Subject: [PATCH] Eliminated race condition in user promotions git-svn-id: https://develop.svn.wordpress.org/trunk@667 602fd350-edb4-49c9-b593-d223f7449a82 --- wp-admin/users.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/wp-admin/users.php b/wp-admin/users.php index bf6b3a4dc0..fb552144a6 100644 --- a/wp-admin/users.php +++ b/wp-admin/users.php @@ -111,9 +111,11 @@ case 'promote': } if ('up' == $prom) { - $sql="UPDATE $tableusers SET user_level=user_level+1 WHERE ID = $id"; + $new_level = $usertopromote_level + 1; + $sql="UPDATE $tableusers SET user_level=$new_level WHERE ID = $id AND $new_level < $user_level"; } elseif ('down' == $prom) { - $sql="UPDATE $tableusers SET user_level=user_level-1 WHERE ID = $id"; + $new_level = $usertopromote_level - 1; + $sql="UPDATE $tableusers SET user_level=$new_level WHERE ID = $id AND $new_level < $user_level"; } $result = $wpdb->query($sql);