sergiotarxz/Wordpress
sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Support orderby => meta_value in WP_User_Query. Adds unit test.

Browse Source 
Props wpsmith.
Fixes #21581.



git-svn-id: https://develop.svn.wordpress.org/trunk@25331 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor 2013-09-10 23:09:10 +00:00
parent 270cc9702d
commit d738f5e586
2 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wp-includes/user.php
View File

@ -435,6 +435,8 @@ class WP_User_Query {
$orderby = 'post_count';
} elseif ( 'ID' == $qv['orderby'] || 'id' == $qv['orderby'] ) {
$orderby = 'ID';
} elseif ( 'meta_value' == $qv['orderby'] ) {
$orderby = "$wpdb->usermeta.meta_value";
} else {
$orderby = 'user_login';
}

25
tests/phpunit/tests/user/query.php
View File

@ -76,4 +76,29 @@ class Tests_User_Query extends WP_UnitTestCase {
$this->assertInstanceOf( 'WP_User', $user );
}
}
function test_orderby() {
$user_ids = $this->factory->user->create_many( 10, array(
'role' => 'author'
) );
$names = array( 'd', 'f', 'n', 'f', 'd', 'j', 'r', 'p', 'h', 'g' );
foreach ( $names as $i => $name )
update_user_meta( $user_ids[$i], 'last_name', $name );
$u = new WP_User_Query( array(
'include' => $user_ids,
'meta_key' => 'last_name',
'orderby' => 'meta_value',
'fields' => 'ids'
) );
$values = array();
foreach ( $u->get_results() as $user )
$values[] = get_user_meta( $user, 'last_name', true );
sort( $names );
$this->assertEquals( $names, $values );
}
}