From d81408d7f61a7eb2565bbc70fb432b8dd4340bcf Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Mon, 7 Jan 2019 12:53:07 +0000 Subject: [PATCH] Taxonomy: Escape CSS classes in `Walker_Category::start_el()` after the `category_css_class` filter runs. Don't add an empty `class` attribute if there are no classes, for consistency with `Walker_Nav_Menu::start_el()`. Props abhijitrakas, mukesh27. See #44880. git-svn-id: https://develop.svn.wordpress.org/trunk@44414 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/class-walker-category.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/wp-includes/class-walker-category.php b/src/wp-includes/class-walker-category.php index 6df6431b6b..7b13264b95 100644 --- a/src/wp-includes/class-walker-category.php +++ b/src/wp-includes/class-walker-category.php @@ -204,8 +204,9 @@ class Walker_Category extends Walker { * @param array $args An array of wp_list_categories() arguments. */ $css_classes = implode( ' ', apply_filters( 'category_css_class', $css_classes, $category, $depth, $args ) ); + $css_classes = $css_classes ? ' class="' . esc_attr( $css_classes ) . '"' : ''; - $output .= ' class="' . $css_classes . '"'; + $output .= $css_classes; $output .= ">$link\n"; } elseif ( isset( $args['separator'] ) ) { $output .= "\t$link" . $args['separator'] . "\n";