sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Upgrade/Install: Check if the theme installer skin's `overwrite` property exists in `Theme_Upgrader::install_strings()`. 

This ensures consistency with `Plugin_Upgrader::install_strings()` and resolves an issue caused by the property not existing in other upgrader implementations.

Props schlessera, azaozz.
See #50670.

git-svn-id: https://develop.svn.wordpress.org/trunk@48493 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2020-07-16 13:17:13 +00:00
parent bd63261888
commit da730fce4d
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/wp-admin/includes/class-theme-upgrader.php
View File

@ -94,16 +94,18 @@ class Theme_Upgrader extends WP_Upgrader {
/* translators: %s: Theme error. */ /* translators: %s: Theme error. */
$this->strings['current_theme_has_errors'] = __( 'The current theme has the following error: "%s".' ); $this->strings['current_theme_has_errors'] = __( 'The current theme has the following error: "%s".' );
if ( 'update-theme' === $this->skin->overwrite ) { if ( ! empty( $this->skin->overwrite ) ) {
$this->strings['installing_package'] = __( 'Updating the theme…' ); if ( 'update-theme' === $this->skin->overwrite ) {
$this->strings['process_failed'] = __( 'Theme update failed.' ); $this->strings['installing_package'] = __( 'Updating the theme…' );
$this->strings['process_success'] = __( 'Theme updated successfully.' ); $this->strings['process_failed'] = __( 'Theme update failed.' );
} $this->strings['process_success'] = __( 'Theme updated successfully.' );
}
if ( 'downgrade-theme' === $this->skin->overwrite ) { if ( 'downgrade-theme' === $this->skin->overwrite ) {
$this->strings['installing_package'] = __( 'Downgrading the theme…' ); $this->strings['installing_package'] = __( 'Downgrading the theme…' );
$this->strings['process_failed'] = __( 'Theme downgrade failed.' ); $this->strings['process_failed'] = __( 'Theme downgrade failed.' );
$this->strings['process_success'] = __( 'Theme downgraded successfully.' ); $this->strings['process_success'] = __( 'Theme downgraded successfully.' );
}
} }
} }