From daf448ae0c575f5eb2e79f7c06bc4232152c1806 Mon Sep 17 00:00:00 2001 From: Andrew Nacin Date: Fri, 15 Nov 2013 05:15:06 +0000 Subject: [PATCH] Fix JSHint errors in 5 files. props seanchayes. fixes #26015, #26020, #26019, #26034, #26022. git-svn-id: https://develop.svn.wordpress.org/trunk@26200 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/js/link.js | 4 +++- src/wp-admin/js/media.js | 5 +++-- src/wp-includes/js/customize-preview.js | 8 ++++---- src/wp-includes/js/jquery/jquery.table-hotkeys.js | 10 +++++----- src/wp-includes/js/media-editor.js | 4 +++- 5 files changed, 18 insertions(+), 13 deletions(-) diff --git a/src/wp-admin/js/link.js b/src/wp-admin/js/link.js index bf5e67ede6..0eb384e43d 100644 --- a/src/wp-admin/js/link.js +++ b/src/wp-admin/js/link.js @@ -1,3 +1,5 @@ +/* global postboxes, deleteUserSetting, setUserSetting, getUserSetting */ + jQuery(document).ready( function($) { var newCat, noSyncChecks = false, syncChecks, catAddAfter; @@ -22,7 +24,7 @@ jQuery(document).ready( function($) { $('#category-tabs a[href="#categories-pop"]').click(); // Ajax Cat - newCat = $('#newcat').one( 'focus', function() { $(this).val( '' ).removeClass( 'form-input-tip' ) } ); + newCat = $('#newcat').one( 'focus', function() { $(this).val( '' ).removeClass( 'form-input-tip' ); } ); $('#link-category-add-submit').click( function() { newCat.focus(); } ); syncChecks = function() { if ( noSyncChecks ) diff --git a/src/wp-admin/js/media.js b/src/wp-admin/js/media.js index b4ed0fb6ce..3c2aa69ae6 100644 --- a/src/wp-admin/js/media.js +++ b/src/wp-admin/js/media.js @@ -1,3 +1,4 @@ +/* global ajaxurl, wpAjax */ var findPosts; (function($){ @@ -6,7 +7,7 @@ var findPosts; var st = document.documentElement.scrollTop || $(document).scrollTop(), overlay = $( '.ui-find-overlay' ); - if ( overlay.length == 0 ) { + if ( overlay.length === 0 ) { $( 'body' ).append( '
' ); findPosts.overlay(); } @@ -98,7 +99,7 @@ var findPosts; $(document).ready(function() { $('#find-posts-submit').click(function(e) { - if ( '' == $('#find-posts-response').html() ) + if ( '' === $('#find-posts-response').html() ) e.preventDefault(); }); $( '#find-posts .find-box-search :input' ).keypress( function( event ) { diff --git a/src/wp-includes/js/customize-preview.js b/src/wp-includes/js/customize-preview.js index caefe653a9..5f81ec7564 100644 --- a/src/wp-includes/js/customize-preview.js +++ b/src/wp-includes/js/customize-preview.js @@ -90,10 +90,10 @@ preview.send( 'synced' ); }); - preview.bind( 'active', function() { - if ( api.settings.nonce ) - preview.send( 'nonce', api.settings.nonce ); - }); + preview.bind( 'active', function() { + if ( api.settings.nonce ) + preview.send( 'nonce', api.settings.nonce ); + }); preview.send( 'ready' ); diff --git a/src/wp-includes/js/jquery/jquery.table-hotkeys.js b/src/wp-includes/js/jquery/jquery.table-hotkeys.js index f8b17602e3..bc7835e954 100644 --- a/src/wp-includes/js/jquery/jquery.table-hotkeys.js +++ b/src/wp-includes/js/jquery/jquery.table-hotkeys.js @@ -8,7 +8,7 @@ p = p.parent(); } return true; - } + }; return this.filter(is_visible); }; $.table_hotkeys = function(table, keys, opts) { @@ -16,7 +16,7 @@ var selected_class, destructive_class, set_current_row, adjacent_row_callback, get_adjacent_row, adjacent_row, prev_row, next_row, check, get_first_row, get_last_row, make_key_callback, first_row; selected_class = opts.class_prefix + opts.selected_suffix; - destructive_class = opts.class_prefix + opts.destructive_suffix + destructive_class = opts.class_prefix + opts.destructive_suffix; set_current_row = function (tr) { if ($.table_hotkeys.current_row) $.table_hotkeys.current_row.removeClass(selected_class); tr.addClass(selected_class); @@ -66,7 +66,7 @@ if (!clickable.length) return false; if (clickable.is('.'+destructive_class)) next_row() || prev_row(); clickable.click(); - } + }; }; first_row = get_first_row(); if (!first_row.length) return; @@ -74,8 +74,8 @@ set_current_row(first_row); else if (opts.highlight_last) set_current_row(get_last_row()); - $.hotkeys.add(opts.prev_key, opts.hotkeys_opts, function() {return adjacent_row_callback('prev')}); - $.hotkeys.add(opts.next_key, opts.hotkeys_opts, function() {return adjacent_row_callback('next')}); + $.hotkeys.add(opts.prev_key, opts.hotkeys_opts, function() {return adjacent_row_callback('prev');}); + $.hotkeys.add(opts.next_key, opts.hotkeys_opts, function() {return adjacent_row_callback('next');}); $.hotkeys.add(opts.mark_key, opts.hotkeys_opts, check); $.each(keys, function() { var callback, key; diff --git a/src/wp-includes/js/media-editor.js b/src/wp-includes/js/media-editor.js index 5e2a5fa629..75b1c570d9 100644 --- a/src/wp-includes/js/media-editor.js +++ b/src/wp-includes/js/media-editor.js @@ -1,3 +1,5 @@ +/* global getUserSetting, tinymce, QTags, wpActiveEditor */ + // WordPress, TinyMCE, and Media // ----------------------------- (function($){ @@ -524,7 +526,7 @@ var display = state.display( attachment ).toJSON(); return this.send.attachment( display, attachment.toJSON() ); }, this ) ).done( function() { - wp.media.editor.insert( _.toArray( arguments ).join("\n\n") ); + wp.media.editor.insert( _.toArray( arguments ).join('\n\n') ); }); }, this );