From dd766aa24649cc5013be66af66f89f9edbb4128c Mon Sep 17 00:00:00 2001 From: Dion Hulse Date: Tue, 21 Feb 2017 03:50:13 +0000 Subject: [PATCH] Menus: Prevent notice thrown in class-walker-page.php. Calling `Walker_Page::walk()` directly was causing an `Undefined index: item_spacing` notice to be thrown, this adds an `isset()` check to prevent it. Props bhargavbhandari90, peterwilsoncc. Merges [39949] to the 4.7 branch. Fixes #39564. git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40092 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/class-walker-page.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/wp-includes/class-walker-page.php b/src/wp-includes/class-walker-page.php index 3fcaa67a86..30831bbc8a 100644 --- a/src/wp-includes/class-walker-page.php +++ b/src/wp-includes/class-walker-page.php @@ -53,7 +53,7 @@ class Walker_Page extends Walker { * Default empty array. */ public function start_lvl( &$output, $depth = 0, $args = array() ) { - if ( 'preserve' === $args['item_spacing'] ) { + if ( isset( $args['item_spacing'] ) && 'preserve' === $args['item_spacing'] ) { $t = "\t"; $n = "\n"; } else { @@ -78,7 +78,7 @@ class Walker_Page extends Walker { * Default empty array. */ public function end_lvl( &$output, $depth = 0, $args = array() ) { - if ( 'preserve' === $args['item_spacing'] ) { + if ( isset( $args['item_spacing'] ) && 'preserve' === $args['item_spacing'] ) { $t = "\t"; $n = "\n"; } else { @@ -103,7 +103,7 @@ class Walker_Page extends Walker { * @param int $current_page Optional. Page ID. Default 0. */ public function start_el( &$output, $page, $depth = 0, $args = array(), $current_page = 0 ) { - if ( 'preserve' === $args['item_spacing'] ) { + if ( isset( $args['item_spacing'] ) && 'preserve' === $args['item_spacing'] ) { $t = "\t"; $n = "\n"; } else { @@ -196,7 +196,7 @@ class Walker_Page extends Walker { * @param array $args Optional. Array of arguments. Default empty array. */ public function end_el( &$output, $page, $depth = 0, $args = array() ) { - if ( 'preserve' === $args['item_spacing'] ) { + if ( isset( $args['item_spacing'] ) && 'preserve' === $args['item_spacing'] ) { $t = "\t"; $n = "\n"; } else {