sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Customizer: Improve _doing_it_wrong() message when widgets or nav_menus are manually removed via WP_Customize_Manager::remove_panel().

Browse Source 
* Link to code reference page for `customize_loaded_components` instead of linking to a Trac comment.
* Remove HTML code from being included in translated string.
* Add missing translator comment for the specifiers in the translated string.

Amends [36216].
Props DrewAPicture.
Fixes #35242.


git-svn-id: https://develop.svn.wordpress.org/trunk@36219 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Weston Ruter 2016-01-07 18:43:11 +00:00
parent 1f47f9c5f5
commit de5f72567a
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/wp-includes/class-wp-customize-manager.php
View File

@ -1202,13 +1202,16 @@ final class WP_Customize_Manager {
'widgets',
'nav_menus',
);
if ( in_array( $id, $core_panels, true ) ) {
$url = 'https://core.trac.wordpress.org/ticket/33552#comment:12';
_doing_it_wrong(
__METHOD__,
sprintf( __( 'Removing %1$s manually will cause PHP warnings. Use the <code>customize_loaded_components</code> filter instead. See <a href="%2$s">%2$s</a>.' ), $id, $url ),
'4.5'
/* translators: 1: panel id, 2: filter reference URL, 3: filter name */
$message = sprintf( __( 'Removing %1$s manually will cause PHP warnings. Use the <a href="%2$s">%3$s</a> filter instead.' ),
$id,
esc_url( 'https://developer.wordpress.org/reference/hooks/customize_loaded_components/' ),
'<code>customize_loaded_components</code>'
);
_doing_it_wrong( __METHOD__, $message, '4.5' );
}
unset( $this->panels[ $id ] );
}