From e2291664f1fa39bad155ed083234f7d17f5f74fb Mon Sep 17 00:00:00 2001 From: John Blackbourn Date: Wed, 29 Nov 2017 15:51:19 +0000 Subject: [PATCH] Hardening: Use a properly generated hash for the `newbloguser` key instead of a determinate substring. git-svn-id: https://develop.svn.wordpress.org/trunk@42258 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/user-new.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wp-admin/user-new.php b/src/wp-admin/user-new.php index ebcd2a7dca..641fd822fd 100644 --- a/src/wp-admin/user-new.php +++ b/src/wp-admin/user-new.php @@ -75,7 +75,7 @@ if ( isset($_REQUEST['action']) && 'adduser' == $_REQUEST['action'] ) { $redirect = add_query_arg( array( 'update' => 'could_not_add' ), 'user-new.php' ); } } else { - $newuser_key = substr( md5( $user_id ), 0, 5 ); + $newuser_key = wp_generate_password( 20, false ); add_option( 'new_user_' . $newuser_key, array( 'user_id' => $user_id, 'email' => $user_details->user_email, 'role' => $_REQUEST[ 'role' ] ) ); $roles = get_editable_roles();