sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't query against entire users table in wp_dropdown_users() to be multisite friendly. Fixes #11086 

git-svn-id: https://develop.svn.wordpress.org/trunk@13122 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Andrew Nacin 2010-02-13 20:12:08 +00:00
parent 0210cf3c6e
commit e2e67c91cb
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
wp-includes/user.php
View File

@ -507,6 +507,7 @@ function setup_userdata($for_user_id = '') {
* <li>selected - Which User ID is selected.</li> * <li>selected - Which User ID is selected.</li>
* <li>name - Default is 'user'. Name attribute of select element.</li> * <li>name - Default is 'user'. Name attribute of select element.</li>
* <li>class - Class attribute of select element.</li> * <li>class - Class attribute of select element.</li>
* <li>blog - ID of blog (Multisite only). Defaults to ID of current blog.</li>
* </ol> * </ol>
* *
* @since 2.3.0 * @since 2.3.0
@ -516,13 +517,13 @@ function setup_userdata($for_user_id = '') {
* @return string|null Null on display. String of HTML content on retrieve. * @return string|null Null on display. String of HTML content on retrieve.
*/ */
function wp_dropdown_users( $args = '' ) { function wp_dropdown_users( $args = '' ) {
global $wpdb; global $wpdb, $blog_id;
$defaults = array( $defaults = array(
'show_option_all' => '', 'show_option_none' => '', 'show_option_all' => '', 'show_option_none' => '',
'orderby' => 'display_name', 'order' => 'ASC', 'orderby' => 'display_name', 'order' => 'ASC',
'include' => '', 'exclude' => '', 'multi' => 0, 'include' => '', 'exclude' => '', 'multi' => 0,
'show' => 'display_name', 'echo' => 1, 'show' => 'display_name', 'echo' => 1,
'selected' => 0, 'name' => 'user', 'class' => '' 'selected' => 0, 'name' => 'user', 'class' => '', 'blog' => $blog_id,
); );
$defaults['selected'] = is_author() ? get_query_var( 'author' ) : 0; $defaults['selected'] = is_author() ? get_query_var( 'author' ) : 0;
@ -530,7 +531,8 @@ function wp_dropdown_users( $args = '' ) {
$r = wp_parse_args( $args, $defaults ); $r = wp_parse_args( $args, $defaults );
extract( $r, EXTR_SKIP ); extract( $r, EXTR_SKIP );
$query = "SELECT * FROM $wpdb->users"; $blog_prefix = $wpdb->get_blog_prefix( $blog );
$query = "SELECT {$wpdb->users}.* FROM $wpdb->users, $wpdb->usermeta WHERE {$wpdb->users}.ID = {$wpdb->usermeta}.user_id AND meta_key = '{$blog_prefix}capabilities'";
$query_where = array(); $query_where = array();
@ -547,7 +549,7 @@ function wp_dropdown_users( $args = '' ) {
$query_where[] = "ID NOT IN ($exclude)"; $query_where[] = "ID NOT IN ($exclude)";
if ( $query_where ) if ( $query_where )
$query .= " WHERE " . join(' AND', $query_where); $query .= " AND " . join(' AND', $query_where);
$query .= " ORDER BY $orderby $order"; $query .= " ORDER BY $orderby $order";