sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Dead code in `wp-admin/includes/file.php`: 

* In `wp_handle_upload()` and `wp_handle_sideload()`, `$ext` gets conditionally reset... and then is never used.
* In `request_filesystem_credentials()`, `$password` is initialized as an empty string. The variable is never used.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28268 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor 2014-05-06 04:21:35 +00:00
parent 7ada7af9d0
commit e42ec45553
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/wp-admin/includes/file.php
View File

@ -294,9 +294,6 @@ function wp_handle_upload( &$file, $overrides = false, $time = null ) {
if ( ( !$type || !$ext ) && !current_user_can( 'unfiltered_upload' ) )
return call_user_func($upload_error_handler, $file, __( 'Sorry, this file type is not permitted for security reasons.' ));
if ( !$ext )
$ext = ltrim(strrchr($file['name'], '.'), '.');
if ( !$type )
$type = $file['type'];
} else {
@ -434,9 +431,6 @@ function wp_handle_sideload( &$file, $overrides = false, $time = null ) {
if ( ( !$type || !$ext ) && !current_user_can( 'unfiltered_upload' ) )
return $upload_error_handler( $file, __( 'Sorry, this file type is not permitted for security reasons.' ));
if ( !$ext )
$ext = ltrim(strrchr($file['name'], '.'), '.');
if ( !$type )
$type = $file['type'];
}
@ -1062,7 +1056,6 @@ function request_filesystem_credentials($form_post, $type = '', $error = false,
}
$hostname = '';
$username = '';
$password = '';
$connection_type = '';
if ( !empty($credentials) )
extract($credentials, EXTR_OVERWRITE);