From e99e14570e37bdbb11a85f629ee578c0311a84d4 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Sat, 5 Oct 2019 02:15:13 +0000 Subject: [PATCH] Filesystem API: Use strict type check in the `in_array()` call for the `$skip_list` parameter in `copy_dir()` and `_copy_dir()`. This ensures that parent folders with a numeric name are not accidentally skipped when only a subfolder is intended to be skipped. Props codex-m. Fixes #46581. git-svn-id: https://develop.svn.wordpress.org/trunk@46400 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/file.php | 2 +- src/wp-admin/includes/update-core.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wp-admin/includes/file.php b/src/wp-admin/includes/file.php index edb3d99361..2e4493e8d8 100644 --- a/src/wp-admin/includes/file.php +++ b/src/wp-admin/includes/file.php @@ -1705,7 +1705,7 @@ function copy_dir( $from, $to, $skip_list = array() ) { $to = trailingslashit( $to ); foreach ( (array) $dirlist as $filename => $fileinfo ) { - if ( in_array( $filename, $skip_list ) ) { + if ( in_array( $filename, $skip_list, true ) ) { continue; } diff --git a/src/wp-admin/includes/update-core.php b/src/wp-admin/includes/update-core.php index 1cb915f858..8df6150356 100644 --- a/src/wp-admin/includes/update-core.php +++ b/src/wp-admin/includes/update-core.php @@ -1312,7 +1312,7 @@ function _copy_dir( $from, $to, $skip_list = array() ) { $to = trailingslashit( $to ); foreach ( (array) $dirlist as $filename => $fileinfo ) { - if ( in_array( $filename, $skip_list ) ) { + if ( in_array( $filename, $skip_list, true ) ) { continue; }