sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't do a strict taxonomy check in `get_category_link()`. 

Prior to version 4.9, a quirk in the implementation of `get_term()` caused
`get_category_link( 123 )` to fetch the taxonomy archive link for term 123
even if 123 is not in the 'category' taxonomy. The quirk was fixed in [40979];
see #40671. This bugfix introduced a regression for theme authors who were
expecting the old behavior.

By lifting the 'category' restriction, we allow the template function to work
in the old way.

Fixes #42717. See #42771.

git-svn-id: https://develop.svn.wordpress.org/trunk@42364 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges 2017-12-04 20:38:57 +00:00
parent 6cb2a02695
commit e9d828ce41
2 changed files with 55 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wp-includes/category-template.php
View File

@ -21,7 +21,7 @@ function get_category_link( $category ) {
$category = (int) $category;
}
$category = get_term_link( $category, 'category' );
$category = get_term_link( $category );
if ( is_wp_error( $category ) ) {
return '';

54
tests/phpunit/tests/category/getCategoryLink.php Normal file
View File

@ -0,0 +1,54 @@
<?php
/**
* @group taxonomy
* @covers ::get_category_link
*/
class Tests_Category_GetCategoryLink extends WP_UnitTestCase {
public function test_success() {
$c = self::factory()->category->create();
$found = get_category_link( $c );
$expected = home_url( '?cat=' . $c );
$this->assertSame( $expected, $found );
}
/**
* @ticket 42771
*/
public function test_should_return_link_for_term_from_another_category_on_primed_cache() {
register_taxonomy( 'wptests_tax', 'post' );
$t = self::factory()->term->create( array(
'taxonomy' => 'wptests_tax',
'slug' => 'test-term',
) );
$term = get_term( $t );
$found = get_category_link( $t );
$expected = home_url( '?wptests_tax=test-term' );
$this->assertSame( $expected, $found );
}
/**
* @ticket 42771
*/
public function test_should_return_link_for_term_from_another_category_on_empty_cache() {
register_taxonomy( 'wptests_tax', 'post' );
$t = self::factory()->term->create( array(
'taxonomy' => 'wptests_tax',
'slug' => 'test-term',
) );
clean_term_cache( $t );
$found = get_category_link( $t );
$expected = home_url( '?wptests_tax=test-term' );
$this->assertSame( $expected, $found );
}
}