sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add a `$post_id` fixture to `Tests_Comment_Query`. Comments created without passing `comment_post_ID` produce an undefined variable notice in `wp_insert_comment()`. 

See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25364 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor 2013-09-11 21:47:14 +00:00
parent 169ddb12ad
commit eddb6d958b
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tests/phpunit/tests/comment/query.php
View File

@ -6,17 +6,20 @@
* @group comment
*/
class Tests_Comment_Query extends WP_UnitTestCase {
var $comment_id;
protected $post_id;
protected $comment_id;
function setUp() {
parent::setUp();
$this->post_id = $this->factory->post->create();
}
/**
* @ticket 21101
*/
function test_get_comment_comment_approved_0() {
$comment_id = $this->factory->comment->create();
$comment_id = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id ) );
$comments_approved_0 = get_comments( array( 'status' => 'hold' ) );
$this->assertEquals( 0, count( $comments_approved_0 ) );
}
@ -25,7 +28,7 @@ class Tests_Comment_Query extends WP_UnitTestCase {
* @ticket 21101
*/
function test_get_comment_comment_approved_1() {
$comment_id = $this->factory->comment->create();
$comment_id = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id ) );
$comments_approved_1 = get_comments( array( 'status' => 'approve' ) );
$this->assertEquals( 1, count( $comments_approved_1 ) );
@ -80,9 +83,9 @@ class Tests_Comment_Query extends WP_UnitTestCase {
* @ticket 21003
*/
function test_orderby_meta() {
$comment_id = $this->factory->comment->create();
$comment_id2 = $this->factory->comment->create();
$comment_id3 = $this->factory->comment->create();
$comment_id = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id ) );
$comment_id2 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id ) );
$comment_id3 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id ) );
add_comment_meta( $comment_id, 'key', 'value1', true );
add_comment_meta( $comment_id, 'key1', 'value1', true );