sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Accessibility: the iframes used for the update progress in the Updates screen need title attributes to describe their content.

Browse Source 
Fixes #34763.

git-svn-id: https://develop.svn.wordpress.org/trunk@35854 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Andrea Fercia 2015-12-10 17:20:18 +00:00
parent d13adcc9bf
commit f207e68c27
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/wp-admin/includes/class-wp-upgrader-skins.php
View File

@ -224,7 +224,8 @@ class Plugin_Upgrader_Skin extends WP_Upgrader_Skin {
public function after() { public function after() {
$this->plugin = $this->upgrader->plugin_info(); $this->plugin = $this->upgrader->plugin_info();
if ( !empty($this->plugin) && !is_wp_error($this->result) && $this->plugin_active ){ if ( !empty($this->plugin) && !is_wp_error($this->result) && $this->plugin_active ){
echo '<iframe style="border:0;overflow:hidden" width="100%" height="170px" src="' . wp_nonce_url('update.php?action=activate-plugin&networkwide=' . $this->plugin_network_active . '&plugin=' . urlencode( $this->plugin ), 'activate-plugin_' . $this->plugin) .'"></iframe>'; // Currently used only when JS is off for a single plugin update?
echo '<iframe title="' . esc_attr( 'Update progress' ) . '" style="border:0;overflow:hidden" width="100%" height="170" src="' . wp_nonce_url( 'update.php?action=activate-plugin&networkwide=' . $this->plugin_network_active . '&plugin=' . urlencode( $this->plugin ), 'activate-plugin_' . $this->plugin ) . '"></iframe>';
} }
$this->decrement_update_count( 'plugin' ); $this->decrement_update_count( 'plugin' );

4
src/wp-admin/update-core.php
View File

@ -644,7 +644,7 @@ if ( 'upgrade-core' == $action ) {
require_once(ABSPATH . 'wp-admin/admin-header.php'); require_once(ABSPATH . 'wp-admin/admin-header.php');
echo '<div class="wrap">'; echo '<div class="wrap">';
echo '<h1>' . __( 'Update Plugins' ) . '</h1>'; echo '<h1>' . __( 'Update Plugins' ) . '</h1>';
echo '<iframe src="', $url, '" style="width: 100%; height: 100%; min-height: 750px;" frameborder="0"></iframe>'; echo '<iframe src="', $url, '" style="width: 100%; height: 100%; min-height: 750px;" frameborder="0" title="' . esc_attr( 'Update progress' ) . '"></iframe>';
echo '</div>'; echo '</div>';
include(ABSPATH . 'wp-admin/admin-footer.php'); include(ABSPATH . 'wp-admin/admin-footer.php');
@ -673,7 +673,7 @@ if ( 'upgrade-core' == $action ) {
?> ?>
<div class="wrap"> <div class="wrap">
<h1><?php _e( 'Update Themes' ); ?></h1> <h1><?php _e( 'Update Themes' ); ?></h1>
<iframe src="<?php echo $url ?>" style="width: 100%; height: 100%; min-height: 750px;" frameborder="0"></iframe> <iframe src="<?php echo $url ?>" style="width: 100%; height: 100%; min-height: 750px;" frameborder="0" title="<?php esc_attr_e( 'Update progress' ); ?>"></iframe>
</div> </div>
<?php <?php
include(ABSPATH . 'wp-admin/admin-footer.php'); include(ABSPATH . 'wp-admin/admin-footer.php');