From f2f3b3696bdeb9558ddce61b28f3b89e7f5fd442 Mon Sep 17 00:00:00 2001 From: Joe McGill Date: Thu, 3 Nov 2016 02:22:43 +0000 Subject: [PATCH] Media: Sanity check array value in `wp_prepare_attachment_for_js()`. This adds a sanity check to the return value of the `image_downsize` filter in `wp_prepare_attachment_for_js()` to avoid undefined offest notices. Props justinbusa for initial patch. Fixes 34437. git-svn-id: https://develop.svn.wordpress.org/trunk@39107 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/media.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/wp-includes/media.php b/src/wp-includes/media.php index ad733013af..a3a8088a15 100644 --- a/src/wp-includes/media.php +++ b/src/wp-includes/media.php @@ -3159,8 +3159,10 @@ function wp_prepare_attachment_for_js( $attachment ) { /** This filter is documented in wp-includes/media.php */ if ( $downsize = apply_filters( 'image_downsize', false, $attachment->ID, $size ) ) { - if ( ! $downsize[3] ) + if ( empty( $downsize[3] ) ) { continue; + } + $sizes[ $size ] = array( 'height' => $downsize[2], 'width' => $downsize[1],