From f323dc9b4864c7829d29a1bec820c12e5c74a048 Mon Sep 17 00:00:00 2001 From: Scott Taylor Date: Sun, 11 Jan 2015 00:12:47 +0000 Subject: [PATCH] `WP_Ajax_Response` has one property only, `$responses`. It was public until [28508], when it became `private` in name only. Is it worth 4 magic methods to pretend that this property is `private`? It is not. Make it `public` and remove the magic methods. See #30891. git-svn-id: https://develop.svn.wordpress.org/trunk@31139 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/class-wp-ajax-response.php | 55 +--------------------- 1 file changed, 1 insertion(+), 54 deletions(-) diff --git a/src/wp-includes/class-wp-ajax-response.php b/src/wp-includes/class-wp-ajax-response.php index 42f30ad030..1c6d8a834c 100644 --- a/src/wp-includes/class-wp-ajax-response.php +++ b/src/wp-includes/class-wp-ajax-response.php @@ -11,9 +11,8 @@ class WP_Ajax_Response { * * @since 2.1.0 * @var array - * @access private */ - private $responses = array(); + public $responses = array(); /** * Constructor - Passes args to {@link WP_Ajax_Response::add()}. @@ -28,58 +27,6 @@ class WP_Ajax_Response { $this->add($args); } - /** - * Make private properties readable for backwards compatibility. - * - * @since 4.0.0 - * @access public - * - * @param string $name Property to get. - * @return mixed Property. - */ - public function __get( $name ) { - return $this->$name; - } - - /** - * Make private properties settable for backwards compatibility. - * - * @since 4.0.0 - * @access public - * - * @param string $name Property to set. - * @param mixed $value Property value. - * @return mixed Newly-set property. - */ - public function __set( $name, $value ) { - return $this->$name = $value; - } - - /** - * Make private properties checkable for backwards compatibility. - * - * @since 4.0.0 - * @access public - * - * @param string $name Property to check if set. - * @return bool Whether the property is set. - */ - public function __isset( $name ) { - return isset( $this->$name ); - } - - /** - * Make private properties un-settable for backwards compatibility. - * - * @since 4.0.0 - * @access public - * - * @param string $name Property to unset. - */ - public function __unset( $name ) { - unset( $this->$name ); - } - /** * Append to XML response based on given arguments. *