From f3241f4883c2c7fef7a442bebd6aad61fda7b99b Mon Sep 17 00:00:00 2001
From: Sergey Biryukov <sergeybiryukov@git.wordpress.org>
Date: Fri, 16 Aug 2019 00:38:42 +0000
Subject: [PATCH] Administration: Replace legacy `updated` message type in
 `add_settings_error()` calls with `success`.

See #44640.

git-svn-id: https://develop.svn.wordpress.org/trunk@45818 602fd350-edb4-49c9-b593-d223f7449a82
---
 src/wp-admin/includes/class-wp-privacy-requests-table.php | 4 ++--
 src/wp-admin/includes/privacy-tools.php                   | 4 ++--
 src/wp-admin/options-head.php                             | 2 +-
 src/wp-admin/options-permalink.php                        | 2 +-
 src/wp-admin/options-privacy.php                          | 2 +-
 src/wp-admin/options.php                                  | 2 +-
 6 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/wp-admin/includes/class-wp-privacy-requests-table.php b/src/wp-admin/includes/class-wp-privacy-requests-table.php
index fe5a516431..dc49e91288 100644
--- a/src/wp-admin/includes/class-wp-privacy-requests-table.php
+++ b/src/wp-admin/includes/class-wp-privacy-requests-table.php
@@ -237,7 +237,7 @@ abstract class WP_Privacy_Requests_Table extends WP_List_Table {
 					'bulk_action',
 					/* translators: %d: number of requests */
 					sprintf( _n( 'Deleted %d request', 'Deleted %d requests', $count ), $count ),
-					'updated'
+					'success'
 				);
 				break;
 			case 'resend':
@@ -254,7 +254,7 @@ abstract class WP_Privacy_Requests_Table extends WP_List_Table {
 					'bulk_action',
 					/* translators: %d: number of requests */
 					sprintf( _n( 'Re-sent %d request', 'Re-sent %d requests', $count ), $count ),
-					'updated'
+					'success'
 				);
 				break;
 		}
diff --git a/src/wp-admin/includes/privacy-tools.php b/src/wp-admin/includes/privacy-tools.php
index 7e2badcb4e..e3a942a6d2 100644
--- a/src/wp-admin/includes/privacy-tools.php
+++ b/src/wp-admin/includes/privacy-tools.php
@@ -88,7 +88,7 @@ function _wp_personal_data_handle_actions() {
 				'privacy_action_email_retry',
 				'privacy_action_email_retry',
 				__( 'Confirmation request sent again successfully.' ),
-				'updated'
+				'success'
 			);
 		}
 	} elseif ( isset( $_POST['action'] ) ) {
@@ -166,7 +166,7 @@ function _wp_personal_data_handle_actions() {
 					'username_or_email_for_privacy_request',
 					'username_or_email_for_privacy_request',
 					__( 'Confirmation request initiated successfully.' ),
-					'updated'
+					'success'
 				);
 				break;
 		}
diff --git a/src/wp-admin/options-head.php b/src/wp-admin/options-head.php
index a0e3a3307c..d96978b438 100644
--- a/src/wp-admin/options-head.php
+++ b/src/wp-admin/options-head.php
@@ -12,7 +12,7 @@ wp_reset_vars( array( 'action' ) );
 
 if ( isset( $_GET['updated'] ) && isset( $_GET['page'] ) ) {
 	// For back-compat with plugins that don't use the Settings API and just set updated=1 in the redirect.
-	add_settings_error( 'general', 'settings_updated', __( 'Settings saved.' ), 'updated' );
+	add_settings_error( 'general', 'settings_updated', __( 'Settings saved.' ), 'success' );
 }
 
 settings_errors();
diff --git a/src/wp-admin/options-permalink.php b/src/wp-admin/options-permalink.php
index c436545f01..ad3fc22242 100644
--- a/src/wp-admin/options-permalink.php
+++ b/src/wp-admin/options-permalink.php
@@ -151,7 +151,7 @@ if ( isset( $_POST['permalink_structure'] ) || isset( $_POST['category_base'] )
 	}
 
 	if ( ! get_settings_errors() ) {
-		add_settings_error( 'general', 'settings_updated', $message, 'updated' );
+		add_settings_error( 'general', 'settings_updated', $message, 'success' );
 	}
 
 	set_transient( 'settings_errors', get_settings_errors(), 30 );
diff --git a/src/wp-admin/options-privacy.php b/src/wp-admin/options-privacy.php
index 61e9569beb..709263d060 100644
--- a/src/wp-admin/options-privacy.php
+++ b/src/wp-admin/options-privacy.php
@@ -45,7 +45,7 @@ if ( ! empty( $action ) ) {
 			}
 		}
 
-		add_settings_error( 'page_for_privacy_policy', 'page_for_privacy_policy', $privacy_page_updated_message, 'updated' );
+		add_settings_error( 'page_for_privacy_policy', 'page_for_privacy_policy', $privacy_page_updated_message, 'success' );
 	} elseif ( 'create-privacy-page' === $action ) {
 
 		if ( ! class_exists( 'WP_Privacy_Policy_Content' ) ) {
diff --git a/src/wp-admin/options.php b/src/wp-admin/options.php
index d842a6e3ab..4c3a7ef3a7 100644
--- a/src/wp-admin/options.php
+++ b/src/wp-admin/options.php
@@ -302,7 +302,7 @@ if ( 'update' == $action ) {
 	 */
 	// If no settings errors were registered add a general 'updated' message.
 	if ( ! count( get_settings_errors() ) ) {
-		add_settings_error( 'general', 'settings_updated', __( 'Settings saved.' ), 'updated' );
+		add_settings_error( 'general', 'settings_updated', __( 'Settings saved.' ), 'success' );
 	}
 	set_transient( 'settings_errors', get_settings_errors(), 30 );