sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Widgets: Make sure changes to media widgets' instance schema via widget_{$this->id_base}_instance_schema filter are not overridden by subclasses.

Browse Source 
Previously, `WP_Widget_Media_Audio`, `WP_Widget_Media_Image`, and `WP_Widget_Media_Video` used to override the changes due to reversed arguments in `array_merge()` call.

Props Toro_Unit, birgire.
Fixes #45029.

git-svn-id: https://develop.svn.wordpress.org/trunk@45100 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2019-04-02 22:12:11 +00:00
parent b3a625fdf1
commit f4e57f92e4
4 changed files with 48 additions and 53 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
src/wp-includes/widgets/class-wp-widget-media-audio.php
View File

@ -19,7 +19,7 @@ class WP_Widget_Media_Audio extends WP_Widget_Media {
/**
* Constructor.
*
* @since 4.8.0
* @since 4.8.0
*/
public function __construct() {
parent::__construct(
@ -54,7 +54,7 @@ class WP_Widget_Media_Audio extends WP_Widget_Media {
/**
* Get schema for properties of a widget instance (item).
*
* @since 4.8.0
* @since 4.8.0
*
* @see WP_REST_Controller::get_item_schema()
* @see WP_REST_Controller::get_additional_fields()
@ -62,21 +62,18 @@ class WP_Widget_Media_Audio extends WP_Widget_Media {
* @return array Schema for properties.
*/
public function get_instance_schema() {
$schema = array_merge(
parent::get_instance_schema(),
array(
'preload' => array(
'type' => 'string',
'enum' => array( 'none', 'auto', 'metadata' ),
'default' => 'none',
'description' => __( 'Preload' ),
),
'loop' => array(
'type' => 'boolean',
'default' => false,
'description' => __( 'Loop' ),
),
)
$schema = array(
'preload' => array(
'type' => 'string',
'enum' => array( 'none', 'auto', 'metadata' ),
'default' => 'none',
'description' => __( 'Preload' ),
),
'loop' => array(
'type' => 'boolean',
'default' => false,
'description' => __( 'Loop' ),
),
);
foreach ( wp_get_audio_extensions() as $audio_extension ) {
@ -89,13 +86,13 @@ class WP_Widget_Media_Audio extends WP_Widget_Media {
);
}
return $schema;
return array_merge( $schema, parent::get_instance_schema() );
}
/**
* Render the media on the frontend.
*
* @since 4.8.0
* @since 4.8.0
*
* @param array $instance Widget instance props.
* @return void

10
src/wp-includes/widgets/class-wp-widget-media-image.php
View File

@ -19,7 +19,7 @@ class WP_Widget_Media_Image extends WP_Widget_Media {
/**
* Constructor.
*
* @since 4.8.0
* @since 4.8.0
*/
public function __construct() {
parent::__construct(
@ -53,7 +53,7 @@ class WP_Widget_Media_Image extends WP_Widget_Media {
/**
* Get schema for properties of a widget instance (item).
*
* @since 4.8.0
* @since 4.8.0
*
* @see WP_REST_Controller::get_item_schema()
* @see WP_REST_Controller::get_additional_fields()
@ -62,7 +62,6 @@ class WP_Widget_Media_Image extends WP_Widget_Media {
*/
public function get_instance_schema() {
return array_merge(
parent::get_instance_schema(),
array(
'size' => array(
'type' => 'string',
@ -161,14 +160,15 @@ class WP_Widget_Media_Image extends WP_Widget_Media {
* - height (redundant when size is not custom)
* - width (redundant when size is not custom)
*/
)
),
parent::get_instance_schema()
);
}
/**
* Render the media on the frontend.
*
* @since 4.8.0
* @since 4.8.0
*
* @param array $instance Widget instance props.
* @return void

54
src/wp-includes/widgets/class-wp-widget-media-video.php
View File

@ -19,7 +19,7 @@ class WP_Widget_Media_Video extends WP_Widget_Media {
/**
* Constructor.
*
* @since 4.8.0
* @since 4.8.0
*/
public function __construct() {
parent::__construct(
@ -55,7 +55,7 @@ class WP_Widget_Media_Video extends WP_Widget_Media {
/**
* Get schema for properties of a widget instance (item).
*
* @since 4.8.0
* @since 4.8.0
*
* @see WP_REST_Controller::get_item_schema()
* @see WP_REST_Controller::get_additional_fields()
@ -63,30 +63,28 @@ class WP_Widget_Media_Video extends WP_Widget_Media {
* @return array Schema for properties.
*/
public function get_instance_schema() {
$schema = array_merge(
parent::get_instance_schema(),
array(
'preload' => array(
'type' => 'string',
'enum' => array( 'none', 'auto', 'metadata' ),
'default' => 'metadata',
'description' => __( 'Preload' ),
'should_preview_update' => false,
),
'loop' => array(
'type' => 'boolean',
'default' => false,
'description' => __( 'Loop' ),
'should_preview_update' => false,
),
'content' => array(
'type' => 'string',
'default' => '',
'sanitize_callback' => 'wp_kses_post',
'description' => __( 'Tracks (subtitles, captions, descriptions, chapters, or metadata)' ),
'should_preview_update' => false,
),
)
$schema = array(
'preload' => array(
'type' => 'string',
'enum' => array( 'none', 'auto', 'metadata' ),
'default' => 'metadata',
'description' => __( 'Preload' ),
'should_preview_update' => false,
),
'loop' => array(
'type' => 'boolean',
'default' => false,
'description' => __( 'Loop' ),
'should_preview_update' => false,
),
'content' => array(
'type' => 'string',
'default' => '',
'sanitize_callback' => 'wp_kses_post',
'description' => __( 'Tracks (subtitles, captions, descriptions, chapters, or metadata)' ),
'should_preview_update' => false,
),
);
foreach ( wp_get_video_extensions() as $video_extension ) {
@ -99,13 +97,13 @@ class WP_Widget_Media_Video extends WP_Widget_Media {
);
}
return $schema;
return array_merge( $schema, parent::get_instance_schema() );
}
/**
* Render the media on the frontend.
*
* @since 4.8.0
* @since 4.8.0
*
* @param array $instance Widget instance props.
*

2
src/wp-includes/widgets/class-wp-widget-media.php
View File

@ -122,7 +122,7 @@ abstract class WP_Widget_Media extends WP_Widget {
/**
* Get schema for properties of a widget instance (item).
*
* @since 4.8.0
* @since 4.8.0
*
* @see WP_REST_Controller::get_item_schema()
* @see WP_REST_Controller::get_additional_fields()