Comments: Remove unnecessary `aria-required` attribute from `comment_form()`, added with the function in [12810].
At the time, having both `required` and `aria-required` meant a wider range of support for browsers and assistive technology. Today, it's safe to use just `required`. Props lakenh, afercia, davidakennedy, henry.wright. Fixes #39045. git-svn-id: https://develop.svn.wordpress.org/trunk@42758 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
parent
cb78bce02f
commit
fb2e65d2b9
|
@ -2258,14 +2258,13 @@ function comment_form( $args = array(), $post_id = null ) {
|
||||||
}
|
}
|
||||||
|
|
||||||
$req = get_option( 'require_name_email' );
|
$req = get_option( 'require_name_email' );
|
||||||
$aria_req = ( $req ? " aria-required='true'" : '' );
|
|
||||||
$html_req = ( $req ? " required='required'" : '' );
|
$html_req = ( $req ? " required='required'" : '' );
|
||||||
$html5 = 'html5' === $args['format'];
|
$html5 = 'html5' === $args['format'];
|
||||||
$fields = array(
|
$fields = array(
|
||||||
'author' => '<p class="comment-form-author">' . '<label for="author">' . __( 'Name' ) . ( $req ? ' <span class="required">*</span>' : '' ) . '</label> ' .
|
'author' => '<p class="comment-form-author">' . '<label for="author">' . __( 'Name' ) . ( $req ? ' <span class="required">*</span>' : '' ) . '</label> ' .
|
||||||
'<input id="author" name="author" type="text" value="' . esc_attr( $commenter['comment_author'] ) . '" size="30" maxlength="245"' . $aria_req . $html_req . ' /></p>',
|
'<input id="author" name="author" type="text" value="' . esc_attr( $commenter['comment_author'] ) . '" size="30" maxlength="245"' . $html_req . ' /></p>',
|
||||||
'email' => '<p class="comment-form-email"><label for="email">' . __( 'Email' ) . ( $req ? ' <span class="required">*</span>' : '' ) . '</label> ' .
|
'email' => '<p class="comment-form-email"><label for="email">' . __( 'Email' ) . ( $req ? ' <span class="required">*</span>' : '' ) . '</label> ' .
|
||||||
'<input id="email" name="email" ' . ( $html5 ? 'type="email"' : 'type="text"' ) . ' value="' . esc_attr( $commenter['comment_author_email'] ) . '" size="30" maxlength="100" aria-describedby="email-notes"' . $aria_req . $html_req . ' /></p>',
|
'<input id="email" name="email" ' . ( $html5 ? 'type="email"' : 'type="text"' ) . ' value="' . esc_attr( $commenter['comment_author_email'] ) . '" size="30" maxlength="100" aria-describedby="email-notes"' . $html_req . ' /></p>',
|
||||||
'url' => '<p class="comment-form-url"><label for="url">' . __( 'Website' ) . '</label> ' .
|
'url' => '<p class="comment-form-url"><label for="url">' . __( 'Website' ) . '</label> ' .
|
||||||
'<input id="url" name="url" ' . ( $html5 ? 'type="url"' : 'type="text"' ) . ' value="' . esc_attr( $commenter['comment_author_url'] ) . '" size="30" maxlength="200" /></p>',
|
'<input id="url" name="url" ' . ( $html5 ? 'type="url"' : 'type="text"' ) . ' value="' . esc_attr( $commenter['comment_author_url'] ) . '" size="30" maxlength="200" /></p>',
|
||||||
);
|
);
|
||||||
|
@ -2282,7 +2281,7 @@ function comment_form( $args = array(), $post_id = null ) {
|
||||||
$fields = apply_filters( 'comment_form_default_fields', $fields );
|
$fields = apply_filters( 'comment_form_default_fields', $fields );
|
||||||
$defaults = array(
|
$defaults = array(
|
||||||
'fields' => $fields,
|
'fields' => $fields,
|
||||||
'comment_field' => '<p class="comment-form-comment"><label for="comment">' . _x( 'Comment', 'noun' ) . '</label> <textarea id="comment" name="comment" cols="45" rows="8" maxlength="65525" aria-required="true" required="required"></textarea></p>',
|
'comment_field' => '<p class="comment-form-comment"><label for="comment">' . _x( 'Comment', 'noun' ) . '</label> <textarea id="comment" name="comment" cols="45" rows="8" maxlength="65525" required="required"></textarea></p>',
|
||||||
/** This filter is documented in wp-includes/link-template.php */
|
/** This filter is documented in wp-includes/link-template.php */
|
||||||
'must_log_in' => '<p class="must-log-in">' . sprintf(
|
'must_log_in' => '<p class="must-log-in">' . sprintf(
|
||||||
/* translators: %s: login URL */
|
/* translators: %s: login URL */
|
||||||
|
|
Loading…
Reference in New Issue