From fc1f8db19a28cc6536dc9862c8c5da61a0984563 Mon Sep 17 00:00:00 2001 From: Jeremy Felt Date: Sun, 10 Apr 2016 02:02:04 +0000 Subject: [PATCH] 4.5 About Page, second round. * Adjust text. * Improve headings hierarchy. * Add translation functions and translator comments throughout. Props ocean90, afercia, ramiy, mikeschroder, mattfelten, helen. See #36173. git-svn-id: https://develop.svn.wordpress.org/trunk@37170 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/about.php | 95 +++++++++++++++++++++++++++----------- src/wp-admin/credits.php | 4 +- src/wp-admin/css/about.css | 12 ++++- src/wp-admin/freedoms.php | 2 +- 4 files changed, 82 insertions(+), 31 deletions(-) diff --git a/src/wp-admin/about.php b/src/wp-admin/about.php index caca10fadf..d23af10f0b 100644 --- a/src/wp-admin/about.php +++ b/src/wp-admin/about.php @@ -61,12 +61,12 @@ include( ABSPATH . 'wp-admin/admin-header.php' );

- +

- +

<code>.' ); ?>

@@ -77,27 +77,35 @@ include( ABSPATH . 'wp-admin/admin-header.php' );

- +

- %2$s' ), $customize_url, __( 'customizer' ) ); - } else { - $customizer_link = __( 'customizer' ); - } - ?> -

+

+ customizer.' ), + esc_url( $customize_url ) + ); + } else { + _e( 'Preview mobile, tablet, and desktop views directly in the customizer.' ); + } + ?>

- +

Site Identity section of the customizer.' ), add_query_arg( 'autofocus[section]', 'title_tagline', $customize_url ) ); + printf( + /* translators: %s: URL to Site Identity section of the customizer */ + __( 'Your theme supports custom logos! Try it out right now in the Site Identity section of the customizer.' ), + esc_url( add_query_arg( array( 'autofocus' => array( 'section' => 'title_tagline' ) ), $customize_url ) ) + ); } else { - _e( 'The Twenty Fifteen and Twenty Sixteen themes have been updated to support custom logos, which can be found in the Site Identity section of the Customizer.' ); + _e( 'The Twenty Fifteen and Twenty Sixteen themes have been updated to support custom logos, which can be found in the Site Identity section of the customizer.' ); } ?>

@@ -106,40 +114,71 @@ include( ABSPATH . 'wp-admin/admin-header.php' );
-

+

-

-

It’s really cool.' ), 'https://make.wordpress.org/core/2016/03/12/performance-improvements-for-images-in-wordpress-4-5/' ); ?>

+

+

It’s really cool.' ), + 'https://make.wordpress.org/core/2016/03/12/performance-improvements-for-images-in-wordpress-4-5/' + ); + ?>

-

-

comprehensive framework for rendering parts of the preview without rewriting your PHP code in JavaScript.' ), 'https://make.wordpress.org/core/2016/02/16/selective-refresh-in-the-customizer/' ); +

+

comprehensive framework for rendering parts of the preview without rewriting your PHP code in JavaScript.' ), + 'https://make.wordpress.org/core/2016/02/16/selective-refresh-in-the-customizer/' + ); if ( current_user_can( 'customize' ) && current_user_can( 'edit_theme_options' ) ) { if ( current_theme_supports( 'menus' ) && ! current_theme_supports( 'customize-selective-refresh-widgets' ) ) { - printf( ' ' . __( 'See it in action with Menus.' ), add_query_arg( 'autofocus[panel]', 'nav_menus', $customize_url ) ); + printf( + /* translators: %s: URL to Menus section of the customizer */ + ' ' . __( 'See it in action with Menus.' ), + esc_url( add_query_arg( array( 'autofocus' => array( 'panel' => 'nav_menus' ) ), $customize_url ) ) + ); } elseif ( current_theme_supports( 'customize-selective-refresh-widgets' ) ) { // If widgets are supported, menus are also because of the menus widget. - printf( ' ' . __( 'See it in action with Menus or Widgets.' ), add_query_arg( 'autofocus[panel]', 'nav_menus', $customize_url ), add_query_arg( 'autofocus[panel]', 'widgets', $customize_url ) ); + printf( + /* translators: 1: URL to Menus section of the customizer, 2: URL to Widgets section of the customizer */ + ' ' . __( 'See it in action with Menus or Widgets.' ), + esc_url( add_query_arg( array( 'autofocus' => array( 'panel' => 'nav_menus' ) ), $customize_url ) ), + esc_url( add_query_arg( array( 'autofocus' => array( 'panel' => 'widgets' ) ), $customize_url ) ) + ); } } ?>

-

+

-

-

wp_add_inline_script() enables adding extra code to registered scripts.' ), 'https://make.wordpress.org/core/2016/03/08/enhanced-script-loader-in-wordpress-4-5/' ); ?>

+

+

wp_add_inline_script()' + ); + ?>

-

-

directly overridden by themes via the template hierarchy.' ), 'https://make.wordpress.org/core/2016/03/11/embeds-changes-in-wordpress-4-5/' ); ?>

+

+

directly overridden by themes via the template hierarchy.' ), + 'https://make.wordpress.org/core/2016/03/11/embeds-changes-in-wordpress-4-5/' + ); + ?>

diff --git a/src/wp-admin/credits.php b/src/wp-admin/credits.php index 8457cd3838..3b29c0361f 100644 --- a/src/wp-admin/credits.php +++ b/src/wp-admin/credits.php @@ -20,7 +20,7 @@ include( ABSPATH . 'wp-admin/admin-header.php' );

-
+
@@ -118,5 +118,7 @@ __( 'Contributing Developers' ); __( 'Cofounder, Project Lead' ); __( 'Lead Developer' ); __( 'Release Lead' ); +__( 'Release Design Lead' ); +__( 'Release Deputy' ); __( 'Core Developer' ); __( 'External Libraries' ); diff --git a/src/wp-admin/css/about.css b/src/wp-admin/css/about.css index e2aac3415b..aad606fbed 100644 --- a/src/wp-admin/css/about.css +++ b/src/wp-admin/css/about.css @@ -109,20 +109,30 @@ text-align: center; } +.about-wrap .changelog h2, .about-wrap h3 { margin: 1.25em 0 .6em; font-size: 1.25em; line-height: 1.5em; } -.about-wrap .changelog h3 { +.about-wrap .changelog h2 { margin-top: 40px; + font-weight: 600; + text-align: left; } .about-wrap h4 { color: #23282d; } +.about-wrap .changelog h3 { + margin: 1.33em 0; + font-size: 1em; + line-height: inherit; + color: #23282d; +} + .about-wrap code, .about-wrap ol li p { font-size: 14px; diff --git a/src/wp-admin/freedoms.php b/src/wp-admin/freedoms.php index 81b02d8785..440f0853cc 100644 --- a/src/wp-admin/freedoms.php +++ b/src/wp-admin/freedoms.php @@ -19,7 +19,7 @@ include( ABSPATH . 'wp-admin/admin-header.php' );

-
+