Comments: Include post permalink in comment reply link.
Include the post's permalink when generating reply links in `get_comment_reply_link()` to account for comments displayed on index and archive pages. This reapplies [32786] which was inadvertently reverted in [42360]. Props justinahinon, donmhico. See #33383. Fixes #47174. git-svn-id: https://develop.svn.wordpress.org/trunk@45787 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
parent
3d53fdba73
commit
feb0830c79
@ -1697,7 +1697,8 @@ function get_comment_reply_link( $args = array(), $comment = null, $post = null
|
||||
'replytocom' => $comment->comment_ID,
|
||||
'unapproved' => false,
|
||||
'moderation-hash' => false,
|
||||
)
|
||||
),
|
||||
get_permalink( $post->ID )
|
||||
)
|
||||
) . '#' . $args['respond_id'],
|
||||
$data_attribute_string,
|
||||
|
@ -26,4 +26,44 @@ class Tests_Comment_GetCommentReplyLink extends WP_UnitTestCase {
|
||||
|
||||
$this->assertNull( get_comment_reply_link( $args ) );
|
||||
}
|
||||
|
||||
/**
|
||||
* Ensure comment reply links include post permalink.
|
||||
*
|
||||
* @ticket 47174
|
||||
*/
|
||||
public function test_get_comment_reply_link_should_include_post_permalink() {
|
||||
// Create a sample post.
|
||||
$post_id = self::factory()->post->create();
|
||||
|
||||
// Insert comment.
|
||||
$comment_id = self::factory()->comment->create(
|
||||
array(
|
||||
'comment_post_ID' => $post_id,
|
||||
'user_id' => 1,
|
||||
)
|
||||
);
|
||||
|
||||
// `depth` and `max_depth` required for reply links to display.
|
||||
$comment_reply_link = get_comment_reply_link(
|
||||
array(
|
||||
'depth' => 1,
|
||||
'max_depth' => 5,
|
||||
),
|
||||
$comment_id,
|
||||
$post_id
|
||||
);
|
||||
|
||||
$expected_url = esc_url(
|
||||
add_query_arg(
|
||||
array(
|
||||
'p' => $post_id,
|
||||
'replytocom' => $comment_id,
|
||||
),
|
||||
home_url( '/#respond' )
|
||||
)
|
||||
);
|
||||
|
||||
$this->assertContains( $expected_url, $comment_reply_link );
|
||||
}
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user