sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Bump H3 headings to H2 on Themes screen for better accessibility. 

props joehills.
fixes #33560.

git-svn-id: https://develop.svn.wordpress.org/trunk@33820 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2015-08-31 03:50:05 +00:00
parent 0de0c060c1
commit ff7e86d14c
3 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/wp-admin/includes/theme.php
View File

@ -533,8 +533,8 @@ function customize_themes_print_templates() {
<# if ( data.active ) { #>
<span class="current-label"><?php _e( 'Current Theme' ); ?></span>
<# } #>
<h3 class="theme-name">{{{ data.name }}}<span class="theme-version"><?php printf( __( 'Version: %s' ), '{{ data.version }}' ); ?></span></h3>
<h4 class="theme-author"><?php printf( __( 'By %s' ), '{{{ data.authorAndUri }}}' ); ?></h4>
<h2 class="theme-name">{{{ data.name }}}<span class="theme-version"><?php printf( __( 'Version: %s' ), '{{ data.version }}' ); ?></span></h2>
<h3 class="theme-author"><?php printf( __( 'By %s' ), '{{{ data.authorAndUri }}}' ); ?></h3>
<p class="theme-description">{{{ data.description }}}</p>
<# if ( data.parent ) { #>

2
src/wp-admin/js/theme.js
View File

@ -983,7 +983,7 @@ themes.view.Themes = wp.Backbone.View.extend({
// 'Add new theme' element shown at the end of the grid
if ( themes.data.settings.canInstall ) {
this.$el.append( '<div class="theme add-new-theme"><a href="' + themes.data.settings.installURI + '"><div class="theme-screenshot"><span></span></div><h3 class="theme-name">' + l10n.addNew + '</h3></a></div>' );
this.$el.append( '<div class="theme add-new-theme"><a href="' + themes.data.settings.installURI + '"><div class="theme-screenshot"><span></span></div><h2 class="theme-name">' + l10n.addNew + '</h2></a></div>' );
}
this.parent.page++;

16
src/wp-admin/themes.php
View File

@ -225,14 +225,14 @@ foreach ( $themes as $theme ) :
<div class="theme-author"><?php printf( __( 'By %s' ), $theme['author'] ); ?></div>
<?php if ( $theme['active'] ) { ?>
<h3 class="theme-name" id="<?php echo $aria_name; ?>">
<h2 class="theme-name" id="<?php echo $aria_name; ?>">
<?php
/* translators: %s: theme name */
printf( __( '<span>Active:</span> %s' ), $theme['name'] );
?>
</h3>
</h2>
<?php } else { ?>
<h3 class="theme-name" id="<?php echo $aria_name; ?>"><?php echo $theme['name']; ?></h3>
<h2 class="theme-name" id="<?php echo $aria_name; ?>"><?php echo $theme['name']; ?></h2>
<?php } ?>
<div class="theme-actions">
@ -327,14 +327,14 @@ $can_delete = current_user_can( 'delete_themes' );
<div class="theme-author"><?php printf( __( 'By %s' ), '{{{ data.author }}}' ); ?></div>
<# if ( data.active ) { #>
<h3 class="theme-name" id="{{ data.id }}-name">
<h2 class="theme-name" id="{{ data.id }}-name">
<?php
/* translators: %s: theme name */
printf( __( '<span>Active:</span> %s' ), '{{{ data.name }}}' );
?>
</h3>
</h2>
<# } else { #>
<h3 class="theme-name" id="{{ data.id }}-name">{{{ data.name }}}</h3>
<h2 class="theme-name" id="{{ data.id }}-name">{{{ data.name }}}</h2>
<# } #>
<div class="theme-actions">
@ -376,8 +376,8 @@ $can_delete = current_user_can( 'delete_themes' );
<# if ( data.active ) { #>
<span class="current-label"><?php _e( 'Current Theme' ); ?></span>
<# } #>
<h3 class="theme-name">{{{ data.name }}}<span class="theme-version"><?php printf( __( 'Version: %s' ), '{{ data.version }}' ); ?></span></h3>
<h4 class="theme-author"><?php printf( __( 'By %s' ), '{{{ data.authorAndUri }}}' ); ?></h4>
<h2 class="theme-name">{{{ data.name }}}<span class="theme-version"><?php printf( __( 'Version: %s' ), '{{ data.version }}' ); ?></span></h2>
<h3 class="theme-author"><?php printf( __( 'By %s' ), '{{{ data.authorAndUri }}}' ); ?></h3>
<# if ( data.hasUpdate ) { #>
<div class="theme-update-message">