sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

REST API: Make template handling resilient against plugins setting the global post.

Browse Source 
Plugins shouldn't be setting the global post object during a REST API request, but if they did this could cause unexpected errors when creating a post with a template.

Props Kipperlenny, TimothyBlynJacobs.
Fixes #49695.


git-svn-id: https://develop.svn.wordpress.org/trunk@49301 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Timothy Jacobs 2020-10-24 14:10:26 +00:00
parent 84e533ab9d
commit ff989eccce
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php
View File

@ -1344,8 +1344,10 @@ class WP_REST_Posts_Controller extends WP_REST_Controller {
} }
if ( $request['id'] ) { if ( $request['id'] ) {
$post = get_post( $request['id'] );
$current_template = get_page_template_slug( $request['id'] ); $current_template = get_page_template_slug( $request['id'] );
} else { } else {
$post = null;
$current_template = ''; $current_template = '';
} }
@ -1355,7 +1357,7 @@ class WP_REST_Posts_Controller extends WP_REST_Controller {
} }
// If this is a create request, get_post() will return null and wp theme will fallback to the passed post type. // If this is a create request, get_post() will return null and wp theme will fallback to the passed post type.
$allowed_templates = wp_get_theme()->get_page_templates( get_post( $request['id'] ), $this->post_type ); $allowed_templates = wp_get_theme()->get_page_templates( $post, $this->post_type );
if ( isset( $allowed_templates[ $template ] ) ) { if ( isset( $allowed_templates[ $template ] ) ) {
return true; return true;