Commit Graph

1147 Commits

Author SHA1 Message Date
Sergey Biryukov 806c94fe0a Docs: Remove an empty line between `@param` and `@return` tags, per the documentation standards.
See #49572.

git-svn-id: https://develop.svn.wordpress.org/trunk@48102 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-20 11:16:12 +00:00
John Blackbourn bcdaf86a42 Docs: Fix some documentation errors in bundled themes.
See #49572.

git-svn-id: https://develop.svn.wordpress.org/trunk@48101 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-20 07:22:31 +00:00
Ian Belanger 6ce65a2207 Bundled Themes: Twenty Sixteen table border extends beyond table.
Fixes issues where tables created by the table block have an extra border on the left side which extends below the table.

Props gsmumbo, mukesh27, JavierCasares.
Fixes #50180.

git-svn-id: https://develop.svn.wordpress.org/trunk@48074 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-17 17:25:19 +00:00
Ian Belanger 6ce58a4bac Bundled Themes: Twenty Nineteen horizontal rule is very narrow.
Fixes the issue by adding specific styles for the `<hr>` tag.

Props laurelfulford, nielslange, kjellr, samful, leprincenoir.
Fixes #45912.

git-svn-id: https://develop.svn.wordpress.org/trunk@48073 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-17 15:46:47 +00:00
Sergey Biryukov 3bdf8b7b02 Docs: Consistently include an empty line between `@since` tag and `@see`, `@link`, or `@global`, per the documentation standards.
See #49572.

git-svn-id: https://develop.svn.wordpress.org/trunk@48067 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-16 21:05:20 +00:00
Ian Belanger e4937bc7dd Bundled Themes: Twenty Seventeen pagination links don't appear for home pages.
Fixes issues where pagination does not work on the page that is set to the home page.

Props dimitris.m, laurelfulford, poena, ianbelanger, samful.
Fixes #39685.

git-svn-id: https://develop.svn.wordpress.org/trunk@48064 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-16 18:38:53 +00:00
Ian Belanger b139654684 Bundled Themes: Twenty Seventeen Navbar z-index issue.
Fixes navbar z-index issue by upping the z-index value to 1000 from 7.

Props halgatewood, justnorris, poena, sinatrateam.
Fixes #39384.

git-svn-id: https://develop.svn.wordpress.org/trunk@48061 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-16 17:14:05 +00:00
Ian Belanger 5b69998102 Bundled Themes: Twenty Nineteen dropcap appears higher than expected in Firefox.
Fixes the issue by adding moz specific top margin for the dropcap.

Props kjellr, joseph.dickson, maxpertici, samful.
Fixes #45876.

git-svn-id: https://develop.svn.wordpress.org/trunk@48047 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-15 15:11:01 +00:00
Ian Belanger 55f0a18c02 Bundled Themes: Twenty Nineteen long submenu item titles do not wrap.
Fixes the issue of long submenu item titles that do not wrap by adding a `max-width: 20rem;` and removing `white-space: nowrap;`.

Props kjellr, mukesh27, mohsinrasool, samful.
Fixes #45866.

git-svn-id: https://develop.svn.wordpress.org/trunk@48032 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-12 15:09:35 +00:00
Ian Belanger 73669965a6 Bundled Themes: Twenty Seventeen CSS issue when using rowspan in tables.
Fixes CSS issue when using rowspan in tables. This issue does not apply to the Table Block, just tables inserted as custom html.

Props aussi, subrataemfluence, jainnidhi.
Fixes #44004.

git-svn-id: https://develop.svn.wordpress.org/trunk@48028 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-11 17:13:05 +00:00
Ian Belanger d5c3483f8c Bundled Themes: Twenty Seventeen add Telegram and Whatsapp support to Social Media Menu.
Adds Telegram and Whatsapp support and SVG's to Social Media Menu.

Props cpasqualini, audrasjb, laurelfulford, karmatosed, ibdz.
Fixes #43999.

git-svn-id: https://develop.svn.wordpress.org/trunk@48027 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-11 15:29:02 +00:00
Ian Belanger 35dffcf2ec Bundled Themes: Twenty Twenty and Twenty Nineteen version bump.
We are releasing new versions of Twenty Twenty & Twenty Nineteen today thus we need to bump the version.

Props ianbelanger.
Fixes #50359.

git-svn-id: https://develop.svn.wordpress.org/trunk@47952 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-10 17:30:43 +00:00
Ian Belanger 5097db06aa Bundled Themes: Twenty Twenty number of replies not translatable.
Fixes the issue by removing the single quote from around the `1` in the elseif conditional of the comments template.

Props Parvand, SergeyBiryukov, desrosj, juliobox, Mista-Flo, benjamingosset, audrasjb, opurockey.
Fixes #49058.

git-svn-id: https://develop.svn.wordpress.org/trunk@47941 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-09 20:00:47 +00:00
Ian Belanger 3b0920dd37 Bundled Themes: Twenty Twenty HTML in featured image caption is being escaped.
Fixes the issue by replacing `esc_html` with `wp_kses_post` in the caption in featured images.

Props pierlo, JavierCasares, audrasjb.
Fixes #49833.

git-svn-id: https://develop.svn.wordpress.org/trunk@47940 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-09 19:50:26 +00:00
Ian Belanger 16c36e4d2e Bundled Themes: Twenty Fifteen bulleted list block appears too far to the left in the editor.
Fixes the issue by removing unnecessary margin rules for bulleted lists in the editor.

Props kjellr.
Fixes #50029.

git-svn-id: https://develop.svn.wordpress.org/trunk@47934 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-09 14:08:04 +00:00
Ian Belanger 6f03104cdc Bundled Themes: Twenty Twenty uses overly specific selector for button background.
Fixes the issue by removing `:not(.toogle)` from the `button` selector, as it is not needed.

Props flixos90.
Fixes #50271.

git-svn-id: https://develop.svn.wordpress.org/trunk@47933 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-09 13:50:38 +00:00
Jonathan Desrosiers 4e31dc573d Bundled Themes: Update several package versions in Twenty Twenty and Twenty Nineteen.
The following packages received version bumps:

Twenty Twenty
- `concurrently`
- `postcss-cli`
- `rtlcss`
- `stylelint-a11y`

Twenty Nineteen
- `node-sass`
- `postcss-cli`
- `rtlcss`

See #49768.

git-svn-id: https://develop.svn.wordpress.org/trunk@47925 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-08 18:45:08 +00:00
Sergey Biryukov ffd5d37c77 Bundled Themes: Consistently check for `WP_Error` before outputting `get_the_tag_list()`.
Some themes already had these checks in place as a result of [41756], but not others.

Props sixhours, davidakennedy, SergeyBiryukov.
Fixes #39860.

git-svn-id: https://develop.svn.wordpress.org/trunk@47886 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-02 17:03:06 +00:00
Jake Spurlock a5baf8b9c6 Bundled Themes: Add missing RTL styles for to fix inconsistent margins on `.alignwide` and `.alignfull` items.
Fixes the inconsistent margins for alignwide and alignfull classes used on Cover Block when it is the first block on a page.

Props kthmd, utz119, nikhilbhansi, and sabernhardt.
Fixes #49435.


git-svn-id: https://develop.svn.wordpress.org/trunk@47846 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-23 06:21:37 +00:00
Ian Belanger 930633096e Bundled Themes: Twenty Twenty inconsistent top and bottom margins for `.alignwide` and `.alignfull` on Chrome vs Safari.
Fixes the inconsistent margins for `alignwide` and `alignfull` classes used on Cover Block when it is the first block on a page.

Props kthmd, utz119, nikhilbhansi.
Fixes #49435.

git-svn-id: https://develop.svn.wordpress.org/trunk@47820 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-18 19:50:22 +00:00
Sergey Biryukov 6742d0d7a6 Coding Standards: Use strict comparison where static strings are involved.
This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47808 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-16 18:40:52 +00:00
Ian Belanger 7edaf9b3e3 Bundled Themes: Twenty Eleven & Twenty Twelve dropdown category widget exceeds parent div when strings are long enough.
Fixes the width of the category dropdown by limiting the width of `select` items in widgets using `max-width: 100%`.

Props gma992, karmatosed.
Fixes #37926.

git-svn-id: https://develop.svn.wordpress.org/trunk@47801 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-15 16:29:43 +00:00
Ian Belanger 9c3a5d30ab Bundled Themes: Twenty Twenty version bump.
We are releasing a new version of Twenty Twenty today thus we need to bump the version.

Props ianbelanger.
Fixes #50174.

git-svn-id: https://develop.svn.wordpress.org/trunk@47800 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-14 18:10:11 +00:00
Ian Belanger 7d94081279 Bundled Themes: Twenty Twenty custom post types that don't support authors, shows author box.
This fixes the issue where custom post types will show an author box, even if they don't support authors.

Props joyously, donmhico.
Fixes #48803.

git-svn-id: https://develop.svn.wordpress.org/trunk@47799 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-14 17:15:41 +00:00
Ian Belanger 3d68fda88f Bundled Themes: Twenty Twenty add GPLv2 compatible TikTok icon to the social icon menu.
This adds a GPLv2 compatible TikTok icon to replace the non-compatible TikTok icon and update the readme.txt file. Updates previous commit which used a non-compatible TikTok icon [47589]

Props poena, audrasjb, Emlebrun.
Fixes #49893.

git-svn-id: https://develop.svn.wordpress.org/trunk@47796 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-14 13:46:27 +00:00
Ian Belanger c1f05c9a32 Bundled Themes: Twenty Twenty add icon for g.page links.
Adds the option to use a g.page url for the social menu.

Props argentite, mayankmajeji.
Fixes #49088.

git-svn-id: https://develop.svn.wordpress.org/trunk@47795 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-14 13:03:59 +00:00
Ian Belanger afaab88e8e Bundled Themes: Twenty Twenty anchor links don't work in mobile menu.
Modifies the mobile modal menu javascript, so that anchor links will close the modal and scroll to the anchor within the page.

Props Giorgio25b, suzylah, yuhin, samful, bdcstr.
Fixes #48916.

git-svn-id: https://develop.svn.wordpress.org/trunk@47784 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-12 16:43:42 +00:00
Ian Belanger e6547ba815 Bundled Themes: Twenty Twenty customizer retina_logo should be hidden when no logo is set.
Modifies the Customize setting `Site Identity > Retina logo` so that the option is hidden if there is no logo is set in `Site Identity > Logo`.

Props truongwp.
Fixes #50109.

git-svn-id: https://develop.svn.wordpress.org/trunk@47776 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-08 19:34:14 +00:00
Ian Belanger 8ba39ba9f6 Bundled Themes: Twenty Twenty image caption is not aligned center when image is, on the front-end.
Fixes the image caption alignment issue by adding `text-align: center;` to `.wp-block-image .aligncenter figcaption`.

Props markusthiel, SergeyBiryukov, garethgillman.
Fixes #49320.

git-svn-id: https://develop.svn.wordpress.org/trunk@47689 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 18:17:11 +00:00
Ian Belanger c629ae3180 Bundled Themes: Twenty Twenty remove unnecessary `$css_dependencies` variable in `twentytwenty_block_editor_styles()`.
Removes the unnecessary `$css_dependencies` variable in `twentytwenty_block_editor_styles()`.

Props ocean90, Dency.
Fixes #49986.

git-svn-id: https://develop.svn.wordpress.org/trunk@47618 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-24 14:57:07 +00:00
Ian Belanger e3a8f680d4 Bundled Themes: Twenty Twenty button styles produce inconsistent output and cannot be edited.
Fixes the issue with button styles not working when the Gutenberg plugin is activated while maintaining backwards compatibility.

Props nrqsnchz, poena, kjellr.
Fixes #49896.

git-svn-id: https://develop.svn.wordpress.org/trunk@47614 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-23 15:39:55 +00:00
Ian Belanger c1bb2c2f74 Bundled Themes: Twenty Twenty resized images are centered inside the editor (with no alignment set) since WordPress 5.4.
Fixes the image alignment issue by removing `margin-left: auto;` and `margin-right: auto;` from `.editor-styles-wrapper .wp-block-image.is-resized`.

Props dianeco, JavierCasares.
Fixes #49600.

git-svn-id: https://develop.svn.wordpress.org/trunk@47613 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-22 19:23:54 +00:00
Ian Belanger 7016ad5a78 Bundled Themes: Twenty Twenty submenu items disappear underneath the Cover block.
Fixes the submenu issue by raising the z-index value of the site-header from 1 to 2.

Props kjellr, JavierCasares.
Fixes #49322.

git-svn-id: https://develop.svn.wordpress.org/trunk@47609 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-21 20:04:29 +00:00
Ian Belanger 134092ae54 Bundled Themes: Twenty Twenty missed license for images.
Fixes the image license in the readme by removing screenshot.png.

Props h71, poena.
Fixes #49316.

git-svn-id: https://develop.svn.wordpress.org/trunk@47608 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-21 19:41:26 +00:00
Ian Belanger e658596ff6 Bundled Themes: Twenty Twenty block editor inserter is missing the `+`.
Fixes the disappearing `+` in the block editor when using the latest version of the Gutenberg plugin, by adding support for the native Gutenberg editor styles and removing `color: inherit;` from Twenty Twenty's style.css.

Props nrqsnchz, .
Fixes #49610.

git-svn-id: https://develop.svn.wordpress.org/trunk@47607 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-21 19:15:20 +00:00
Sergey Biryukov d5a7a3a45d Comments: Use `comment` instead of an empty string for the `comment_type` DB field value in comments table.
This is the first step to bring support for custom comment types into WordPress.

Add a scheduled upgrade routine to update the type value for existing comments, in batches of 100 at a time.

Props imath, aaroncampbell, jeremyfelt, dshanske.
Fixes #49236.

git-svn-id: https://develop.svn.wordpress.org/trunk@47597 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-17 19:33:52 +00:00
Ian Belanger c1aea8fd8a Bundled Themes: Twenty Twenty fix typo in readme.txt.
Fixed TikTok was misspelled as Tik Tok in the readme.txt.

Props Asif2BD.
Fixes #49932.

git-svn-id: https://develop.svn.wordpress.org/trunk@47594 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-17 15:45:56 +00:00
Ian Belanger 2370457175 Bundled Themes: Twenty Nineteen center and right-aligned heading accents appear broken.
Fixes the center and right aligned heading accents so that they align with the text, instead of just staying left-aligned.

Props kjellr, melchoyce.
Fixes #49699.

git-svn-id: https://develop.svn.wordpress.org/trunk@47591 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-16 19:45:19 +00:00
Ian Belanger 3d762adf5c Bundled Themes: Twenty Twenty inline images in list blocks are not positioned correctly.
Fixes the alignment of inline images in list blocks to match the way they look in the editor.

Props poena, mayankmajeji, JavierCasares.
Fixes #49793.

git-svn-id: https://develop.svn.wordpress.org/trunk@47590 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-16 19:36:03 +00:00
Ian Belanger 76dc390352 Bundled Themes: Twenty Twenty add TikTok to the social icon menu.
This adds TikTok as an option in the social icon menu.

Props mislavjuric, poena, audrasjb.
Fixes #49893.

git-svn-id: https://develop.svn.wordpress.org/trunk@47589 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-16 19:00:01 +00:00
Ian Belanger 07bc94cc11 Bundled Themes: Twenty Nineteen editor style interferes with navigation menu block.
Update editor styles to prepare for changes coming to the editor in 5.5. Currently the issue is only present when using the latest version of the Gutenberg plugin.

Props kjellr, Joen.
Fixes #49613.

git-svn-id: https://develop.svn.wordpress.org/trunk@47587 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-16 14:54:37 +00:00
Ian Belanger 7b6e7babe4 Bundled Themes: Twenty Nineteen decrease the font size for widget titles.
Update styles to decrease the font size for widget titles.

Props kjellr, mukesh27.
Fixes #45865.

git-svn-id: https://develop.svn.wordpress.org/trunk@47586 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-16 14:36:20 +00:00
Sergey Biryukov 0b4e2c4604 Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved.
This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47550 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-05 03:00:44 +00:00
Jonathan Desrosiers fab1752b16 Bundled Themes: Bump version numbers and update changelogs in default themes for WordPress 5.4.
Props ianbelanger, desrosj, SergeyBiryukov.
Fixes #49743.

git-svn-id: https://develop.svn.wordpress.org/trunk@47539 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-31 19:09:45 +00:00
Sergey Biryukov 212778ab02 Twenty Nineteen: Update `style-editor.css` after [47327].
Props ianbelanger.
See #48526.

git-svn-id: https://develop.svn.wordpress.org/trunk@47537 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-31 18:55:13 +00:00
Sergey Biryukov d985b9d903 Twenty Nineteen: Update `style-rtl.css` after [47339].
Props ianbelanger.
See #49410.

git-svn-id: https://develop.svn.wordpress.org/trunk@47536 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-31 18:53:24 +00:00
Ian Belanger 628aec5fe2 Bundled Themes: Twenty Twenty Button block forces All Capital letters - revert [47531].
Reverts [47531] to add `text-transform: uppercase;` back to button blocks.

Props joyously.
Fixes #49710.

git-svn-id: https://develop.svn.wordpress.org/trunk@47534 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-30 18:27:08 +00:00
Ian Belanger ef988903b0 Bundled Themes: Twenty Twenty Button block forces All Capital letters.
Removes `text-transform: uppercase;` from button blocks in order to give the user the option to have a button without All Capital letters.

Props mukesh27.
Fixes #49710.

git-svn-id: https://develop.svn.wordpress.org/trunk@47531 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-30 15:18:40 +00:00
Sergey Biryukov 01ad44e871 Bundled Themes: Update calendar widget styles for 5.4 markup to fix the alignment of a single month link.
Follow-up to [47405].

Props sabernhardt.
Reviewed by ianbelanger, SergeyBiryukov.
Fixes #49549.

git-svn-id: https://develop.svn.wordpress.org/trunk@47444 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-10 20:51:46 +00:00
Ian Belanger 150a49a0b1 Bundled Themes: Twenty Twenty content font CSS selector is too important - updated.
This adds more selectors for headings, tables, addresses, cite, figcaption, file and caption blocks to make the font-family match as before [47133].

Props alexandreb3, SergeyBiryukov.
Fixes #49318.

git-svn-id: https://develop.svn.wordpress.org/trunk@47439 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-09 19:46:27 +00:00
Ian Belanger 3c5d847872 Bundled Themes: Update calendar widget styles for 5.4 markup.
Fixes the alignment of month links in the calendar widget with the changes in version 5.4 for all Bundled Themes, except Twenty Thirteen, which was already fixed in #49546.

Props sabernhardt.
Fixes #49549.

git-svn-id: https://develop.svn.wordpress.org/trunk@47405 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-02 16:53:36 +00:00
Ian Belanger b4d0da91f7 Bundled Themes: Twenty Twenty searchform.php error.
Fixes phpcs error in the searchform.php file. The variables in this file were not prefixed correctly.

Props fahimmurshed.
Fixes #49523.

git-svn-id: https://develop.svn.wordpress.org/trunk@47393 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-28 20:54:42 +00:00
Ian Belanger a00d79a07d Bundled Themes: Twenty Thirteen update calendar widget styles for 5.4 markup.
Fixes the alignment of month links in the calendar widget with the changes in version 5.4

Props sabernhardt.
Fixes #49546.

git-svn-id: https://develop.svn.wordpress.org/trunk@47392 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-28 20:05:39 +00:00
Sergey Biryukov 559ccdda0c Twenty Twenty: Replace quotation marks in starter content with HTML entities.
Props fahimmurshed.
Fixes #49534.

git-svn-id: https://develop.svn.wordpress.org/trunk@47388 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-27 21:58:54 +00:00
Ian Belanger bb6b0cdaa5 Bundled Themes: Twenty Nineteen text color setting in pullquote block not applied.
Fixes the pullquote color setting by adding classes that are more specific to the color options.

Props ianbelanger.
Fixes #49410.

git-svn-id: https://develop.svn.wordpress.org/trunk@47339 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-21 14:57:12 +00:00
Ian Belanger 6194b3c5d2 Bundled Themes: Twenty Nineteen Update margins in editor styles to address upcoming block editor margin changes.
Fixes the margins in the block editor to address recent changes in block margins.

Props Joen, SergeyBiryukov, kjellr, jffng, allancole.
Fixes #48526.

git-svn-id: https://develop.svn.wordpress.org/trunk@47327 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-20 16:38:38 +00:00
Ian Belanger e7382153fe Bundled Themes: Twenty Sixteen text color setting in pullquote block not applied.
Fixes the pullquote color setting by moving `color` from `blockquote p` to `blockquote`. Also adds the border-left to the front-end stylesheet to match the editor. Also adds styles for rtl pullquote.

Props kokkieh, desrosj, mukesh27, khushbu19, disillusia, aliveic, abrightclearweb, SergeyBiryukov.
Fixes #47019.

git-svn-id: https://develop.svn.wordpress.org/trunk@47273 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 19:36:56 +00:00
Ian Belanger 72e7742446 Bundled Themes: Twenty Twenty property border-style is overwritten - coding standard.
Fixes coding standard violations in the classic editor stylesheets.

Props ankitmaru.
Fixes #49006.

git-svn-id: https://develop.svn.wordpress.org/trunk@47264 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 16:09:50 +00:00
Ian Belanger d4475d552c Bundled Themes: Twenty Twenty post navigation links outside of the container.
Fixes a bug where the in-page pagination does not align within the inner container.

Props ataurr, audrasjb, mukesh27.
Fixes #48979.

git-svn-id: https://develop.svn.wordpress.org/trunk@47244 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 19:23:38 +00:00
Ian Belanger a604bba1f7 Bundled Themes: Twenty Twenty add WhatsApp to the social icon menu.
This adds WhatsApp as an option in the social icon menu.

Props rryyaanndd, audrasjb.
Fixes #49098.

git-svn-id: https://develop.svn.wordpress.org/trunk@47243 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 19:10:21 +00:00
Sergey Biryukov f160d6a765 Twenty Nineteen: Add the missing `inc/helper-functions.php` file.
Follow-up to [47214].

Props kjellr, jffng.
Fixes #45984.

git-svn-id: https://develop.svn.wordpress.org/trunk@47242 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 19:05:17 +00:00
Ian Belanger d56903d331 Bundled Themes: Twenty Twenty Author Bio/Post Meta Width in Cover Template in Mobile.
Fixes a bug where the author bio and post meta have no left or right padding in smaller viewports.

Props JarretC.
Fixes #49254.

git-svn-id: https://develop.svn.wordpress.org/trunk@47241 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 18:23:29 +00:00
Sergey Biryukov 130751cda3 Coding Standards: Use Yoda conditions where appropriate.
See #49222.

git-svn-id: https://develop.svn.wordpress.org/trunk@47219 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-09 16:52:28 +00:00
Sergey Biryukov 95f3bdbaac Twenty Nineteen: Improve code organization in `template-functions.php` by moving helper functions into their own file.
These functions are moved to `inc/helper-functions.php`:

* `twentynineteen_can_show_post_thumbnail()`
* `twentynineteen_image_filters_enabled()`
* `twentynineteen_get_avatar_size()`
* `twentynineteen_is_comment_by_post_author()`
* `twentynineteen_get_discussion_data()`
* `twentynineteen_hsl_hex()`

Additionally, `twentynineteen_add_dropdown_icons()` is moved to `inc/icon-functions.php` to join `twentynineteen_nav_menu_social_icons()`.

Props akshayar, allancole, grapplerulrich.
Fixes #45984.

git-svn-id: https://develop.svn.wordpress.org/trunk@47214 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-08 12:59:44 +00:00
Sergey Biryukov e72fff9cef Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant.
This avoids the performance overhead of the function call every time `dirname( __FILE__ )` was used instead of `__DIR__`.

This commit also includes:

* Removing unnecessary parentheses from `include`/`require` statements. These are language constructs, not function calls.
* Replacing `include` statements for several files with `require_once`, for consistency:
 * `wp-admin/admin-header.php`
 * `wp-admin/admin-footer.php`
 * `wp-includes/version.php`

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

git-svn-id: https://develop.svn.wordpress.org/trunk@47198 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-06 06:31:22 +00:00
Ian Belanger 90a8a6adf6 Bundled Themes: Twenty Twenty Menu rendering problem Unicode (Bangla).
Fixes a bug where certain words break on to a second line in the primary and footer menus, in certain languages.

Props smallprogrammers, Shital Patel, mukesh27, audrasjb.
Fixes #48970.

git-svn-id: https://develop.svn.wordpress.org/trunk@47192 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-05 15:00:40 +00:00
Sergey Biryukov 7d90de1772 Twenty Nineteen: Remove duplicate `font-size` property.
The theme does not use a `px` fallback for `rem` units anywhere else.

Follow-up to [47053] for Twenty Twenty.

See #49015.

git-svn-id: https://develop.svn.wordpress.org/trunk@47140 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-31 00:07:50 +00:00
Ian Belanger df1c7771da Fixes PHPCS Introduced in [47135].
There was extra whitespace in the previous commit, this removes it.

See #48552

git-svn-id: https://develop.svn.wordpress.org/trunk@47139 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-30 21:53:48 +00:00
Sergey Biryukov 10a5077524 Twenty Nineteen: Standardize the Required PHP and Tested Up To headers.
* Remove `WordPress` from `Requires at least` headers.
* Ensure the `Requires at least` and `Requires PHP` headers are present in the `style.css` file.

Follow-up to [46676], which updated `style-rtl.css`, but not `style.scss` or `style.css`.

See #48517.

git-svn-id: https://develop.svn.wordpress.org/trunk@47136 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-30 20:02:46 +00:00
Ian Belanger b651a3cb9e Bundled Themes: Twenty Twenty add theme support for responsive embeds.
Adds the call to `responsive-embed` theme support in order to fix issues with facebook embeds not being responsive at certain screen widths.

Props williampatton, nielslange.
Fixes #48552.

git-svn-id: https://develop.svn.wordpress.org/trunk@47135 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-30 19:19:37 +00:00
Ian Belanger 363c862b66 Bundled Themes: Twenty Twenty content font CSS selector is too important.
This makes the font family selector for `entry-content` less specific and thus easier to override.

Props alexandreb3, larrach, audrasjb.
Fixes #49318.

git-svn-id: https://develop.svn.wordpress.org/trunk@47133 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-30 18:26:22 +00:00
Sergey Biryukov cfc3b57488 Docs: Improve inline comments per the documentation standards.
Includes minor code layout fixes for better readability.

See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47122 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-29 00:43:23 +00:00
Sergey Biryukov 3e3b98aad7 Twenty Twenty: Remove unnecessary escaping of `get_the_title()` in `comments.php`.
For users with the `unfiltered_html` capability, titles can contain legitimate markup.

The title is filtered on saving, so the content in the database is considered safe.

Props kjellr, joyously, peterwilsoncc.
Fixes #49190.

git-svn-id: https://develop.svn.wordpress.org/trunk@47110 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-25 22:04:08 +00:00
Sergey Biryukov a8f4ed69de Docs: Update links to https://secure.php.net/, they now redirect to https://www.php.net/.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47088 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-20 03:12:12 +00:00
Jonathan Desrosiers 424071a2b6 Bundled Themes: Remove duplicate `font-size` property in Twenty Twenty.
Props ankitmaru.
Fixes #49015.



git-svn-id: https://develop.svn.wordpress.org/trunk@47053 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-08 16:48:43 +00:00
Sergey Biryukov f4a8e840af Happy New Year!
Update copyright year to 2020 in bundled themes' `readme.txt`.

git-svn-id: https://develop.svn.wordpress.org/trunk@47026 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-01 03:51:29 +00:00
Sergey Biryukov 7b3483c866 Coding Standards: Fix WPCS issue in [47019].
See #49091.

git-svn-id: https://develop.svn.wordpress.org/trunk@47020 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-29 22:30:26 +00:00
Sergey Biryukov 1dfd6c5168 Twenty Twenty: Remove extra space from `arrow-down-circled` icon name in `TwentyTwenty_SVG_Icons::$ui_icons`.
Props kitchin.
Fixes #49091.

git-svn-id: https://develop.svn.wordpress.org/trunk@47019 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-29 20:43:04 +00:00
Ian Belanger b7b29ddfc9 Bundled Themes: Bump version number and update changelog in Twenty Twenty for WordPress 5.3.1.
This bumps the Twenty Twenty version number to `1.1` and update the `readme.txt` changelog.

Props audrasjb, sinatrateam, SergeyBiryukov
Fixes #48944.

git-svn-id: https://develop.svn.wordpress.org/trunk@46902 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-12 18:24:33 +00:00
Sergey Biryukov 55de626b72 Twenty Twenty: Adjust the comment in [46851] per the documentation standards.
See #48876.

git-svn-id: https://develop.svn.wordpress.org/trunk@46854 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-09 16:16:09 +00:00
Ian Belanger 9b69d0f71d Bundled Themes: Misaligned input placeholder text Twenty Twenty.
This fixes placeholder misalignment in Firefox when a `height` is added as an inline style to the input field.

Props aljullu, subratamal.
Fixes #48876.

git-svn-id: https://develop.svn.wordpress.org/trunk@46851 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-09 15:08:16 +00:00
Sergey Biryukov 2de8f8b3cd Twenty Twenty: Remove redundant `echo` for `bloginfo()` call in `footer.php`.
Props acosmin.
Fixes #48918.

git-svn-id: https://develop.svn.wordpress.org/trunk@46849 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-09 14:58:52 +00:00
Ian Belanger 868f91eec7 Bundled Themes: Make checkbox in comment form larger Twenty Twenty.
This makes the checkbox in the comment form larger and more consistent with other checkboxes.

Props kharisblank, audrasjb.
Fixes #48652.

git-svn-id: https://develop.svn.wordpress.org/trunk@46844 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-09 14:06:55 +00:00
Sergey Biryukov 358705ab1f Twenty Twenty: Correct alignment for embedded Instagram posts.
Props SGr33n, audrasjb, nielslange, JarretC.
Fixes #48688.

git-svn-id: https://develop.svn.wordpress.org/trunk@46840 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-09 13:37:30 +00:00
Sergey Biryukov d706e903b7 Twenty Twenty: Pass `$post_meta` and `$location` values to `twentytwenty_start_of_post_meta_list` and `twentytwenty_end_of_post_meta_list` actions to provide better context.
Props msaari, SergeyBiryukov.
Fixes #48906.

git-svn-id: https://develop.svn.wordpress.org/trunk@46832 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-09 11:48:00 +00:00
Sergey Biryukov 8b0feef2fe Twenty Twenty: Use duplicate hook references for `page_css_class` and `page_menu_link_attributes` filters in `TwentyTwenty_Walker_Page`.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46828 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-07 14:01:44 +00:00
Sergey Biryukov ac6dc8aa0c Bundled Themes: Correct `@since` tags to refer to the theme version instead of WordPress version.
This makes `@since` notations in Twenty Seventeen, Twenty Nineteen, and Twenty Twenty consistent with the previous bundled themes.

See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46827 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-07 13:54:43 +00:00
Sergey Biryukov 388524c939 Twenty Twenty: Replace Smooth Scroll JS implementation with `scroll-behavior` CSS property.
The JS implementation had multiple issues and did not work as expected.

This change includes an accessibility enhancement by using `prefers-reduced-motion: reduce` media query property for users that don't want motion effects. For further explanation on this media query, see MDN documentation: https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-behavior#Accessibility_concerns

Props audrasjb, melchoyce, joostdevalk, Anlino, mauteri, sergiomdgomes, littlebigthing, williampatton, netweb, andraganescu, joyously, acosmin, mukesh27, hareesh-pillai.
Fixes #48763, #48551, #48866.

git-svn-id: https://develop.svn.wordpress.org/trunk@46824 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-07 11:03:09 +00:00
Ian Belanger 46cffd88e5 Bundled Themes: Adds Customizer option to show or hide author bio Twenty Twenty.
This adds an option to the Customizer that allows you to turn the author bio on or off, sitewide.

Props williampatton, nielslange acosmin, dlh.
Fixes #48550.

git-svn-id: https://develop.svn.wordpress.org/trunk@46813 602fd350-edb4-49c9-b593-d223f7449a82
2019-12-04 15:57:54 +00:00
Ian Belanger 43ecd78bd3 Bundled Themes: Fixes JS TypeError in Twenty Twenty.
On mobile devices using a webkit browser, the menu and search modals could not be opened due to a `TypeError: document.body is null`. This commit fixes that issue by adding a `touch-enabled` class to the body for browsers that do not support media queries.

Props quicoto, poena, Boga86, acosmin, macmanx.
Fixes #48601.

git-svn-id: https://develop.svn.wordpress.org/trunk@46786 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-26 18:19:54 +00:00
Sergey Biryukov 5e801fe58e Twenty Twenty: Remove duplicate array key/value in `TwentyTwenty_Non_Latin_Languages::get_non_latin_css()`.
Props manikmist09.
Fixes #48624.

git-svn-id: https://develop.svn.wordpress.org/trunk@46765 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-24 10:53:40 +00:00
Sergey Biryukov c5d880c616 Twenty Twenty: Correctly align the author bio and bottom post meta on single posts on mobile.
Props nielslange, Anlino.
Fixes #48619.

git-svn-id: https://develop.svn.wordpress.org/trunk@46762 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-23 14:52:13 +00:00
Sergey Biryukov 4ebaf2b2d2 Twenty Twenty: Fix typos in a variable name and inline comment in `assets/js/color-calculations.js`.
Props tanvirul.
Fixes #48704.

git-svn-id: https://develop.svn.wordpress.org/trunk@46747 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-18 17:05:23 +00:00
Sergey Biryukov 2a3cbd8e04 Bundled Themes: Update Twenty Twenty.
This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46715], see fa8c3fc...a9e73ab.

Props Anlino, karmatosed, williampatton, poena, joyously, ianbelanger, chetan200891.
See #48110, #48386, #48450, #48505, #48557.
Fixes #48571.

git-svn-id: https://develop.svn.wordpress.org/trunk@46722 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-12 18:22:39 +00:00
Sergey Biryukov 1047d80b69 Bundled Themes: Update copyright year in `readme.txt` for Twenty Twelve and Twenty Twenty.
Follow-up to [46719].

See #48566.

git-svn-id: https://develop.svn.wordpress.org/trunk@46720 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-12 17:49:24 +00:00
Sergey Biryukov 6c776ea07b Bundled Themes: Update copyright year in `readme.txt`.
Add a unit test to ensure the year stays up to date.

Props dkarfa, SergeyBiryukov.
Fixes #48566.

git-svn-id: https://develop.svn.wordpress.org/trunk@46719 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-12 17:34:05 +00:00
Sergey Biryukov eabc288f67 Bundled Themes: Update Twenty Twenty.
* Add `.has-background` excluding condition to wide and full group-blocks.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46714], see 162edc0...fa8c3fc.

Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Fixes #48557.

git-svn-id: https://develop.svn.wordpress.org/trunk@46715 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-12 02:04:14 +00:00
Sergey Biryukov 732a358f61 Bundled Themes: Update Twenty Twenty.
* Add a11y-friendly default text-colors when selecting a background-color.
* Remove margins for the group block when a background-color is set.
* Excluding pullquote block from width resize rules.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46711], see ab5fa23...162edc0.

Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Fixes #48557.

git-svn-id: https://develop.svn.wordpress.org/trunk@46713 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-12 01:42:20 +00:00
Sergey Biryukov 14df1712fd Twenty Twenty: Make CSS adjustments to account for the latest editor changes and ensure that group blocks work in expected ways.
Props williampatton, allancole, karmatosed, pierlo, joen, ianbelanger.
Fixes #48557.

git-svn-id: https://develop.svn.wordpress.org/trunk@46711 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 20:54:49 +00:00
Sergey Biryukov fdeb2ff358 Twenty Twenty: Fix WPCS issue in [46701].
See #48557.

git-svn-id: https://develop.svn.wordpress.org/trunk@46702 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 12:57:54 +00:00