Commit Graph

1138 Commits

Author SHA1 Message Date
Ryan Boren ee8cf061f8 Introduce wp_get_mime_types() for fetching the complete list of mime types. Remove the static caching of the types so that filters other than the first filter work. Use wp_get_mime_types() in do_enclose(). fixes #21299 #21594
git-svn-id: https://develop.svn.wordpress.org/trunk@21541 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-17 17:25:19 +00:00
Ryan Boren c4efcb4def Fix MS Office mime types. Group the mime list in get_allowed_mime_types() by type. Props hebbet, markel, SergeyBiryukov. fixes #17117
git-svn-id: https://develop.svn.wordpress.org/trunk@21527 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-15 16:48:36 +00:00
Ryan Boren 20a1def1c0 switch_to_blog() and restore_current_blog() housekeeping.
wp-includes/admin-bar.php:

* Replace get_admin_url() and get_home_url() with admin_url() and home_url() and place them inside a switch/restore. Likewise replace current_user_can_for_blog() with current_user_can(). This avoids doing multiple switch restores.

wp-includes/ms-blogs.php:

* Deprecate the $validate argument to switch_to_blog(). This avoids a not very necessary call to get_blog_details(), possibly saving a few queries.
* Use $_wp_switched and $_wp_switched_stack instead of $switched and $switched_stack to make it less likely these globals will be stomped.
* Use GLOBALS to access blog_id and other globals. I've preferred this style lately since it makes it obvious a global is being used and avoids global blog_id being stomped by a local variable.
* Lose some is_object() checks. wp_get_current_user() always returns an object, for example.
* Call the new WP_Roles::reinit() method.

wp-includes/class-wp-xmlrpc-server.php:

* Replace current_user_can_for_blog() with current_user_can() and move it inside the switch/restore pair. This eliminates a switch/restore.

wp-includes/capabilities.php:

* Use array_keys() instead of $role => $data since $data is unused. I *think* this is a bit faster.
* Introduce WP_Roles::reinit(). This reinitializes WP_Roles and is used after switch_to_blog() has already update the blog ID in the wpdb object. If a global roles array is being used instead of the db, reinit is skipped.
* current_user_can_for_blog() now does a switch/restore. It didn't before meaning it could be reinitializing the user with the wrong role information for the current blog.

wp-includes/ms-settings.php:

* Define $_wp_switched_stack and $_wp_switched. This way switch_to_blog() and restore_current_blog() can rely on it being set.

wp-settings.php:

* Instantiate the WP_Roles global. This was it is always defined during init. To remove the WP_Roles checks from WP_Role and WP_User this would probably have to move before plugins are loaded, which might not be a good thing.

wp-includes/functions.php:

* Update wp_upload_dir() to reference _wp_switched.



git-svn-id: https://develop.svn.wordpress.org/trunk@21485 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-09 16:28:15 +00:00
Ryan Boren 872ba2c28f Call func_get_args() once in add_query_arg(). Props SergeyBiryukov. see #21332
git-svn-id: https://develop.svn.wordpress.org/trunk@21373 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-31 15:28:10 +00:00
Andrew Nacin 6de675bd6a Remove unnecessary error suppression operators from func_get_arg() and func_num_args(). see #21332.
git-svn-id: https://develop.svn.wordpress.org/trunk@21298 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-21 06:07:39 +00:00
Andrew Nacin 96f9446e11 Check if array key exists in wp_list_filter(). props wpsmith. fixes #20929.
git-svn-id: https://develop.svn.wordpress.org/trunk@21184 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-29 19:42:27 +00:00
Andrew Nacin 42c8c7b5fe Add back an empty line removed in [21180].
git-svn-id: https://develop.svn.wordpress.org/trunk@21181 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-29 15:16:36 +00:00
Andrew Nacin 9283b786be Add note to get_allowed_mime_types() about the upload_mimes filter. props JustinSainton. fixes #20990.
git-svn-id: https://develop.svn.wordpress.org/trunk@21180 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-29 15:13:53 +00:00
Mark Jaquith bfd2e57437 Allow tel: and fax: protocols. Wrangle the last hardcoded protocol enumeration so that it uses wp_allowed_protocols(). fixes #21081
git-svn-id: https://develop.svn.wordpress.org/trunk@21170 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-28 20:30:10 +00:00
Andrew Nacin 4c406cc8ad Add initial support for browser-based uploads in iOS 6. see #20923 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@21141 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-26 20:39:04 +00:00
Andrew Nacin 5b9214124c Deprecate wp_explain_nonce(). fixes #21076.
git-svn-id: https://develop.svn.wordpress.org/trunk@21133 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-26 06:10:07 +00:00
Andrew Nacin 9e30b38e96 Don't call debug_backtrace() with an argument for PHP 5.2.4, which is currently the lowest version we support. props swekitsune, kurtpayne. fixes #20953.
git-svn-id: https://develop.svn.wordpress.org/trunk@21113 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-25 20:41:37 +00:00
Ryan Boren 8c50f982ea Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@20715 602fd350-edb4-49c9-b593-d223f7449a82
2012-05-03 16:41:59 +00:00
Andrew Nacin 199f9adec2 Properly extract file headers via get_file_data() when CR line endings are used. props solarissmoke for the initial patch. fixes #19854.
git-svn-id: https://develop.svn.wordpress.org/trunk@20640 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-30 01:25:29 +00:00
Andrew Nacin f107d5e049 Fix typo in filter name for wp_die() APP request handler. props benbalter, fixes #20457.
git-svn-id: https://develop.svn.wordpress.org/trunk@20480 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-16 16:15:18 +00:00
Ryan Boren d1100bacb4 Schedule auto-draft deletion from post-new.php instead of from admin.php. This provides better throttling for large multisite installs and reduces the risk of a delete avalanche.
fixes #19663


git-svn-id: https://develop.svn.wordpress.org/trunk@20453 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-12 18:49:48 +00:00
Andrew Ozz e032e94c4f Don't hide links to the upload form and show an error for mobile devices that cannot upload, see #20410
git-svn-id: https://develop.svn.wordpress.org/trunk@20449 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-12 00:16:37 +00:00
Ryan Boren 03512f97e8 Move deletion of auto-draft posts to the wp_scheduled_delete cron function. Props mgolawala. fixes #19663
git-svn-id: https://develop.svn.wordpress.org/trunk@20440 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-11 20:39:09 +00:00
Andrew Nacin 1909f3fbeb Use the metadata API rather than raw queries and direct do_action calls. see #20417.
git-svn-id: https://develop.svn.wordpress.org/trunk@20435 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-11 20:02:39 +00:00
Dion Hulse cc9bcf724b Restore the h1 styling for wp_die(), primarily affects database down messages. See #17975
git-svn-id: https://develop.svn.wordpress.org/trunk@20209 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-18 11:51:25 +00:00
Andrew Nacin 69485d4803 Use array_combine() in get_file_data() and avoid variable variables when an array is just fine. fixes #20126.
git-svn-id: https://develop.svn.wordpress.org/trunk@20088 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 21:07:31 +00:00
Andrew Nacin 339251c75c New wp_die_app_handler context in wp_die() for APP requests. Introduces _scalar_wp_die_handler() as a generic handler that wraps die(), for use by plugins. Move deprecated function to the end of the wp-app.php file (same as xmlrpc.php). see #20042.
git-svn-id: https://develop.svn.wordpress.org/trunk@20063 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-01 21:35:15 +00:00
Ryan Boren 89e9bcc1d6 Pinking shears 6-20000
git-svn-id: https://develop.svn.wordpress.org/trunk@20000 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-27 19:46:52 +00:00
Jon Cave e60c17736d Overhaul mysql2date() documentation and parameter names. See #20056.
git-svn-id: https://develop.svn.wordpress.org/trunk@19974 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-21 20:03:11 +00:00
Jon Cave 3b607e3675 Remove obsolete mysql2date documentation. Props Viper007Bond. Fixes #20056.
git-svn-id: https://develop.svn.wordpress.org/trunk@19973 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-21 19:55:18 +00:00
Andrew Nacin ee01523b96 Deprecate ancient "debugging" tools.
* logIO() and the global $xmlrpc_logging in XML-RPC.
 * log_app() and the global $app_logging in APP.
 * debug_fwrite(), debug_fopen(), debug_fclose(), and $debug.
see #20051.



git-svn-id: https://develop.svn.wordpress.org/trunk@19935 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-17 00:02:42 +00:00
Ryan Boren f7abac6c21 Properly redirect to install.php when visiting wp-login.php with a config file but no db. Props SergeyBiryukov. fixes #18397
git-svn-id: https://develop.svn.wordpress.org/trunk@19923 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-14 18:08:45 +00:00
Ryan Boren 021c55798e Split the main WP_Query posts query into two queries to avoid temp tables. Leverage cache to avoid second query in persistent cache environments. Props scribu, cheald, prettyboymp. see #18536
git-svn-id: https://develop.svn.wordpress.org/trunk@19918 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-14 15:09:35 +00:00
Jon Cave 1f9b62bf85 Prevent undefined index notices in do_enclose(). Props jeremyclarke. Fixes #19865.
git-svn-id: https://develop.svn.wordpress.org/trunk@19881 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-08 20:55:18 +00:00
Andrew Nacin 0c59eacb55 Use is_rtl() for html direction when possible. In sites.php, language_attributes() will always exist (MU vestige). When the DB is dead, language_attributes() is worse than a simple is_rtl() check. is_rtl() exists here due to wp_load_translations_early(). see #18180.
git-svn-id: https://develop.svn.wordpress.org/trunk@19862 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-08 06:05:35 +00:00
Andrew Nacin 25eac276df Re-purpose wp_die() for ajax responses.
* Allows unit testing of core ajax actions.
 * wp_die() now has separate filters to choose a handler depending on the context (ajax, XML-RPC, else).
 * wp_die) in ajax context does not need to be called with a string. Conversion takes place before die().
props kurtpayne, see #15327.



git-svn-id: https://develop.svn.wordpress.org/trunk@19801 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-31 22:12:58 +00:00
Peter Westwood 15e41d5879 Correct the datatype for the skip_frames argument in the phpDoc props Rarst.
git-svn-id: https://develop.svn.wordpress.org/trunk@19777 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-28 14:36:16 +00:00
Jon Cave e6cbf0b4e6 Separated into 3 commits for good luck. See r19775.
git-svn-id: https://develop.svn.wordpress.org/trunk@19776 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-28 12:37:08 +00:00
Peter Westwood dbc1c14868 Separating my commits so that my spelling mistakes are plain for everyone to see. Fix another mistake props duck_.
git-svn-id: https://develop.svn.wordpress.org/trunk@19775 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-28 12:32:55 +00:00
Peter Westwood 6538ad3d0c Fix my spelling mistakes and typos in the wp_debug_backtrace_summary() phpDoc props duck_ see #19589.
git-svn-id: https://develop.svn.wordpress.org/trunk@19774 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-28 12:25:58 +00:00
Peter Westwood b3a331887a Refactor WPDB::get_caller() into wp_debug_backtrace_summary() and improve the functionality to provide enhanced context and a standardised default pretty format. Fixes #19589
git-svn-id: https://develop.svn.wordpress.org/trunk@19773 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-28 11:56:50 +00:00
Andrew Nacin 2fd55c3df1 Introduce wp_load_translations_early(), which can be used before the locale is properly loaded in order to translate early error strings. Internationalize setup-config.php -- translators no longer have a reason to modify this file. fixes #18180.
git-svn-id: https://develop.svn.wordpress.org/trunk@19760 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-26 20:34:27 +00:00
Ryan Boren 2b186b0c45 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: https://develop.svn.wordpress.org/trunk@19712 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-08 17:01:11 +00:00
Ryan Boren a8d77cbae9 User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302
git-svn-id: https://develop.svn.wordpress.org/trunk@19687 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-05 20:50:54 +00:00
Ryan Boren 8c36bb6779 One newline is enough.
git-svn-id: https://develop.svn.wordpress.org/trunk@19685 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-05 20:13:03 +00:00
Ryan Boren 5e76729992 One newline is enough.
git-svn-id: https://develop.svn.wordpress.org/trunk@19684 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-05 20:10:39 +00:00
Andrew Ozz 68ac3d9c93 Replace background image with CSS3 gradient in wp_die(), fixes #19701
git-svn-id: https://develop.svn.wordpress.org/trunk@19635 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-30 22:25:53 +00:00
Andrew Nacin c671754b4f Disable the 8) smiley as it breaks regular text more than all of the others. props sksmatt. fixes #17122.
git-svn-id: https://develop.svn.wordpress.org/trunk@19613 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-20 21:46:19 +00:00
Andrew Nacin 923ee213c9 Update since. see #18845.
git-svn-id: https://develop.svn.wordpress.org/trunk@19608 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-20 20:59:03 +00:00
Andrew Nacin 16c7792717 Add `__return_null()` to complement the existing true, false, zero, and empty array methods. props johnbillion, fixes #18845.
git-svn-id: https://develop.svn.wordpress.org/trunk@19607 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-20 20:58:30 +00:00
Ryan Boren 93d4783778 Move option, setting, and transient functions from functions.php to option.php. see #19552
git-svn-id: https://develop.svn.wordpress.org/trunk@19602 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-19 23:15:32 +00:00
Ryan Boren 676ba7043e Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: https://develop.svn.wordpress.org/trunk@19593 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-13 23:45:31 +00:00
Peter Westwood b087efe566 Add button styles to the inline styles in _default_wp_die_handler so that the Create a Config button is styled again. Fixes #17975.
git-svn-id: https://develop.svn.wordpress.org/trunk@19417 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-23 17:29:49 +00:00
Ryan Boren 80ee709653 Introduce wp_no_robots(). Call it for pages that should never be indexed, regardless of blog privacy settings. Props nacin. fixes #19251
git-svn-id: https://develop.svn.wordpress.org/trunk@19304 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-15 20:44:48 +00:00
Andrew Ozz 0b8d97f135 Fix styling for the installation screens, props chexee, fixes #18576
git-svn-id: https://develop.svn.wordpress.org/trunk@19297 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-15 15:47:07 +00:00