Commit Graph

30414 Commits

Author SHA1 Message Date
Jeremy Felt 035ae948d5 Fix missing period in missing site error.
Props @ocean90.
See #32934.


git-svn-id: https://develop.svn.wordpress.org/trunk@33145 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-09 16:32:26 +00:00
Jeremy Felt 8b9b56f59f Avoid PHP notice when attempting to edit a site that does not exist.
Show a more explicit error - "The requested site does not exist."

Fixes #32934.


git-svn-id: https://develop.svn.wordpress.org/trunk@33144 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-09 16:28:42 +00:00
Jeremy Felt bb7f147703 Do not allow deletion of a super admin user through `wpmu_delete_user()`.
In step with the UI provided by `wp-admin/network/users.php`, super admin privileges must be removed before a user can be deleted through the API.

Props @johnjamesjacoby, @jeremyfelt.
Fixes #32935.


git-svn-id: https://develop.svn.wordpress.org/trunk@33143 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-09 16:15:30 +00:00
Dominik Schilling (ocean90) b9ef1b8533 Remove debug cruft from [33124].
see #28909.

git-svn-id: https://develop.svn.wordpress.org/trunk@33142 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-09 07:55:44 +00:00
Andrew Ozz 128557239f TinyMCE: when deleting an image, ensure the wrapping link (if any) is deleted too. Fixes the erroneous showing of the link toolbar after deleting an image. Also small readability fix.
See #32604. 

git-svn-id: https://develop.svn.wordpress.org/trunk@33141 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-09 00:24:34 +00:00
Konstantin Obenland 3e5e085bb0 4.3-beta2-33140
git-svn-id: https://develop.svn.wordpress.org/trunk@33140 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 22:05:19 +00:00
Konstantin Obenland 6ce24e8d5d 4.3-beta2
git-svn-id: https://develop.svn.wordpress.org/trunk@33139 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 21:38:57 +00:00
Weston Ruter 2a8973f117 Customizer: Remove additional wrapper element around `wp_nav_menu()` which broke some theme designs.
Also includes these related changes:
* Export `oldContainer` and `newContainer` among the `customize-preview-menu-refreshed` event params for themes to be able to more easily re-initialize the DOM elements.
* Improve performance for partial refresh by only sending settings related to the menu being previewed.
* Fix previewing of menu assigned to Custom Menu by exporting a menu `term_id` as opposed to an object, as the former is more stable for comparing in in args hashes.
* Do full refresh of preview when nav menu unassigned so that the layout can be updated.
* Harden conditions for when partial refresh is eligible for a `wp_nav_menu()` instance.

Fixes #32841.


git-svn-id: https://develop.svn.wordpress.org/trunk@33138 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 21:29:53 +00:00
Dominik Schilling (ocean90) 55de610283 Add/Edit User: Move weak password label to the checkbox.
props paulwilde.
fixes #32908.

git-svn-id: https://develop.svn.wordpress.org/trunk@33137 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 21:27:25 +00:00
Dominik Schilling (ocean90) 790b60ffb2 Customizer: Use `visibility` to hide available widgets and menu items panels from screen readers and to move them out of tab order.
props afercia.
fixes #32883.

git-svn-id: https://develop.svn.wordpress.org/trunk@33136 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 21:20:54 +00:00
Boone Gorges 002dd563e0 Improvements to responsive styling on my-sites.php.
* Ensure that floated elements break to a new line at the end of a row.
* Allow enough vertical space for long site titles.
* Give more breathing room to cells at narrow widths.

Fixes #31685.

git-svn-id: https://develop.svn.wordpress.org/trunk@33135 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 21:01:40 +00:00
Weston Ruter ccbd855021 Customizer: Defer listening to nav menu setting changes until active.
Defer the preview starting to listen to setting changes until after the Customizer has synced settings into the preview. This ensures that any differences between the JS and PHP representations of the settings won't cause an infinite refresh.

See #32911.
Fixes #32894.


git-svn-id: https://develop.svn.wordpress.org/trunk@33134 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 20:41:18 +00:00
Dominik Schilling (ocean90) 55ffb38e28 Updates: Select All should not be a column header.
See #31654.

props tywayne.
fixes #32905.

git-svn-id: https://develop.svn.wordpress.org/trunk@33133 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 20:37:33 +00:00
Helen Hou-Sandi 013e8d2263 Spinners: Ensure one appears in the lost connection notice.
fixes #32914.


git-svn-id: https://develop.svn.wordpress.org/trunk@33132 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 20:19:44 +00:00
Weston Ruter 3c0e4d3860 Customizer: Prevent loss of `walker` and `fallback_cb` args for `wp_nav_menu`.
These args only need to be cleared out when exported to JavaScript, when they are not JSON-serializable. So the filter now clears these when gathering args for exporting to JS, but otherwise now leaves the original values to be passed through to `wp_nav_menu()`.

Fixes #32781.


git-svn-id: https://develop.svn.wordpress.org/trunk@33131 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 20:17:52 +00:00
Helen Hou-Sandi f5043ab022 Toolbar: Disambiguate links to the dashboard vs. to the customizer.
All links in the site name menu now point to admin screens, and Customize is its own top-level link. This makes it clear which context you are about to enter.

fixes #32924. see #32678.


git-svn-id: https://develop.svn.wordpress.org/trunk@33130 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 20:02:44 +00:00
Aaron Jorbin f86fd644e1 Remove grunt-autoprefixer in favor of grunt-postcss with autoprefixer
grunt-autoprefixer was deprecated - e020f878d5
None of the autoprefixer tasks should have been called directly, so they are now removed.  `grunt precommit` and `grunt build` still work exactly as they should.  This change doesn't affect the output of our builds.

An NPM install is required after you have updated after this change.

See #31700
Props netweb



git-svn-id: https://develop.svn.wordpress.org/trunk@33129 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 19:53:22 +00:00
Andrew Ozz 6cfda41066 TinyMCE, Press This: add the `wptextpattern` plugin to the Press This editor.
See #31441.

git-svn-id: https://develop.svn.wordpress.org/trunk@33128 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 19:52:07 +00:00
Andrew Ozz 093a19b6d9 TinyMCE: add help for the text patterns to the shortcuts help popup.
See #31441.

git-svn-id: https://develop.svn.wordpress.org/trunk@33127 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 19:42:59 +00:00
Dominik Schilling (ocean90) f54070a08e Dashicons: Update to the latest files.
Revert the updates to .dashicons-plus (f132) in [33108] and instead introduce a new icon, .dashicons-plus-alt2 (f543).

props liljimmi, melchoyce, empireoflight.
see #30902.

git-svn-id: https://develop.svn.wordpress.org/trunk@33126 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 19:37:04 +00:00
John Blackbourn 389fb33d76 Skip the `Tests_Option_Transient::test_nonexistent_key_old_timeout()` tests on multisite for now.
See #31130
Fixes #30380


git-svn-id: https://develop.svn.wordpress.org/trunk@33125 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 18:23:46 +00:00
ocean90 94e3540dcc Update PHPMailer to 5.2.10 from 5.2.7.
Includes two modifications for WordPress:
* Removes support for NTLM in `class-smtp.php` since the required client (`extras/ntlm_sasl_client.php`) is not distributed as part of WordPress.
* Requires `class-smtp.php` for backwards compatibility with direct (non-wp_mail()) uses of PHPMailer, as the autoloader isn't used. See [27385].

This also includes a change to our `MockMailer` for unit tests. It now overrides `postSend() instead of `send()`, and `preSend()`.
`preSend()` resets `$this->Encoding` because PHPMailer doesn't clean up after itself / presets all variables. This becomes an issue when `PHPMailer::createBody()` sets `$this->Encoding = 'quoted-printable'` (away from it's default of 8bit) when it encounters a line longer than 998 characters. `Tests_Comment::test_comment_field_lengths` is such a case.

props MattyRob, dd32.
fixes #28909.

git-svn-id: https://develop.svn.wordpress.org/trunk@33124 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 17:15:02 +00:00
Aaron Jorbin 08d5df5f44 Remove PHP4 constructors from Unit Tests
If you are subclassing these classes in your own tests, you'll need to update your code.

Props johnbillion
See #31982



git-svn-id: https://develop.svn.wordpress.org/trunk@33123 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 16:04:11 +00:00
Helen Hou-Sandi 3762069f89 Move `get_default_comment_status()` to `wp-includes/comment.php` to sit alongside `get_comment_statuses()`.
props nacin.
see #31168.


git-svn-id: https://develop.svn.wordpress.org/trunk@33122 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 15:43:24 +00:00
Sergey Biryukov 863ce98362 Menus: Restore visibility of up/down arrows for reordering menu items with JS disabled.
props afercia.
fixes #32916.

git-svn-id: https://develop.svn.wordpress.org/trunk@33121 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 06:47:45 +00:00
Weston Ruter bde076cbfb Customizer: Prevent preview from loading during QUnit tests and causing an XHR cross-domain error.
Fixes #32666.


git-svn-id: https://develop.svn.wordpress.org/trunk@33120 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 05:37:37 +00:00
John Blackbourn 0888ce55b1 Introduce unit tests for `sanitize_option()`.
Props MikeHansenMe, welcher, johnbillion
See #32351


git-svn-id: https://develop.svn.wordpress.org/trunk@33119 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-08 00:05:17 +00:00
John Blackbourn 063637755b Allow shortcode parameter names (attributes) to contain dashes.
Props aaroncampbell, tyxla, izem
Fixes #9405


git-svn-id: https://develop.svn.wordpress.org/trunk@33118 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 23:58:49 +00:00
Helen Hou-Sandi 41705c3e7c Ensure error messages look like, well, errors.
props obenland, rachelbaker.
fixes #32475.


git-svn-id: https://develop.svn.wordpress.org/trunk@33117 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 23:10:57 +00:00
Scott Taylor 5de7ee67ce After [32980], update the docs to reflect that `display_name` is now included when searching for users in some scenarios.
Fixes #27304.


git-svn-id: https://develop.svn.wordpress.org/trunk@33116 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 19:38:30 +00:00
Scott Taylor 138d68a58a In `wp_insert_user()`, comparing an email address against the user's old email address should not be case-sensitive.
Adds unit tests.

Props tyxla.
Fixes #32158.


git-svn-id: https://develop.svn.wordpress.org/trunk@33115 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 19:28:46 +00:00
Scott Taylor a297e1532e In `install_dashboard()` (`plugin-install`, FWIW), make sure `slug` is populated and degrease the unfortunate whitespace that was present.
Props tyxla.
Fixes #32889.


git-svn-id: https://develop.svn.wordpress.org/trunk@33114 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 19:18:03 +00:00
Konstantin Obenland 312f5179cb Hide notices introduced in [30505] on about page.
See #19237.

Props jadpm.
Fixes #32625.



git-svn-id: https://develop.svn.wordpress.org/trunk@33113 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 18:46:13 +00:00
Konstantin Obenland 36a9b5b0d4 Menus: Respect context when linking to the Customizer.
`Manage in Customizer` will now link to menu locations or the menus panel in
the customizer, depending on whether the user is editing menus or managing
locations.

Props rabmalin for initial patch.
Fixes #32852.



git-svn-id: https://develop.svn.wordpress.org/trunk@33112 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 17:48:23 +00:00
Konstantin Obenland a399fb0b38 Respect the special case of having only one theme.
If there is only one theme, the Pointer won't show and the overlay is active by
default. In that case the overlay covered submenu flyouts, after [33068].
Without the Pointer active, there is no need to bump the `z-index`, so it can
remain at 10.

Fixes #31544.



git-svn-id: https://develop.svn.wordpress.org/trunk@33111 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 17:13:59 +00:00
Dominik Schilling (ocean90) daa477e3b8 Transients: If `get_option( $transient_timeout )` returns false, don't bother trying to delete the transient in `get_transient()`.
props jamesgol, ericmann.
fixes #30380.

git-svn-id: https://develop.svn.wordpress.org/trunk@33110 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 16:44:08 +00:00
Helen Hou-Sandi 68b5d643d0 Better styling for `.form-invalid` inputs.
props liljimmi.
fixes #32490.


git-svn-id: https://develop.svn.wordpress.org/trunk@33109 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 16:40:34 +00:00
Dominik Schilling (ocean90) dbbe2627d4 Dashicons: Update to the latest files.
New icons:
* .dashicons-admin-customizer (f540)
* .dashicons-admin-multisite (f541)
* .dashicons-editor-table (f535)
* .dashicons-filter (f536)
* .dashicons-hidden (f530)
* .dashicons-image-filter (f533)
* .dashicons-image-rotate (f531)
* .dashicons-layout (f538)
* .dashicons-sticky (f537)
* .dashicons-thumbs-down (f542)
* .dashicons-thumbs-up (f529)
* .dashicons-unlock (f528)
* .dashicons-warning (f534)

Updated icons:
* .dashicons-plus (f132)
* .dashicons-yes (f147)

props liljimmi, melchoyce, empireoflight.
fixes #30902.

git-svn-id: https://develop.svn.wordpress.org/trunk@33108 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 16:02:58 +00:00
Helen Hou-Sandi 62670c5adb Menu customizer: Ensure item type doesn't collide with the handle focus glow.
props andg, metodiew.
fixes #32813.


git-svn-id: https://develop.svn.wordpress.org/trunk@33107 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 15:51:50 +00:00
Helen Hou-Sandi 8209a24d85 Show row actions on focus for the dashboard comment list.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@33106 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 15:25:03 +00:00
Helen Hou-Sandi 0e6e1e6612 List tables: Ensure special CSS for the title column gets applied.
This could have some side effects if a custom list table has a title column with a strong element inside that is not the post title, but that is fairly edge and we can address that if it comes up. Also moves the rules into `list-tables.css`.

see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@33105 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 15:20:45 +00:00
Helen Hou-Sandi 8f024536c1 List tables: Add a fallback for the primary column.
Without a primary column defined, nothing shows in the responsive view at all, which is bad.

props mordauk.
see #25408.


git-svn-id: https://develop.svn.wordpress.org/trunk@33104 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 15:11:54 +00:00
Dion Hulse 70ab756043 Ensure that Custom Links in menu's are marked as current regardless of their scheme.
Props McGuive7, marsjaninzmarsa.
Fixes #32221


git-svn-id: https://develop.svn.wordpress.org/trunk@33103 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 09:56:19 +00:00
Boone Gorges 8e6997b652 Use `assertEqualSets()` in `WP_Query::parse_tax_query()` tests.
Props ocean90.
See #32454.

git-svn-id: https://develop.svn.wordpress.org/trunk@33102 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 00:57:04 +00:00
Helen Hou-Sandi 6d8f6f8d11 List tables: Account for comments being reused on the post edit screen.
Adding the `.wp-list-table` class gets us a few responsive goodies for free. And now it won't show a strange button outline.

see #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@33101 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 00:08:46 +00:00
Jeremy Felt dabe7ab9c3 Assign proper active class when showing plugin updates in network admin
Previously, a plugin would trigger an active class if it was active on the network's main site.

Fixes #32901.


git-svn-id: https://develop.svn.wordpress.org/trunk@33100 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-07 00:01:31 +00:00
Helen Hou-Sandi 9c1265181c List tables: Get rid of double borders for plugins and themes on narrow screens.
see #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@33099 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-06 23:48:16 +00:00
Helen Hou-Sandi 94cd2d47eb List tables: Ensure the no items message appears on narrow screens.
fixes #32900. see #32395.


git-svn-id: https://develop.svn.wordpress.org/trunk@33098 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-06 23:29:44 +00:00
Jeremy Felt 69239d86f9 Remove unused `$current_site` global in MS Sites list table
Found itself unused after [32719].

See #32434.


git-svn-id: https://develop.svn.wordpress.org/trunk@33097 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-06 22:50:59 +00:00
Konstantin Obenland 2cafc0d787 Check for all required caps before (un)sticking a post.
In cases where a user has the `edit_others_posts` capability but not
`publish_posts`, it was possible for that user to unstick a post after editing,
since the input field was never made available in that context.

Props ericmann, chriscct7.
Fixes #24153.



git-svn-id: https://develop.svn.wordpress.org/trunk@33096 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-06 22:40:59 +00:00