Commit Graph

1520 Commits

Author SHA1 Message Date
Daryl Koopersmith c5eee310f4 Trailing commas make IE7 cry. fixes #22819.
git-svn-id: https://develop.svn.wordpress.org/trunk@23124 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 20:42:10 +00:00
bumpbot be03cb514b Compress scripts/styles: 3.5-RC4-23121. TinyMCE updated.
git-svn-id: https://develop.svn.wordpress.org/trunk@23121 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 11:41:16 +00:00
Andrew Nacin 66f1a19089 Add a sane, inclusive HTML element/attribute schema to TinyMCE.
TinyMCE 3.4.x (shipped with WordPress 3.4.x) had an HTML4-based schema definition, with HTML5 elements added to it. TinyMCE 3.5.x (shipping, again coincidentally, with WordPress 3.5) allows for HTML5 schema support, which also provides for full HTML5 attribute support. The problem is its HTML5 schema excludes all HTML4 elements and attributes that were dropped in the HTML5 spec, which is unacceptable behavior.

This "duck punch" of TinyMCE's Schema.js file creates a new, sane schema. It is TinyMCE's HTML4 and HTML5 schema definitions recursively merged.

Objects are not whitelisted in either schema to allow for embed elements as child nodes, so object, param, and embed remain separately whitelisted in the WordPress TinyMCE plugin. Our attempts to add other attributes in said plugin is now superceded.

props koopersmith, azaozz.
fixes #22790.



git-svn-id: https://develop.svn.wordpress.org/trunk@23120 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 11:26:25 +00:00
Andrew Nacin 35edf3665d Add TinyMCE 3.5.8's Schema.js file in preparation for monkey patching it. see #22790.
git-svn-id: https://develop.svn.wordpress.org/trunk@23119 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 11:12:51 +00:00
bumpbot 77d453ddea Compress scripts/styles: 3.5-RC4-23115.
git-svn-id: https://develop.svn.wordpress.org/trunk@23115 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 01:15:44 +00:00
Andrew Nacin 844c3f322d Remove trailing comma from JS. props koopersmith, fixes #22800.
git-svn-id: https://develop.svn.wordpress.org/trunk@23114 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 01:13:04 +00:00
bumpbot 412a605ecf Compress scripts/styles: 3.5-RC4-23113. TinyMCE updated.
git-svn-id: https://develop.svn.wordpress.org/trunk@23113 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 00:07:33 +00:00
Ryan Boren ce2720984b Extend allowed elements for object and embed.
Props azaozz
fixes #22790


git-svn-id: https://develop.svn.wordpress.org/trunk@23112 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 00:05:54 +00:00
bumpbot 01259734c2 Compress scripts/styles: 3.5-RC4-23111.
git-svn-id: https://develop.svn.wordpress.org/trunk@23111 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 23:17:49 +00:00
Ryan Boren a0a13a3fc4 When inserting from URL in the media modal, retain query params and properly insert the caption code.
Props koopersmith
fixes #22796


git-svn-id: https://develop.svn.wordpress.org/trunk@23110 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 23:12:59 +00:00
bumpbot 789be95446 Compress scripts/styles: 3.5-RC3-23104.
git-svn-id: https://develop.svn.wordpress.org/trunk@23104 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 08:13:44 +00:00
Andrew Nacin 3403c1d157 Properly apply CSS and an ID attribute to the select files container. props koopersmith. fixes #22780. see #22762.
git-svn-id: https://develop.svn.wordpress.org/trunk@23100 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 07:00:41 +00:00
bumpbot 66f7523e43 Compress scripts/styles: 3.5-RC3-23099.
git-svn-id: https://develop.svn.wordpress.org/trunk@23099 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 06:58:33 +00:00
Andrew Nacin b186d63721 Media: When the attachment details view changes to another view or attachment, save compat fields on destroy. (We already do this for non-compat fields.) props koopersmith. fixes #22776.
git-svn-id: https://develop.svn.wordpress.org/trunk@23098 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 06:56:06 +00:00
Mark Jaquith e0f5f47c57 Add the ability to click "Edit" and kick out to the advanced image editor from within the Media modal. New window, with "Refresh" offered on your return. fixes #22743. props koopersmith, nacin, helenyhou.
git-svn-id: https://develop.svn.wordpress.org/trunk@23095 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 05:52:19 +00:00
bumpbot 40dad409f4 Compress scripts/styles: 3.5-RC3-23093.
git-svn-id: https://develop.svn.wordpress.org/trunk@23093 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 05:26:39 +00:00
Daryl Koopersmith a4f2112fd3 Add a canonical location for media frames, an alias to fetch attachments, and frame caching to custom header. fixes #22775.
git-svn-id: https://develop.svn.wordpress.org/trunk@23092 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 05:06:49 +00:00
bumpbot 21f933625f Compress scripts/styles: 3.5-RC3-23091. TinyMCE updated.
git-svn-id: https://develop.svn.wordpress.org/trunk@23091 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 04:58:34 +00:00
Andrew Ozz b0cd25962e Upgrade to TinyMCE 3.5.8, fixes #22755
git-svn-id: https://develop.svn.wordpress.org/trunk@23090 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 04:50:31 +00:00
Mark Jaquith d801545ff6 New method of managing media selections. There is now a "master" selection in the background. props koopersmith. fixes #22725
* This especially helps when you switch between insert/gallery and have non-images selected (as galleries don't support non-images).
* The views now act as filters on the "master" selection, instead of having their own selections that get passed around.

git-svn-id: https://develop.svn.wordpress.org/trunk@23089 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 03:55:37 +00:00
Andrew Nacin dc3a34b19b Restore captions for non-image attachments. see #22759.
git-svn-id: https://develop.svn.wordpress.org/trunk@23087 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 03:36:17 +00:00
Daryl Koopersmith 977deb7d63 Do not alter the body's overflow attribute when the media modal is opened. Fix image insertion in the visual editor in Firefox. props azaozz. fixes #22765.
git-svn-id: https://develop.svn.wordpress.org/trunk@23085 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 03:15:39 +00:00
bumpbot 2255750962 Compress scripts/styles: 3.5-RC3-23084.
git-svn-id: https://develop.svn.wordpress.org/trunk@23084 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 00:42:44 +00:00
Andrew Nacin 1cc12103f5 Restore the Description field to the media UI in 3.5.
We tried in vain -- a noble but ultimately failed effort -- to reduce the number of fields for attachments from four (title, caption, alt, description) to one (caption for images, title otherwise). Alternative text needed to stay for accessibility reasons, of course.

Eventually title returned due to heavy plugin reliance. Description is too used by too many plugins (often times incorrectly -- the caption is more likely the proper field), hence its less-than-triumphant return today.

Version 3.5 has tried to streamline media in a number of ways. Removing fields may have been too much at once, as it forced not only a user interface change, but a paradigm change as well.

Finally, on upload we populate the description field with IPTC/EXIF captions, rather than the caption field. See #22768, this should be fixed. For now, Description stays.

This commit also restores 'Title' attribute editing to the main tab of the Edit Image dialog. The "Title" field no longer populates title attributes for <img> tags by design (for accessibility and other purposes, see #18984). So, here is a more obvious 'workaround' for the tooltip community.

Finally, this:
 * Cleans up the post.php attachment editor, including by showing a prettier form of the mime type.
 * Enables plugins to specifically hide attachment_fields_to_edit from either post.php (where you can create meta boxes) or the modal (which you may not want to clutter), for compatibility reasons.
 * Hides the 'Describe this file...' placeholder when a field is read-only in the modal.

props nacin, helenyhou.
fixes #22759.



git-svn-id: https://develop.svn.wordpress.org/trunk@23083 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 00:41:06 +00:00
bumpbot bee0035c66 Compress scripts/styles: 3.5-RC3-23080.
git-svn-id: https://develop.svn.wordpress.org/trunk@23080 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 21:22:59 +00:00
Ryan Boren f549a8baa6 Fix uploads in IE9
Props koopersmith
fixes #22762


git-svn-id: https://develop.svn.wordpress.org/trunk@23079 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 21:21:17 +00:00
bumpbot c936792bbb Compress scripts/styles: 3.5-RC3-23078.
git-svn-id: https://develop.svn.wordpress.org/trunk@23078 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 19:22:54 +00:00
Andrew Nacin 0d7c64c9fd Media: Final names for the actions in the dialog sidebar: "Insert from URL" and "Set Featured Image" to go with "Insert Media" and "Create Gallery".
Longer strings (such as a translation) looks excellent when it wraps to another line.

props markjaquith, fixes #22753.



git-svn-id: https://develop.svn.wordpress.org/trunk@23076 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 19:07:48 +00:00
Andrew Nacin bdba526d83 Media: Use '%d selected' for the selection string, and offer a comment to translators to help them find a workable solution with this would-be plural string. fixes #22749. see #22229.
git-svn-id: https://develop.svn.wordpress.org/trunk@23075 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 19:03:38 +00:00
bumpbot c3b88709fd Compress scripts/styles: 3.5-RC3-23073.
git-svn-id: https://develop.svn.wordpress.org/trunk@23073 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 10:58:32 +00:00
Mark Jaquith 92793b6ec2 Intelligently make media fields readonly when the user cannot update or do anything with them. props koopersmith, helenyhou, nacin. fixes #22613
git-svn-id: https://develop.svn.wordpress.org/trunk@23072 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 10:29:24 +00:00
Mark Jaquith d767e74ae9 Implement tabbing between fields in the media modal. props lessbloat, koopersmith. fixes #22659
git-svn-id: https://develop.svn.wordpress.org/trunk@23070 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 09:57:58 +00:00
Mark Jaquith 81bdf1b5d1 When setting the featured image from the dedicated meta box, only show the featured image section in the media chooser. props koopersmith. fixes #22731
* Less distracting
* Some of these sections won't apply for CPTs without an editor

git-svn-id: https://develop.svn.wordpress.org/trunk@23069 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 09:43:10 +00:00
Mark Jaquith 189d4da5de Fix the "Uploaded to this post" filter in the "Add to gallery" state. fixes #22723
Also, use "images" wording instead of generic "media items" when in a gallery (images-only) context. fixes #22722

Both are props koopersmith

git-svn-id: https://develop.svn.wordpress.org/trunk@23068 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 09:25:17 +00:00
Mark Jaquith aabaa0fb8e Use data on the ui.item to transport the original Sortable index for the update() function. This way extensions can set/access this info in their own custom Sortable functions. see #22696
git-svn-id: https://develop.svn.wordpress.org/trunk@23067 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 09:04:19 +00:00
bumpbot fc3c9a8004 Compress scripts/styles: 3.5-RC3-23066.
git-svn-id: https://develop.svn.wordpress.org/trunk@23066 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 04:58:33 +00:00
Ryan Boren 86203fa6bf Clear the From URL view in the media modal after inserting an image. Improve button enable checks.
Props koopersmith
fixes #22740


git-svn-id: https://develop.svn.wordpress.org/trunk@23065 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 04:43:51 +00:00
Mark Jaquith 4413c9514b Allow a sortable options hash to be passed in, so you can override the defaults. props koopersmith. see #22696
git-svn-id: https://develop.svn.wordpress.org/trunk@23064 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 04:11:49 +00:00
bumpbot 6b81fd778d Compress scripts/styles: 3.5-RC3-23059.
git-svn-id: https://develop.svn.wordpress.org/trunk@23059 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 02:58:34 +00:00
Andrew Nacin bc8f994e7b Media models: Trac and ignore deleted attachments.
Treat an admin-ajax response of 1 as successful for backwards compatibility with existing handlers.

props koopersmith. fixes #22750.



git-svn-id: https://develop.svn.wordpress.org/trunk@23057 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 02:31:41 +00:00
Andrew Nacin 01e7e10bf7 Media: Don't try to resize the bottom selection UI. props koopersmith. fixes #22748.
git-svn-id: https://develop.svn.wordpress.org/trunk@23056 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 01:38:44 +00:00
Andrew Nacin 426eb50936 Fix inserting of multiple attachments with captions when the first attachment does not have a caption. props azaozz. fixes #22720.
git-svn-id: https://develop.svn.wordpress.org/trunk@23055 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 00:59:25 +00:00
bumpbot 25337c050c Compress scripts/styles: 3.5-RC3-23054.
git-svn-id: https://develop.svn.wordpress.org/trunk@23054 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 00:58:31 +00:00
Daryl Koopersmith eae68af55c Toggle display of plupload overlays when the select files button is hidden. see #22732.
git-svn-id: https://develop.svn.wordpress.org/trunk@23053 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 00:45:21 +00:00
Andrew Nacin 3fd91ed4cf Media: Return to the library when the editing a selection and all items get de-selected. props koopersmith. fixes #22715.
git-svn-id: https://develop.svn.wordpress.org/trunk@23051 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 00:22:11 +00:00
Ryan Boren e13e333569 When inserting an image From URL, show the fields only if it looks like we have a valid image.
Props koopersmith
fixes #22740


git-svn-id: https://develop.svn.wordpress.org/trunk@23048 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-04 23:07:41 +00:00
bumpbot 2e35cea2fa Compress scripts/styles: 3.5-RC3-23047. TinyMCE updated.
git-svn-id: https://develop.svn.wordpress.org/trunk@23047 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-04 22:44:27 +00:00
Ryan Boren 52b234de11 When deleting an image in the editor with the delete or backspace keys, hide the edit and delete popup buttons.
Props azaozz, lessbloat
fixes #22717


git-svn-id: https://develop.svn.wordpress.org/trunk@23046 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-04 22:42:26 +00:00
Ryan Boren b5fdf3753f In the media modal, clear attachment details when clearing the selection.
Props koopersmith
fixes #22718


git-svn-id: https://develop.svn.wordpress.org/trunk@23045 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-04 22:19:08 +00:00
bumpbot db2e7dc099 Compress scripts/styles: 3.5-RC3-23043.
git-svn-id: https://develop.svn.wordpress.org/trunk@23043 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-04 20:58:33 +00:00