Commit Graph

30387 Commits

Author SHA1 Message Date
Andrew Ozz 44eaf91b75 Press This: fix iOS bug that prevents closing of the split button when tapping outside of it.
See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32966 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 02:14:29 +00:00
Scott Taylor 550763988b `ob_get_contents()` followed by `ob_end_clean()` can be replaced by `ob_get_clean()`.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32965 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 01:11:45 +00:00
Scott Taylor f162be6046 For doc block types, favor `bool` over the few remaining `boolean`s
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32964 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 01:02:12 +00:00
Scott Taylor 2a5278e2dd Some doc blocks should use `bool` instead of `true|false`
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32963 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 00:44:21 +00:00
Scott Taylor 297b615b99 In `WP_Filesystem_Base::chdir|chgrp|chmod()` (all mock `abstract` methods), modify `@return` to include `string` so that subclass `@return`s match.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32962 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 00:42:43 +00:00
Scott Taylor fe617914d4 Declare visibility for `WP_Locale` methods.
See #32444.



git-svn-id: https://develop.svn.wordpress.org/trunk@32961 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-27 00:31:27 +00:00
Andrew Ozz 4affc95146 TinyMCE: prevent error in the wptextpattern plugin when the first child node in a paragraph is not a text node.
See #31441;

git-svn-id: https://develop.svn.wordpress.org/trunk@32960 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 23:18:16 +00:00
Andrew Ozz a0ebf84f40 Update Twemoji to 1.4.1 including up to 3c0c13d3a5 (exclude SVG elements). Remove our hacks and adapt wp-emoji.js to use the new image attributes callback.
Fixes #32203.

git-svn-id: https://develop.svn.wordpress.org/trunk@32959 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 22:00:13 +00:00
Andrew Ozz d688a2ddc2 TinyMCE, inline link toolbar: fix z-index bug in iOS Safari.
See #32604.

git-svn-id: https://develop.svn.wordpress.org/trunk@32958 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 20:28:59 +00:00
Andrew Ozz 8b77a613c1 TinyMCE: add the editor focusing help the Keyboard Shortcuts modal.
See #31913.

git-svn-id: https://develop.svn.wordpress.org/trunk@32957 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 18:48:02 +00:00
Andrew Ozz 82d937a96e TinyMCE, inline link toolbar: fix styling on small screens so the displayed URL is not needlessly truncated.
See #32604.

git-svn-id: https://develop.svn.wordpress.org/trunk@32956 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 17:54:57 +00:00
Dominik Schilling (ocean90) d6ebee58c2 Customizer: Prevent dragging menu items above the main heading.
Improve targeting for the `sortableItems`, resolving an issue where the first `<li>` in the control became a sortable target, allowing the user to drag a single top level menu outside the intended sortable area.

props adamsilverstein.
fixes #32738.
#wceu

git-svn-id: https://develop.svn.wordpress.org/trunk@32955 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 17:10:12 +00:00
Boone Gorges 4f60683623 Improve error checking in `get_edit_term_link()`.
The function should not throw notices when an improper term or taxonomy is
passed.

Props tmatsuur, MikeHansenMe.
Fixes #32786.

git-svn-id: https://develop.svn.wordpress.org/trunk@32954 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 14:12:27 +00:00
Boone Gorges da5c716009 Introduce `WP_UnitTestCase::delete_user()`.
This static method provides a multisite-agnostic way to delete users during
automated testing.

See #32796.

git-svn-id: https://develop.svn.wordpress.org/trunk@32953 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 12:58:29 +00:00
Scott Taylor d0c3281ea8 In Media microtemplates after [32467], use `<button>` instead of `<a>` for several more non-links.
Props afercia.
Fixes #26550.


git-svn-id: https://develop.svn.wordpress.org/trunk@32952 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 05:00:42 +00:00
Andrew Ozz 9b671bdf9e TinyMCE: update the Keyboard Shortcuts help modal, use the TinyMCE UI API instead of an iframe.
Props iseulde, azaozz. Fixes #31913.

git-svn-id: https://develop.svn.wordpress.org/trunk@32951 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 04:39:11 +00:00
Dion Hulse b7127176a1 Remove an undeeded space concatenation from `wpmu_validate_user_signup()`.
This was previously used to prevent `strpos()` returning 0, which is not needed after r32942.
See #32444


git-svn-id: https://develop.svn.wordpress.org/trunk@32950 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-26 01:38:25 +00:00
Scott Taylor afd45937eb After [32866], fix doc blocks.
Props DrewAPicture.
See #32363.


git-svn-id: https://develop.svn.wordpress.org/trunk@32949 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 21:01:56 +00:00
Scott Taylor 229a9cc434 List tables: when post navigation links point to the current page, use `<span>`s and text instead of `<a>`s.
Props afercia.
Fixes #32253.


git-svn-id: https://develop.svn.wordpress.org/trunk@32948 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 20:31:51 +00:00
Scott Taylor dcd5b25395 After [32896], update `ConvertChars.php` unit tests and rename to `ConvertInvalidEntries.php`.
Props boonebgorges.
Fixes #32335.


git-svn-id: https://develop.svn.wordpress.org/trunk@32947 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 19:50:14 +00:00
Scott Taylor 9f5df5d045 Admin menu: improve accessibility when collapsed.
Props afercia.
Fixes #32346.


git-svn-id: https://develop.svn.wordpress.org/trunk@32946 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 19:32:36 +00:00
Scott Taylor 53bc964fc1 After [32796], improve the accessibility and markup for instances of `touch_time()`.
Props rianrietveld, afercia.
Fixes #31714.


git-svn-id: https://develop.svn.wordpress.org/trunk@32945 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 19:30:00 +00:00
Andrew Ozz ae029a133e Press This: better screen reader text for the arrow part of the split button.
Props afercia. See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32944 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 19:23:54 +00:00
Scott Taylor 4d28f9a7de In `get_site_option()` and `get_option()`, ensure that `$notoptions` is an array before writing to it. Prevents a flood of `Cannot use a scalar value as an array`, because `$notoptions` is otherwise set to the result of `wp_cache_get()`, which returns `mixed`.
Props hauvong.
Fixes #31147.


git-svn-id: https://develop.svn.wordpress.org/trunk@32943 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 19:00:51 +00:00
Scott Taylor 6690882fc1 `wpmu_validate_user_signup()` should strictly check against `false` when using `strpos()`.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32942 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 16:56:01 +00:00
Scott Taylor cd188f40d1 `WP_Rewrite::add_rule()` should strictly check against `false` when using `strpos()`.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32941 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 16:55:35 +00:00
Scott Taylor 9cef023a96 `prep_atom_text_construct()` and `before_last_bar()` should strictly check against `false` when using `str(r)?pos()`.
Sidenote: there's a function named `before_last_bar`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32940 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 16:48:14 +00:00
Scott Taylor f335ef9a66 Remove unused code from `WP_Press_This::html()`.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32939 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 16:37:56 +00:00
Scott Taylor 1bae0bb006 Remove unused code from `WP_MS_Sites_List_Table::display_rows()`.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32938 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 16:35:51 +00:00
Andrew Ozz 017d27a2c1 TinyMCE, inline link toolbar:
- Add max-width for all floating toolbars.
- Ensure the inline link toolbar doesn't exceed the width on small screen devices.
- Do not cut/concatenate the URL when it is less than 40 characters long.
- Show more of the URL if the beginning part plus the ending part are less than 40 characters long.
See #32604.

git-svn-id: https://develop.svn.wordpress.org/trunk@32937 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 04:41:34 +00:00
Andrew Ozz 6d6a1980b2 Press This: support passing `i` parameter to add an image src.
Props stephdau, azaozz. Fixes #32173.

git-svn-id: https://develop.svn.wordpress.org/trunk@32936 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 03:05:47 +00:00
Andrew Ozz dc56b51c47 Define `SCRIPT_DEBUG` early on every load, similarly to `WP_DEBUG`. Remove `defined( 'SCRIPT_DEBUG' )` checks.
Fixes #32333.

git-svn-id: https://develop.svn.wordpress.org/trunk@32935 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 02:28:50 +00:00
Andrew Ozz e06cc095b4 Press This, split button: wrap the sub-buttons in an unordered list to aid accessibility.
Props afercia. See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32934 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 01:54:36 +00:00
John Blackbourn dd419b74cc Introduce a `no_terms` label for taxonomies. This label is used when indicating that there are no terms in the given taxonomy associated with an object.
Fixes #32150
Props afercia


git-svn-id: https://develop.svn.wordpress.org/trunk@32933 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 00:15:46 +00:00
Ella Iseulde Van Dorpe 7fc64e8adb wplink: update TinyMCE UI after updating the link
See #32604.


git-svn-id: https://develop.svn.wordpress.org/trunk@32932 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 23:22:44 +00:00
Ella Iseulde Van Dorpe ed5625f831 TinyMCE: wplink: add inline toolbar
Now the URL can be viewed as soon as you put the cursor in an anchor tag. Clicking on it will open the page in a new tab. You also have the edit and remove button close at hand.

First run.
See #32604.


git-svn-id: https://develop.svn.wordpress.org/trunk@32931 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 23:04:46 +00:00
Scott Taylor ac63fb4dc3 YouTube oEmbed parsing: support the `m` subdomain.
Adds unit tests.

Props Toru, johnbillion.
Fixes #32714.


git-svn-id: https://develop.svn.wordpress.org/trunk@32930 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 21:05:59 +00:00
Scott Taylor 2ddca22b66 Remove the `whois.arin.net` link from `wp_notify_postauthor()` and `wp_notify_moderator()`.
Also, remove from `edit-form-comment.php` and add a new filter: `edit_comment_misc_actions`. 

Props ozh, joedolson, rachelbaker.
Fixes #15281.


git-svn-id: https://develop.svn.wordpress.org/trunk@32929 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 20:55:05 +00:00
Sergey Biryukov 8d756c76c1 Add `editor_stylesheets` filter to `get_editor_stylesheets()`.
props danielbachhuber, MikeHansenMe.
fixes #31672.

git-svn-id: https://develop.svn.wordpress.org/trunk@32928 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 13:31:11 +00:00
Drew Jaynes 64da56c543 Fix a typo in the DocBlock for `get_plugins()`.
Props onnimonni, swissspidy.
Fixes #32758.


git-svn-id: https://develop.svn.wordpress.org/trunk@32927 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 12:21:57 +00:00
Drew Jaynes e95626a94f Document default values for optional arguments in `edit_term_link()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32926 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 10:55:13 +00:00
Drew Jaynes bdd00bc8c7 Add missing documentation for the `$echo` parameter in the DocBlock for `edit_term_link()`.
Props tmatsuur.
Fixes #32776.


git-svn-id: https://develop.svn.wordpress.org/trunk@32925 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 10:52:32 +00:00
Dion Hulse b1b9db161f WP Filesystem: Correctly set the @since for WP_Filesystem_Base::getchmod() added in r32923.
This is 2.5.0 as that's when the function become available in all subclasses.
See #29548


git-svn-id: https://develop.svn.wordpress.org/trunk@32924 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 04:51:16 +00:00
Dion Hulse fc52d9cbb1 WP Filesystem: Correctly parse the permissions field in the directory listings, and actually set it in FTP environments
Props mnelson4 for initial patch.
Fixes #29548


git-svn-id: https://develop.svn.wordpress.org/trunk@32923 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 04:48:18 +00:00
Andrew Ozz bdace7c8b5 Press This: fix spinner position relative to the split button.
See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32922 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 03:31:03 +00:00
Andrew Ozz 504f154363 Press This: ensure proper tab order in the split button. Tweak padding and border color a bit.
See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32921 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 03:22:57 +00:00
Andrew Ozz 9911a1cbe6 Press This: convert the Preview | Save | Publish buttons to a split button.
See #32757.

git-svn-id: https://develop.svn.wordpress.org/trunk@32920 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 02:45:38 +00:00
John Blackbourn 447550ec7b Implement tests for the `upload_mimes` filter to ensure it prevents the upload of disallowed file types.
See #32693


git-svn-id: https://develop.svn.wordpress.org/trunk@32919 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 00:42:33 +00:00
John Blackbourn 8c22c526bd Implement canonical and `url_to_postid()` tests for child pages which share a post name with other child pages.
See #32759


git-svn-id: https://develop.svn.wordpress.org/trunk@32918 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 00:40:45 +00:00
John Blackbourn 06ed4c4d0f Correct the title used on the user dashboard.
Fixes #32754
Props johnjamesjacoby


git-svn-id: https://develop.svn.wordpress.org/trunk@32917 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-24 00:36:40 +00:00