Commit Graph

33393 Commits

Author SHA1 Message Date
Pascal Birchler b62421681e Docs: Improve readability of the default arguments of `wp_list_categories()`.
Adds missing documentation for the `separator` argument introduced in [35140].

Props birgire for initial patch.
Fixes #34751.

git-svn-id: https://develop.svn.wordpress.org/trunk@36135 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 11:29:19 +00:00
Andrea Fercia b2b14848d6 Admin: fix repositioning of notices when the first header is not an immediate children of `.wrap`.
Props DvanKooten for the initial patch.
Fixes #35047 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@36134 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 11:04:38 +00:00
Dion Hulse a1b31b59c4 XMLRPC: Revert [35509] which caused a change of behviour in at least one XMLRPC client.
XMLRPC has many quirks in it's operation, #16980 being just one of the many, #35185 just became yet another quirk.

See #16980.
Fixes #35185.


git-svn-id: https://develop.svn.wordpress.org/trunk@36132 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 04:05:22 +00:00
Sergey Biryukov c04ae32ff9 Widgets: Revert [34465], as it introduced a regression, making the `$index` argument of `dynamic_sidebar()` case-sensitive.
Fixes #34995 for trunk. See #23423.

git-svn-id: https://develop.svn.wordpress.org/trunk@36130 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 03:12:36 +00:00
Gary Pendergast a9dcce7060 Redirects: Prevent redirects if a queried object exists.
After [34659], it became possible to cause an incorrect redirect, by changing the slug of a post, then creating a new post with the old slug. The correct behaviour is to prevent redirecting to the old post.

Props dd32, pento.

Fixes #35031 for trunk.



git-svn-id: https://develop.svn.wordpress.org/trunk@36128 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 03:00:33 +00:00
Sergey Biryukov cf82d2ef2b Query: Remove a stray debug line from `WP_Query::get_posts()`.
Props dlh.
Fixes #35271.

git-svn-id: https://develop.svn.wordpress.org/trunk@36127 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 02:22:26 +00:00
Gary Pendergast 873326b7eb Emoji: Update emoji support to Unicode 8.0, including the Diversity set.
Fixes #33592.



git-svn-id: https://develop.svn.wordpress.org/trunk@36126 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-31 01:29:12 +00:00
Pascal Birchler aae9afe5aa Comments: Don't nofollow links within the site.
Fixes #11360.

git-svn-id: https://develop.svn.wordpress.org/trunk@36125 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-30 23:19:11 +00:00
Pascal Birchler 4f6d5aa034 Plugins: Add a new `pre_uninstall_plugin` action that runs right before uninstalling a plugin.
Fixes #34569.

git-svn-id: https://develop.svn.wordpress.org/trunk@36124 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-30 22:37:49 +00:00
Pascal Birchler bb07293f8c Embeds: Change attachment metadata condition to prevent a warning in the embeds template.
Fixes #35237.

git-svn-id: https://develop.svn.wordpress.org/trunk@36123 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-30 22:24:31 +00:00
Andrea Fercia a03aa810c5 Media: Fix icons for HiDPI displays on the media modal after [32952].
Props vtieu.
Fixes #35200.

git-svn-id: https://develop.svn.wordpress.org/trunk@36122 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-30 18:31:41 +00:00
Andrew Ozz 8686ab4a7a Responsive images: fix the check whether the attachment meta matches the image src to work with http/https and CDNs.
Props webaware, joemcgill, azaozz.
Fixes #35045 and #35102 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@36121 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-30 01:03:11 +00:00
Andrew Ozz f39a799718 Responsive images: add compatibility for versions < 2.7 when the full image path was stored in the metadata. Introduces `_wp_get_attachment_relative_path()` and uses it in `wp_get_attachment_url()`.
Props dd32, SergeyBiryukov.
Fixes #35106 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@36120 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-30 00:05:07 +00:00
Aaron Jorbin d65a4e6498 Ensure only approved comments trigger post author notifications
Posts that are trashed shouldn't trigger post author notifications.  Adds unit tests to enforce this.

Props scottbrownconsulting, peterwilsoncc, swissspidy
Fixes #35006



git-svn-id: https://develop.svn.wordpress.org/trunk@36119 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-29 17:53:23 +00:00
Dion Hulse 18a6a047bd Tests: After [36100] use an object style which is compatible with PHP5 `get_object_vars()`.
See #35058.


git-svn-id: https://develop.svn.wordpress.org/trunk@36117 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-29 05:43:05 +00:00
Gary Pendergast f46c0a637b Tests: When testing the `utf8mb4` charset, ensure that the current MySQL server has `utf8mb4` support.
See #35249.



git-svn-id: https://develop.svn.wordpress.org/trunk@36116 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-29 04:39:02 +00:00
Rachel Baker 61ff693ff0 Comments: Return early from `wp_update_comment_count()` if there is not a valid post.
Props ambrosey, juanfra. 
Fixes #34977



git-svn-id: https://develop.svn.wordpress.org/trunk@36115 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-28 22:57:37 +00:00
Drew Jaynes ee386bf22a Docs: Hash notate properties and defaults for the benefit of `$args` parameter documentation for `WP_Customize_Control::__construct()`.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@36114 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-28 20:09:58 +00:00
Sergey Biryukov 26d7619306 Import: Add a missing space to `post_exists()`.
The lack of space resulted in SQL error when searching for posts by content.

Props yetAnotherDaniel, johnbillion.
Fixes #35246.

git-svn-id: https://develop.svn.wordpress.org/trunk@36113 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-28 19:06:05 +00:00
John Blackbourn a9b9aa65b9 Themes: Add `singular` to the list of body classes when viewing a single post object.
Adds tests

Fixes #35164
Props danielpataki, johnbillion


git-svn-id: https://develop.svn.wordpress.org/trunk@36112 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-28 17:20:07 +00:00
John Blackbourn eb4b852316 Docs: Correct a funky docblock in `funky_javascript_fix()`.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36111 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-28 17:17:56 +00:00
Andrew Ozz 9b9d310c74 Responsive images: when creating `srcset` do not exclude the image size which is in the `src` attribute even when it is larger than `max_srcset_image_width`.
Props joemcgill.
Fixes #35108 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@36110 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-28 02:28:53 +00:00
Boone Gorges ba1f056a26 Force non-public taxonomies to have a query_var of `false`.
[35333] implemented `public=false` for taxonomies. The implementation prevented
non-public taxonomies from having their archives accessed via query_var during
a normal request. But it didn't prevent non-public taxonomies from registering
their query vars in the `$wp_taxonomies` global. The latter implementation
details causes problems specifically when a taxonomy is registered with
`query_var=true`; for public taxonomies, `register_taxonomy()` translates this
into a query_var equivalent to the taxonomy name, but in the case of non-public
taxonomies, the query_var was set to the boolean itself. The boolean then
causes problems when using non-strict comparison to filter taxonomy objects by
query_var, as when using `get_taxonomies()`.

This changeset addresses the issue by forcing the query_var property of
non-public taxonomies to `false`.

Fixes #35089.

git-svn-id: https://develop.svn.wordpress.org/trunk@36108 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-27 16:40:13 +00:00
Sergey Biryukov 7e3d2c3e4c Docs: Improve documentation for `wp_admin_css_color()`.
Props kiranpotphode.
Fixes #34857.

git-svn-id: https://develop.svn.wordpress.org/trunk@36107 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-27 16:32:00 +00:00
Sergey Biryukov 5502d59fb9 Docs: Fix typo in a comment in `wp_rand()`.
Props boluda.
Fixes #35228.

git-svn-id: https://develop.svn.wordpress.org/trunk@36102 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-26 11:06:47 +00:00
Dion Hulse 0ce64dd122 Allow `map_deep()` to work with object properties containing a reference. Restores the previous behaviour of `stripslashes_deep()`.
Props jeff@pyebrook.com, swissspidy.
See #22300, [35252].
Fixes #35058.


git-svn-id: https://develop.svn.wordpress.org/trunk@36100 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-26 05:21:14 +00:00
Dion Hulse 42aeb0af8b Tests: Use the correct URL in some shortcode tests.
git-svn-id: https://develop.svn.wordpress.org/trunk@36099 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-26 04:50:23 +00:00
Dion Hulse a1cd9049d9 Shortcodes: `=` is a reserved character in shortcode names, mark it as such.
This allows for shortcodes such as `[shortcode=attribute]` to work, which while never intentionally supported were widely used in the pre-shortcode days.

Props aaroncampbell.
Fixes #34939 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@36097 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-26 04:45:26 +00:00
Dion Hulse bb0d1af58f Canonical: Output correct canonical links for paged posts when not using pretty permalinks.
Props peterwilsoncc.
Fixes #34890


git-svn-id: https://develop.svn.wordpress.org/trunk@36096 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-26 04:27:43 +00:00
Dion Hulse 0df95091ee Nav Menus: Avoid a PHP Notice when a menu contains a now unregistered post type archive.
Props kucrut.
Fixes #34449 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@36095 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-26 04:04:55 +00:00
Dion Hulse 1d2904bf2a Pages: `get_page_uri()` should return the URI at which the resource being accessed is available at, this may include non-'publish' status posts.
Reverts [34001] and fixes the original issue in #15963 - avoiding a PHP Notice for when the post doesn't exist.

Props tharsheblows.
See #15963.
Fixes #35084.


git-svn-id: https://develop.svn.wordpress.org/trunk@36094 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-26 03:45:28 +00:00
Sergey Biryukov 1fdddd302e Toolbar: In Comments link, replace title attribute containing the number of pending comments with a screen reader text.
Props slushman, rachelbaker.
Fixes #34895.

git-svn-id: https://develop.svn.wordpress.org/trunk@36093 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-26 01:39:50 +00:00
Sergey Biryukov 54c918d407 Remove redundant title attribute from `wp_star_rating()`. Hide the visible number of ratings from assistive technologies.
This data is redundant, as the same information is already conveyed by the text hidden with `.screen-reader-text` class.

Props afercia.
Fixes #35141.

git-svn-id: https://develop.svn.wordpress.org/trunk@36092 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-26 00:47:35 +00:00
Sergey Biryukov 443419ae37 Docs: Clarify that `get_post_types()` accepts `'not'` as its `$operator` parameter.
Props barryceelen.
Fixes #35225.

git-svn-id: https://develop.svn.wordpress.org/trunk@36091 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-26 00:37:14 +00:00
Sergey Biryukov 27ccbb591c Docs: Clarify that `wp_filter_object_list()` accepts `'not'` as its `$operator` parameter.
Props barryceelen.
See #35225.

git-svn-id: https://develop.svn.wordpress.org/trunk@36090 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-26 00:36:12 +00:00
Aaron Jorbin bc01ead655 Help Tab Order should be based on the Priority Argument
[34370] made the order that tabs are returned respect the order they are added, however it broke the respect of priority. By using a ksort instead of a sort, we can restore that default behavior. This adjusts the unit tests so that both order added and priority are tested.

Props meitar,  swissspidy, jorbin
Fixes #35215. See #33941.


git-svn-id: https://develop.svn.wordpress.org/trunk@36089 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-25 22:43:41 +00:00
SergeyBiryukov 2ce0bfa8f4 Theme Editor: Break `$wp_file_descriptions` array into sections and reorder for consistency and readability.
Props ramiy.
Fixes #35223.

git-svn-id: https://develop.svn.wordpress.org/trunk@36088 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-25 21:11:02 +00:00
Sergey Biryukov ffc86bf4e1 Theme Editor: Add `taxonomy.php`, `home.php`, `front-page.php`, `date.php`, and `singular.php` to file descriptions.
Props ramiy.
See #35223.

git-svn-id: https://develop.svn.wordpress.org/trunk@36087 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-25 21:04:13 +00:00
Sergey Biryukov b51d90ee72 Docs: Correct `@return` type for `rest_parse_date()`.
Props TimothyBlynJacobs.
Fixes #35224.

git-svn-id: https://develop.svn.wordpress.org/trunk@36086 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-25 20:40:43 +00:00
Sergey Biryukov bcc607689b Docs: Correct `@return` type for `count_user_posts()`.
Props nofearinc.
Fixes #35222.

git-svn-id: https://develop.svn.wordpress.org/trunk@36085 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-25 20:17:55 +00:00
Gary Pendergast c54bcc4d39 User: Don't continue checking a password reset key, if the hash is empty.
An empty reset key hash will never be valid, so we can skip seeing if it can be used to validate the given key, and return a failure early.

This fixes a warning in the unit tests under HHVM.

See #33926.




git-svn-id: https://develop.svn.wordpress.org/trunk@36084 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-24 02:48:29 +00:00
Gary Pendergast 275c8c1f08 Upgrade PHPMailer from 5.2.10 to 5.2.14.
The full list of changes is available here: https://github.com/PHPMailer/PHPMailer/compare/v5.2.10...v5.2.14

Fixes #35212 for trunk.



git-svn-id: https://develop.svn.wordpress.org/trunk@36083 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-24 01:58:33 +00:00
Konstantin Obenland 498fbb407c Menus: Bring back line break between menu items.
While removing line breaks was great for all use cases except justified menu
items, it broke menus with justified menu items.
Reverts [34321].

Props wp-architect.
Fixes #35107.



git-svn-id: https://develop.svn.wordpress.org/trunk@36081 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-24 00:20:24 +00:00
Konstantin Obenland 1d68393907 Taxonomy: Pass object ids to delete_* actions.
Allows for more targeted updates to affected posts in callbacks.
Disambiguates `$objects` variable and amends unit tests.

Fixes #35213.


git-svn-id: https://develop.svn.wordpress.org/trunk@36080 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 23:43:03 +00:00
Boone Gorges 9c2d3a7a4d Improve post-filter sanitization of excluded terms in `get_adjacent_post()`.
See [36078], #35211.

git-svn-id: https://develop.svn.wordpress.org/trunk@36079 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 20:14:12 +00:00
Boone Gorges fff6412f91 Move excluded_terms filter in `get_adjacent_post()`.
The filter was added in 4.4 [34528] #9571, but in a place where it could not
affect the adjacent post query.

Fixes #35211.

git-svn-id: https://develop.svn.wordpress.org/trunk@36078 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 19:56:32 +00:00
Boone Gorges 7d03711fc8 Move `get_adjacent_post()` tests to their own file.
See #35211.


git-svn-id: https://develop.svn.wordpress.org/trunk@36077 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 19:38:29 +00:00
Boone Gorges d7fccb6c01 Respect `$_wp_suspend_cache_invalidation` in `clean_object_term_cache()`.
Props mwidmann.
Fixes #35208.

git-svn-id: https://develop.svn.wordpress.org/trunk@36076 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 19:28:06 +00:00
Sergey Biryukov 6bc8f2e24c Twenty Fifteen: Add left margin for lists inside blockquotes in `editor-style.css`.
Props diddledan.
Fixes #33380.

git-svn-id: https://develop.svn.wordpress.org/trunk@36075 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 13:09:38 +00:00
John Blackbourn 858cf7d215 Docs: Miscellaneous docblock code quality tweaks.
See #32246


git-svn-id: https://develop.svn.wordpress.org/trunk@36074 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-23 07:52:04 +00:00