Commit Graph

41 Commits

Author SHA1 Message Date
Ryan Boren 4088ca8723 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23563 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 17:00:25 +00:00
Ryan Boren c363aea627 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23554 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:28:40 +00:00
Ryan Boren a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Andrew Nacin 6e9830f34d Don't stomp existing sizes inside wp_save_image().
props markoheijnen.
see #22985.
for trunk.



git-svn-id: https://develop.svn.wordpress.org/trunk@23246 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-03 05:23:36 +00:00
Andrew Nacin 110c7769e5 Rip keyboard shortcuts out of the image editor help. props helenyhou. fixes #22786.
git-svn-id: https://develop.svn.wordpress.org/trunk@23106 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 09:21:27 +00:00
Mark Jaquith e0f5f47c57 Add the ability to click "Edit" and kick out to the advanced image editor from within the Media modal. New window, with "Refresh" offered on your return. fixes #22743. props koopersmith, nacin, helenyhou.
git-svn-id: https://develop.svn.wordpress.org/trunk@23095 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 05:52:19 +00:00
Ryan Boren 8b1ebd858a In wp_image_editor(), use wp_image_editor_supports() to check for rotation capabilities rather than directly checking the existence of the imagerotate function.
In WP_Image_Editor_GD::test(), check for existence of imagerotate if the rotate capability is required.

Props DH-Shredder
fixes #22597


git-svn-id: https://develop.svn.wordpress.org/trunk@22863 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-27 14:36:55 +00:00
Andrew Nacin f44d1d009e WP_Image_Editor: the last stand.
* Have wp_get_image_editor() rather than WP_Image_Editor::get_instance(). Having static factory methods would be less confusing if there weren't also static methods tied to individual editor implementations.
 * Lazy-load the WP_Image_Editor base class and editor implementations.
 * Have WP_Image_Editor_GD::supports_mime_type() actually check which types it supports.
 * Deprecate gd_edit_image_support() in favor of wp_image_editor_supports().

props DH-Shredder, scribu, markoheijnen. fixes #22356. see #6821.



git-svn-id: https://develop.svn.wordpress.org/trunk@22817 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 09:52:16 +00:00
Daryl Koopersmith ba65b3ffc7 Media: Replace the thumbnail on post.php using a request variable instead of the referer. props ocean90. fixes #21391.
git-svn-id: https://develop.svn.wordpress.org/trunk@22807 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 03:43:16 +00:00
Andrew Nacin b69e4bf685 Properly refresh the thumbnail on post.php after an image edit. props ocean90. see #21391.
git-svn-id: https://develop.svn.wordpress.org/trunk@22749 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 12:05:24 +00:00
Ryan Boren e678b95a5a WP_Image_Editor improvements.
* Make test() and supports_mime_type() static.
* Add required_methods argument to get_instance(). Allows requesting an implementation that has certain methods/capabilities.
* Whitespace cleanup

Props markoheijnen
see #6821


git-svn-id: https://develop.svn.wordpress.org/trunk@22510 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-09 19:38:54 +00:00
Ryan Boren 167cc00a84 Check for WP_Error return from WP_Image_Editor::get_instance().
Props markoheijnen
see #6821


git-svn-id: https://develop.svn.wordpress.org/trunk@22192 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-11 18:59:41 +00:00
Ryan Boren 7790af3154 Introduce WP_Image_Editor, WP_Image_Editor_Imagick, and WP_Image_Editor_GD. Abstracts image editing API and adds support for ImageMagick.
Props DH-Shredder, kurtpayne, markoheijnen
see #6821


git-svn-id: https://develop.svn.wordpress.org/trunk@22094 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-01 20:59:06 +00:00
Andrew Nacin 1e270f44a4 Remove 'hwstring_small' from attachment metadata and deprecate get_udims(). props SergeyBiryukov. fixes #21518.
git-svn-id: https://develop.svn.wordpress.org/trunk@21808 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-11 01:38:26 +00:00
Ryan Boren 6fde0bddaf Make choosing a header image from the media library play nicely with file replication plugins that do not guarantee images will be retained in the local filesystem.
* When passing an attachment ID to wp_crop_image(), use load_image_to_edit() to fetch the image via a url fopen when the image does not exist in the filesystem.
* Move load_image_to_edit() to wp-admin/includes/image.php so that it is always available for admin pages loads.
* Fallback to the height and width stored in the attachment meta when the image no longer exists in the filesystem.

see #19840


git-svn-id: https://develop.svn.wordpress.org/trunk@20384 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-06 20:47:24 +00:00
Andrew Nacin 0c751dd7a3 Use relative paths for admin-ajax.php to avoid cross-domain issues with IDN domains in IE and Opera. props SergeyBiryukov, fixes #18952.
git-svn-id: https://develop.svn.wordpress.org/trunk@19871 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-08 16:12:11 +00:00
Ryan Boren 2b186b0c45 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: https://develop.svn.wordpress.org/trunk@19712 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-08 17:01:11 +00:00
Ryan Boren 5e76729992 One newline is enough.
git-svn-id: https://develop.svn.wordpress.org/trunk@19684 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-05 20:10:39 +00:00
Ryan Boren 676ba7043e Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: https://develop.svn.wordpress.org/trunk@19593 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-13 23:45:31 +00:00
Andrew Nacin f95cb305ea Use get_intermediate_image_sizes() in image edit functions. props mau, fixes #17475.
git-svn-id: https://develop.svn.wordpress.org/trunk@18996 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-18 20:33:34 +00:00
Peter Westwood 8f1955ddf5 Introduce WP_MAX_MEMORY_LIMIT constant for the high memory limit we set when image processing and unzipping.
Ensure it is always filterable by plugins as well as configurable in wp-config
Fixes #13847 props hakre


git-svn-id: https://develop.svn.wordpress.org/trunk@17749 602fd350-edb4-49c9-b593-d223f7449a82
2011-04-28 16:25:36 +00:00
Ryan Boren 9691cb5eb2 Take out unnecessary compat functions from compat.php. Props hakre, ptahdunbar. see #16918
git-svn-id: https://develop.svn.wordpress.org/trunk@17603 602fd350-edb4-49c9-b593-d223f7449a82
2011-04-05 17:13:04 +00:00
Dion Hulse 1a22b56c53 Remove PHP4 based WP_Http_Fopen class. Props sivel for initial patch. See #16917 Fixes #13915
git-svn-id: https://develop.svn.wordpress.org/trunk@17534 602fd350-edb4-49c9-b593-d223f7449a82
2011-03-23 11:35:41 +00:00
Andrew Nacin 8d9b2cd2b3 Properly check, initialize, or cast a number of variables. props ChenHui. see #14642.
git-svn-id: https://develop.svn.wordpress.org/trunk@16377 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-15 06:38:10 +00:00
Peter Westwood 08864673f3 Allow better contextual based filtering of the path to the image being edited by having specific filters for local filesystem and url based paths.
git-svn-id: https://develop.svn.wordpress.org/trunk@16130 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-01 10:36:35 +00:00
Ryan Boren c01fb90ff1 Deprecate wp_shrink_dimension(), add wp-admin/includes/deprecated.php. Props filosofo. fixes #11967
git-svn-id: https://develop.svn.wordpress.org/trunk@12823 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-25 18:50:01 +00:00
Ryan Boren 2e46e81309 i18n fixes. Props nbachiyski. fixes #11954
git-svn-id: https://develop.svn.wordpress.org/trunk@12789 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-21 21:37:43 +00:00
Ryan Boren 8ef8b7bad5 Trailing whitespace cleanup
git-svn-id: https://develop.svn.wordpress.org/trunk@12733 602fd350-edb4-49c9-b593-d223f7449a82
2010-01-15 22:11:12 +00:00
Andrew Ozz 39665b05c3 Show disabled image rotation buttons when imagerotate() is missing, props husky and hakre, fixes #11536
git-svn-id: https://develop.svn.wordpress.org/trunk@12555 602fd350-edb4-49c9-b593-d223f7449a82
2009-12-27 21:24:39 +00:00
Peter Westwood 154ecfda7b Fix spelling mistake in tooltip for image rotation button. Fixes #11488 for trunk props computerwiz908.
git-svn-id: https://develop.svn.wordpress.org/trunk@12481 602fd350-edb4-49c9-b593-d223f7449a82
2009-12-22 12:02:51 +00:00
Andrew Ozz 8219ad5b49 Fix the scale image check in image editor, fixes #11473 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@12446 602fd350-edb4-49c9-b593-d223f7449a82
2009-12-18 09:52:32 +00:00
Andrew Ozz 437db709fc Swap the Flip horizontally and Flip vertically buttons in the image editor so they are more understandable, props scribu, fixes #11171
git-svn-id: https://develop.svn.wordpress.org/trunk@12281 602fd350-edb4-49c9-b593-d223f7449a82
2009-11-26 07:49:44 +00:00
Andrew Ozz 52bff7f918 Fix image meta after editing image, disable the Save button when no changes, fixes #11115
git-svn-id: https://develop.svn.wordpress.org/trunk@12163 602fd350-edb4-49c9-b593-d223f7449a82
2009-11-11 11:24:01 +00:00
Andrew Ozz 5012c4e964 Add 'IMAGE_EDIT_OVERWRITE' constant to control edited image save or replace, most useful for setups that have dynamic image resizing, see #10528
git-svn-id: https://develop.svn.wordpress.org/trunk@12155 602fd350-edb4-49c9-b593-d223f7449a82
2009-11-07 11:20:09 +00:00
Andrew Ozz 917e03d25b Image Editor: fix refreshing of the thumbnail, use WP_Http_Fopen::test(), see #10528
git-svn-id: https://develop.svn.wordpress.org/trunk@11985 602fd350-edb4-49c9-b593-d223f7449a82
2009-09-30 23:39:09 +00:00
Andrew Ozz 2895da93b2 Image Editor: add load and save image filters, fix backup sizes meta, see #10528
git-svn-id: https://develop.svn.wordpress.org/trunk@11984 602fd350-edb4-49c9-b593-d223f7449a82
2009-09-30 08:38:32 +00:00
Andrew Ozz a8505d056f Image Editor: fix preview size calculation when cropping small part of a very large image, see #10528
git-svn-id: https://develop.svn.wordpress.org/trunk@11973 602fd350-edb4-49c9-b593-d223f7449a82
2009-09-26 04:07:27 +00:00
Andrew Ozz dfed9737d7 Image Editor: fix JS prompt, add size to 'load_image_to_edit' filter, see #10528
git-svn-id: https://develop.svn.wordpress.org/trunk@11967 602fd350-edb4-49c9-b593-d223f7449a82
2009-09-24 08:47:33 +00:00
Andrew Ozz 5e878a916d Image Editor improvements, see #10528
git-svn-id: https://develop.svn.wordpress.org/trunk@11965 602fd350-edb4-49c9-b593-d223f7449a82
2009-09-24 01:54:07 +00:00
Ryan Boren 43c201d458 Remove trailing whitespace
git-svn-id: https://develop.svn.wordpress.org/trunk@11930 602fd350-edb4-49c9-b593-d223f7449a82
2009-09-14 14:03:32 +00:00
Andrew Ozz 4f22e99cf5 Image editing (first run). Includes code by stephanreiter, see #10528
git-svn-id: https://develop.svn.wordpress.org/trunk@11911 602fd350-edb4-49c9-b593-d223f7449a82
2009-09-10 22:07:33 +00:00