Commit Graph

17266 Commits

Author SHA1 Message Date
Sergey Biryukov
4ac1670efe Docs: Correct @since version for available_permalink_structure_tags filter.
Follow-up to [41182].

Props tiagohillebrandt, sabernhardt.
Fixes #42624.

git-svn-id: https://develop.svn.wordpress.org/trunk@47893 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-03 10:36:32 +00:00
Sergey Biryukov
c21a340f95 Docs: Miscellaneous DocBlock corrections.
See #49572.

git-svn-id: https://develop.svn.wordpress.org/trunk@47892 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-03 10:00:27 +00:00
Adam Silverstein
fa96d59318 Formatting: add a new 'safe_style_disallowed_chars' filter.
Enable developers to change the regex used in `safecss_filter_attr` to limit characters in the parsed CSS.

Props paulschreiber, swissspidy, rmccue, bartekcholewa, miinasikk.
Fixes #37134.



git-svn-id: https://develop.svn.wordpress.org/trunk@47891 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-02 23:44:40 +00:00
Sergey Biryukov
e18d6e942b Comments: Rename Walker_Comment::comment_text() to ::filter_comment_text() for clarity.
Ensure the comment object is not null before checking its status.

Follow-up to [47887].

See #49956.

git-svn-id: https://develop.svn.wordpress.org/trunk@47889 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-02 20:51:34 +00:00
Jake Spurlock
d232910423 Comments: Ensure that unmoderated comments won't be search indexed.
After a comment is submitted, only allow a brief window where the comment is live on the site. 

Fixes #49956.
Props: jonkolbert, ayeshrajans, Asif2BD, peterwilsoncc, imath, audrasjb, jonoaldersonwp, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/trunk@47887 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-02 20:10:02 +00:00
Sergey Biryukov
ffd5d37c77 Bundled Themes: Consistently check for WP_Error before outputting get_the_tag_list().
Some themes already had these checks in place as a result of [41756], but not others.

Props sixhours, davidakennedy, SergeyBiryukov.
Fixes #39860.

git-svn-id: https://develop.svn.wordpress.org/trunk@47886 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-02 17:03:06 +00:00
Sergey Biryukov
49f03fff79 Docs: Correct @param type for pre_redirect_guess_404_permalink filter.
Improve filter documentation for consistency with other similar short-circuit filters in core.

Follow-up to [47878].

See #16557.

git-svn-id: https://develop.svn.wordpress.org/trunk@47885 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-02 16:21:49 +00:00
Dominik Schilling
9bea5b3444 I18N: Use wp.i18n for translatable strings in wp-admin/js/updates.js.
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.

Props swissspidy, ocean90.
See #20491.
Fixes #50235.

git-svn-id: https://develop.svn.wordpress.org/trunk@47884 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-01 21:39:30 +00:00
Andrew Ozz
5263a96a4c Plugins and Themes Auto-Updates: update the state of the auto-update link on the themes screen after successfully saving the setting.
Props desrosj, pbiron, azaozz.
Fixes #50291.

git-svn-id: https://develop.svn.wordpress.org/trunk@47883 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-01 20:51:10 +00:00
Jake Spurlock
0cf715f55b Administration: Unify the date structure in list view and excerpt view.
Both views now show a full date string. Something like `Published 2020/05/27 at 10:25 pm`.

Fixes: #35391.
Props: afercia, ocean90, TimothyBlynJacobs, audrasjb, SergeyBiryukov, joedolson.



git-svn-id: https://develop.svn.wordpress.org/trunk@47879 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-01 19:13:54 +00:00
Jake Spurlock
0ad7471880 Canonical: Add the ability to disable redirect_guess_404_permalink().
This also adds a few more filters to make adding redirects easier. Notably:

1. `do_redirect_guess_404_permalink`
2. `pre_redirect_guess_404_permalink`
3. `strict_redirect_guess_404_permalink`

Fixes: #16557.
Props: msafi, nacin, simonwheatley, westi, mboynes, joostdevalk, Lex_Robinson, MikeSchinkel, haukep, paulschreiber, DrewAPicture, ravenswd, esemlabel, stevegibson12, martychc23, DrLightman, jivanpal, neonkowy, laternastudio, apedog, audrasjb, davidbaumwald, Confridin, donmhico, ryotsun. 



git-svn-id: https://develop.svn.wordpress.org/trunk@47878 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-01 18:47:41 +00:00
Dominik Schilling
028299ac79 Editor: Fix code style for constructor arguments added in [47875].
Also revert unintended changes to `WP_Block_Type::__construct()` DocBlock.

See #48529.

git-svn-id: https://develop.svn.wordpress.org/trunk@47876 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-01 16:25:18 +00:00
Greg Ziółkowski
822ca9ebc7 Add fields to WP_Block_Type
As part of #47620 and the RFC for block registeration. Server registered blocks are missing some fields. These changeset includes them.

Props spacedmonkey, aduth.

Fixes #48529.



git-svn-id: https://develop.svn.wordpress.org/trunk@47875 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-01 12:25:34 +00:00
Sergey Biryukov
e0ede89881 Docs: Correct and clarify an inline comment about the upload_url_path and upload_path options in wp-admin/options-media.php.
Synchronize it with a similar comment in `wp-admin/options.php`.

See #49572.

git-svn-id: https://develop.svn.wordpress.org/trunk@47874 602fd350-edb4-49c9-b593-d223f7449a82
2020-06-01 11:20:16 +00:00
Sergey Biryukov
4ae8bdf8c3 Upgrade/Install: Rename wp_in_maintenance_mode() to wp_is_maintenance_mode(), for consistency with wp_is_recovery_mode().
While the former name might be a bit more accurate, the latter matches the existing naming pattern.

Follow-up to [47623].

Fixes #49959.

git-svn-id: https://develop.svn.wordpress.org/trunk@47871 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-30 15:11:02 +00:00
Sergey Biryukov
2e39930d71 Docs: Adjust the documentation for the new ID alias in get_term_by() for consistency with get_user_by().
Follow-up to [47865].

See #45163.

git-svn-id: https://develop.svn.wordpress.org/trunk@47870 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-30 10:06:49 +00:00
Jake Spurlock
7b13f5abd8 Taxonomy: Extend get_term_by to accept ID as a term parameter.
Similar to `get_user_by`, both `ID` and `id` should be able to accepted.

Fixes #45163.
Props emrikol, esoj.
 


git-svn-id: https://develop.svn.wordpress.org/trunk@47865 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-29 22:41:25 +00:00
Sergey Biryukov
64a2e8d55e Docs: Improve documentation for functions in wp-includes/category.php per the documentation standards.
See #49572.

git-svn-id: https://develop.svn.wordpress.org/trunk@47864 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-29 10:05:36 +00:00
Sergey Biryukov
0133a78dec Docs: Document that get_category_by_slug() returns false if the category doesn't exist.
Props stevenlinx.
Fixes #50277.

git-svn-id: https://develop.svn.wordpress.org/trunk@47863 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-29 10:00:32 +00:00
Sergey Biryukov
7f73f1a1e4 Coding Standards: Use strict comparison in wp-admin/_index.php.
See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47862 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-28 10:00:44 +00:00
Sergey Biryukov
cfc5b94f28 Docs: Remove unused @global declarations from _WP_Editors::print_tinymce_scripts().
Follow-up to [47860].

See #45398.

git-svn-id: https://develop.svn.wordpress.org/trunk@47861 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-27 19:46:34 +00:00
Jake Spurlock
d8b8495e8e Editor: Remove TinyMCE global version.
The global variable is not being used in the `editor_settings` method. 

Fixes #45398.
Props ishitaka, noisysocks, mista-flo.



git-svn-id: https://develop.svn.wordpress.org/trunk@47860 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-27 19:26:32 +00:00
Andrea Fercia
184118c3c9 Administration and Site Health: Make information on Search engine visibility more prominent.
- makes the "Search engines discouraged" message on the Dashboard more prominent
- adds "Search engine visibility" information under Site Health > Info > WordPress 
- removes title case in favor of sentence case in all the related strings 

Props audrasjb, swissspidy, emanuel_blagonic, Presskopp, karmatosed, valentinbora, melchoyce.
Fixes #35288.


git-svn-id: https://develop.svn.wordpress.org/trunk@47859 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-27 14:32:00 +00:00
Sergey Biryukov
45d8f6b9d0 Docs: Correct @return value for WP_REST_Meta_Fields::get_value().
Props chrisvanpatten.
Fixes #50259.

git-svn-id: https://develop.svn.wordpress.org/trunk@47858 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-27 09:42:38 +00:00
Jake Spurlock
8efc5321c9 Coding Standards: Change auto-update filters to be more consistent.
* send_theme_auto_update_email 👉 auto_theme_update_send_email
* wp_plugins_auto_update_enabled 👉 plugins_auto_update_enabled
* wp_themes_auto_update_enabled 👉 themes_auto_update_enabled

Want to make sure that @ronalfy gets props for his work in #50052 too.

See #50052.
Props: ronalfy, pbiron, azaozz, audrasjb, whyisjake.



git-svn-id: https://develop.svn.wordpress.org/trunk@47857 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-26 18:01:18 +00:00
Dominik Schilling
adcf5cf7a3 Posts, Post Types: Pass the post object to the delete_attachment action.
Also add the missing `$post` parameter to the `delete_post` and `deleted_post` actions in `wp_delete_attachment()`.

See #30940.

git-svn-id: https://develop.svn.wordpress.org/trunk@47856 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-26 14:47:26 +00:00
Sergey Biryukov
2c75752c88 Coding Standards: Fix instances of Generic.WhiteSpace.ArbitraryParenthesesSpacing.FoundEmpty.
See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47855 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-26 09:35:34 +00:00
Sergey Biryukov
6ec9c9c446 Docs: Improve documentation for add_existing_user_to_blog().
Props stevenlinx.
Fixes #50243.

git-svn-id: https://develop.svn.wordpress.org/trunk@47854 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-25 14:21:50 +00:00
Sergey Biryukov
219acea88f Coding Standards: Use strict comparison in wp-admin/network where static strings are involved.
Includes minor code layout fixes for better readability.

Follow-up to [47808].

See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47853 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-24 09:14:21 +00:00
Sergey Biryukov
2919961c18 Coding Standards: Use strict comparison for $wp_db_version check in wp-admin/network/upgrade.php.
Follow-up to [47787], [47788].

See #50155, #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47852 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-24 09:13:39 +00:00
Sergey Biryukov
3e2d77ae04 Coding Standards: Use strict comparison for more count() calls.
Follow-up to [47848].

Props mukesh27.
Fixes #50232. See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47851 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-23 16:20:10 +00:00
Dominik Schilling
f37a28858d Role/Capability: Use meta caps edit_post, read_post, and delete_post directly.
Rather than consulting the post type object, let `map_meta_cap()` handle that for us.

Props peterwilsoncc, ocean90.
Fixes #50128.
See #23226.

git-svn-id: https://develop.svn.wordpress.org/trunk@47850 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-23 15:22:53 +00:00
Dominik Schilling
584df2a169 Rest API: Ensure rest_ensure_response() upgrades WP_HTTP_Response to WP_REST_Response.
An instance of `WP_HTTP_Response` doesn't ensure that the required methods used in `WP_REST_Server::dispatch()` exist, currently causing a fatal error.

Props ali11007, TimothyBlynJacobs, ocean90.
Fixes #49495.

git-svn-id: https://develop.svn.wordpress.org/trunk@47849 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-23 14:34:38 +00:00
Sergey Biryukov
772a11b72a Coding Standards: Use strict comparison for count() calls.
See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47848 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-23 11:36:36 +00:00
Jake Spurlock
a5baf8b9c6 Bundled Themes: Add missing RTL styles for to fix inconsistent margins on .alignwide and .alignfull items.
Fixes the inconsistent margins for alignwide and alignfull classes used on Cover Block when it is the first block on a page.

Props kthmd, utz119, nikhilbhansi, and sabernhardt.
Fixes #49435.


git-svn-id: https://develop.svn.wordpress.org/trunk@47846 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-23 06:21:37 +00:00
Sergey Biryukov
1ce6af5284 Coding Standards: Fix WPCS issues in wp-admin/plugin-editor.php and wp-admin/theme-editor.php.
See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47845 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-22 23:59:10 +00:00
Sergey Biryukov
a6cb663c13 Theme Editor: Remove unused $has_templates boolean.
The variable is a remnant from when the Theme Editor still had the "Templates" heading and is unused in the current logic.

The condition it was a part of would always evaluate to true for a child theme, regardless of the `$has_templates` value.

Props dboy1988.
Fixes #50199.

git-svn-id: https://develop.svn.wordpress.org/trunk@47844 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-22 23:18:47 +00:00
Jake Spurlock
3ab28fd579 REST API: Ensure proper namespacing when registering routes.
The PR will corerce routes that have a leading slash and throwing a `_doing_it_wrong` notice while ensuring a proper namespace.

Fixes #49749.
Props TimothyBlynJacobs, skarabeq, afercia.



git-svn-id: https://develop.svn.wordpress.org/trunk@47842 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-22 20:46:03 +00:00
Sergey Biryukov
3fe58b173f Coding Standards: Fix WPCS issues in wp-admin/includes/class-wp-site-health-auto-updates.php.
See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47841 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-22 17:54:50 +00:00
Sergey Biryukov
4d6ac487e7 Coding Standards: Fix WPCS issues in wp-admin/includes/class-wp-debug-data.php.
Follow-up to [47550], [47557], [47835].

See #50052.

git-svn-id: https://develop.svn.wordpress.org/trunk@47840 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-22 17:24:05 +00:00
Sergey Biryukov
174ead229d Customize: Move the WordPress logo with a white background to the wp-includes directory.
This ensures that the image used as a default site icon looks good on a dark background.

The image was previously changed in the `wp-admin` directory, but the site icon is now loaded from `wp-includes`.

Follow-up to [36635], [47018], [47564], [47832].

Props ocean90.
Fixes #49798.

git-svn-id: https://develop.svn.wordpress.org/trunk@47838 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-21 09:08:52 +00:00
Peter Wilson
09a6234ed3 KSES: Support the video element's playsinline attribute.
Allow users without the `unfiltered_html` capability to use the `playsinline` attribute when embedding videos.

Additionally this adds unit tests for passing the video element through kses.

Fixes #50167. See #29826.


git-svn-id: https://develop.svn.wordpress.org/trunk@47837 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-21 04:52:33 +00:00
Sergey Biryukov
e834dc8935 Docs: Add missing @since tag for auto_plugin_theme_update_email filter.
See #50052.

git-svn-id: https://develop.svn.wordpress.org/trunk@47836 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-20 19:31:50 +00:00
Jake Spurlock
eb79d7f1ee Security: Add user interface to auto-update themes and plugins.
Building on core update mechanisms, this adds the ability to enable automatic updates for themes and plugins to the WordPress admin. 

Fixes: #50052.
Props: afercia, afragen, audrasjb, azaozz, bookdude13, davidperonne, desrosj, gmays, gmays, javiercasares, karmatosed, knutsp, mapk, mukesh27, netweb, nicolaskulka, nielsdeblaauw, paaljoachim, passoniate, pbiron, pedromendonca, whodunitagency, whyisjake, wpamitkumar, and xkon.


git-svn-id: https://develop.svn.wordpress.org/trunk@47835 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-20 18:47:24 +00:00
Andrea Fercia
cdd8b92ea6 Accessibility: Media: Hide the invisible "file input" on media views from assistive technologies.
The file input button is visually hidden, but was announced by screen readers in workflows unrelated to file uploads.
It is now hidden from assistive technologies by the means of an `aria-hidden` attribute, as its CSS display property must not be changed to make sure it still works on old browsers.

See #49753.
Fixes #47611.


git-svn-id: https://develop.svn.wordpress.org/trunk@47834 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-20 13:31:32 +00:00
Sergey Biryukov
ea99b194dc Customize: Load the default site icon from the wp-includes directory.
Files inside the `wp-admin` directory may not be publicly available.

Follow-up to [36635], [47018].

Props whyisjake, finomeno, ocean90.
Fixes #50131.

git-svn-id: https://develop.svn.wordpress.org/trunk@47832 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-20 10:34:18 +00:00
Sergey Biryukov
78a308ea84 Coding Standards: Fix WPCS issues in wp-includes/class-wp-customize-manager.php.
Follow-up to [47819].

Props sorenbronsted.
See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47821 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-19 08:39:28 +00:00
Ian Belanger
930633096e Bundled Themes: Twenty Twenty inconsistent top and bottom margins for .alignwide and .alignfull on Chrome vs Safari.
Fixes the inconsistent margins for `alignwide` and `alignfull` classes used on Cover Block when it is the first block on a page.

Props kthmd, utz119, nikhilbhansi.
Fixes #49435.

git-svn-id: https://develop.svn.wordpress.org/trunk@47820 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-18 19:50:22 +00:00
Sergey Biryukov
a60b30444f Themes: Prevent installation of themes that require a higher version of PHP or WordPress.
Props afragen.
Fixes #49653. See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@47819 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-18 16:01:38 +00:00
Sergey Biryukov
581bc56b16 Themes: Remove extra whitespace from wp-admin/includes/ajax-actions.php and wp-admin/includes/theme.php.
Follow-up to [47816].

See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@47818 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-18 12:53:34 +00:00
Sergey Biryukov
cd7d648040 Themes: Remove debug call from wp-admin/theme-install.php.
Follow-up to [47816].

See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@47817 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-18 12:47:48 +00:00
Sergey Biryukov
b91e74d2f6 Themes: Prevent activation and live preview of themes that require a higher version of PHP or WordPress.
Props afragen, jorbin, TimothyBlynJacobs, SergeyBiryukov.
See #48491.

git-svn-id: https://develop.svn.wordpress.org/trunk@47816 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-18 12:30:04 +00:00
Sergey Biryukov
6ec559b2ba Site Health: Use WP_Theme::parent() in the inactive themes test as a more reliable check that the parent theme exists.
This is also more consistent with the other instances of directly referencing `WP_Theme::parent()` properties or methods in core.

Props mukesh27, juanlopez4691, davidbaumwald, afragen, SergeyBiryukov.
Fixes #49934.

git-svn-id: https://develop.svn.wordpress.org/trunk@47815 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-18 04:36:57 +00:00
Sergey Biryukov
5e43c07be4 Coding Standards: Fix WPCS issues in plugin and theme upgrader classes.
See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47814 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-17 09:37:12 +00:00
Sergey Biryukov
2a81a84e12 Accessibility: Login and Registration: Respect the prefers-reduced-motion media query for "shake" CSS animation on login failure.
This shake should not occur when the user has opted to reduce motion, for example by selecting the "Reduce motion" option in macOS' preferences or unselecting "Show animations in Windows" in Windows' preferences.

Follow-up to [47226].

Props eddystile, johnbillion, sabernhardt, afercia, audrasjb.
Fixes #49723.

git-svn-id: https://develop.svn.wordpress.org/trunk@47813 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-16 20:23:04 +00:00
Timothy Jacobs
c85005dec1 Coding Standards: Correct docblock indentation.
Fixes PHPCS failure introduced in r47811.


git-svn-id: https://develop.svn.wordpress.org/trunk@47812 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-16 19:54:20 +00:00
Timothy Jacobs
5405017564 REST API: Add @since entries for rest_validate_value_from_schema().
See #49572, #48818, #44949, #50053, #48820, #49720, #42961, #44975, #43392, #38583.


git-svn-id: https://develop.svn.wordpress.org/trunk@47811 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-16 19:31:48 +00:00
Timothy Jacobs
d8a063eabb REST API: Support the JSON Schema pattern keyword.
Props jason_the_adams, birgire, sorenbronsted.
Fixes #44949.


git-svn-id: https://develop.svn.wordpress.org/trunk@47810 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-16 19:01:49 +00:00
Timothy Jacobs
8b9823f536 REST API: Check required properties are provided when validating an object.
Previously, the WP_REST_Request object validated that top-level properties were defined, but this did not extend to those object's required properties. This adds validation to rest_validate_value_from_schema() directly.

Both the v3 and v4 JSON Schema syntax for required properties is supported.

Props sorenbronsted.
Fixes #48818.


git-svn-id: https://develop.svn.wordpress.org/trunk@47809 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-16 18:41:41 +00:00
Sergey Biryukov
6742d0d7a6 Coding Standards: Use strict comparison where static strings are involved.
This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47808 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-16 18:40:52 +00:00
Sergey Biryukov
36e4db6b01 Media: Expose media grid frame via wp-media-grid-ready trigger for easier customization.
Props soulseekah.
Fixes #50185.

git-svn-id: https://develop.svn.wordpress.org/trunk@47807 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-16 17:23:31 +00:00
Sergey Biryukov
26a527fa9f Coding Standards: Fix WPCS issues in wp-admin/includes/class-wp-screen.php.
See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47802 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-15 18:11:40 +00:00
Ian Belanger
7edaf9b3e3 Bundled Themes: Twenty Eleven & Twenty Twelve dropdown category widget exceeds parent div when strings are long enough.
Fixes the width of the category dropdown by limiting the width of `select` items in widgets using `max-width: 100%`.

Props gma992, karmatosed.
Fixes #37926.

git-svn-id: https://develop.svn.wordpress.org/trunk@47801 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-15 16:29:43 +00:00
Ian Belanger
9c3a5d30ab Bundled Themes: Twenty Twenty version bump.
We are releasing a new version of Twenty Twenty today thus we need to bump the version.

Props ianbelanger.
Fixes #50174.

git-svn-id: https://develop.svn.wordpress.org/trunk@47800 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-14 18:10:11 +00:00
Ian Belanger
7d94081279 Bundled Themes: Twenty Twenty custom post types that don't support authors, shows author box.
This fixes the issue where custom post types will show an author box, even if they don't support authors.

Props joyously, donmhico.
Fixes #48803.

git-svn-id: https://develop.svn.wordpress.org/trunk@47799 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-14 17:15:41 +00:00
Sergey Biryukov
25133cf3f1 Docs: Update Michael Heilemann's URL in a comment in wp-includes/theme-compat/footer.php.
Props ritterml, mukesh27.
Fixes #50171.

git-svn-id: https://develop.svn.wordpress.org/trunk@47798 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-14 15:31:34 +00:00
SergeyBiryukov
7fcb660015 Themes: Add "Block Editor Patterns" and "Full Site Editing" to the list of WordPress theme features.
Follow-up to [meta9876].

Props dingo_d.
Fixes #50164. See #meta5212.

git-svn-id: https://develop.svn.wordpress.org/trunk@47797 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-14 14:41:02 +00:00
Ian Belanger
3d68fda88f Bundled Themes: Twenty Twenty add GPLv2 compatible TikTok icon to the social icon menu.
This adds a GPLv2 compatible TikTok icon to replace the non-compatible TikTok icon and update the readme.txt file. Updates previous commit which used a non-compatible TikTok icon [47589]

Props poena, audrasjb, Emlebrun.
Fixes #49893.

git-svn-id: https://develop.svn.wordpress.org/trunk@47796 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-14 13:46:27 +00:00
Ian Belanger
c1f05c9a32 Bundled Themes: Twenty Twenty add icon for g.page links.
Adds the option to use a g.page url for the social menu.

Props argentite, mayankmajeji.
Fixes #49088.

git-svn-id: https://develop.svn.wordpress.org/trunk@47795 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-14 13:03:59 +00:00
Sergey Biryukov
783c936d68 Docs: Add @since notes for theme features added or removed in get_theme_feature_list() after its introduction in WordPress 3.1.
See #50165.

git-svn-id: https://develop.svn.wordpress.org/trunk@47794 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-14 12:49:00 +00:00
Sergey Biryukov
5adac72f47 Themes: Add "Block Editor Styles" and "Wide Blocks" to the list of WordPress theme features.
These were added to Theme Directory API in anticipation of being committed to core for WordPress 5.2+, which has not happened until now.

Follow-up to [meta8273].

See #46272.

git-svn-id: https://develop.svn.wordpress.org/trunk@47790 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-14 09:16:45 +00:00
Sergey Biryukov
d0d9c1465c Export: Use correct escaping function for term IDs in <wp:term> nodes.
Follow-up to [34333].

Props DrLightman, marcio-zebedeu.
Fixes #50113.

git-svn-id: https://develop.svn.wordpress.org/trunk@47789 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-14 07:53:57 +00:00
Sergey Biryukov
6e00150660 Coding Standards: Use strict comparison in wp-admin/upgrade.php.
Props mukesh27.
Fixes #50155.

git-svn-id: https://develop.svn.wordpress.org/trunk@47788 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-13 10:08:58 +00:00
Sergey Biryukov
6e8ab8448a Coding Standards: Correct db_version check in wp-admin/admin.php.
Follow-up to [47785].

See #49239.

git-svn-id: https://develop.svn.wordpress.org/trunk@47787 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-12 20:57:48 +00:00
Sergey Biryukov
b42fe1e654 Docs: Improve documentation for functions in wp-admin/install-helper.php per the documentation standards.
Synchronize descriptions with the functions' counterparts from `wp-admin/includes/upgrade.php`.

See #49572.

git-svn-id: https://develop.svn.wordpress.org/trunk@47786 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-12 18:38:02 +00:00
Sergey Biryukov
94d96bde71 Coding Standards: Use strict comparison in some wp-admin files.
Props pikamander2, mukesh27, SergeyBiryukov.
Fixes #49239.

git-svn-id: https://develop.svn.wordpress.org/trunk@47785 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-12 18:30:03 +00:00
Ian Belanger
afaab88e8e Bundled Themes: Twenty Twenty anchor links don't work in mobile menu.
Modifies the mobile modal menu javascript, so that anchor links will close the modal and scroll to the anchor within the page.

Props Giorgio25b, suzylah, yuhin, samful, bdcstr.
Fixes #48916.

git-svn-id: https://develop.svn.wordpress.org/trunk@47784 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-12 16:43:42 +00:00
Sergey Biryukov
eae306d5bf Docs: Add a note that the $protocols parameter of esc_url_raw() defaults to return value of wp_allowed_protocols().
This complements already existing note in `esc_url()`.

Props audrasjb.
Fixes #50147.

git-svn-id: https://develop.svn.wordpress.org/trunk@47783 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-11 20:32:06 +00:00
Sergey Biryukov
892e013bbf Docs: Use 3-digit, x.x.x style semantic versioning for inline comments in populate_options().
See #49572.

git-svn-id: https://develop.svn.wordpress.org/trunk@47782 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-11 17:24:24 +00:00
Sergey Biryukov
8e3b8c73d5 Coding Standards: Fix WPCS issues in wp-includes/update.php.
Props mukesh27.
Fixes #50130.

git-svn-id: https://develop.svn.wordpress.org/trunk@47778 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-09 12:50:43 +00:00
Sergey Biryukov
efb6e805da Administration: Avoid a PHP 7.4 notice in add_meta_box() when attempting to re-add a previously removed box.
The logic for skipping previously removed meta boxes with the `core` priority should also apply to the `sorted` priority that is used when the boxes were manually reordered.

Add a unit test.

Props coolmann, franzarmas, SergeyBiryukov.
Fixes #50019.

git-svn-id: https://develop.svn.wordpress.org/trunk@47777 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-09 12:24:31 +00:00
Ian Belanger
e6547ba815 Bundled Themes: Twenty Twenty customizer retina_logo should be hidden when no logo is set.
Modifies the Customize setting `Site Identity > Retina logo` so that the option is hidden if there is no logo is set in `Site Identity > Logo`.

Props truongwp.
Fixes #50109.

git-svn-id: https://develop.svn.wordpress.org/trunk@47776 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-08 19:34:14 +00:00
Sergey Biryukov
24b71985b8 Coding Standards: Fix WPCS issues in wp-admin/includes/template.php.
See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47775 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-08 16:34:50 +00:00
Sergey Biryukov
0d7244226f Coding Standards: Use strict comparison in wp-includes/widgets/class-wp-widget-rss.php.
Props mukesh27.
Fixes #50125.

git-svn-id: https://develop.svn.wordpress.org/trunk@47774 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-08 08:34:21 +00:00
Sergey Biryukov
09bcb48557 Site Health: Improve the appearance of administration email verification box.
Add `max-width` on desktop view and some padding on smaller screens.

Props chetan200891, azaozz, Clorith, afragen.
Fixes #48607.

git-svn-id: https://develop.svn.wordpress.org/trunk@47772 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-07 21:40:19 +00:00
Dominik Schilling
3d31284c5e Administration: Remove any CSS related to Internet Explorer versions 6 – 10.
In WordPress 3.2 support for IE6 was dropped, IE7 followed a few versions later. With the 4.8 release, WordPress officially ended support for Internet Explorer versions 8, 9, and 10. Yet, we still have shipped CSS for the unsupported IE versions....until now! Goodbye to ie.css and star hacks!

* Removes ie.css and `ie` style handle.
* Removes IE specific class names and any related CSS.
* Drops support for IE8 and older in `wp_customize_support_script()`.
* Updates compatibility mode for CSS minification to `ie11`.

Props ayeshrajans, isabel_brison, afercia, netweb, peterwilsoncc, ocean90.
Fixes #17232, #46015.

git-svn-id: https://develop.svn.wordpress.org/trunk@47771 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-06 20:13:38 +00:00
Sergey Biryukov
26439dd788 Menus: Add a Cancel link to the screen for creating a new menu.
The use case this helps the most is when there's only one menu and you click "create a new menu". In this case the Cancel link allows you to go back to the single existing menu.

Props garrett-eclipse, audrasjb.
Fixes #46367.

git-svn-id: https://develop.svn.wordpress.org/trunk@47770 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-06 19:33:45 +00:00
Sergey Biryukov
bb526f5087 Script Loader: Add the $group parameter to WP_Dependencies::do_item().
Previously, the method was called with two parameters in `::do_items()`, while the method signature only included one parameter.

Technically, this was not an issue as `WP_Dependencies::do_item()` is a placeholder meant to be overwritten when extending the class. When handling scripts, `WP_Dependencies` is extended with `WP_Scripts`, and the `$group` parameter was only used in `WP_Scripts::do_item()`, which does expect a second argument.

However, officially adding the parameter to `WP_Dependencies::do_item()` signature prevents code misunderstanding and avoids a warning in PHP code inspection tools.

Props kaggdesign, soulseekah, azaozz, SergeyBiryukov.
Fixes #43627.

git-svn-id: https://develop.svn.wordpress.org/trunk@47769 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-06 16:25:09 +00:00
Sergey Biryukov
97a336a03c Site Health: Do not trigger the fatal error handler while updates are being installed.
Triggering the error handler during updates may cause false positives. For example, updates may temporarily "fail" while files are moved around, but work fine once completed. Sending emails about temporary failures would just be confusing to the recipient.

Props Clorith, airamerica.
Fixes #48964.

git-svn-id: https://develop.svn.wordpress.org/trunk@47768 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-06 14:36:47 +00:00
Jake Spurlock
0a8365be5a Code standards: Drop a newline in the customizer to comply with WordPress Coding Standards
Extends [47763] and #46829.


git-svn-id: https://develop.svn.wordpress.org/trunk@47764 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-05 21:58:12 +00:00
Jake Spurlock
8338f44306 Menus: Denote the special pages in the Customizer menu editor.
The special pages here are the pages that are used for the Privacy Policy, Home, and the Posts page.

Fixes #46829.
Props garrett-eclipse, audrasjb.


git-svn-id: https://develop.svn.wordpress.org/trunk@47763 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-05 21:15:49 +00:00
Sergey Biryukov
b19c56b736 Site Health: Display the original PHP memory limit on Site Health Info screen.
This ensures that if the limit has been modified for admin screens by `wp_raise_memory_limit()`, the original value is displayed along with the current value.

Props Clorith, espiat, zodiac1978, SergeyBiryukov.
Fixes #49329.

git-svn-id: https://develop.svn.wordpress.org/trunk@47762 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-05 18:56:44 +00:00
Sergey Biryukov
0206900cff Canonical: Only redirect non-existing page requests to the post permalink if the post is found.
Follow-up to [47760].

See #45337, #40773, #28081, #11694.

git-svn-id: https://develop.svn.wordpress.org/trunk@47761 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-04 10:47:05 +00:00
Sergey Biryukov
de14ea86bf Canonical: Redirect paged requests for a static page assigned as the "Posts page".
This avoids displaying duplicate content of the home page under different URLs with appended page numbers.

This change only affects the `<!--nextpage-->` pagination (`page` query variable) and not the regular multiple posts pagination (`paged` query variable).

The posts page does not support the `<!--nextpage-->` pagination, so requests for invalid page numbers should be redirected to the page permalink, applying the logic previously implemented for single posts or pages.

Follow-up to [34492], [47727].

Props jeremyfelt, sachit.tandukar, SergeyBiryukov.
Fixes #45337. See #40773, #28081, #11694.

git-svn-id: https://develop.svn.wordpress.org/trunk@47760 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-04 10:40:06 +00:00
Sergey Biryukov
54c8470bd6 Coding Standards: Fix WPCS issues in wp-includes/canonical.php.
Reformat long conditions and dense code blocks for better readability.

See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47759 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-04 09:03:11 +00:00
Timothy Jacobs
8153d15f09 REST API: Support more JSON Schemas when filtering a response by context.
The array type, multi-types, and the additional properties keyword are now supported. Additionally, the filter recurses to an infinite depth.

Fixes #48819.


git-svn-id: https://develop.svn.wordpress.org/trunk@47758 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-04 02:44:44 +00:00
Timothy Jacobs
5460e0df1e REST API: Accept POST requests in the block renderer endpoint.
Rendering a block is idempotent, so a GET is the most natural request method. However, the maximum length of URLs prevented blocks with large attributes from being rendered.

Props ryankienstra.
Fixes #49680.


git-svn-id: https://develop.svn.wordpress.org/trunk@47756 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-03 22:56:01 +00:00
Timothy Jacobs
6ab90a209d REST API: Validate that the oembed url parameter is a string.
This prevents a PHP warning from being issued by esc_url_raw when a non-string value is provided.

Props dd32.
Fixes #49991.


git-svn-id: https://develop.svn.wordpress.org/trunk@47755 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-03 22:40:53 +00:00
John Blackbourn
7d24075a26 Docs: Misc docblock corrections and improvements.
See #49572

git-svn-id: https://develop.svn.wordpress.org/trunk@47754 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-03 19:36:06 +00:00
Timothy Jacobs
ef05acdfaa REST API: Support the uuid JSON Schema format.
This accepts a uuid of any version. A future commit could add support for restricting uuids to a specific version.

Props johnwatkins0.
Fixes #50053.


git-svn-id: https://develop.svn.wordpress.org/trunk@47753 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-03 19:18:40 +00:00
Andrea Fercia
6e181e8823 File Editor: Remove CSS exceptions for the "Select plugin/theme to edit" and documentation "Look Up" buttons.
Buttons should use the default buttons styles, no exceptions.

Props passoniate, garethgillman.
See #49197.
Fixes #49353.


git-svn-id: https://develop.svn.wordpress.org/trunk@47751 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-03 14:19:51 +00:00
Andrea Fercia
8f1d4525c2 Upload: Improve file input and button alignment in plugin/theme upload form.
Resets flexbox on smaller screens. Improves vertical alignment on large screens.
Follow-up to [47599] and [47271].

Props mukesh27, DarkoG.
See #48859, #49914.
Fixes #49951.


git-svn-id: https://develop.svn.wordpress.org/trunk@47750 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-03 13:34:26 +00:00
Sergey Biryukov
5dbed96333 Docs: Further update inline documentation for the wpdb class per the documentation standards.
Restore some previous edits from [46696], [47060], [47122], [47230] that were accidentally reverted in [47740].

See #49572.

git-svn-id: https://develop.svn.wordpress.org/trunk@47749 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-03 11:43:14 +00:00
John Blackbourn
84772cc608 Media: Ensure a consistent structure for the array returned by wp_get_attachment_image_src().
The array returned by this function previously included a fourth element only when an intermediate image size was used. This change ensures a consistent structure in the returned array regardless of the function's internal behaviour.

Props wido, joemcgill, johnbillion

Fixes #46113

git-svn-id: https://develop.svn.wordpress.org/trunk@47748 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-02 22:55:17 +00:00
John Blackbourn
4889e7a8d2 Menus: Allow empty taxonomy terms to be surfaced when searching for items.
This brings the behaviour inline with that of browsing terms or using the All Items tab, which correctly shows empty terms.

Props birgire, audrasjb

Fixes #45298

git-svn-id: https://develop.svn.wordpress.org/trunk@47747 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-02 22:34:50 +00:00
John Blackbourn
1510f69d69 Upgrade/Install: Unlink the logo on the installation and config setup screens.
This allows for a natural tab order during installation, without negatively impacting users who use the keyboard for navigation, those who use a screen reader, or those who use neither.

Props lwill, afercia, audrasjb.

Fixes #47759

git-svn-id: https://develop.svn.wordpress.org/trunk@47746 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-02 21:44:48 +00:00
John Blackbourn
8eab1eb9a9 Administration: Reduce the chance that a PHP error message that occurs before the admin menu gets output is covered by the admin menu.
Props EmpireOfLight, afercia, Mte90, audrasjb, sunnyratilal

Fixes #35155

git-svn-id: https://develop.svn.wordpress.org/trunk@47745 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-02 20:59:31 +00:00
John Blackbourn
c570d4409f Docs: Update inline documentation for the wpdb class.
Props theMikeD

Fixes #49477

git-svn-id: https://develop.svn.wordpress.org/trunk@47740 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-02 17:23:28 +00:00
Dominik Schilling
c09e2d21a7 Users: Don't reset user language preference on user update.
Props johnbillion.
Fixes #38665.

git-svn-id: https://develop.svn.wordpress.org/trunk@47739 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-02 16:27:34 +00:00
Sergey Biryukov
b7a8094d32 Query: Simplify the logic in WP::handle_404() to allow for easier modifications.
See #45337.

git-svn-id: https://develop.svn.wordpress.org/trunk@47738 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-02 08:46:39 +00:00
Jonathan Desrosiers
7e0a63f8c5 General: More PHP compatibility adjustments.
In this round:
- Removed references to `safe_mode` in `class-php3.php`. This was removed in PHP 5.4.
- Add inline exclude comments for compatibility checks in getID3.

Follow up of [47735-47736].

See #49922.

git-svn-id: https://develop.svn.wordpress.org/trunk@47737 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-01 20:10:58 +00:00
Jonathan Desrosiers
627b93f54d General: Fix typo within phpcs:ignore inline comment.
Follow up of [47735].

See #49922.

git-svn-id: https://develop.svn.wordpress.org/trunk@47736 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-01 19:34:05 +00:00
Jonathan Desrosiers
8e2de8212b General: Fix various issues flagged by the PHPCompatibilityWP PHPCS ruleset.
As part of the continued effort to improve PHP compatibility, the following improvments are being made:

- Removing deprecated PHP `safe_mode` checks not found in bundled external libraries.
- Change the remaining `while` loops using `each()` to `foreach` loops.
- Prevent false positives from being flagged for the `sodium_compat` library being caused by loading this in a non-standard way.
- Add inline comments to not flag deprecated PHP directives in the getID3 library.

Props desrosj, earnjam, dryanpress.
See #49922.

git-svn-id: https://develop.svn.wordpress.org/trunk@47735 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-01 19:05:04 +00:00
Sergey Biryukov
05423578d7 Taxonomy: Restore (un-deprecate) the tag_row_actions filter.
The filter provides a simple way for plugin authors to add actions generically for all taxonomy list tables without looping through each taxonomy individually.

Props joemcgill, delowardev.
Fixes #49808.

git-svn-id: https://develop.svn.wordpress.org/trunk@47734 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-01 16:43:46 +00:00
Jonathan Desrosiers
d12ad5050b External Libraries: Update the SimplePie library to the latest version (1.5.5).
This brings SimplePie in sync with the most up to date version, 1.5.5.

This update brings many bug fixes, small enhancements, and PHP compatibility fixes for newer versions of PHP.

For a full list of changes, see https://github.com/simplepie/simplepie/blob/master/CHANGELOG.md#155-may-1-2020.

Props dshanske, slushman, etruel, wpshades, dmenard, desrosj, hareesh-pillai, stevenkword, jrf, Ipstenu, johnbillion.
Fixes #36669.

git-svn-id: https://develop.svn.wordpress.org/trunk@47733 602fd350-edb4-49c9-b593-d223f7449a82
2020-05-01 14:24:42 +00:00
Sergey Biryukov
af596bcc5b Canonical: Redirect paged requests for non-paginated posts to the post permalink.
This avoids displaying duplicate content of the same post under different URLs and ensures the canonical URL is correct.

Previously, requests for invalid page numbers were only redirected to the post permalink if the post was actually paginated using the `<!--nextpage-->` marker.

Follow-up to [34492].

Props jeremyfelt, prografika, sachit.tandukar, subrataemfluence, hronak, ekatherine, henry.wright, chesio, dd32, SergeyBiryukov.
Fixes #40773. See #45337, #28081, #11694.

git-svn-id: https://develop.svn.wordpress.org/trunk@47727 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-30 12:03:11 +00:00
Sergey Biryukov
be8b8baec9 Help/About: Revert [47699] from trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@47706 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 18:41:12 +00:00
whyisjake
d27a3718d5 Update the about page for WordPress 5.4.1
git-svn-id: https://develop.svn.wordpress.org/trunk@47699 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 18:35:02 +00:00
Ian Belanger
8ba39ba9f6 Bundled Themes: Twenty Twenty image caption is not aligned center when image is, on the front-end.
Fixes the image caption alignment issue by adding `text-align: center;` to `.wp-block-image .aligncenter figcaption`.

Props markusthiel, SergeyBiryukov, garethgillman.
Fixes #49320.

git-svn-id: https://develop.svn.wordpress.org/trunk@47689 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 18:17:11 +00:00
Sergey Biryukov
514f7c4cc9 Docs: Correct @since versions, remove duplicate comment.
Follow-up to [47633].

git-svn-id: https://develop.svn.wordpress.org/trunk@47663 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 17:23:21 +00:00
Jake Spurlock
74d6f9613b Formatting: Expand sanitize_file_name to have better support for utf8 characters.
Props: xknown, peterwilsoncc.


git-svn-id: https://develop.svn.wordpress.org/trunk@47638 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 15:38:43 +00:00
Jake Spurlock
935ab39e8e Cache API: Ensure proper escaping around the stats method in the cache API.
Props: nickdaugherty, batmoo, whyisjake, westi.


git-svn-id: https://develop.svn.wordpress.org/trunk@47637 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 15:34:55 +00:00
Jake Spurlock
ec05c8b897 Block Editor: Coding standards, properly escape class names.
Props: aduth, noisysocks, pento, talldanwp, jorgefilipecosta, whyisjake, ellatrix, ehti.


git-svn-id: https://develop.svn.wordpress.org/trunk@47636 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 15:32:19 +00:00
Jake Spurlock
8e11facb67 Query: Ensure that only a single post can be returned on date/time based queries.
Props: sstoqnov, peterwilsoncc.


git-svn-id: https://develop.svn.wordpress.org/trunk@47635 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 15:26:56 +00:00
Jake Spurlock
4354d1fc5c User: Invalidate user_activation_key on password update.
Props: sstoqnov, sergeybiryukov.



git-svn-id: https://develop.svn.wordpress.org/trunk@47634 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 15:23:37 +00:00
Jake Spurlock
cfb690cb8e Customize: Add additional filters to Customizer to prevent JSON corruption.
This solution extends the wp_insert_post_data filter to pass in addition to the slashed/sanitized/processed data, and the slashed/sanitized/unprocessed data, to also pass the initial slashed/unsanitized/unprocessed data which was passed into wp_insert_post(). This then allows plugins to have complete control over how sanitization is performed based on the post type.

Props westonruter, peterwilsoncc, sstoqnov, whyisjake, xknown.
 


git-svn-id: https://develop.svn.wordpress.org/trunk@47633 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 15:12:50 +00:00
Sergey Biryukov
833ce3b15b Networks and Sites: Link to Nginx documentation on Network Setup screen when Nginx is in use.
Props lipathor, audrasjb, johnbillion, flixos90.
Fixes #41166.

git-svn-id: https://develop.svn.wordpress.org/trunk@47632 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-29 14:41:42 +00:00
Sergey Biryukov
3d932981e2 Docs: Correct @return type for WP_Theme::get_post_templates().
The method returns an array of strings, not a single string.

Props mayankmajeji, salvatore.formisano.
Fixes #50020.

git-svn-id: https://develop.svn.wordpress.org/trunk@47631 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-28 15:00:30 +00:00
Sergey Biryukov
e46d1cfc84 Site Health: Avoid a PHP notice in WP_Site_Health::wp_cron_scheduled_check() if async test response does not contain the expected result.
Additionally, avoid a PHP notice in `::get_test_php_version()` if the minimum recommended version of PHP could not be determined.

Props schlessera, oakesjosh.
Fixes #49943.

git-svn-id: https://develop.svn.wordpress.org/trunk@47628 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-27 21:59:10 +00:00
Timothy Jacobs
86cbde382a REST API: Support the (min|max)Length JSON Schema keywords.
Props sorenbronsted.
Fixes #48820.


git-svn-id: https://develop.svn.wordpress.org/trunk@47627 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-27 02:27:02 +00:00
Sergey Biryukov
3a229d0b47 Comments: Ensure that inserting a comment with an empty type results in correct comment type.
Add unit tests for `wp_handle_comment_submission()` and `wp_insert_comment()` receiving an empty type.

Follow-up to [47597].

Props ocean90, imath.
Fixes #49236.

git-svn-id: https://develop.svn.wordpress.org/trunk@47626 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-26 13:42:03 +00:00
Sergey Biryukov
aff2844d75 Comments: Restore inclusion of an empty comment type when building the WHERE clause in WP_Comment_Query::get_comment_ids().
This ensures that `get_comments( array( 'type' => 'comment' ) )` still includes comments that have not yet migrated to the `comment` type.

Follow-up to [47597].

Props ocean90.
See #49236.

git-svn-id: https://develop.svn.wordpress.org/trunk@47625 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-26 13:12:04 +00:00
Sergey Biryukov
c117fbe0cf Upgrade/Install: Introduce wp_in_maintenance_mode(), a helper function to check if WordPress is currently in maintenance mode.
Props Clorith.
Fixes #49959.

git-svn-id: https://develop.svn.wordpress.org/trunk@47623 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-25 20:18:00 +00:00
Sergey Biryukov
59433bb306 Administration: Remove right padding on form tables on smaller screens so that the spacing is equal on both sides.
Additionally, reduce the right margin on screen meta links (Help and Screen Options) to align with the tables.

Props jainnidhi, garrett-eclipse, ibdz, SergeyBiryukov.
Fixes #43279.

git-svn-id: https://develop.svn.wordpress.org/trunk@47622 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-25 12:25:54 +00:00
Ian Belanger
c629ae3180 Bundled Themes: Twenty Twenty remove unnecessary $css_dependencies variable in twentytwenty_block_editor_styles().
Removes the unnecessary `$css_dependencies` variable in `twentytwenty_block_editor_styles()`.

Props ocean90, Dency.
Fixes #49986.

git-svn-id: https://develop.svn.wordpress.org/trunk@47618 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-24 14:57:07 +00:00
Sergey Biryukov
055d1c6749 Code Modernization: Remove error suppression from parse_url() calls.
Previously, the `@` operator was used to prevent possible warnings emitted by `parse_url()` in PHP < 5.3.3 when URL parsing failed.

Now that the minimum version of PHP required by WordPress is 5.6.20, this is no longer needed.

Props netpassprodsr, Howdy_McGee.
Fixes #49980. See #24780.

git-svn-id: https://develop.svn.wordpress.org/trunk@47617 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-24 07:26:57 +00:00
Sergey Biryukov
d756c57432 Networks and Sites: Don't display an empty Menu Settings section in network admin if there are no items.
This accounts for returning an empty array from the `mu_menu_items` filter.

Props dlh.
Fixes #49977.

git-svn-id: https://develop.svn.wordpress.org/trunk@47616 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-23 18:56:40 +00:00
Ian Belanger
e3a8f680d4 Bundled Themes: Twenty Twenty button styles produce inconsistent output and cannot be edited.
Fixes the issue with button styles not working when the Gutenberg plugin is activated while maintaining backwards compatibility.

Props nrqsnchz, poena, kjellr.
Fixes #49896.

git-svn-id: https://develop.svn.wordpress.org/trunk@47614 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-23 15:39:55 +00:00
Ian Belanger
c1bb2c2f74 Bundled Themes: Twenty Twenty resized images are centered inside the editor (with no alignment set) since WordPress 5.4.
Fixes the image alignment issue by removing `margin-left: auto;` and `margin-right: auto;` from `.editor-styles-wrapper .wp-block-image.is-resized`.

Props dianeco, JavierCasares.
Fixes #49600.

git-svn-id: https://develop.svn.wordpress.org/trunk@47613 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-22 19:23:54 +00:00
Jonathan Desrosiers
2b5b39931c Bootstrap/Load: Deprecate wp_unregister_GLOBALS().
The `register_globals` directive in PHP was deprecated in version 5.3 and removed entirely in 5.4.

Now that WordPress only supports PHP 5.6.20 and newer, the `wp_unregister_GLOBALS()` function can be deprecated.

Props ayeshrajans, desrosj, SergeyBiryukov.
Fixes #49938.

git-svn-id: https://develop.svn.wordpress.org/trunk@47612 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-22 15:40:41 +00:00
Sergey Biryukov
3659b767f1 Docs: Synchronize parameter documentation for various metadata functions, update per the documentation standards.
See #49572.

git-svn-id: https://develop.svn.wordpress.org/trunk@47611 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-22 10:29:34 +00:00
Sergey Biryukov
b6391847b4 Docs: Document the default value of $single and $prev_value parameters in various metadata functions.
Props denisco.
See #49572.

git-svn-id: https://develop.svn.wordpress.org/trunk@47610 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-22 09:38:12 +00:00
Ian Belanger
7016ad5a78 Bundled Themes: Twenty Twenty submenu items disappear underneath the Cover block.
Fixes the submenu issue by raising the z-index value of the site-header from 1 to 2.

Props kjellr, JavierCasares.
Fixes #49322.

git-svn-id: https://develop.svn.wordpress.org/trunk@47609 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-21 20:04:29 +00:00
Ian Belanger
134092ae54 Bundled Themes: Twenty Twenty missed license for images.
Fixes the image license in the readme by removing screenshot.png.

Props h71, poena.
Fixes #49316.

git-svn-id: https://develop.svn.wordpress.org/trunk@47608 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-21 19:41:26 +00:00
Ian Belanger
e658596ff6 Bundled Themes: Twenty Twenty block editor inserter is missing the +.
Fixes the disappearing `+` in the block editor when using the latest version of the Gutenberg plugin, by adding support for the native Gutenberg editor styles and removing `color: inherit;` from Twenty Twenty's style.css.

Props nrqsnchz, .
Fixes #49610.

git-svn-id: https://develop.svn.wordpress.org/trunk@47607 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-21 19:15:20 +00:00
Sergey Biryukov
5763451b44 Networks and Sites: Display the Site Address field on Add Site screen in left-to-right text direction.
Props ramiy.
Fixes #49949.

git-svn-id: https://develop.svn.wordpress.org/trunk@47606 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-21 11:24:15 +00:00
Sergey Biryukov
60b23a5cd0 Menus: Remove unused commented out code in wp-admin/nav-menus.php.
Props garrett-eclipse, audrasjb.
Fixes #49967.

git-svn-id: https://develop.svn.wordpress.org/trunk@47605 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-21 09:00:30 +00:00
Sergey Biryukov
2e126bda26 External Libraries: Revert [47603].
With the Docker image for PHP 7.4 updated to stable version, this should no longer be necessary.

See https://github.com/WordPress/wpdev-docker-images/pull/26

Props ocean90.
Fixes #49945.

git-svn-id: https://develop.svn.wordpress.org/trunk@47604 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-20 15:39:40 +00:00
Sergey Biryukov
a7624a3c43 External Libraries: Comment out magic quote functions in getID3().
For some reason, the `version_compare()` check does not work as expected on Travis.

Follow-up to [46113], [47601].

See #49945.

git-svn-id: https://develop.svn.wordpress.org/trunk@47603 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-20 12:10:49 +00:00
Sergey Biryukov
5f03485bc7 External Libraries: Backport a commit from getID3() trunk to fix a PHP 7.4+ notice.
This addresses a "Trying to access array offset on value of type bool" notice in the `getid3_mp3::MPEGaudioHeaderValid()` method.

Props schlessera.
Fixes #49945.

git-svn-id: https://develop.svn.wordpress.org/trunk@47602 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-20 11:32:37 +00:00
Sergey Biryukov
02e17123f9 External Libraries: Update getID3() to 1.9.19.
Changelog: https://github.com/JamesHeinrich/getID3/compare/v1.9.18...v1.9.19

Props ayeshrajans, schlessera.
See #49945.

git-svn-id: https://develop.svn.wordpress.org/trunk@47601 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-20 11:11:48 +00:00
Sergey Biryukov
5d5e3439e4 Users: Change "Your Profile" and "My Profile" links in admin menu and toolbar to just "Profile" for consistency.
Props donmhico, bcworkz, seanchayes, mikeschroder, garrett-eclipse, akhileshsabharwal, ScottSmith, nacin, jenmylo, afercia, swissspidy, felix-edelmann, helen, melchoyce, karmatosed.
Fixes #26769.

git-svn-id: https://develop.svn.wordpress.org/trunk@47600 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-20 08:37:31 +00:00
Sergey Biryukov
b562537d98 Upload: Better align file input and buttons in plugin/theme upload form.
Follow-up to [47271].

Props seedsca, piyushmca.
Fixes #49914.

git-svn-id: https://develop.svn.wordpress.org/trunk@47599 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-19 09:45:33 +00:00
Sergey Biryukov
d2deb5eba3 Accessibility: Widgets: Prevent checkboxes in widget control forms from overlapping on smaller screens.
Props jaz_on, milindmore22, passoniate, audrasjb, carriganvb, afercia, SergeyBiryukov.
Fixes #49228.

git-svn-id: https://develop.svn.wordpress.org/trunk@47598 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-18 07:01:58 +00:00
Sergey Biryukov
d5a7a3a45d Comments: Use comment instead of an empty string for the comment_type DB field value in comments table.
This is the first step to bring support for custom comment types into WordPress.

Add a scheduled upgrade routine to update the type value for existing comments, in batches of 100 at a time.

Props imath, aaroncampbell, jeremyfelt, dshanske.
Fixes #49236.

git-svn-id: https://develop.svn.wordpress.org/trunk@47597 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-17 19:33:52 +00:00
Sergey Biryukov
02e7fc0c7e Coding Standards: Fix WPCS indentation issue in wp-admin/nav-menus.php.
This was causing a `PEAR.Functions.FunctionCallSignature.Indent` error if PHP_CodeSniffer 3.5.3 or newer is installed locally, despite the task passing on Travis.

See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47596 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-17 18:53:33 +00:00
Sergey Biryukov
19ca20fbe2 Coding Standards: Fix WPCS indentation issue in wp-admin/includes/class-wp-links-list-table.php.
This was causing a `Generic.WhiteSpace.ScopeIndent.IncorrectExact` error if PHP_CodeSniffer 3.4.1 or newer is installed locally, despite the task passing on Travis.

See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47595 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-17 18:29:06 +00:00
Ian Belanger
c1aea8fd8a Bundled Themes: Twenty Twenty fix typo in readme.txt.
Fixed TikTok was misspelled as Tik Tok in the readme.txt.

Props Asif2BD.
Fixes #49932.

git-svn-id: https://develop.svn.wordpress.org/trunk@47594 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-17 15:45:56 +00:00
Sergey Biryukov
bee5595311 Coding Standards: Format the markup of widget forms in a more consistent manner.
See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47593 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-17 09:36:25 +00:00
Sergey Biryukov
c9ba1876e1 Administration: Remove the smiley from overly happy "No activity yet!" message on Dashboard.
Props francoist, karmatosed, ibdz, estelaris, nrqsnchz, Presskopp.
Fixes #48387.

git-svn-id: https://develop.svn.wordpress.org/trunk@47592 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-17 07:55:33 +00:00
Ian Belanger
2370457175 Bundled Themes: Twenty Nineteen center and right-aligned heading accents appear broken.
Fixes the center and right aligned heading accents so that they align with the text, instead of just staying left-aligned.

Props kjellr, melchoyce.
Fixes #49699.

git-svn-id: https://develop.svn.wordpress.org/trunk@47591 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-16 19:45:19 +00:00
Ian Belanger
3d762adf5c Bundled Themes: Twenty Twenty inline images in list blocks are not positioned correctly.
Fixes the alignment of inline images in list blocks to match the way they look in the editor.

Props poena, mayankmajeji, JavierCasares.
Fixes #49793.

git-svn-id: https://develop.svn.wordpress.org/trunk@47590 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-16 19:36:03 +00:00
Ian Belanger
76dc390352 Bundled Themes: Twenty Twenty add TikTok to the social icon menu.
This adds TikTok as an option in the social icon menu.

Props mislavjuric, poena, audrasjb.
Fixes #49893.

git-svn-id: https://develop.svn.wordpress.org/trunk@47589 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-16 19:00:01 +00:00
Sergey Biryukov
9f5d9a932d Plugins: Add HTML ID attributes to plugin action links for easier targeting in browser-based testing.
Props roytanck, shooper.
Fixes #49916.

git-svn-id: https://develop.svn.wordpress.org/trunk@47588 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-16 17:00:58 +00:00
Ian Belanger
07bc94cc11 Bundled Themes: Twenty Nineteen editor style interferes with navigation menu block.
Update editor styles to prepare for changes coming to the editor in 5.5. Currently the issue is only present when using the latest version of the Gutenberg plugin.

Props kjellr, Joen.
Fixes #49613.

git-svn-id: https://develop.svn.wordpress.org/trunk@47587 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-16 14:54:37 +00:00
Ian Belanger
7b6e7babe4 Bundled Themes: Twenty Nineteen decrease the font size for widget titles.
Update styles to decrease the font size for widget titles.

Props kjellr, mukesh27.
Fixes #45865.

git-svn-id: https://develop.svn.wordpress.org/trunk@47586 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-16 14:36:20 +00:00
Sergey Biryukov
cb29ca927c Site Health: Detect an active PHP session as a possible reason for HTTP requests timing out.
PHP sessions created by a `session_start()` function call may interfere with REST API and loopback requests.

An active session should be closed by `session_write_close()` before making any HTTP requests.

Props matthieumota, netweblogic, Clorith, afragen, vjik, SergeyBiryukov.
Fixes #47320.

git-svn-id: https://develop.svn.wordpress.org/trunk@47585 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-16 08:18:49 +00:00
Sergey Biryukov
90b0f49b1a Code Modernization: Remove conditional use of stream_get_contents() PHP function.
The function was introduced in PHP 5.0.0. Now that the minimum version of PHP required by WordPress is 5.6.20, these conditions are no longer needed.

Props jrf.
Fixes #48091.

git-svn-id: https://develop.svn.wordpress.org/trunk@47584 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-15 11:52:38 +00:00
Sergey Biryukov
72f54ba785 Comments: Clarify that "Comment Moderation" and "Comment Blocklist" options in Discussion Settings also apply to browser's user agent string for submitted comments.
Props zodiac1978.
Fixes #49902.

git-svn-id: https://develop.svn.wordpress.org/trunk@47583 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-15 06:38:03 +00:00
Dominik Schilling
165bcc506d Posts, Post Types: Pass the post object to the before_delete_post, delete_post, deleted_post, and after_delete_post actions.
Props jadpm.
Fixes #30940.

git-svn-id: https://develop.svn.wordpress.org/trunk@47582 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-14 19:24:49 +00:00
Sergey Biryukov
7ef97cfb10 Mail: Make the check for empty post title in wp-mail.php more resilient.
This addresses a regression in [47054], which caused posts sent via email to published with an empty title.

Props whyisjake, Otto42, MarkRH, MattyRob, mukesh27, afragen, pikamander2.
Fixes #49853.

git-svn-id: https://develop.svn.wordpress.org/trunk@47580 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-14 11:30:35 +00:00
Sergey Biryukov
4d601e57b6 Docs: Add a @since note for un-deprecated category_link and tag_link filters.
Follow-up to [47576].

See #49759.

git-svn-id: https://develop.svn.wordpress.org/trunk@47578 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-14 08:13:18 +00:00
Jake Spurlock
7d4a746f27 Taxonomy: Un-depracate category_link and tag_link filters.
Depracating these filter might have been an accident, so let's restore.

Props SergeyBiryukov, audrasjb, peterwilsoncc.
Fixes #49759. 


git-svn-id: https://develop.svn.wordpress.org/trunk@47576 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-14 00:31:18 +00:00
Sergey Biryukov
d419b1b6d6 Plugins: Simplify the logic of validate_plugin_requirements(), update documentation.
This updates the function for consistency with `validate_theme_requirements()`.

Follow-up to [44978], [45546], [47573].

Fixes #43992.

git-svn-id: https://develop.svn.wordpress.org/trunk@47574 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-13 15:29:17 +00:00
Sergey Biryukov
286d672389 Themes: Block theme activation if it requires a higher version of PHP or WordPress.
Introduce `validate_theme_requirements()` for validating a theme's WordPress and PHP version requirements.

Follow-up to [44978] and [45546] for plugins.

Props afragen, audrasjb, SergeyBiryukov.
See #43992.

git-svn-id: https://develop.svn.wordpress.org/trunk@47573 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-13 15:26:37 +00:00
Sergey Biryukov
d5df031e6f Privacy: Add an indication when the Copy action in Privacy Policy Guide is complete.
This adds a "Copied!" text near the "Copy this section to clipboard" button to provide direct feedback that the action was completed.

Props garrett-eclipse, nickylimjj, xkon, desrosj, birgire.
Fixes #44588.

git-svn-id: https://develop.svn.wordpress.org/trunk@47572 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-12 14:24:38 +00:00
Sergey Biryukov
63ac227863 Rewrite Rules: Use double quotes instead of backticks in .htaccess instructions about # BEGIN/END markers.
Previously, the backticks resulted in extra markup being added when posted on support forums.

Props mayankmajeji, knutsp.
Fixes #49868.

git-svn-id: https://develop.svn.wordpress.org/trunk@47571 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-11 15:07:27 +00:00
Sergey Biryukov
eca3d5a2f3 Docs: Fix typo in WP_Upgrader::__construct() DocBlock.
Props mattrad.
Fixes #49856.

git-svn-id: https://develop.svn.wordpress.org/trunk@47570 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-10 09:46:21 +00:00
Jake Spurlock
3a2e24bab4 Site Health instantiation prevents use of some hooks by plugins.
As the WP_Site_Health class is instantiated prior to plugins being required and the `plugins_loaded` hook being fired, it prevents plugins from using the following hooks in the functions called by `maybe_create_scheduled_event()`.

Fixes #49824.
Props peterwilsoncc, whyisjake.



git-svn-id: https://develop.svn.wordpress.org/trunk@47568 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-10 03:55:08 +00:00
Jake Spurlock
8e016efcad Customize: Give the WordPress logo a white background for dark mode browsers.
The favicon is transparent, which would normally look fine, but on a dark background it washes out.

Props DhrRob, audrasjb.
Fixes 49798.


git-svn-id: https://develop.svn.wordpress.org/trunk@47564 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-10 02:48:51 +00:00
Jake Spurlock
6d586d4287 Privacy: Support additional elements (table, ol, ul) in privacy policy guide new styling
The privacy policy guide supports a lot of HTML, include rules for lists, and ensure proper styling for the rest.

Props garrett-eclipse. 
Fixes #49772.


git-svn-id: https://develop.svn.wordpress.org/trunk@47560 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-09 22:32:43 +00:00
K. Adam White
3abe80eea1 REST API: Handle parameter types consistently within set_param().
A request has multiple parameter types, including "query" and "json." Updating a parameter could previously modify a key's value in the wrong parameter type, leading to confusing and self-contradictory response objects.

Props mnelson4, TimothyBlynJacobs, vagios, jnylen0.
Fixes #40838.


git-svn-id: https://develop.svn.wordpress.org/trunk@47559 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-09 19:28:58 +00:00
Andrea Fercia
e4b83cf509 Accessibility: Fix the headings hierarchy on the Freedoms page.
Props ryelle, afercia.
Fixes #49838.


git-svn-id: https://develop.svn.wordpress.org/trunk@47558 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-09 16:07:19 +00:00
Sergey Biryukov
d8c502e966 Coding Standards: Use strict type check for in_array() and array_search().
This addresses all the remaining `WordPress.PHP.StrictInArray.MissingTrueStrict` issues in core.

Includes minor code layout fixes for better readability.

Follow-up to [47550].

See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47557 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-09 15:41:04 +00:00
Sergey Biryukov
adda585fb8 Privacy: Make the deprecated wp_get_user_request_data() function available on front end.
Previously, it was accidentally made available only in admin context.

Follow-up to [44606], [47245].

Props garrett-eclipse, johnjamesjacoby, r-a-y, Dono12.
Fixes #49802.

git-svn-id: https://develop.svn.wordpress.org/trunk@47555 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-08 18:31:21 +00:00
Andrew Ozz
7b5d78f82f Media: Enable lazy-loading of images by automatically adding the new loading="lazy" attribute to image tags on the front-end.
- Introduces `wp_lazy_loading_enabled()`, `wp_filter_content_tags()`, `wp_img_tag_add_loading_attr()`, and `wp_img_tag_add_srcset_and_sizes_attr()` functions.
- Introduces `wp_lazy_loading_enabled`, `wp_img_tag_add_loading_attr`, and `wp_img_tag_add_srcset_and_sizes_attr` filters.

Props flixos90, addyosmani, mor10, swissspidy, pierlo, westonruter, spacedmonkey, mikeschroder, jonoaldersonwp, peterwilsoncc, narwen, jeffpaul, OptimizingMatters, futtta, mukeshpanchal27, azaozz.

Fixes #44427.

git-svn-id: https://develop.svn.wordpress.org/trunk@47554 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-08 00:53:18 +00:00
Sergey Biryukov
4b79e69d89 Users: Pass the ID of the user that was logged out to the wp_logout action.
Props donmhico, figureone, TimothyBlynJacobs, rebasaurus.
Fixes #49533.

git-svn-id: https://develop.svn.wordpress.org/trunk@47553 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-07 16:12:22 +00:00
Sergey Biryukov
b195a159e1 Coding Standards: Whitelist date_default_timezone_set() usage in wp-settings.php.
See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47552 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-06 09:04:55 +00:00
Sergey Biryukov
0b4e2c4604 Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.
This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.

git-svn-id: https://develop.svn.wordpress.org/trunk@47550 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-05 03:00:44 +00:00
Andrew Ozz
2e589142eb Media: Remove display: none; from the (visually hidden) <input type="file"> button used in Plupload to select files for uploading. Fixes selecting files in Edge <= 44 and iOS Safari.
Props treecutter, johnbillion, pbiron, isabel_brison, Ipstenu, azaozz.
Fixes #49753 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@47549 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-04 22:52:30 +00:00
K. Adam White
b5117e1ad5 REST API: Fix revisions controller get_item permission check.
r45812 incorrectly introduced a delete_post permissions check into the get_item method, breaking some plugins which requested revisions when generating previews.

Props sorenbronsted, yohannp, TimothyBlynJacobs.
Fixes #49645.


git-svn-id: https://develop.svn.wordpress.org/trunk@47547 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-03 19:38:15 +00:00
Sergey Biryukov
178e16e33a Docs: Add documentation for the $parent parameter of get_admin_page_parent().
Props subrataemfluence.
Fixes #45849.

git-svn-id: https://develop.svn.wordpress.org/trunk@47546 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-03 17:21:25 +00:00
Sergey Biryukov
dfa959bbd5 Docs: Use third-person singular verbs for function descriptions in wp-includes/category-template.php, per the documentation standards.
See #49572.

git-svn-id: https://develop.svn.wordpress.org/trunk@47545 602fd350-edb4-49c9-b593-d223f7449a82
2020-04-02 15:49:53 +00:00
Jonathan Desrosiers
fab1752b16 Bundled Themes: Bump version numbers and update changelogs in default themes for WordPress 5.4.
Props ianbelanger, desrosj, SergeyBiryukov.
Fixes #49743.

git-svn-id: https://develop.svn.wordpress.org/trunk@47539 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-31 19:09:45 +00:00
Sergey Biryukov
212778ab02 Twenty Nineteen: Update style-editor.css after [47327].
Props ianbelanger.
See #48526.

git-svn-id: https://develop.svn.wordpress.org/trunk@47537 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-31 18:55:13 +00:00
Sergey Biryukov
d985b9d903 Twenty Nineteen: Update style-rtl.css after [47339].
Props ianbelanger.
See #49410.

git-svn-id: https://develop.svn.wordpress.org/trunk@47536 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-31 18:53:24 +00:00
Sergey Biryukov
ceba6b656f Administration: Make the height of dashboard widget headings consistent with that of post meta boxes on smaller screens.
This also ensures that the toggle arrow for dashboard widgets is properly aligned.

Props chetan200891.
Fixes #49727.

git-svn-id: https://develop.svn.wordpress.org/trunk@47535 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-31 02:50:52 +00:00
Ian Belanger
628aec5fe2 Bundled Themes: Twenty Twenty Button block forces All Capital letters - revert [47531].
Reverts [47531] to add `text-transform: uppercase;` back to button blocks.

Props joyously.
Fixes #49710.

git-svn-id: https://develop.svn.wordpress.org/trunk@47534 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-30 18:27:08 +00:00
Sergey Biryukov
4634a4ce3f Help/About: Use CDN URLs for 5.4 About page header images.
See #49295.

git-svn-id: https://develop.svn.wordpress.org/trunk@47532 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-30 17:47:34 +00:00
Ian Belanger
ef988903b0 Bundled Themes: Twenty Twenty Button block forces All Capital letters.
Removes `text-transform: uppercase;` from button blocks in order to give the user the option to have a button without All Capital letters.

Props mukesh27.
Fixes #49710.

git-svn-id: https://develop.svn.wordpress.org/trunk@47531 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-30 15:18:40 +00:00
Sergey Biryukov
936b65887c Filesystem API: Correct punctuation in request_filesystem_credentials() error message.
Props mayankmajeji, kharisblank.
Fixes #49724.

git-svn-id: https://develop.svn.wordpress.org/trunk@47530 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-30 01:30:42 +00:00
Sergey Biryukov
2b52250f1a Site Health: Remove paragraph tag from the actions container in issue template.
Most of the tests pass content that is already wrapped in a paragraph or list tags, thus producing nested paragraphs or invalid markup.

Additionally, don't output an empty `<div>` tag if the test does not provide any actions.

Props maxpertici, afercia.
Fixes #48948.

git-svn-id: https://develop.svn.wordpress.org/trunk@47529 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-30 01:23:47 +00:00
Sergey Biryukov
a73eca1021 Site Health: Correct markup in ::get_test_php_extensions() and ::get_test_background_updates() description.
These tests output an unordered list, which doesn't need to be wrapped in a paragraph tag.

Additionally, pass an empty string as an `actions` parameter in `::get_test_php_default_timezone()`, for consistency with other tests.

Props afercia.
See #48948.

git-svn-id: https://develop.svn.wordpress.org/trunk@47528 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-29 03:44:36 +00:00
Sergey Biryukov
96a35dad0b Site Health: Add pretty links support information to debug data.
Props valentinbora, afragen.
Fixes #49422.

git-svn-id: https://develop.svn.wordpress.org/trunk@47527 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-28 21:18:19 +00:00
John Blackbourn
fe18be23fd Comments: Ensure all elements in the array returned by get_comment_count() are integers.
Previously elements would be a mixture of strings and integers depending on their numeric value.

Props progremzion, m.usama.masood

Fixes #48093

git-svn-id: https://develop.svn.wordpress.org/trunk@47526 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-28 20:42:31 +00:00
Sergey Biryukov
4b42334001 Help/About: Improve accessibility of the 5.4 About page:
* Remove vertical text and unnecessary italics.
* Update H1 headings on About, Credits, Freedoms, Privacy pages to be unique to each page.

Props sabernhardt, ryelle, melchoyce, karmatosed, audrasjb, afercia, davidbaumwald, SergeyBiryukov.
See #49295.

git-svn-id: https://develop.svn.wordpress.org/trunk@47521 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-27 23:39:37 +00:00
Sergey Biryukov
815f0341da Coding Standards: Remove some extra tabs in wp-admin/user-new.php.
Follow-up to [47516], [47519].

See #38665.

git-svn-id: https://develop.svn.wordpress.org/trunk@47520 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-27 22:29:00 +00:00
Sergey Biryukov
c71cefe4c9 Coding Standards: Fix WPCS issues in [47516].
See #38665.

git-svn-id: https://develop.svn.wordpress.org/trunk@47519 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-27 22:23:12 +00:00
Jorge Costa
dd1f14ac2f Block Editor: Update WordPress Packages WordPress 5.4 RC 5 Take 2.
The following package versions were changed:
@wordpress/edit-post: 3.13.8 -> 3.13.9
Includes PR https://github.com/WordPress/gutenberg/pull/21220

Props aduth, mapk, ItsJonQ.
Fixes: #49717.

git-svn-id: https://develop.svn.wordpress.org/trunk@47517 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-27 22:06:42 +00:00
John Blackbourn
9c18a5c6e9 Users: Add a user language preference option to the "Add New User" form.
This uses the same language selection control as the user editing screen and allows new users to be invited to a site in their own language.

Props barryceelen, johnbillion

Fixes #38665

git-svn-id: https://develop.svn.wordpress.org/trunk@47516 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-27 21:56:24 +00:00
Sergey Biryukov
33056ff892 Site Health: Remove esc_url() used on "Debugging in WordPress" article URL in WP_Fatal_Error_Handler::display_default_error_template().
The function may not be available in some contexts, for example if a fatal error happens in `advanced-cache.php` drop-in.

Props rob006.
Fixes #49709.

git-svn-id: https://develop.svn.wordpress.org/trunk@47515 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-27 18:20:55 +00:00
Jorge Costa
e858ea7058 Block Editor: Update WordPress Packages WordPress 5.4 RC 5.
The following package versions were changed:
@wordpress/annotations: 1.12.2 -> 1.12.3
@wordpress/block-directory: 1.5.6 -> 1.5.7
@wordpress/block-editor: 3.7.6 -> 3.7.7
@wordpress/block-library: 2.14.6 -> 2.14.7
@wordpress/blocks: 6.12.2 -> 6.12.3
@wordpress/components: 9.2.5 -> 9.2.6
@wordpress/core-data: 2.12.2 -> 2.12.3
@wordpress/edit-post: 3.13.7 -> 3.13.8
@wordpress/editor: 9.12.6 -> 9.12.7
@wordpress/format-library: 1.14.6 -> 1.14.7
@wordpress/list-reusable-blocks: 1.13.5 -> 1.13.6
@wordpress/nux: 3.12.5 -> 3.12.6
@wordpress/server-side-render: 1.8.5 -> 1.8.6
Description of editor changes included in the RC available at https://github.com/WordPress/gutenberg/pull/21210.

Props mcsf, aduth.
Fixes: #49716.

git-svn-id: https://develop.svn.wordpress.org/trunk@47513 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-27 18:08:43 +00:00
K. Adam White
bef2746334 REST API: Fix _fields filtering of registered rest fields.
Use rest_is_field_included when determining which additional fields to include to permit filtering by nested field properties.

Props Dudo, kadamwhite, TimothyBlynJacobs.
Fixes #49648.


git-svn-id: https://develop.svn.wordpress.org/trunk@47511 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-26 17:50:39 +00:00
John Blackbourn
728a031767 Themes: Always list broken themes even if the user cannot take a corresponding action within the admin area.
This prevents broken themes being hidden when the `DISALLOW_FILE_MODS` constant is in use.

Props rebasaurus

Fixes #49268

git-svn-id: https://develop.svn.wordpress.org/trunk@47510 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-26 17:48:07 +00:00
John Blackbourn
f5550907e1 Query: Introduce an action which gets fired when a 404 is triggered.
Fixes #48061

git-svn-id: https://develop.svn.wordpress.org/trunk@47509 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-26 17:41:14 +00:00
Sergey Biryukov
d8c8058309 Coding Standards: Fix WPCS issues in wp-includes/class-wp-http-proxy.php.
Props thrijith, mukesh27.
Fixes #46784.

git-svn-id: https://develop.svn.wordpress.org/trunk@47508 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-26 07:18:20 +00:00
Sergey Biryukov
0f9477d5e8 Docs: Add documentation for WP_Comments_List_Table::floated_admin_avatar().
Props akbarhusen, ayeshrajans, Soean, ajayghaghretiya1, netweb, SergeyBiryukov.
Fixes #41491.

git-svn-id: https://develop.svn.wordpress.org/trunk@47507 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-25 14:41:15 +00:00
Robert Anderson
251fd685dd Comments: Fix title not updating when replying to a comment
When replying to an existing comment, the comment form is moved to below the
existing comment with JS, but the form heading was not being updated. This
fixes the issue by introducing a new data-attribute to the reply link with the
correct heading string, and applying that string to the heading when the form
is moved.

Props isabel_brison, azaozz, peterwilsoncc.
Fixes #38009.


git-svn-id: https://develop.svn.wordpress.org/trunk@47506 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-25 04:53:06 +00:00
Sergey Biryukov
36d112d1c8 Docs: Revert a type change for the $value parameter of WP_Dependencies::add_data() in [47170].
Although described as a string in several places, it's technically not limited to a particular type.

Props westonruter.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47502 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-24 20:54:38 +00:00
Jorge Costa
afe1b96db2 Help/About: Fix a typo on the about page and fix a link.
The text "on your" appeared two times. This commit fixes the issue and removes the duplication. It also updates the field guide permalink.

Props garrett-eclipse, ixkaito, karmatosed, SergeyBiryukov.

git-svn-id: https://develop.svn.wordpress.org/trunk@47500 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-24 15:01:57 +00:00
Jorge Costa
def0da1bbe Block Editor: Update WordPress Packages WordPress 5.4 RC 4.
The following package versions were changed:
@wordpress/annotations: 1.12.1 -> 1.12.2
@wordpress/block-directory: 1.5.5 -> 1.5.6
@wordpress/block-editor: 3.7.5 -> 3.7.6
@wordpress/block-library: 2.14.5 -> 2.14.6
@wordpress/blocks: 6.12.1 -> 6.12.2
@wordpress/components: 9.2.4 -> 9.2.5
@wordpress/core-data: 2.12.1 -> 2.12.2
@wordpress/data: 4.14.1 -> 4.14.2
@wordpress/data-controls: 1.8.1 -> 1.8.2
@wordpress/edit-post: 3.13.6 -> 3.13.7
@wordpress/editor: 9.12.5 -> 9.12.6
@wordpress/format-library: 1.14.5 -> 1.14.6
@wordpress/keyboard-shortcuts: 1.1.1 -> 1.1.2
@wordpress/list-reusable-blocks: 1.13.4 -> 1.13.5
@wordpress/notices: 2.0.1 -> 2.0.2
@wordpress/nux: 3.12.4 -> 3.12.5
@wordpress/rich-text: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.4 -> 1.8.5
@wordpress/viewport: 2.13.1 -> 2.13.2
Description of editor changes included in the RC available at https://github.com/WordPress/gutenberg/pull/21083.

Props itsjonq, mcsf, aduth.
Fixes: #49688.

git-svn-id: https://develop.svn.wordpress.org/trunk@47495 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-23 23:38:27 +00:00
Sergey Biryukov
ad8d01a7e9 Docs: Add missing @since tags for WP_User_Request properties.
Correct type for `$email`, `$confirmed_timestamp`, and `$completed_timestamp` properties.

Props pbiron, garrett-eclipse.
Fixes #49675.

git-svn-id: https://develop.svn.wordpress.org/trunk@47494 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-23 20:18:15 +00:00
Sergey Biryukov
630ba8979a Administration: Add / character to <img> tag in WP_Plugin_Install_List_Table::display_rows().
While this has no effect on void elements in HTML5, it fixes a minor inconsistency with the rest of core.

Props adnan.limdi, Soean.
Fixes #41904.

git-svn-id: https://develop.svn.wordpress.org/trunk@47493 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-22 18:35:46 +00:00
Sergey Biryukov
f44d456a4b Upgrade/Install: Return a more appropriate HTTP response status code (409 Conflict) if the wp-config.php file already exists.
Props linyows, ocean90.
Fixes #42466.

git-svn-id: https://develop.svn.wordpress.org/trunk@47478 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-21 15:42:57 +00:00
Sergey Biryukov
7c15916c28 Coding Standards: Fix WPCS issue in [47475].
See #49295.

git-svn-id: https://develop.svn.wordpress.org/trunk@47476 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-20 17:31:13 +00:00
Sergey Biryukov
e45a2eb99d Help/About: Add design for 5.4 About page.
Props melchoyce, marybaum, marktimemedia, elmastudio, ryelle, karmatosed, audrasjb, afercia, francina, sabernhardt.
See #49295.

git-svn-id: https://develop.svn.wordpress.org/trunk@47475 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-20 17:11:35 +00:00
Sergey Biryukov
827d77e341 Administration: Escape admin title on output after the admin_title filter runs, not before.
Props lalitpendhare, adnan.limdi, subrataemfluence, andraganescu.
Fixes #41921.

git-svn-id: https://develop.svn.wordpress.org/trunk@47474 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-20 02:18:53 +00:00
Sergey Biryukov
7ede058b16 Privacy: Correct bottom padding for table of contents on Privacy Policy Guide on smaller screens.
Props jagirbahesh, birgire, garrett-eclipse.
Fixes #49570.

git-svn-id: https://develop.svn.wordpress.org/trunk@47473 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-19 20:43:13 +00:00
Sergey Biryukov
b0889a7639 Post Formats: Pass post type to the disable_formats_dropdown filter in WP_Posts_List_Table::formats_dropdown().
Props MatheusFD, birgire.
Fixes #47959.

git-svn-id: https://develop.svn.wordpress.org/trunk@47472 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-18 19:11:33 +00:00
Sergey Biryukov
e7022adab2 Docs: Correct the description of $hard parameter in flush_rewrite_rules().
Props david.binda.
Fixes #49660.

git-svn-id: https://develop.svn.wordpress.org/trunk@47468 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-17 19:32:45 +00:00
Jorge Costa
f5c0507910 Block Editor: Update WordPress Packages WordPress 5.4 RC 3.
The following package versions were changed:
@wordpress/block-directory: 1.5.4 -> 1.5.5
@wordpress/block-editor: 3.7.4 -> 3.7.5
@wordpress/block-library: 2.14.4 -> 2.14.5
@wordpress/components: 9.2.3 -> 9.2.4
@wordpress/dependency-extraction-webpack-plugin: 2.3.0 -> 2.4.0
@wordpress/edit-post: 3.13.5 -> 3.13.6
@wordpress/editor: 9.12.4 -> 9.12.5
@wordpress/format-library: 1.14.4 -> 1.14.5
@wordpress/list-reusable-blocks: 1.13.3 -> 1.13.4
@wordpress/nux: 3.12.3 -> 3.12.4
@wordpress/server-side-render: 1.8.3 -> 1.8.4

Props aduth.
Fixes: #49657.

git-svn-id: https://develop.svn.wordpress.org/trunk@47462 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-16 22:05:14 +00:00
John Blackbourn
c8d918e476 Docs: Various docblock corrections and improvements.
See #49572

git-svn-id: https://develop.svn.wordpress.org/trunk@47461 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-16 18:38:03 +00:00
Sergey Biryukov
5b88e2fa53 Menus: When adding a label for special pages in wp_setup_nav_menu_item() strip all HTML tags, as the label is escaped on output.
Follow-up to [47211], [47213].

Props stiofansisland.
Fixes #49374.

git-svn-id: https://develop.svn.wordpress.org/trunk@47458 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-16 01:30:14 +00:00
Sergey Biryukov
812c92e1e9 Administration: When editing a plugin or theme file, close any active PHP session.
This prevents HTTP requests from timing out when attempting to connect back to the site.

Props bruandet, vjik, donmhico, SergeyBiryukov.
Fixes #43358.

git-svn-id: https://develop.svn.wordpress.org/trunk@47457 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-15 19:43:50 +00:00
Sergey Biryukov
a2861f1277 Site Health: Run the first scheduled site health check a day after the initial site setup.
This reduces the chance of displaying incorrect results due to running the check too early in first time setup scenarios.

Props Clorith, garrett-eclipse, roytanck, joostdevalk.
Fixes #49577.

git-svn-id: https://develop.svn.wordpress.org/trunk@47456 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-14 16:34:54 +00:00
Sergey Biryukov
c3156e6258 Toolbar: Move the logic for rendering the admin bar on wp_footer to wp_admin_bar_render().
Clarify in the function documentation that it is now called on `wp_body_open` action first, with `wp_footer` as a fallback.

Follow-up to [47221].

Fixes #47053.

git-svn-id: https://develop.svn.wordpress.org/trunk@47455 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-14 15:59:22 +00:00
Sergey Biryukov
31dd2e70f0 General: Trim the input data in maybe_unserialize(), for consistency with is_serialized().
Props pbearne, mikeschroder.
Fixes #36416.

git-svn-id: https://develop.svn.wordpress.org/trunk@47454 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-13 21:12:01 +00:00
SergeyBiryukov
13c5098f74 General: Move maybe_serialize() to a more appropriate place in the file, before maybe_unserialize().
Rename the `$original` parameter of `maybe_unserialize()` to `$data`, for consistency with other serialization functions.

See #36416.

git-svn-id: https://develop.svn.wordpress.org/trunk@47453 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-13 21:05:02 +00:00
Sergey Biryukov
ed9d5c383f Database: Introduce wpdb::db_server_info() to retrieve full MySQL server information string as supplied by mysqli_get_server_info().
This complements `wpdb::db_version()`, which only returns a numeric version string and strips any additional information, e.g. vendor name.

Props clarinetlord, birgire, webaware, pento.
Fixes #40037. See #27703.

git-svn-id: https://develop.svn.wordpress.org/trunk@47451 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-12 15:53:01 +00:00
Timothy Jacobs
60edf36394 REST API: Introduce "hex-color" JSON Schema format.
Props spacedmonkey, chrisvanpatten.
Fixes #49270.


git-svn-id: https://develop.svn.wordpress.org/trunk@47450 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-12 02:40:29 +00:00
Peter Wilson
eba126609f Media: Introduce preflight filter to wp_delete_attachment().
Introduces the filter `pre_delete_attachment` to allow developers to prevent or modify the deletion of attachments. This improves consistency with `wp_delete_post()` and `wp_trash_post()`.

Props joemcgill, peterwilsoncc.
Fixes #49597.


git-svn-id: https://develop.svn.wordpress.org/trunk@47448 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-10 22:46:12 +00:00
Sergey Biryukov
01ad44e871 Bundled Themes: Update calendar widget styles for 5.4 markup to fix the alignment of a single month link.
Follow-up to [47405].

Props sabernhardt.
Reviewed by ianbelanger, SergeyBiryukov.
Fixes #49549.

git-svn-id: https://develop.svn.wordpress.org/trunk@47444 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-10 20:51:46 +00:00
Sergey Biryukov
6095b4467a Help/About: Use consistent vertical whitespace between sections on Freedoms page.
Props chetan200891.
Fixes #49619.

git-svn-id: https://develop.svn.wordpress.org/trunk@47443 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-10 20:37:59 +00:00
Jorge Costa
94516bbb3f Block Editor: Update WordPress Packages WordPress 5.4 RC 2.
The following package versions were changed:
@wordpress/block-directory: 1.5.3 -> 1.5.4
@wordpress/block-editor: 3.7.3 -> 3.7.4
@wordpress/block-library: 2.14.3 -> 2.14.4
@wordpress/edit-post: 3.13.4 -> 3.13.5
@wordpress/editor: 9.12.3 -> 9.12.4
@wordpress/format-library: 1.14.3 -> 1.14.4

Props aduth, gziolo, mapk.
Fixes: #49611.

git-svn-id: https://develop.svn.wordpress.org/trunk@47441 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-10 14:51:10 +00:00
Ian Belanger
150a49a0b1 Bundled Themes: Twenty Twenty content font CSS selector is too important - updated.
This adds more selectors for headings, tables, addresses, cite, figcaption, file and caption blocks to make the font-family match as before [47133].

Props alexandreb3, SergeyBiryukov.
Fixes #49318.

git-svn-id: https://develop.svn.wordpress.org/trunk@47439 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-09 19:46:27 +00:00
Sergey Biryukov
4f06d9a2bb Help/About: Update and correct some strings for 5.4 About page.
Props garrett-eclipse, Ipstenu, ocean90, tobifjellner, la-geek.
Reviewed by ocean90, SergeyBiryukov.
See #49295.

git-svn-id: https://develop.svn.wordpress.org/trunk@47436 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-09 00:09:25 +00:00
Sergey Biryukov
77578e0869 Themes: Prevent tags in Theme Details modal from being partially hidden behind action buttons on smaller screens.
Props sagarjadhav, valentinbora.
Fixes #31783.

git-svn-id: https://develop.svn.wordpress.org/trunk@47435 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-08 01:50:37 +00:00
Sergey Biryukov
f6ff42bee4 Administration: Add missing description for "Page title" element of the admin menu array.
Props ajoah, valentinbora, kaitlin414.
Fixes #42911.

git-svn-id: https://develop.svn.wordpress.org/trunk@47434 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-08 00:16:36 +00:00
Sergey Biryukov
c227b20a0f Customize: Ensure color picker's Clear button is aligned properly.
Props Cybr.
Fixes #49543.

git-svn-id: https://develop.svn.wordpress.org/trunk@47433 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-07 01:11:38 +00:00
Sergey Biryukov
72cb0ebff8 REST API: Fix typo in disable-custom-gradients theme feature description.
Props Ipstenu, tobifjellner, pixelverbieger.
Reviewed by ocean90, johnbillion, SergeyBiryukov.
Fixes #49585.

git-svn-id: https://develop.svn.wordpress.org/trunk@47432 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-06 00:15:09 +00:00
Sergey Biryukov
48df8c3646 General: Ensure get_tag_regex() always returns a string, to match the documented value.
Props subrataemfluence.
Fixes #45643.

git-svn-id: https://develop.svn.wordpress.org/trunk@47430 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-04 12:03:32 +00:00
Sergey Biryukov
7a4f9cc9a6 General: Correct the default value of the $defaults parameter in wp_parse_args() to match the documented type.
Props subrataemfluence.
See #45643.

git-svn-id: https://develop.svn.wordpress.org/trunk@47429 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-04 11:58:31 +00:00
Sergey Biryukov
047f6e4bef Docs: Reorder @throws tags in WP_Customize_Nav_Menu_Setting and WP_Customize_Nav_Menu_Item_Setting for consistency with WP_Customize_Custom_CSS_Setting.
See #49572.

git-svn-id: https://develop.svn.wordpress.org/trunk@47428 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-04 11:33:14 +00:00
Sergey Biryukov
b52783bc4f Docs: Add missing @throws tag to _wp_json_sanity_check() DocBlock.
Props subrataemfluence.
See #45643.

git-svn-id: https://develop.svn.wordpress.org/trunk@47427 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-04 11:32:52 +00:00
Peter Wilson
55b3866749 Trunk is now 5.5 alpha
git-svn-id: https://develop.svn.wordpress.org/trunk@47426 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-04 01:18:56 +00:00
Jorge Costa
66f510bda0 Post WordPress 5.4 RC 1 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@47424 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 22:00:22 +00:00
Jorge Costa
d4f965278a WordPress 5.4 RC 1.
git-svn-id: https://develop.svn.wordpress.org/trunk@47423 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 21:41:29 +00:00
Sergey Biryukov
0ffce72ed0 Help/About: Add strings for 5.4 About page.
Props elmastudio, chanthaboune, francina, marybaum, audrasjb.
See #49295.

git-svn-id: https://develop.svn.wordpress.org/trunk@47422 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 21:20:45 +00:00
Jorge Costa
ae5596bf0a Editor: Update WordPress packages to make editor full-screen by default.
The following package versions were changed:
@wordpress/e2e-test-utils: 4.3.0 -> 4.3.1
@wordpress/edit-post: 3.13.3 -> 3.13.4
This commit update allows the following PR to be part of trunk https://github.com/WordPress/gutenberg/pull/20611.

Props youknowriad, mcsf, mapk.
Fixes: #49574.

git-svn-id: https://develop.svn.wordpress.org/trunk@47421 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 20:43:49 +00:00
Sergey Biryukov
60f78cd845 Privacy: Prevent unexpected scrolling when clicking the "Copy this section to clipboard" button on Privacy Policy Guide screen.
Props garrett-eclipse, birgire, davidbaumwald, pbiron.
Fixes #49540.

git-svn-id: https://develop.svn.wordpress.org/trunk@47420 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 17:49:53 +00:00
Sergey Biryukov
7dd3e6edd9 Media: Improve the appearance of image editor on small and medium screens.
This prevents the main area of Edit Media screen from being pushed down too far.

Props sabernhardt, afercia, fierevere, sathyapulse, mikeschroder, johnbillion.
Fixes #48780. See #47136.

git-svn-id: https://develop.svn.wordpress.org/trunk@47418 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 17:19:55 +00:00
Jorge Costa
ac4de42983 Scripts: Use core-js url as polyfill for window.URL.
URL polyfill from the polyfill-library library is not spec-conformant, in a way which negatively impacts its usability for pending revisions to the block editor. Specifically, there were revisions to the implementation of the wp-url script to detect URL validity by relying on thrown errors from the URL constructor, but this specific behavior is not implemented in this version of the polyfill.
There was another issue in r47238, which is that the test used to check whether the polyfill should be included is not accurate. This commit uses a different check and fixes the issue.

Props aduth.
Fixes: #49360.

git-svn-id: https://develop.svn.wordpress.org/trunk@47416 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 16:53:32 +00:00
Sergey Biryukov
360c98280c Site Health: Fix typo in Site Health Status dashboard widget.
Follow-up to [47063], [47413].

Props Clorith, dlh.
See #49562.

git-svn-id: https://develop.svn.wordpress.org/trunk@47415 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 12:20:35 +00:00
Sergey Biryukov
cd84eaac26 Docs: Correct formatting of some DocBlocks in Plugin_Upgrader and Theme_Upgrader per the documentation standards.
See #49400.

git-svn-id: https://develop.svn.wordpress.org/trunk@47414 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 11:38:00 +00:00
Sergey Biryukov
288f5234e9 Site Health: Improve the strings in Site Health Status dashboard widget.
Follow-up to [47063].

Props dlh.
Fixes #49562.

git-svn-id: https://develop.svn.wordpress.org/trunk@47413 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 11:20:00 +00:00
John Blackbourn
e45162e496 Privacy: Fix the URLs and legacy redirects for the personal data export and erasure screens.
Props Jurgen Oldenburg, garrett-eclipse

Fixes #49476

git-svn-id: https://develop.svn.wordpress.org/trunk@47412 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 00:48:21 +00:00
John Blackbourn
e9c74d09c8 Privacy: Reintroduce consistency to the styling of suggested privacy text from core and plugins.
Props garrett-eclipse

Fixes #49282

git-svn-id: https://develop.svn.wordpress.org/trunk@47411 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 00:40:27 +00:00
John Blackbourn
b20dd081ba Editor: Revert a fix for incorrect usage of ID attributes on custom fields.
This reverts [47222] due to compatibility issues with plugins which are using the `#poststuff` selector.

See #46964

git-svn-id: https://develop.svn.wordpress.org/trunk@47410 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 00:35:41 +00:00
John Blackbourn
0fcbdc1e2d Upgrade/Install: Improved inline docs for the plugin and theme updater maintenance mode functionality.
Props bookdude13

See #49400

git-svn-id: https://develop.svn.wordpress.org/trunk@47409 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-03 00:27:52 +00:00
Jorge Costa
8bee6a4860 Block Editor: Update WordPress Packages WordPress 5.4 RC 1.
The following package versions were changed:
@wordpress/annotations: 1.12.0 -> 1.12.1
@wordpress/block-directory: 1.5.2 -> 1.5.3
@wordpress/block-editor: 3.7.2 -> 3.7.3
@wordpress/block-library: 2.14.2 -> 2.14.3
@wordpress/blocks: 6.12.0 -> 6.12.1
@wordpress/components: 9.2.2 -> 9.2.3
@wordpress/core-data: 2.12.0 -> 2.12.1
@wordpress/data: 4.14.0 -> 4.14.1
@wordpress/data-controls: 1.8.0 -> 1.8.1
@wordpress/edit-post: 3.13.2 -> 3.13.3
@wordpress/editor: 9.12.2 -> 9.12.3
@wordpress/format-library: 1.14.2 -> 1.14.3
@wordpress/keyboard-shortcuts: 1.1.0 -> 1.1.1
@wordpress/list-reusable-blocks: 1.13.2 -> 1.13.3
@wordpress/notices: 2.0.0 -> 2.0.1
@wordpress/nux: 3.12.2 -> 3.12.3
@wordpress/priority-queue: 1.5.0 -> 1.5.1
@wordpress/rich-text: 3.12.0 -> 3.12.1
@wordpress/server-side-render: 1.8.2 -> 1.8.3
@wordpress/viewport: 2.13.0 -> 2.13.1

Props aduth.
Fixes: #49567.

git-svn-id: https://develop.svn.wordpress.org/trunk@47408 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-02 23:19:06 +00:00
John Blackbourn
ef878b59c9 Feeds: Remove an unreachable condition when generating archive feed links.
Props donmhico, pbiron

Fixes #48427

git-svn-id: https://develop.svn.wordpress.org/trunk@47406 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-02 18:50:22 +00:00
Ian Belanger
3c5d847872 Bundled Themes: Update calendar widget styles for 5.4 markup.
Fixes the alignment of month links in the calendar widget with the changes in version 5.4 for all Bundled Themes, except Twenty Thirteen, which was already fixed in #49546.

Props sabernhardt.
Fixes #49549.

git-svn-id: https://develop.svn.wordpress.org/trunk@47405 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-02 16:53:36 +00:00
Sergey Biryukov
3feb885ec3 Docs: Use more specific type in parameter descriptions for is_page(), is_single(), is_singular(), and their WP_Query counterpart methods.
Props marekdedic, shaharia.azam, shaampk1.
Fixes #48354. See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47402 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-01 17:27:03 +00:00
Sergey Biryukov
6c33566c05 Docs: Synchronize parameter descriptions for conditional tags with their WP_Query counterpart methods.
See #48354, #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47401 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-01 17:19:58 +00:00
Sergey Biryukov
f327466200 Docs: Use more specific type in parameter description for wp_unslash().
Props marekdedic.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47400 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-01 16:23:24 +00:00
Sergey Biryukov
a7c0d2c8fc Docs: Use more specific type in description for _WP_Dependency::$deps.
Props marekdedic.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47399 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-01 16:22:51 +00:00
John Blackbourn
ac6cb23470 Docs: Miscellaneous docs fixes and improvements.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47398 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-01 10:38:00 +00:00
John Blackbourn
78a6e4febb Docs: Use more specific types in parameter descriptions in place of mixed.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47397 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-01 10:36:38 +00:00
John Blackbourn
ba57b0141c Docs: Correct the parameter documentation of the request_filesystem_credentials filter.
See #48303

git-svn-id: https://develop.svn.wordpress.org/trunk@47396 602fd350-edb4-49c9-b593-d223f7449a82
2020-03-01 10:31:31 +00:00
Sergey Biryukov
5f23c79b1d Privacy: Make the progress indicator for export and erasure visible even if not hovered over.
Follow-up to [47246].

Props pbiron, garrett-eclipse.
Fixes #44264.

git-svn-id: https://develop.svn.wordpress.org/trunk@47395 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-29 23:43:57 +00:00
John Blackbourn
b7bc6f7bb0 Docs: Correct and improve the docs for some media related functions.
See #48303

git-svn-id: https://develop.svn.wordpress.org/trunk@47394 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-29 16:47:44 +00:00
Ian Belanger
b4d0da91f7 Bundled Themes: Twenty Twenty searchform.php error.
Fixes phpcs error in the searchform.php file. The variables in this file were not prefixed correctly.

Props fahimmurshed.
Fixes #49523.

git-svn-id: https://develop.svn.wordpress.org/trunk@47393 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-28 20:54:42 +00:00
Ian Belanger
a00d79a07d Bundled Themes: Twenty Thirteen update calendar widget styles for 5.4 markup.
Fixes the alignment of month links in the calendar widget with the changes in version 5.4

Props sabernhardt.
Fixes #49546.

git-svn-id: https://develop.svn.wordpress.org/trunk@47392 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-28 20:05:39 +00:00
Sergey Biryukov
b54d5925ce Docs: Improve documentation for WP_REST_Attachments_Controller.
This adds a missing DocBlock for `::register_routes()` and parameter descriptions for `::post_process_item()`.

Includes minor documenation fixes in other REST API classes for consistency.

Props dkarfa, mukesh27, SergeyBiryukov.
Fixes #48841.

git-svn-id: https://develop.svn.wordpress.org/trunk@47391 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-28 12:29:53 +00:00
Sergey Biryukov
697127203b Docs: Improve documentation for various metadata functions.
This adds a more specific description for accepted object types: `post`, `comment`, `term`, `user`, or any other object type with an associated meta table.

Props sheparddw, kraftbj, DrewAPicture, SergeyBiryukov.
Fixes #45464.

git-svn-id: https://develop.svn.wordpress.org/trunk@47390 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-28 12:12:58 +00:00
Sergey Biryukov
559ccdda0c Twenty Twenty: Replace quotation marks in starter content with HTML entities.
Props fahimmurshed.
Fixes #49534.

git-svn-id: https://develop.svn.wordpress.org/trunk@47388 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-27 21:58:54 +00:00
Sergey Biryukov
ef613db765 Docs: Add a reference to WP_Customize_Panel::__construct() for information on accepted arguments in WP_Customize_Manager::add_panel().
Synchronize the documentation between two places, use `WP_Customize_Panel::__construct()` as the canonical source.

Props iaaxpage, marekdedic.
Fixes #48344.

git-svn-id: https://develop.svn.wordpress.org/trunk@47387 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-27 20:34:49 +00:00
Sergey Biryukov
19bdff7326 Docs: Add a reference to WP_Customize_Section::__construct() for information on accepted arguments in WP_Customize_Manager::add_section().
Synchronize the documentation between two places, use `WP_Customize_Section::__construct()` as the canonical source.

Props amolv, marekdedic.
Fixes #48346.

git-svn-id: https://develop.svn.wordpress.org/trunk@47386 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-27 20:27:45 +00:00
Sergey Biryukov
33b88a7c7f Docs: Clarify the type of theme_supports argument in various Customizer classes.
Props marekdedic.
See #48347.

git-svn-id: https://develop.svn.wordpress.org/trunk@47385 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-27 20:21:35 +00:00
Sergey Biryukov
9793244c74 Docs: Add a reference to WP_Customize_Setting::__construct() for information on accepted arguments in WP_Customize_Manager::add_setting().
Synchronize the documentation between two places, use `WP_Customize_Setting::__construct()` as the canonical source.

Props tmanoilov, marekdedic.
Fixes #48347.

git-svn-id: https://develop.svn.wordpress.org/trunk@47384 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-27 20:07:31 +00:00
Sergey Biryukov
bd71eb4b74 Docs: Use a consistent description for the $manager parameter in various Customizer class constructions.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47383 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-26 15:31:19 +00:00
Sergey Biryukov
aab2667898 Docs: Add a @see reference to WP_Customize_Control::__construct() in child class constructors.
Follow-up to [47363], [47364].

See #48343, #48348.

git-svn-id: https://develop.svn.wordpress.org/trunk@47382 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-26 13:29:01 +00:00
Andrew Ozz
3a4faa975f Build Tools: Do not delete the (now committed) script-loader-packages.php file when running clean:js and copy it to /build. Fixes cases when running grunt watch or -dev where that file may be deleted and not recreated.
See #48154.

git-svn-id: https://develop.svn.wordpress.org/trunk@47380 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-26 05:13:05 +00:00
Jorge Costa
0975f8e79b Post WordPress 5.4 Beta 3 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@47379 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 22:11:55 +00:00
Jorge Costa
16aa8bbcce WordPress 5.4 Beta 3.
git-svn-id: https://develop.svn.wordpress.org/trunk@47378 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 21:54:53 +00:00
Sergey Biryukov
762dc39878 Block Editor: Update wp-includes/assets/script-loader-packages.php.
Follow-up to [47352], [47354].

Props aduth, ocean90, garrett-eclipse.
Fixes #49506.

git-svn-id: https://develop.svn.wordpress.org/trunk@47377 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 21:43:57 +00:00
Sergey Biryukov
0347132f12 Privacy: Switch buttons in Next Steps column of privacy request tables to break-word for better legibility on various screen sizes.
Props garrett-eclipse, afercia, nrqsnchz.
Fixes #46304.

git-svn-id: https://develop.svn.wordpress.org/trunk@47376 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 20:59:08 +00:00
Sergey Biryukov
ccb7aec7fc Accessibility: Media: Hide the invisible "file upload button" on media views from assistive technologies.
The button is visually hidden, but was announced by screen readers in workflows unrelated to file uploading, leading to confusion.

Props afercia, audrasjb, azaozz.
Fixes #47611.

git-svn-id: https://develop.svn.wordpress.org/trunk@47375 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 20:42:19 +00:00
Sergey Biryukov
22c02a0325 General: Introduce HTML classes in get_calendar() for easier CSS targeting:
* `.wp-calendar-table` for the `<table>` element.
* `.wp-calendar-nav` for the navigation wrapper.
* `.wp-calendar-nav-prev` for the previous month link.
* `.wp-calendar-nav-next` for the next month link.

Replace `#prev` and `#next` HTML IDs with `.wp-calendar-nav-prev` and `.wp-calendar-nav-next` classes.

Props sabernhardt, BackuPs, audrasjb, jorbin.
Fixes #39763.

git-svn-id: https://develop.svn.wordpress.org/trunk@47374 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 20:28:29 +00:00
Sergey Biryukov
91878831dd Docs: In update_option(), remove an inaccurate statement about the $autoload value for new options.
If the option does not exist, it will be created with whatever was passed to the `$autoload` parameter, `'yes'` being only the default value.

Props leogermani.
Fixes #48357.

git-svn-id: https://develop.svn.wordpress.org/trunk@47373 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 20:06:32 +00:00
Sergey Biryukov
38e9142a66 Coding Standards: Use strict comparison for normalize_whitespace() checks when comparing revisions or autosaves.
Props dkarfa, itowhid06, TimothyBlynJacobs.
Fixes #47965.

git-svn-id: https://develop.svn.wordpress.org/trunk@47372 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 19:33:22 +00:00
Sergey Biryukov
f852ca2cc1 Widgets: Create a unique HTML ID for the <ul> element of Recent Comments widget if more than one instance is displayed on the page.
Props peterwilsoncc, audrasjb, birgire, justinahinon, mbrailer, desrosj.
Fixes #46747.

git-svn-id: https://develop.svn.wordpress.org/trunk@47371 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 19:27:22 +00:00
Sergey Biryukov
97d43fbff5 Bootstrap/Load: In wp_magic_quotes(), revert the type change to string for REQUEST_TIME and REQUEST_TIME_FLOAT values, which should retain their proper type.
Among other things, this preserves compatibility of WP with PHPUnit Code Coverage generation.

Props jrf, Veraxus, Rarst.
See #48605.

git-svn-id: https://develop.svn.wordpress.org/trunk@47370 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 18:31:33 +00:00
Sergey Biryukov
8dbe048737 Docs: In wp_insert_user(), correct @type for rich_editing, syntax_highlighting, comment_shortcuts, and show_admin_bar_front arguments.
Follow-up to [47368].

See #49087.

git-svn-id: https://develop.svn.wordpress.org/trunk@47369 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 18:18:26 +00:00
Sergey Biryukov
d722bdb0ac Docs: In wp_insert_user(), clarify that rich_editing, syntax_highlighting, comment_shortcuts, and show_admin_bar_front arguments accept true or false as a string literal, not boolean.
Props garrett-eclipse, audrasjb, valentinbora, bilgilabs, SergeyBiryukov.
Fixes #49087.

git-svn-id: https://develop.svn.wordpress.org/trunk@47368 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 18:15:00 +00:00
Sergey Biryukov
f1124fc1cb Docs: Clarify in WP_Customize_Manager::remove_*() methods that removing a setting, panel, section, or control does not destroy the class instance or remove its filters.
Props dlh, fgiannar, jon81, westonruter.
Fixes #48747.

git-svn-id: https://develop.svn.wordpress.org/trunk@47367 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 17:48:40 +00:00
Sergey Biryukov
a6b80a326a Comments: Restore the fourth parameter of comments_number() as $post_id, for consistency with get_comments_number_text().
The parameter was previously used as the number of comments, marked as deprecated in [5101].

Given that it's been deprecated for the last 13 years, it should be safe to undeprecate and repurpose it for a cleaner function signature, instead of adding a fifth parameter.

Follow-up to [47276].

Fixes #48772.

git-svn-id: https://develop.svn.wordpress.org/trunk@47366 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 17:32:34 +00:00
Sergey Biryukov
812773b8fc Widgets: Avoid an overflow issue in widget controls that include <select> form fields.
Props alexischenal, audrasjb, dkarfa.
Fixes #49401.

git-svn-id: https://develop.svn.wordpress.org/trunk@47365 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 17:02:27 +00:00
Sergey Biryukov
3bd4e3a075 Docs: Add a reference to WP_Customize_Control::__construct() for information on accepted arguments in WP_Customize_Manager::add_control().
Synchronize the documentation between two places, use `WP_Customize_Control::__construct()` as the canonical source.

Props hAmpzter, marekdedic, SergeyBiryukov.
Fixes #48343.

git-svn-id: https://develop.svn.wordpress.org/trunk@47364 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 16:39:36 +00:00
Sergey Biryukov
5178d29f4a Docs: Add a reference to WP_Customize_Control::__construct() for information on accepted arguments to override class property defaults in child classes.
Props marcio-zebedeu, marekdedic.
Fixes #48348.

git-svn-id: https://develop.svn.wordpress.org/trunk@47363 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 16:19:08 +00:00
K. Adam White
4e0062e5be REST API: Correctly infer empty objects passed via query parameters.
Permit passing an empty object as the string "?obj=". The type of the passed empty argument is inferred from the registered schema.

Props TimothyBlynJacobs, steffanhalv, schlessera, dd32.
Fixes #42961.


git-svn-id: https://develop.svn.wordpress.org/trunk@47362 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 15:32:27 +00:00
K. Adam White
b5190458fe REST API: Permit access to the themes controller if user can edit any post type.
Check a more exhaustive list of post type editing caps beyond "edit_post" to ensure custom user roles with access to to specific post types may still use block editor functionality depending on theme features.

Props miyauchi, TimothyBlynJacobs.
Fixes #46723.


git-svn-id: https://develop.svn.wordpress.org/trunk@47361 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 15:18:19 +00:00
K. Adam White
a0ac0ff13d REST API: Apply all relevant block rendering filters when rendering block previews.
Several filters were introduced to the render_block method since the initial implementation of the block-renderer/ endpoints, causing the output of those endpoints to diverge from the rendered content of blocks on the frontend.

Props kadamwhite, TimothyBlynJacobs, miinasikk.
Fixes #49387.


git-svn-id: https://develop.svn.wordpress.org/trunk@47360 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 15:03:57 +00:00
Sergey Biryukov
51e6228635 Script Loader: Improve performance of wp_script_is() for scripts registered with complex dependencies.
This switches `WP_Dependencies::recurse_deps()` from recursively checking the same handles over and over again to keep a flattened array of queued items and their dependencies for faster lookup in `WP_Dependencies::query()`.

Props superdav42.
Fixes #46469.

git-svn-id: https://develop.svn.wordpress.org/trunk@47359 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 13:40:52 +00:00
Sergey Biryukov
887e0a8004 Docs: Add a @since note for including delete_posts in default capabilities in get_post_type_capabilities().
Follow-up to [47357].

See #30991.

git-svn-id: https://develop.svn.wordpress.org/trunk@47358 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 12:53:35 +00:00
Sergey Biryukov
317e1c076c Posts, Post Types: Ensure delete_posts is included in default post type capabilities regardless of map_meta_cap value.
This resolves PHP notices in a few places in core where this capability is checked.

Props Mte90, johnbillion, dipesh.kakadiya, jipmoors, bamadesigner, dd32, johnjamesjacoby, xedin.unknown, flixos90, SergeyBiryukov.
Fixes #30991.

git-svn-id: https://develop.svn.wordpress.org/trunk@47357 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 12:48:11 +00:00
Sergey Biryukov
196859f90f Customize: When a menu item is removed from the menu, uncheck its source item on the available items panel.
Props donmhico, garrett-eclipse, audrasjb.
Fixes #46830.

git-svn-id: https://develop.svn.wordpress.org/trunk@47356 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 11:12:18 +00:00
Sergey Biryukov
f40c6c9ebe Script Loader: Remove unnecessary reference sign from function definitions in script loader.
This resolves PHP warnings when extensions like `php_uopz` or `php_tideways_xhprof` are in use.

Object variables in PHP 5+ contain a reference to the object, and it's the reference that's passed around.

Props jqz, killerbishop, Mte90, TJNowell, jorbin, pento, pcarvalho, valentinbora, SergeyBiryukov.
Fixes #44979.

git-svn-id: https://develop.svn.wordpress.org/trunk@47355 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 00:57:33 +00:00
Jorge Costa
bc3850c8dc Block Editor: Update WordPress Packages WordPress 5.4 Beta 3.
The following package versions were changed:
@wordpress/block-directory: 1.5.1 -> 1.5.2
@wordpress/block-editor: 3.7.1 -> 3.7.2
@wordpress/block-library: 2.14.1 -> 2.14.2
@wordpress/components: 9.2.1 -> 9.2.2
@wordpress/edit-post: 3.13.1 -> 3.13.2
@wordpress/editor: 9.12.1 -> 9.12.2
@wordpress/format-library: 1.14.1 -> 1.14.2
@wordpress/list-reusable-blocks: 1.13.1 -> 1.13.2
@wordpress/media-utils: 1.7.1 -> 1.7.2
@wordpress/nux: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.1 -> 1.8.2

Fixes #49506.

git-svn-id: https://develop.svn.wordpress.org/trunk@47354 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-25 00:16:12 +00:00
Sergey Biryukov
753ffe3968 Accessibility: Widgets: Restore missing string in script loader.
The string was previously added in [42794] and accidentally removed in [44163].

Props garrett-eclipse, audrasjb.
Fixes #49505.

git-svn-id: https://develop.svn.wordpress.org/trunk@47353 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-24 23:05:14 +00:00
Andrew Ozz
b2d243fbe6 Build Tools:
- Update the DependencyExtractionWebpackPlugin to 2.3.0 and set it to output a single assets file.
- Grunt: copy the assets file to both `SOURCE_DIR` and `BUILD_DIR` as `wp-includes/assets/script-loader-packages.php`.
- "Unignore" the `wp-includes/assets` directory. Its content will be committed similarly to `wp-includes/blocks`.
- Update `wp_default_packages_scripts()` to use the above file. This also removes the hard-coded lists of packages and packages with translations.

Props gziolo, pbearne, johnbillion, isabel_brison, ocean90, azaozz.
Fixes #48154.

git-svn-id: https://develop.svn.wordpress.org/trunk@47352 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-24 21:20:49 +00:00
K. Adam White
4e18f78ced REST API: Fix namespace shadowing issue in route matching logic.
Following [47260] a namespace such as "test-ns" prevents any namespace such as "test-ns/v1" from being found when matching routes.
While not best practice, this was an unintentional back-compat break; this patch restores the original behavior.

Props david.binda, TimothyBlynJacobs.
Fixes #48530.



git-svn-id: https://develop.svn.wordpress.org/trunk@47351 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-24 18:05:12 +00:00
Sergey Biryukov
74baee2f19 Menus: Introduce wp_nav_menu_item_custom_fields_customize_template action that fires at the end of the form field template for nav menu items in the customizer.
This brings parity with the `wp_nav_menu_item_custom_fields` action added in [47190] for the Menus screen.

Props celloexpressions.
Fixes #47056.

git-svn-id: https://develop.svn.wordpress.org/trunk@47350 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-24 14:56:42 +00:00
Sergey Biryukov
c2316edc3a Coding Standards: Add missing braces to if conditions and use strict comparison in js/_enqueues/wp/media/editor.js.
Props ankitmaru.
Fixes #49317.

git-svn-id: https://develop.svn.wordpress.org/trunk@47349 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-23 08:56:44 +00:00
Sergey Biryukov
2f10289ffb Docs: Use third-person singular verbs for function descriptions in wp-includes/option.php, per the documentation standards.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47347 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-23 01:05:28 +00:00
Sergey Biryukov
84764d4cee Docs: Add a @staticvar entry for $transports in WP_Http::_dispatch_request().
Props utsav72640.
Fixes #48774.

git-svn-id: https://develop.svn.wordpress.org/trunk@47346 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-22 19:10:47 +00:00
Sergey Biryukov
af57dcb03e I18N: Replace .htaccess with placeholders in the strings for Site Health custom rules check.
Props ramiy.
Fixes #48864.

git-svn-id: https://develop.svn.wordpress.org/trunk@47345 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-22 18:54:09 +00:00
Sergey Biryukov
74908c06bf I18N: Use a consistent wording for "Unable to write to file" strings.
Props ramiy.
Fixes #48862.

git-svn-id: https://develop.svn.wordpress.org/trunk@47344 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-22 18:31:39 +00:00
Adam Silverstein
8793357dfa Comments: improve styling on mobile for comments marked as spam.
Correct an issue where comments marked as spam in a mobile view displayed incorrectly, filling a narrow and very tall column with the notice that a comment was marked as spam. 

Props jeremyfelt, lorenzof, mukesh27, razamalik, xkon.
Fixes #48814.



git-svn-id: https://develop.svn.wordpress.org/trunk@47340 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-21 17:02:18 +00:00
Ian Belanger
bb6b0cdaa5 Bundled Themes: Twenty Nineteen text color setting in pullquote block not applied.
Fixes the pullquote color setting by adding classes that are more specific to the color options.

Props ianbelanger.
Fixes #49410.

git-svn-id: https://develop.svn.wordpress.org/trunk@47339 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-21 14:57:12 +00:00
Sergey Biryukov
3ff0ef5030 I18N: Replace upload_max_filesize, php.ini, MAX_FILE_SIZE with placeholders in upload error strings.
Props ramiy.
Fixes #48869.

git-svn-id: https://develop.svn.wordpress.org/trunk@47330 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-20 17:16:21 +00:00
Timothy Jacobs
8a62f46beb REST API: Don't assume all item schemas have properties.
All schema types, not just objects, are permitted as the base type of a resource. A future patch could add validation support for those types, but this fix only prevents a PHP warning from being issued.

Props dhavalkasvala, johnwatkins0, birgire.
Fixes #48785.


git-svn-id: https://develop.svn.wordpress.org/trunk@47328 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-20 16:56:17 +00:00
Ian Belanger
6194b3c5d2 Bundled Themes: Twenty Nineteen Update margins in editor styles to address upcoming block editor margin changes.
Fixes the margins in the block editor to address recent changes in block margins.

Props Joen, SergeyBiryukov, kjellr, jffng, allancole.
Fixes #48526.

git-svn-id: https://develop.svn.wordpress.org/trunk@47327 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-20 16:38:38 +00:00
Timothy Jacobs
be371a7431 REST API: Fix links format in OPTIONS requests for non-variable routes.
Props nsundberg, johnwatkins0, birgire.
Fixes #49149.


git-svn-id: https://develop.svn.wordpress.org/trunk@47326 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-20 00:53:43 +00:00
Timothy Jacobs
727faabe98 REST API: Warn if registering array settings without an items schema.
The documentation for register_setting has also been clarified to include all of the supported types and the flexibility of the show_in_rest parameter.

Fixes #42875.
Props perrywagle, dshanske, kadamwhite.


git-svn-id: https://develop.svn.wordpress.org/trunk@47325 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-19 22:54:03 +00:00
Sergey Biryukov
5f26580730 Docs: Add missing quote to {@see 'comment_$old_status_to_$new_status'} hook reference in wp_transition_comment_status() DocBlock.
Props coffee2code.
Fixes #49474.

git-svn-id: https://develop.svn.wordpress.org/trunk@47324 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-19 13:43:16 +00:00
Sergey Biryukov
2d73050eda Posts, Post Types: Discard tags_input parameter in wp_update_post() if it's the same as existing post tags.
This ensures that `wp_update_post()` does not unintentionally modify post tags if the post has several tags with the same name but different slugs.

Tags should only be modified if `tags_input` parameter was explicitly provided, and is different from the existing tags.

Props kaggdesign, SergeyBiryukov.
Fixes #45121.

git-svn-id: https://develop.svn.wordpress.org/trunk@47317 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-19 03:50:38 +00:00
Tammie Lister
6930542657 Bump version number to beta 2-47310
git-svn-id: https://develop.svn.wordpress.org/trunk@47310 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-18 21:27:31 +00:00
Tammie Lister
bc0847e8bd Bump version number to beta 2
git-svn-id: https://develop.svn.wordpress.org/trunk@47309 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-18 21:09:56 +00:00
Jonathan Desrosiers
9f87034879 Widgets: Revert [47307].
Even though the source URL for an attachment is stored in a variable, attachments should still be passed through the `wp_video_shortcode()` function.

Unprops desrosj, spacedmonkey.
See #46718.

git-svn-id: https://develop.svn.wordpress.org/trunk@47308 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-18 18:17:53 +00:00
Jonathan Desrosiers
0d7a5f949d Widgets: Remove unnecessary redundant conditional.
Props spacedmonkey.
Fixes #46718.

git-svn-id: https://develop.svn.wordpress.org/trunk@47307 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-18 17:50:54 +00:00
Jonathan Desrosiers
b797e91541 Site Health: Display the REST API test error codes correctly.
This change fixes an issue where the error codes associated with failed REST API tests are not being printed to the screen. In addition, the square brackets have been replaced with parentheses for consistency, and the error code (which is much less useful to end-users than the error message itself) has been moved to the end of the line.

This also clarifies the associated translator comments.

Props afercia, desrosj.
Fixes #49426.

git-svn-id: https://develop.svn.wordpress.org/trunk@47306 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-18 16:46:11 +00:00
Sergey Biryukov
6234fd90c2 Theme Editor: Disable CodeMirror CSS linting.
Being a good idea in theory, in practice it does not always work reliably, may not recognize newer CSS properties, and sometimes displays phantom errors with no particular error message.

A plugin can re-enable CSS linting via the `wp_code_editor_settings` filter.

Props skypressatx, ThemeZee, johnbillion, ianbelanger, ZanderZ, starvoters1, raoulunger, prashantvatsh, SergeyBiryukov.
Fixes #44471.

git-svn-id: https://develop.svn.wordpress.org/trunk@47305 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-18 15:49:08 +00:00
Andrea Fercia
5133f6b779 Accessibility: Improve readability by removing unnecessary italic font style.
Per Web Content Accessibility Guidelines 2.0, big chunks of italic text should be avoided.
Same applies to UI controls, since they're meant to be comfortably readable by the largest possible audience, e.g.: label elements.

Removes italic font style from:
- the Quick Edit / Bulk Edit forms
- the Recovery Mode plugin error details
- the Image Editor inline help

Props birgire, audrasjb, SergeyBiryukov, melchoyce, estelaris, sabernhardt, xkon, nrqsnchz, afercia.
See #47327.


git-svn-id: https://develop.svn.wordpress.org/trunk@47304 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-18 15:30:10 +00:00
Sergey Biryukov
002bfea745 Site Health: Prevent the Site Health Status dashboard widget from loading on network admin screen for now.
Props Clorith, pbiron.
See #47606, #47085.

git-svn-id: https://develop.svn.wordpress.org/trunk@47300 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-17 09:58:00 +00:00
Sergey Biryukov
9ac7fca92b Users: Limit the scope of admin files required in WP_REST_Users_Controller.
This requires only `wp-admin/includes/user.php` for `get_editable_roles()`, instead of `wp-admin/includes/admin.php`.

Follow-up to [43589].

Props johnwatkins0.
Fixes #49450.

git-svn-id: https://develop.svn.wordpress.org/trunk@47299 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-17 05:31:18 +00:00
Sergey Biryukov
b8993b72bd Docs: Improve inline comments for require_once calls in WP_REST_Users_Controller per the documentation standards.
Follow-up to [47295].

See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47298 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-17 03:54:11 +00:00
Sergey Biryukov
7d8b92ede9 Docs: Fix typo in a comment in WP_REST_Attachments_Controller::create_item().
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47297 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-17 03:28:05 +00:00
Sergey Biryukov
2d9f3a1330 REST API: Restore wp-admin/includes/image.php requirement in WP_REST_Attachments_Controller::create_item().
Although the file is already included via the `::insert_attachment()` method, this addresses an inconsistency and corrects a misleading comment.

It also reduces the possibility of a future error in case `::insert_attachment()` is no longer called earlier in `::create_item()` at some point.

Follow-up to [43850] and [44206].

Props luisrivera.
Fixes #49449.

git-svn-id: https://develop.svn.wordpress.org/trunk@47296 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-17 03:22:43 +00:00
Sergey Biryukov
f8d1664544 Docs: Improve inline comments for require_once() calls in WP_REST_Attachments_Controller.
See #49449, #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47295 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-17 03:11:50 +00:00
Sergey Biryukov
96f845d1a7 Menus: Restore the title of the currently active/expanded menu item when clicking "Cancel" after editing.
Other inputs are already restored to their previous values in that case.

Props Girishpanchal, nilamacharya, JoshuaWold, welcher, SergeyBiryukov.
Fixes #43031.

git-svn-id: https://develop.svn.wordpress.org/trunk@47294 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-16 06:25:54 +00:00
Sergey Biryukov
0e52a4efc1 Themes: Correct the height of theme actions button container on various screen sizes.
Props aftabmuni, alexischenal, ideaboxcreations, audrasjb, SergeyBiryukov.
Fixes #49302.

git-svn-id: https://develop.svn.wordpress.org/trunk@47293 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-15 05:06:39 +00:00
Sergey Biryukov
45e02b9026 Widgets: Hide the "Align" legend in Image Widget display settings, since the associated controls are also hidden.
Props audrasjb, fotisps, marcelo2605.
Fixes #48931.

git-svn-id: https://develop.svn.wordpress.org/trunk@47292 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-15 02:48:28 +00:00
Sergey Biryukov
ae82bd40cc Administration: Allow wp_update_link() to update the link_owner field, for consistency with other link fields.
Props pbiron, valentinbora, nikhilgupte.
Fixes #41687.

git-svn-id: https://develop.svn.wordpress.org/trunk@47291 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-15 01:53:22 +00:00
Sergey Biryukov
1911d0db67 Administration: Correct alignment of form controls inside custom meta boxes.
Props audrasjb, dontdream, valentinbora.
Fixes #49013.

git-svn-id: https://develop.svn.wordpress.org/trunk@47289 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-14 00:50:42 +00:00
Sergey Biryukov
543944257c Coding Standards: Rename $d parameter in various date/time functions to $format for clarity.
See #49222.

git-svn-id: https://develop.svn.wordpress.org/trunk@47287 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-14 00:05:43 +00:00
Sergey Biryukov
a41b2d93d3 Docs: Update @return tag for wp_allow_comment() with trash as a possible return value.
Props oakesjosh, jeremyfelt.
Fixes #49206.

git-svn-id: https://develop.svn.wordpress.org/trunk@47286 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-13 17:48:50 +00:00
Sergey Biryukov
3dd39ffece General: Update Michel Valdrighi's website in license.txt.
Props sebastienserre.
Fixes #49130.

git-svn-id: https://develop.svn.wordpress.org/trunk@47285 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-12 11:52:11 +00:00
Sergey Biryukov
58efcbdcd6 Privacy: Only show the Privacy Policy page notice when editing the page, not on drafts list.
Props chetan200891, xkon, garrett-eclipse.
Fixes #48431.

git-svn-id: https://develop.svn.wordpress.org/trunk@47284 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-12 11:42:23 +00:00
Sergey Biryukov
a6d078c228 Privacy: Improve the appearance of privacy request email inputs on mobile.
Props garrett-eclipse, xkon.
Fixes #48189.

git-svn-id: https://develop.svn.wordpress.org/trunk@47283 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-12 11:27:27 +00:00
Jorge Costa
20849f39b4 Post WordPress 5.4 Beta 1 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@47282 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 22:44:50 +00:00
Jorge Costa
f9fe81df19 WordPress 5.4 Beta 1.
git-svn-id: https://develop.svn.wordpress.org/trunk@47281 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 22:18:40 +00:00
Sergey Biryukov
f97a60c9b7 Privacy: Revert [47269] for now to address side effects on Multisite installations.
See #44176.

git-svn-id: https://develop.svn.wordpress.org/trunk@47280 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 21:46:54 +00:00
Sergey Biryukov
1106d82f93 Privacy: Introduce filters for the headers of all the privacy-related e-mails:
* `wp_privacy_personal_data_email_headers`
* `user_request_confirmed_email_headers`
* `user_erasure_complete_email_headers`
* `user_request_action_email_headers`

Props xkon, garrett-eclipse, zaffarn, desrosj.
Fixes #44501.

git-svn-id: https://develop.svn.wordpress.org/trunk@47279 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 21:41:26 +00:00
Sergey Biryukov
b8e935b2f2 Privacy: Add a table of contents to Personal Data Export report for easier navigation.
Props xkon, garrett-eclipse, birgire, karmatosed.
Fixes #46894.

git-svn-id: https://develop.svn.wordpress.org/trunk@47278 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 21:26:25 +00:00
Sergey Biryukov
d6352c544b Coding Standards: Use a strict in_array() check for reserved names of user data items in wp_user_personal_data_exporter().
Props azaozz.
Fixes #47509.

git-svn-id: https://develop.svn.wordpress.org/trunk@47277 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 20:53:40 +00:00
Sergey Biryukov
4020493d45 Comments: Add a $post_id parameter to get_comments_number_text() and comments_number().
This allow for using these functions outside of the loop.

Props donmhico, garrett-eclipse, Hinjiriyo, imath.
Fixes #48772.

git-svn-id: https://develop.svn.wordpress.org/trunk@47276 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 20:39:12 +00:00
Jonathan Desrosiers
c83253c7f8 Upgrade/Install: Enable maintenance mode when plugins are auto-updated.
When an attempt is made to update an active plugin automatically, there is the potential currently for two negative scenarios:

- The plugin can be deactivated if the Plugins admin screen is loaded when the plugin update is incomplete, causing a PHP error.
- The WSOD protection could be triggered, sending a false alarm email to the site administrator.

By enabling maintenance mode before an active plugin update is attempted, these scenarios can be avoided.

This change implements the same approach as the `Theme_Upgrader` class of using the `upgrader_pre_install` and `upgrader_post_install` hooks to toggle maintenance mode.

Props desrosj, SergeyBiryukov.
Fixes #49400.

git-svn-id: https://develop.svn.wordpress.org/trunk@47275 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 20:12:52 +00:00
Andrew Ozz
896de1cba2 Media: Pass through the $unfiltered param to get_attached_file() in wp_get_original_image_path().
Props ianmjones, joemcgill, azaozz.
Fixes #48421.

git-svn-id: https://develop.svn.wordpress.org/trunk@47274 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 19:45:46 +00:00
Ian Belanger
e7382153fe Bundled Themes: Twenty Sixteen text color setting in pullquote block not applied.
Fixes the pullquote color setting by moving `color` from `blockquote p` to `blockquote`. Also adds the border-left to the front-end stylesheet to match the editor. Also adds styles for rtl pullquote.

Props kokkieh, desrosj, mukesh27, khushbu19, disillusia, aliveic, abrightclearweb, SergeyBiryukov.
Fixes #47019.

git-svn-id: https://develop.svn.wordpress.org/trunk@47273 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 19:36:56 +00:00
Sergey Biryukov
c7267a039f Export: Use correct context for the Posts label on the Export screen.
The string refers to the post type name specifically, not to a generic term to identify a publication on WordPress.

Props audrasjb, jdy68.
Fixes #49306.

git-svn-id: https://develop.svn.wordpress.org/trunk@47272 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 19:33:58 +00:00
Jorge Costa
e608cd21ac Upload: Fix Plugin and Theme upload form are misaligned.
This commit makes sure that when uploading a plugin or theme file, the Install Now button is correctly aligned, and the button does not drops to the next line if filename is long.

Props seedsca, SergeyBiryukov, audrasjb.
Fixes #48859.

git-svn-id: https://develop.svn.wordpress.org/trunk@47271 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 19:16:57 +00:00
Sergey Biryukov
0ad4121c91 Privacy: Introduce wp_privacy_additional_user_data filter to make it easier to include additional user meta in a personal data export.
Props pbiron, xkon, garrett-eclipse, azaozz.
Fixes #47509.

git-svn-id: https://develop.svn.wordpress.org/trunk@47270 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 18:57:51 +00:00
Sergey Biryukov
0911aecf36 Privacy: Un-map privacy capabilities to make them available to be assigned for custom roles:
* `erase_others_personal_data`
* `export_others_personal_data`
* `manage_privacy_options`

Previously mapped to `manage_options` or `manage_network` (on Multisite), these are now added to the Administrator role separately.

Additionally, `manage_privacy_options` is added to the Editor role.

Props garrett-eclipse, xkon, pbiron, desrosj, johnbillion, flixos90, juliobox, lakenh, Ov3rfly, ianatkins.
Fixes #44176.

git-svn-id: https://develop.svn.wordpress.org/trunk@47269 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 18:34:08 +00:00
Sergey Biryukov
49b145c23f Site Health: Adjust "Database username" and "Table prefix" strings for consistency with the same strings in wp-admin/setup-config.php.
Props ramiy.
Fixes #47043.

git-svn-id: https://develop.svn.wordpress.org/trunk@47268 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 16:46:10 +00:00
Sergey Biryukov
2599e1b4fb Customize: Avoid unnecessary get_theme_mod() call and premature escaping in get_header_video_url().
The result is still escaped with `esc_url_raw()` for retrieval, and with `esc_url()` for display in `the_header_video_url()`.

Props dlh, Tkama.
Fixes #40044.

git-svn-id: https://develop.svn.wordpress.org/trunk@47267 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 16:34:09 +00:00
Andrea Fercia
5866986d74 Media: Fix bottom spacing on various Media Modal elements for non-webkit browsers.
Implementation of bottom padding in overflow content differs across browsers. See https://github.com/w3c/csswg-drafts/issues/129. To make bottom spacing consistent across browsers there's the need for an alternate CSS method.
- uses a CSS `after` pseudo element or simply a bottom margin to reserve some bottom spacing
- removes a couple leftovers from [40428]
- fixes an annoying visual glitch where the media modal content is visible behind the bottom toolbar border

Props sabernhardt, afercia.
See #40152.
Fixes #48378.


git-svn-id: https://develop.svn.wordpress.org/trunk@47266 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 16:30:13 +00:00
K. Adam White
b6dcb779ed REST API: Introduce rest_{$this->post_type}_item_schema filter to enable manipulation of schema values.
register_rest_field can be used to add properties to a schema, but no mechanism existed to alter existing properties like "content".
Running the schema through this filter lets plugins append additional sub-properties to existing schema definitions.

Props luisherranz, TimothyBlynJacobs, swissspidy, westonruter, kadamwhite.
Fixes #47779.



git-svn-id: https://develop.svn.wordpress.org/trunk@47265 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 16:26:56 +00:00
Ian Belanger
72e7742446 Bundled Themes: Twenty Twenty property border-style is overwritten - coding standard.
Fixes coding standard violations in the classic editor stylesheets.

Props ankitmaru.
Fixes #49006.

git-svn-id: https://develop.svn.wordpress.org/trunk@47264 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 16:09:50 +00:00
Sergey Biryukov
f26d4d3735 Widgets: Prevent currently active wide widget controls from being partially covered by another widget's controls.
The currently active widget controls should always be displayed on top.

Props audrasjb, fervillz, rinkuyadav999, jaydeep23290, ashokrd2013, melchoyce, pento, westonruter, SergeyBiryukov.
Fixes #42001.

git-svn-id: https://develop.svn.wordpress.org/trunk@47263 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 15:24:47 +00:00
Anthony Burchell
08b3c1d123 Media: Reset aspect ratio constraints when width and height fields fail numeric validation.
Props TBschen, valentinbora.
Fixes #49073.


git-svn-id: https://develop.svn.wordpress.org/trunk@47262 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 04:38:55 +00:00
K. Adam White
886a02686b REST API: Allow meta to be set when creating a new media record via REST.
Props TimothyBlynJacobs, apermo.
Fixes #44567.


git-svn-id: https://develop.svn.wordpress.org/trunk@47261 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 03:37:17 +00:00
K. Adam White
fc434a0c77 REST API: Match REST API routes on namespace before performing regex checks.
Rule out groups of API endpoints by simple namespace string comparison to reduce the number of regex checks necessary when matching a route.

Props TimothyBlynJacobs.
Fixes #48530.


git-svn-id: https://develop.svn.wordpress.org/trunk@47260 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 03:20:05 +00:00
azaozz
3125c21cc4 Media: Improve wording for error message on failed post-processing of uploaded images.
Props eclev91, desrosj, antpb, azaozz.
Fixes #49280.

git-svn-id: https://develop.svn.wordpress.org/trunk@47259 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 03:18:02 +00:00
K. Adam White
d06637f9b5 REST API: List all core theme feature support details in /themes endpoint response.
Fully list which first-party core theme features are supported in the /themes endpoint response. This brings the REST API themes controller's response more in line with the output of get_theme_support().

Props adamboro, apieschel, koke, spacedmonkey, TimothyBlynJacobs.
See #49037.


git-svn-id: https://develop.svn.wordpress.org/trunk@47258 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 01:58:08 +00:00
Sergey Biryukov
b364e2a072 Media: Improve the preview of transparent images in Image widget by using CSS3 to show a checkered background.
Props bahia0019.
Fixes #49237.

git-svn-id: https://develop.svn.wordpress.org/trunk@47257 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 01:45:01 +00:00
Sergey Biryukov
d9c6c5eed9 Administration: Move .has-row-actions class in Recent Comments dashboard widget next to .dashboard-comment-wrap, for consistency.
Follow-up to [47255].

See #42938.

git-svn-id: https://develop.svn.wordpress.org/trunk@47256 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 01:19:55 +00:00
Sergey Biryukov
196fc7ab60 Administration: Remove a blank space in the Recent Comments dashboard widget if avatars are disabled on Discussion Settings screen.
Props Marius84, shital-patel, GaryJ, ianbelanger, sgastard, lgrev01, donmhico, garrett-eclipse, audrasjb, SergeyBiryukov.
Fixes #42938.

git-svn-id: https://develop.svn.wordpress.org/trunk@47255 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 01:15:31 +00:00
Sergey Biryukov
8650885f85 Site Health: Improve the wording for PHP update recommendations.
Props Clorith, grafruessel, sathyapulse, wpgurudev, garrett-eclipse, marybaum, xkon, SergeyBiryukov.
Fixes #48716.

git-svn-id: https://develop.svn.wordpress.org/trunk@47254 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 00:39:11 +00:00
Sergey Biryukov
22ca3c51a6 Comments: Improve the appearance of the Status box on Edit Comment screen.
This makes the box more consistent with the Publish meta box in classic editor.

Props birgire, nfmohit, melchoyce, afercia.
Fixes #43587.

git-svn-id: https://develop.svn.wordpress.org/trunk@47252 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-11 00:05:01 +00:00
Sergey Biryukov
45cb25d4f2 Media: In media_sideload_image(), store the original attachment URL in the _source_url post meta value.
Props dshanske, joemcgill, antpb.
Fixes #48164.

git-svn-id: https://develop.svn.wordpress.org/trunk@47251 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 23:45:50 +00:00
Jorge Costa
f558f5ff37 Block Editor: Update WordPress Packages; Remove navigation block; Add social links block
The following package versions were changed:
@wordpress/annotations: 1.11.0 -> 1.12.0
@wordpress/api-fetch: 3.10.0 -> 3.11.0
@wordpress/block-directory: 1.4.0 -> 1.5.0
@wordpress/block-editor: 3.6.0 -> 3.7.0
@wordpress/block-library: 2.13.0 -> 2.14.0
@wordpress/blocks: 6.11.0 -> 6.12.0
@wordpress/components: 9.1.0 -> 9.2.0
@wordpress/core-data: 2.11.0 -> 2.12.0
@wordpress/data: 4.13.0 -> 4.14.0
@wordpress/data-controls: 1.7.0 -> 1.8.0
@wordpress/e2e-test-utils: 4.2.0 -> 4.3.0
@wordpress/edit-post: 3.12.0 -> 3.13.0
@wordpress/editor: 9.11.0 -> 9.12.0
@wordpress/format-library: 1.13.0 -> 1.14.0
@wordpress/icons: 1.0.0 -> 1.1.0
@wordpress/keyboard-shortcuts: 1.0.0 -> 1.1.0
@wordpress/list-reusable-blocks: 1.12.0 -> 1.13.0
@wordpress/media-utils: 1.6.0 -> 1.7.0
@wordpress/notices: 1.12.0 -> 2.0.0
@wordpress/nux: 3.11.0 -> 3.12.0
@wordpress/plugins: 2.11.0 -> 2.12.0
@wordpress/primitives: 1.0.0 -> 1.1.0
@wordpress/rich-text: 3.11.0 -> 3.12.0
@wordpress/server-side-render: 1.7.0 -> 1.8.0
@wordpress/url: 2.10.0 -> 2.11.0
@wordpress/viewport: 2.12.0 -> 2.13.0
The navigation block inclusion was reverted.
The social links block was included.

Props gziolo, youknowriad, mcsf, noisysocks.
Fixes #49397.

git-svn-id: https://develop.svn.wordpress.org/trunk@47250 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 22:31:13 +00:00
Sergey Biryukov
de5d82fe52 Docs: Improve documentation for the $attr parameter of wp_get_attachment_image().
Props juanfra, Mte90, DrewAPicture, joemcgill, SergeyBiryukov.
Fixes #36661.

git-svn-id: https://develop.svn.wordpress.org/trunk@47249 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 22:01:49 +00:00
Sergey Biryukov
0c07311e95 Coding Standards: Fix JSHint issues in [47246].
See #44264.

git-svn-id: https://develop.svn.wordpress.org/trunk@47248 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 21:36:53 +00:00
Sergey Biryukov
7a7c3c60d9 Privacy: Convert buttons to links visually in Privacy Export/Erasure "Next Steps" column.
With a lot of export or erasure requests, the secondary buttons were becoming overwhelming when stacked on top of each other.

Props xkon, karmatosed.
Fixes #49323.

git-svn-id: https://develop.svn.wordpress.org/trunk@47247 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 21:13:08 +00:00
Sergey Biryukov
a6a02eaca7 Privacy: Give progress indication for export and erasure.
This adds a progress indicator for "Download Personal Data" and "Erase Personal Data" row actions, which can take a while with a lot of data.

Props garrett-eclipse, allendav, dominic_ks, xkon, karmatosed, birgire.
Fixes #44264.

git-svn-id: https://develop.svn.wordpress.org/trunk@47246 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 20:17:58 +00:00
Sergey Biryukov
c0c2fd3f63 Privacy: Rename wp_get_user_request_data() to wp_get_user_request() for clarity; deprecate the old function.
The function returns an instance of the `WP_User_Request` object itself, not its `$request_data` property.

Follow-up to [44606].

Props garrett-eclipse.
Fixes #46302.

git-svn-id: https://develop.svn.wordpress.org/trunk@47245 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 19:55:51 +00:00
Ian Belanger
d4475d552c Bundled Themes: Twenty Twenty post navigation links outside of the container.
Fixes a bug where the in-page pagination does not align within the inner container.

Props ataurr, audrasjb, mukesh27.
Fixes #48979.

git-svn-id: https://develop.svn.wordpress.org/trunk@47244 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 19:23:38 +00:00
Ian Belanger
a604bba1f7 Bundled Themes: Twenty Twenty add WhatsApp to the social icon menu.
This adds WhatsApp as an option in the social icon menu.

Props rryyaanndd, audrasjb.
Fixes #49098.

git-svn-id: https://develop.svn.wordpress.org/trunk@47243 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 19:10:21 +00:00
Sergey Biryukov
f160d6a765 Twenty Nineteen: Add the missing inc/helper-functions.php file.
Follow-up to [47214].

Props kjellr, jffng.
Fixes #45984.

git-svn-id: https://develop.svn.wordpress.org/trunk@47242 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 19:05:17 +00:00
Ian Belanger
d56903d331 Bundled Themes: Twenty Twenty Author Bio/Post Meta Width in Cover Template in Mobile.
Fixes a bug where the author bio and post meta have no left or right padding in smaller viewports.

Props JarretC.
Fixes #49254.

git-svn-id: https://develop.svn.wordpress.org/trunk@47241 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 18:23:29 +00:00
Jorge Costa
437ac63d76 Block Editor: Backport inclusion of new editor settings to the core.
This commit includes in the core settings for the gradients theme API stabilized in https://github.com/WordPress/gutenberg/pull/20107, and for the image sizes required for the latest posts feature image https://github.com/WordPress/gutenberg/pull/17151/.

Props: youknowriad, ryelle.
Fixes #49389.

git-svn-id: https://develop.svn.wordpress.org/trunk@47240 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 17:50:36 +00:00
Timothy Jacobs
e7399111b4 REST API: Add support for the REDIRECT_HTTP_AUTHORIZATION header.
Previously the REST API did not account for server configurations where the Authorization header must be added using ModRewrite. This caused major DUX issues when trying to use custom authentication mechanisms.

Fixes #47077.
Props dshanske, cklosows.


git-svn-id: https://develop.svn.wordpress.org/trunk@47239 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 16:06:58 +00:00
Andrew Duthie
2c795289c8 Script Loader: Add polyfill for window.URL, window.DOMRect.
Pending block editor revisions for WordPress 5.4 will make use of `window.URL` and `window.DOMRect`. These are not available in Internet Explorer (or pre-Chromium Edge for `DOMRect`) and must be polyfilled to avoid script errors.

The changes make use of the existing polyfill pattern, and existing `polyfill-library` dependency. The dependency is bumped to the latest version, since the previous version did not include the `DOMRect` polyfill.

Props jorgefilipecosta.
Fixes #49360.


git-svn-id: https://develop.svn.wordpress.org/trunk@47238 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 15:15:07 +00:00
Sergey Biryukov
5b0be97e7c Privacy: Include session tokens in Personal Data Export.
Session tokens contain an IP address and user agent.

Props garrett-eclipse, nickylimjj, lakenh, xkon, rconde.
Fixes #45889.

git-svn-id: https://develop.svn.wordpress.org/trunk@47237 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 05:42:52 +00:00
Sergey Biryukov
8fef1b28a9 Privacy: Include community-events-location user meta value in Personal Data Export.
The value is used by the WordPress Events and News widget to show relevant WP community events.

The location information may include an IP address, location description, and latitude/longitude coordinates.

Props garrett-eclipse, coreymckrill, xkon.
Fixes #43921.

git-svn-id: https://develop.svn.wordpress.org/trunk@47236 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 05:30:03 +00:00
Sergey Biryukov
d321144c67 Site Health: Move the warning about WP_DEBUG_LOG being publicly accessible from "critical issues" to "recommended improvements" if the error log is outside of the WordPress directory.
Props afragen, Clorith, miss_jwo, mikeschroder, kubiq, xkon.
Fixes #47985.

git-svn-id: https://develop.svn.wordpress.org/trunk@47235 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 05:14:18 +00:00
Sergey Biryukov
acb845d7ea Administration: Standardize "found in Trash" messages.
Props Presskopp, audrasjb.
Fixes #38669.

git-svn-id: https://develop.svn.wordpress.org/trunk@47234 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 04:56:01 +00:00
Sergey Biryukov
023d4b2796 Administration: Capitalize Trash consistently in various messages and comments.
When used as a noun referring to the "virtual" place, `Trash` should be capitalized.

Props garrett-eclipse, aandrewdixon, Presskopp.
Fixes #45317.

git-svn-id: https://develop.svn.wordpress.org/trunk@47233 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 04:10:09 +00:00
Sergey Biryukov
5302cd6514 Login and Registration: Clarify the message on "Lost Password" screen.
Props pbiron, Presskopp.
Fixes #49346.

git-svn-id: https://develop.svn.wordpress.org/trunk@47232 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 03:48:45 +00:00
Sergey Biryukov
924b49cf34 Docs: Add documentation for globals in wp-settings.php.
Props chinteshprajapati.
Fixes #46253.

git-svn-id: https://develop.svn.wordpress.org/trunk@47231 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 03:32:57 +00:00
Sergey Biryukov
c80af9030d Docs: Add descriptions for some globals:
* `$wp_version`
* `$wp_local_package`
* `$required_php_version`
* `$required_mysql_version`

See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47230 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 03:28:20 +00:00
Andrew Ozz
6fd606d236 Media: Ensure imgareaselect.js is not initialized twice for the same image. May happen when uploading an image into a post and then clicking on Edit Image.
Fixes #49262.

git-svn-id: https://develop.svn.wordpress.org/trunk@47229 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 02:52:12 +00:00
Sergey Biryukov
b39db8c898 Editor: Add unique classes to .post-attributes-label-wrapper paragraphs for easier JS or CSS targeting.
Props sathyapulse, sabernhardt, garrett-eclipse, noisysocks.
Fixes #44408.

git-svn-id: https://develop.svn.wordpress.org/trunk@47228 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 02:27:23 +00:00
Sergey Biryukov
dabec45a08 Import: Remove "Blogroll" import option (for links in OPML format) from the list of popular importer plugins.
Link Manager is disabled for new installations since WordPress 3.5, so core should not encourage importing links.

See #meta4706 for the corresponding WordPress.org API change.

Props Ipstenu, hareesh-pillai, DrewAPicture, nacin, karmatosed, dd32, garrett-eclipse.
Fixes #22994. See #21307.

git-svn-id: https://develop.svn.wordpress.org/trunk@47227 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 02:10:52 +00:00
Sergey Biryukov
37a83d5a95 Login and Registration: Use CSS animation instead of old JavaScript code for "shake" animation on login failure.
Props markjaquith, valentinbora.
Fixes #48490.

git-svn-id: https://develop.svn.wordpress.org/trunk@47226 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-10 01:50:33 +00:00
Timothy Jacobs
98e5dd52de REST API: Introduce selective link embedding.
Previously the _embed flag would embed all embeddable links in a response even if only a subset of the links were necessary. Now, a list of link relations can be passed in the _embed parameter to restrict the list of embedded objects.

Props rheinardkorf, adamsilverstein, jnylen0, cklosows, chrisvanpatten, TimothyBlynJacobs.
Fixes #39696.


git-svn-id: https://develop.svn.wordpress.org/trunk@47224 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-09 20:52:06 +00:00
Aaron Jorbin
c647007a82 General: Fix HTML for get_calendar()
The <tfoot> element was allowed to precede the <tbody> element in HTML 5. However, that was changed in HTML 5.1 and <tfoot> must now follow <tbody>.

This removes the tfooot and instead uses a nav element for navigation between months.

Fixes: #39763
Props: isabel_brison, Harry Milatz, audrasjb, abhijitrakas, SergeyBiryukov


git-svn-id: https://develop.svn.wordpress.org/trunk@47223 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-09 20:42:26 +00:00
Joe Dolson
1d7cdbeab7 Editor: Fix incorrect usage of ID attributes on custom fields.
Repeated containers used for custom fields have duplicate ID attributes. Duplicate IDs are incorrect HTML, and will also cause unexpected results when trying to manipulate using JS. Duplicate IDs are changed to matching classes; CSS & JS updated to match. 

Props jankimoradiya, audrasjb, donmhico, afercia.
Fixes #46964.


git-svn-id: https://develop.svn.wordpress.org/trunk@47222 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-09 19:39:54 +00:00
Joe Dolson
3fb063f705 Toolbar: Load toolbar in wp_body_open when available.
For accessibility, the visual appearance and source order should match. Moving the toolbar to load in the new hook `wp_body_open` (5.2) fixes a long-standing source order problem.

Props jankimoradiya, afercia, SergeyBiryukov, audrasjb, ocean90, xkon, dinhtungdu.
Fixes #47053.


git-svn-id: https://develop.svn.wordpress.org/trunk@47221 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-09 18:24:41 +00:00
Sergey Biryukov
8cbfdbaa09 Coding Standards: Correct the get_plugin_page_hook() check in wp-admin/admin.php.
The condition is meant to check for a non-empty string, however `get_plugin_page_hook()` can return null, in which case the strict check doesn't work as expected.

Follow-up to [47218].

See #48455, #49222.

git-svn-id: https://develop.svn.wordpress.org/trunk@47220 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-09 17:06:55 +00:00
Sergey Biryukov
130751cda3 Coding Standards: Use Yoda conditions where appropriate.
See #49222.

git-svn-id: https://develop.svn.wordpress.org/trunk@47219 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-09 16:52:28 +00:00
Sergey Biryukov
40ffe0ef06 Coding Standards: Use Yoda conditions in some wp-admin files.
Props subrataemfluence, marcio-zebedeu, bookdude13, 1naveengiri, alishankhan.
Fixes #44365, #48455.

git-svn-id: https://develop.svn.wordpress.org/trunk@47218 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-09 16:51:22 +00:00
Andrea Fercia
43fb40739d Accessibility: Media: Make the toolbar and inline uploader visual order always match the DOM order.
Depending on the specific media view, the media UI elements are placed in a
different visual order. This change makes sure their visual order always
matches the DOM order.

Propos syhc, audrasjb, afercia.
See #37188.
Fixes #48403.


git-svn-id: https://develop.svn.wordpress.org/trunk@47217 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-09 16:30:41 +00:00
Sergey Biryukov
734bf726d7 Embeds: Add support for TikTok.
Props audrasjb, jblz, peterwilsoncc, felipeloureirosantos.
Fixes #49083.

git-svn-id: https://develop.svn.wordpress.org/trunk@47216 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-09 04:53:29 +00:00
Sergey Biryukov
ca37df8027 Site Health: Only get MySQL server information in tests where it's actually needed.
This resolves an issue with plugins like HyperDB, which doesn't have a database connection until a query is made.

Props xkon, Otto42, Clorith.
See #47606.

git-svn-id: https://develop.svn.wordpress.org/trunk@47215 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-08 20:08:31 +00:00
Sergey Biryukov
95f3bdbaac Twenty Nineteen: Improve code organization in template-functions.php by moving helper functions into their own file.
These functions are moved to `inc/helper-functions.php`:

* `twentynineteen_can_show_post_thumbnail()`
* `twentynineteen_image_filters_enabled()`
* `twentynineteen_get_avatar_size()`
* `twentynineteen_is_comment_by_post_author()`
* `twentynineteen_get_discussion_data()`
* `twentynineteen_hsl_hex()`

Additionally, `twentynineteen_add_dropdown_icons()` is moved to `inc/icon-functions.php` to join `twentynineteen_nav_menu_social_icons()`.

Props akshayar, allancole, grapplerulrich.
Fixes #45984.

git-svn-id: https://develop.svn.wordpress.org/trunk@47214 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-08 12:59:44 +00:00
Sergey Biryukov
1f8531c753 Menus: When adding a label for special pages in wp_setup_nav_menu_item(), check if get_post_states() is available, to avoid fatal errors on front end.
Fixes #49374.

git-svn-id: https://develop.svn.wordpress.org/trunk@47213 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-08 12:47:33 +00:00
Sergey Biryukov
2aecc8f3e6 Tests: Add a basic test for wp() function.
Props pbearne, donmhico.
Fixes #48844.

git-svn-id: https://develop.svn.wordpress.org/trunk@47212 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-08 05:29:54 +00:00
Sergey Biryukov
11eb80e59e Menus: Use get_post_states() to denote special pages on the added menu item accordions.
Front Page, Posts Page, or Privacy Policy Page should now be marked as such on the added menu items.

Props garrett-eclipse.
Fixes #49374.

git-svn-id: https://develop.svn.wordpress.org/trunk@47211 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-07 23:44:22 +00:00
Sergey Biryukov
dce15b92d0 Docs: Improve description for the $editor_id parameter of wp_editor() and _WP_Editors::editor().
The restictions mentioned for the parameter value should be consistenct.

Props pbiron, SergeyBiryukov.
Fixes #49384.

git-svn-id: https://develop.svn.wordpress.org/trunk@47210 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-07 23:28:22 +00:00
Sergey Biryukov
23c2257935 Accessibility: Menus: Make tab panels in Add menu items section more accessible for keyboard users.
Props audrasjb, afercia.
Fixes #49211.

git-svn-id: https://develop.svn.wordpress.org/trunk@47209 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-07 21:36:59 +00:00
Sergey Biryukov
6c7f322c71 Accessibility: Customize: Improve focus styles for color picker and media upload button in Customizer.
Props audrasjb, timhavinga, afercia, karmatosed.
Fixes #48694.

git-svn-id: https://develop.svn.wordpress.org/trunk@47208 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-07 21:09:39 +00:00
Sergey Biryukov
f8b2ff1b53 Coding Standards: Adjust coding standards to always omit parentheses for include/require statements.
These are language constructs, not function calls, so the parentheses are unnecessary.

This updates the PHPCS configuration file the enforce the sniff until it is moved from the `WordPress-Extra` ruleset to the `WordPress-Core` ruleset upstream.

Follow-up to [47198].

Props desrosj, jrf, GaryJ.
Fixes #49376.

git-svn-id: https://develop.svn.wordpress.org/trunk@47207 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-07 19:14:29 +00:00
John Blackbourn
2ce61ea2d6 Posts, Post Types: Add a parameter to the post_locked_dialog action which contains a reference to the user who holds the lock.
Fixes #48443

git-svn-id: https://develop.svn.wordpress.org/trunk@47206 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-07 17:51:09 +00:00
John Blackbourn
c7caac7289 Taxonomy: Clarify the docs for the return values of the term_exists() function.
Props dotancohen, sathyapulse

Fixes #43345

git-svn-id: https://develop.svn.wordpress.org/trunk@47205 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-07 17:46:51 +00:00
John Blackbourn
1feff0de47 Script Loader: Fix a docblock so it points to the correct page on the developer reference.
Props joyously, pbiron

Fixes #48503

git-svn-id: https://develop.svn.wordpress.org/trunk@47204 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-07 17:40:29 +00:00
John Blackbourn
7efcf03d94 Posts, Post Types: Introduce a filter which allows the addition of __trashed suffixes on post slugs to be skipped.
Fixes #46433

git-svn-id: https://develop.svn.wordpress.org/trunk@47203 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-07 17:31:52 +00:00
Andrew Ozz
112649ea92 Media: Add link to the original image in the image properties if it was scaled or rotated after uploading.
Fixes #49290.

git-svn-id: https://develop.svn.wordpress.org/trunk@47202 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-07 05:11:45 +00:00
Jorge Costa
8640eaa96e Block Editor: Update WordPress Packages.
The following package versions were changed:
@wordpress/a11y: 2.6.0 -> 2.7.0
@wordpress/annotations: 1.10.0 -> 1.11.0
@wordpress/api-fetch: 3.9.0 -> 3.10.0
@wordpress/autop: 2.5.1 -> 2.6.0
@wordpress/blob: 2.6.0 -> 2.7.0
@wordpress/block-directory: 1.3.0 -> 1.4.0
@wordpress/block-editor: 3.5.0 -> 3.6.0
@wordpress/block-library: 2.12.0 -> 2.13.0
@wordpress/block-serialization-default-parser: 3.4.1 -> 3.5.0
@wordpress/blocks: 6.10.0 -> 6.11.0
@wordpress/components: 9.0.0 -> 9.1.0
@wordpress/compose: 3.10.0 -> 3.11.0
@wordpress/core-data: 2.10.0 -> 2.11.0
@wordpress/custom-templated-path-webpack-plugin: 1.5.0 -> 1.6.0
@wordpress/data: 4.12.0 -> 4.13.0
@wordpress/data-controls: 1.6.0 -> 1.7.0
@wordpress/date: 3.7.0 -> 3.8.0
@wordpress/dependency-extraction-webpack-plugin: 2.1.0 -> 2.2.0
@wordpress/deprecated: 2.6.1 -> 2.7.0
@wordpress/dom: 2.7.0 -> 2.8.0
@wordpress/dom-ready: 2.6.0 -> 2.7.0
@wordpress/e2e-test-utils: 4.1.0 -> 4.2.0
@wordpress/edit-post: 3.11.0 -> 3.12.0
@wordpress/editor: 9.10.0 -> 9.11.0
@wordpress/element: 2.10.0 -> 2.11.0
@wordpress/escape-html: 1.6.0 -> 1.7.0
@wordpress/format-library: 1.12.0 -> 1.13.0
@wordpress/hooks: 2.6.0 -> 2.7.0
@wordpress/html-entities: 2.5.0 -> 2.6.0
@wordpress/i18n: 3.8.0 -> 3.9.0
@wordpress/is-shallow-equal: 1.7.0 -> 1.8.0
@wordpress/keyboard-shortcuts: 0.2.0 -> 1.0.0
@wordpress/keycodes: 2.8.0 -> 2.9.0
@wordpress/library-export-default-webpack-plugin: 1.5.0 -> 1.6.0
@wordpress/list-reusable-blocks: 1.11.0 -> 1.12.0
@wordpress/media-utils: 1.5.0 -> 1.6.0
@wordpress/notices: 1.11.0 -> 1.12.0
@wordpress/nux: 3.10.0 -> 3.11.0
@wordpress/plugins: 2.10.0 -> 2.11.0
@wordpress/priority-queue: 1.4.0 -> 1.5.0
@wordpress/redux-routine: 3.6.2 -> 3.7.0
@wordpress/rich-text: 3.10.0 -> 3.11.0
@wordpress/scripts: 6.2.0 -> 7.0.0
@wordpress/server-side-render: 1.6.0 -> 1.7.0
@wordpress/shortcode: 2.5.0 -> 2.6.0
@wordpress/token-list: 1.8.0 -> 1.9.0
@wordpress/url: 2.9.0 -> 2.10.0
@wordpress/viewport: 2.11.0 -> 2.12.0
@wordpress/wordcount: 2.6.2 -> 2.7.0
Added these new packages:
@wordpress/warning
@wordpress/primitives
@wordpress/icons
Re-added keyboard-shortcuts to script loader removed by mistake on revision 47198.

Props gziolo, itsjonq, youknowriad, mcsf, andraganescu.
Fixes #49358.

git-svn-id: https://develop.svn.wordpress.org/trunk@47199 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-06 21:01:16 +00:00
Sergey Biryukov
e72fff9cef Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.
This avoids the performance overhead of the function call every time `dirname( __FILE__ )` was used instead of `__DIR__`.

This commit also includes:

* Removing unnecessary parentheses from `include`/`require` statements. These are language constructs, not function calls.
* Replacing `include` statements for several files with `require_once`, for consistency:
 * `wp-admin/admin-header.php`
 * `wp-admin/admin-footer.php`
 * `wp-includes/version.php`

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.

git-svn-id: https://develop.svn.wordpress.org/trunk@47198 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-06 06:31:22 +00:00
Sergey Biryukov
b02e49c2e8 Coding Standards: Move WP_Object_Cache to wp-includes/class-wp-object-cache.php.
This ensures the file containing the `WP_Object_Cache` class conforms to the coding standards.

For backward compatibility, the new file is included from `wp-includes/cache.php`.

Fixes #49373. See #49222.

git-svn-id: https://develop.svn.wordpress.org/trunk@47197 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-06 05:51:58 +00:00
Sergey Biryukov
011962fae0 Posts, Post Types: Add default menu_icon values for built-in post types.
This allows the icons to be retrieved via `get_post_type_object()`.

Props m.usama.masood, michael.ecklund, SergeyBiryukov.
Fixes #38844.

git-svn-id: https://develop.svn.wordpress.org/trunk@47196 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-05 22:38:11 +00:00
Sergey Biryukov
3d43f46907 Posts, Post Types: Change "Featured Image" post label to use sentence case: "Featured image".
This makes it more consistent with other UI elements in the block editor.

Props mcsf.
Fixes #49371.

git-svn-id: https://develop.svn.wordpress.org/trunk@47194 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-05 19:07:33 +00:00
Ian Belanger
90a8a6adf6 Bundled Themes: Twenty Twenty Menu rendering problem Unicode (Bangla).
Fixes a bug where certain words break on to a second line in the primary and footer menus, in certain languages.

Props smallprogrammers, Shital Patel, mukesh27, audrasjb.
Fixes #48970.

git-svn-id: https://develop.svn.wordpress.org/trunk@47192 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-05 15:00:40 +00:00
Sergey Biryukov
616e4ffb4e Posts, Post Types: Wrap text submitted via Quick Draft dashboard widget in the Paragraph block.
Props audrasjb, jeroenrotty.
Fixes #48120.

git-svn-id: https://develop.svn.wordpress.org/trunk@47191 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-05 08:08:37 +00:00
Sergey Biryukov
5a5c1924fd Menus: Introduce wp_nav_menu_item_custom_fields action that fires just before the move buttons of a nav menu item in the menu editor.
Props MikeSchinkel, birgire, sebastian.pisula, desrosj, helgatheviking.
Fixes #47056. See #38904, #18584.

git-svn-id: https://develop.svn.wordpress.org/trunk@47190 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-05 07:41:08 +00:00
Sergey Biryukov
f838035c8f Docs: Correct type for $item and $args parameters in Walker_Nav_Menu_Checklist and Walker_Nav_Menu_Edit to match the parent Walker_Nav_Menu` class.
Follow-up to [38559], [45537].

See #24587, #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47189 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-05 07:23:25 +00:00
Sergey Biryukov
95b89c599f Site Health: Improve focus style for accordion items on Site Health screens.
The new style is more consistent with other elements like `.wp-core-ui` buttons.

Props audrasjb, mensmaximus, afercia, melchoyce, Clorith.
Fixes #48578.

git-svn-id: https://develop.svn.wordpress.org/trunk@47188 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-05 06:41:13 +00:00
Sergey Biryukov
658ff7a581 Docs: Add a @since note for [47186].
See #48558.

git-svn-id: https://develop.svn.wordpress.org/trunk@47187 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-05 06:31:05 +00:00
Sergey Biryukov
e4d8eac50f Taxonomy: In register_taxonomy(), return the registered taxonomy object on success, for consistency with register_post_type().
Props krynes, SergeyBiryukov.
Fixes #48558.

git-svn-id: https://develop.svn.wordpress.org/trunk@47186 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-05 06:24:16 +00:00
Sergey Biryukov
1fa5058ef3 Docs: Clarify that is_page_template() accepts a template filename, not the Template Name file header.
Props mkaz.
Fixes #49362.

git-svn-id: https://develop.svn.wordpress.org/trunk@47182 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-05 03:12:14 +00:00
Sergey Biryukov
5e8563eb6b Posts, Post Types: Fail gracefully when checking whether a single post with an unregistered post status should be displayed in WP_Query::get_posts().
If the post status is not registered, assume it's not public, but still allow access to users with edit permissions (same as for a protected post status, e.g. `draft`), so that they could recover orphaned content.

Add unit tests.

Follow-up to [47178].

Props roytanck, SergeyBiryukov.
Fixes #48653.

git-svn-id: https://develop.svn.wordpress.org/trunk@47181 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-05 01:31:38 +00:00
Sergey Biryukov
5ada288488 Posts, Post Types: Revert [47179] pending test failures investigation.
See #48653.

git-svn-id: https://develop.svn.wordpress.org/trunk@47180 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-04 23:00:53 +00:00
Sergey Biryukov
9e5c22aa09 Posts, Post Types: Fail gracefully when checking whether the post should be displayed in WP_Query::get_posts() against unregistered post status.
If the post status is not registered, assume it's not public.

Follow-up to [47178].

Props roytanck.
See #48653.

git-svn-id: https://develop.svn.wordpress.org/trunk@47179 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-04 22:20:25 +00:00
Sergey Biryukov
6f15251aa4 Posts, Post Types: Fail gracefully when checking mapped cap against unregistered post status.
With `map_meta_cap` enabled for a post type, the `read_post` capability for posts with a public status is supposed to be mapped to the post type's `read` capability.

When a post is left in the database after the post status is no longer present, and WP does a `read_post` check against it, a PHP notice was thrown, and the cap check always failed.

As a more graceful fallback, the cap is now mapped onto `edit_others_posts`, which allows highly privileged users to be able to access orphaned content.

A `_doing_it_wrong()` notice is also added, so that developers and site administrators are aware that the cap mapping is failing in the absence of the registered post status.

Follow-up to [34091], which introduced a similar approach to checking mapped caps against an unregistered post type.

Props roytanck, SergeyBiryukov.
Fixes #48653.

git-svn-id: https://develop.svn.wordpress.org/trunk@47178 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-04 22:13:15 +00:00
Sergey Biryukov
0bfacbe3b2 Coding Standards: Fix WPCS issues in [47175].
See #49361.

git-svn-id: https://develop.svn.wordpress.org/trunk@47177 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-04 21:40:27 +00:00
Jorge Costa
4bcf9be615 Block Editor: Include navigation block server logic.
Core did not include the navigation block PHP files.
This commit fixes the issue referred, and now the navigation block is executed on the frontend. The block still does not work as expected and throws an error during frontend execution. That problem is going to be fixed on the next WordPress package update.
This commit adds the file as it is on the npm package used.

Props gziolo.
Fixes #49348.

git-svn-id: https://develop.svn.wordpress.org/trunk@47176 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-04 20:14:50 +00:00
Sergey Biryukov
664e5a7568 Users: Pass the $reassign parameter to the remove_user_from_blog action.
Props Tivus.
Fixes #49361.

git-svn-id: https://develop.svn.wordpress.org/trunk@47175 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-04 19:41:41 +00:00
Sergey Biryukov
8f3f181c4e Docs: Improve description for add_user_to_blog() and remove_user_from_blog() parameters.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47174 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-04 19:38:12 +00:00
Sergey Biryukov
2c8da49588 Users: In remove_user_from_blog():
* Change default value of the `$blog_id` parameter to match the documented type.
* Change the type of the `$reassign` parameter for consistency with `$user_id` and `$blog_id`.
* Add documentation for the return value.

See #49361.

git-svn-id: https://develop.svn.wordpress.org/trunk@47173 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-04 19:34:27 +00:00
Sergey Biryukov
e876090344 TinyMCE: Remove duplicate keys and strings from langs/wp-langs-en.js.
Props david.binda.
Fixes #49359.

git-svn-id: https://develop.svn.wordpress.org/trunk@47172 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-04 16:41:46 +00:00
Sergey Biryukov
b26b0ccf8c Database: Add ANSI to the list of incompatible SQL modes.
Starting with MySQL 5.7.5, the `ANSI` mode implies `ONLY_FULL_GROUP_BY`, which is already listed in `wpdb` as incompatible per [27072].

When `ANSI` is enabled on MySQL 5.7.5+, `ONLY_FULL_GROUP_BY` remains enabled even after being "unset" by `wpdb::set_sql_mode()`.

To prevent this, the `ANSI` mode should also be listed as incompatible. It is not enabled on default MySQL installations.

Props jnylen0.
Fixes #48377.

git-svn-id: https://develop.svn.wordpress.org/trunk@47171 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-04 01:12:53 +00:00
Sergey Biryukov
ec83cd08eb Docs: Improve documentation for WP_Dependencies, WP_Scripts, and WP_Styles methods.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47170 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-03 00:17:38 +00:00
Sergey Biryukov
dd48b7f757 Canonical: When removing trailing punctuation from query string arguments, match the whole query var name.
Props daveslaughter.
Fixes #49347.

git-svn-id: https://develop.svn.wordpress.org/trunk@47169 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-03 00:12:22 +00:00
Sergey Biryukov
3f050fcf63 Plugins: Remove obsolete plugin_slugs transient from WP_Plugins_List_Table::prepare_items().
The transient is only used in the `wp_dashboard_plugins_output()` function, which is deprecated and unused since [40607].

The function itself also sets the same transient, so it can be removed from `WP_Plugins_List_Table`.

Props aftabmuni.
Fixes #49340.

git-svn-id: https://develop.svn.wordpress.org/trunk@47167 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-02 15:48:37 +00:00
Sergey Biryukov
78029013d8 REST API: Merge "not allowed to create new terms" permission error message with an existing string.
Follow-up to [39309], [39313].

See #38857.

git-svn-id: https://develop.svn.wordpress.org/trunk@47166 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-02 05:39:29 +00:00
Sergey Biryukov
4e6674c48c Docs: Fix typo in a comment with WP_DEBUG_DISPLAY description.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47165 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-02 05:32:35 +00:00
Sergey Biryukov
706daca6a3 Editor: Remove back-compat stub for Classic Editor's old distraction-free writing mode.
The original script was deprecated in [30338] and removed in [32677].

Props Presskopp, ketuchetan.
Fixes #39448.

git-svn-id: https://develop.svn.wordpress.org/trunk@47164 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-02 04:13:25 +00:00
Sergey Biryukov
73e75195eb Docs: Add more specific description for WP_Http::processResponse() return value.
Props marekdedic, takeshifurusato.
Fixes #48351.

git-svn-id: https://develop.svn.wordpress.org/trunk@47161 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-02 03:25:57 +00:00
Sergey Biryukov
fd3083e3f5 Post Thumbnails: Make sure get_post_thumbnail_id() returns an integer, to match the documented return value.
This makes the function more consistent with `get_the_ID()` or `wp_get_post_parent_id()`, both returning an integer.

Props 0v3rth3d4wn.
Fixes #40096.

git-svn-id: https://develop.svn.wordpress.org/trunk@47160 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-02 03:06:31 +00:00
Sergey Biryukov
139fe26f1f Docs: Improve inline comments in wp-admin/options.php per the documentation standards.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47159 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-02 02:40:50 +00:00
Sergey Biryukov
84f0321f42 Administration: Include options page name in the "Options page not found" error message to provide better context for plugin developers.
Props tdlewis77, williampatton.
Fixes #42941.

git-svn-id: https://develop.svn.wordpress.org/trunk@47158 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-01 22:40:06 +00:00
Sergey Biryukov
5e11891a05 Docs: Correct DocBlock formatting for register_setting().
Document the full list of whitelisted option key names.

See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47157 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-01 21:59:14 +00:00
Sergey Biryukov
54c6311c96 Accessibility: Text Changes: Use sentence case for the word Error in various error messages, instead of all caps.
Using all caps should be avoided for better readability and because screen readers may pronounce all-caps words as abbreviations.

Props afercia, ryokuhi, sabernhardt, garrett-eclipse.
See #47656, #43037, #42945.

git-svn-id: https://develop.svn.wordpress.org/trunk@47156 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-01 21:36:44 +00:00
Sergey Biryukov
b3da2c99a1 Text Changes: Capitalize error messages consistently.
Props Presskopp.
Fixes #42945.

git-svn-id: https://develop.svn.wordpress.org/trunk@47154 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-01 20:53:14 +00:00
Sergey Biryukov
db8a038541 Text Changes: Add missing periods to some error messages, for consistency.
Props Presskopp.
Fixes #42735.

git-svn-id: https://develop.svn.wordpress.org/trunk@47153 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-01 20:30:20 +00:00
Sergey Biryukov
9e8a7292c1 Text Changes: Add missing periods to comment status update notices, for consistency.
Props Presskopp.
See #42735.

git-svn-id: https://develop.svn.wordpress.org/trunk@47152 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-01 20:27:28 +00:00
Sergey Biryukov
3b2ba4c2b4 Networks and Sites: Reduce max-width for user and site search inputs on Dashboard screen in Network Admin.
This ensures that the inputs don't push the buttons to the next line.

Props williampatton, bordoni.
Fixes #49043.

git-svn-id: https://develop.svn.wordpress.org/trunk@47151 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-01 17:36:35 +00:00
Sergey Biryukov
d4b892f022 Docs: Document the addition of $json_report_pathname parameter to the wp_privacy_personal_data_export_file_created action.
Follow-up to [47146].

Props xkon.
Fixes #49029.

git-svn-id: https://develop.svn.wordpress.org/trunk@47150 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-01 04:15:15 +00:00
Sergey Biryukov
637b6f5456 Site Health: Rename WP_Site_Health::initialize() introduced in [47063] to ::get_instance(), for clarity and consistency with other core classes.
Use `WP_Site_Health::get_instance()` where it's needed, instead of creating multiple instances of the class.

Props afercia, xkon, Clorith, SergeyBiryukov.
See #47606.

git-svn-id: https://develop.svn.wordpress.org/trunk@47149 602fd350-edb4-49c9-b593-d223f7449a82
2020-02-01 00:37:14 +00:00
Sergey Biryukov
f0b830e62c Privacy: Clarify bulk action labels for personal data export and removal requests.
Props garrett-eclipse, xkon, shariqkhan2012, websupporter, desrosj, JoshuaWold.
Fixes #44674.

git-svn-id: https://develop.svn.wordpress.org/trunk@47148 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-31 03:41:06 +00:00
Sergey Biryukov
df755ff8ac Accessibility: Privacy: Improve the readability of the suggested text in Privacy Policy Guide.
Per WCAG 2.0 guidelines, big chunks of italic text should be avoided for better accessibility.

Props birgire, sabernhardt, xkon, garrett-eclipse, melchoyce, karmatosed, afercia, jepperask, SergeyBiryukov.
Fixes #44621. See #47327.

git-svn-id: https://develop.svn.wordpress.org/trunk@47147 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-31 03:24:00 +00:00
Sergey Biryukov
b894d8665a Privacy: Introduce a JSON file into the personal data export.
The produced ZIP archive will now include an `export.json` file along with the current `index.html`.

Props xkon.
Fixes #49029. See #46424.

git-svn-id: https://develop.svn.wordpress.org/trunk@47146 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-31 01:34:17 +00:00
Sergey Biryukov
13a9ab716e Site Health: Add support for required WordPress and PHP versions to themes.
Follow-up to [45546] for plugins.

Props flixos90, afragen.
Fixes #44592. See #40934, #meta3718.

git-svn-id: https://develop.svn.wordpress.org/trunk@47145 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-31 01:15:32 +00:00
Sergey Biryukov
7192a8f562 Privacy: Remove user's email address from personal data export filename.
Use `wp_unique_filename()` to avoid potential collisions instead.

Props xkon, garrett-eclipse, donmhico, Ov3rfly, Clorith, allendav.
Fixes #44197.

git-svn-id: https://develop.svn.wordpress.org/trunk@47144 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-31 00:56:29 +00:00
Sergey Biryukov
8b5b3bb38c Administration: Add punctuation to "If you change this, we will send you an email" message on General Settings, Network Settings, and Profile screens.
Props kinjaldalwadi, donmhico.
Fixes #49235.

git-svn-id: https://develop.svn.wordpress.org/trunk@47143 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-31 00:26:37 +00:00
Sergey Biryukov
7d90de1772 Twenty Nineteen: Remove duplicate font-size property.
The theme does not use a `px` fallback for `rem` units anywhere else.

Follow-up to [47053] for Twenty Twenty.

See #49015.

git-svn-id: https://develop.svn.wordpress.org/trunk@47140 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-31 00:07:50 +00:00
Ian Belanger
df1c7771da Fixes PHPCS Introduced in [47135].
There was extra whitespace in the previous commit, this removes it.

See #48552

git-svn-id: https://develop.svn.wordpress.org/trunk@47139 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-30 21:53:48 +00:00
K. Adam White
547a08ee03 REST API: Reuse previously-generated embedded objects when building collection response.
Store each generated embedded object in a temporary cache when querying for linked resources so that repeated links to the same resource do not trigger repeated queries or processing.

Props TimothyBlynJacobs.
Fixes #48838.



git-svn-id: https://develop.svn.wordpress.org/trunk@47138 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-30 20:20:30 +00:00
Sergey Biryukov
10a5077524 Twenty Nineteen: Standardize the Required PHP and Tested Up To headers.
* Remove `WordPress` from `Requires at least` headers.
* Ensure the `Requires at least` and `Requires PHP` headers are present in the `style.css` file.

Follow-up to [46676], which updated `style-rtl.css`, but not `style.scss` or `style.css`.

See #48517.

git-svn-id: https://develop.svn.wordpress.org/trunk@47136 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-30 20:02:46 +00:00
Ian Belanger
b651a3cb9e Bundled Themes: Twenty Twenty add theme support for responsive embeds.
Adds the call to `responsive-embed` theme support in order to fix issues with facebook embeds not being responsive at certain screen widths.

Props williampatton, nielslange.
Fixes #48552.

git-svn-id: https://develop.svn.wordpress.org/trunk@47135 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-30 19:19:37 +00:00
Sergey Biryukov
a271f98952 Themes: Replace &mdash; with &ndash; as a separator between Monday and Friday in theme starter content.
The `ndash` standardly is the "through" indicator for showing inclusive dates and numbers, while the `mdash` is an interruptor and used as an aside.

Props mikejdent, garrett-eclipse.
Fixes #48286.

git-svn-id: https://develop.svn.wordpress.org/trunk@47134 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-30 19:15:19 +00:00
Ian Belanger
363c862b66 Bundled Themes: Twenty Twenty content font CSS selector is too important.
This makes the font family selector for `entry-content` less specific and thus easier to override.

Props alexandreb3, larrach, audrasjb.
Fixes #49318.

git-svn-id: https://develop.svn.wordpress.org/trunk@47133 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-30 18:26:22 +00:00
Sergey Biryukov
b30baca3ca Dashboard: Improve the appearance of "WordPress Events and News" dashboard widget for multi-day events.
If an upcoming event spans over several days, this information is now properly reflected in the widget.

Props imath, casiepa, iandunn, hareesh-pillai, melchoyce, mapk, desrosj, audrasjb, SergeyBiryukov.
Fixes #47798.

git-svn-id: https://develop.svn.wordpress.org/trunk@47124 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-29 02:17:41 +00:00
Sergey Biryukov
7e521e68dc Docs: Fix typos in wp-admin/includes/class-pclzip.php.
With the upstream library not updated in 10 years since the last time it was merged, it should be safe to treat it as "adopted" rather than external, and make these fixes.

Props passoniate, ottok.
Fixes #49163. See #38464.

git-svn-id: https://develop.svn.wordpress.org/trunk@47123 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-29 00:54:21 +00:00
Sergey Biryukov
cfc3b57488 Docs: Improve inline comments per the documentation standards.
Includes minor code layout fixes for better readability.

See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47122 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-29 00:43:23 +00:00
Sergey Biryukov
c9663d78cf Docs: Improve comments in js/_enqueues/wp/revisions.js per the documentation standards.
Props passoniate.
Fixes #49177.

git-svn-id: https://develop.svn.wordpress.org/trunk@47120 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-29 00:35:39 +00:00
Sergey Biryukov
6bdc961d5f Docs: Improve comments in some wp-admin files per the documentation standards.
Follow-up to [47084].

Props passoniate, apedog.
Fixes #49223, #49227.

git-svn-id: https://develop.svn.wordpress.org/trunk@47119 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-29 00:33:45 +00:00
Sergey Biryukov
c1abc8203a Docs: Fix typo in a comment in js/media/models/attachment.js.
Props wptoolsdev.
Fixes #49303.

git-svn-id: https://develop.svn.wordpress.org/trunk@47117 602fd350-edb4-49c9-b593-d223f7449a82
2020-01-27 14:42:37 +00:00