sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
31,948 Commits 2 Branches 473 Tags 137 MiB
Commit Graph

8370 Commits

Author SHA1 Message Date
Scott Taylor 0d3da57a9a XML-RPC: `wp.getComments` should be allowed to return approved comments to those without the `'moderate_comments'` cap. 
Adds (rewrites) unit tests from 4 years ago that we never committed because....

Props wonderboymusic, koke, ericmann, nprasath002.
Fixes #17981.


git-svn-id: https://develop.svn.wordpress.org/trunk@34570 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-26 02:48:47 +00:00
Scott Taylor e09edc2d7f Comments: in `WP_Comment::get_children()`, accept an array so that the values for `format`, `status`, `hierarchical`, and `orderby` can be passed, instead of just `format`. The defaults for `get_comments()` include `status = 'all'` and `orderby = ''` - which is no bueno. 
For threaded comments, we need comments to be retrieved within bounds, so logged-out users don't see unmoderated comments on the front end, etc.

Updates unit tests.

See #8071.


git-svn-id: https://develop.svn.wordpress.org/trunk@34569 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-26 02:24:17 +00:00
John Blackbourn 1bb2876fe6 `callback` is not a valid type in PHP, PSR-5, or phpDocumentor. `callable` should be used instead. 
Fixes #34032


git-svn-id: https://develop.svn.wordpress.org/trunk@34566 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 23:57:46 +00:00
Drew Jaynes ea23f4603c Docs: Fix the syntax for a mid-file sectional comment in wp-admin/includes/dashboard.php. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34565 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 22:50:58 +00:00
Drew Jaynes 7a74f67964 Docs: Remove an inline comment duplicated by the DocBlock summary for `wp_dashboard_trigger_widget_control()`. 
Props tyxla.
Fixes #34014.


git-svn-id: https://develop.svn.wordpress.org/trunk@34564 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 22:49:02 +00:00
Weston Ruter 78b73c8906 Customizer: Defer embedding widget controls to improve DOM performance and initial load time. 
The Menu Customizer feature includes a performance technique whereby the controls for nav menu items are only embedded into the DOM once the containing menu section is expanded. This commit implements the same DOM deferral for widgets but goes a step further than just embedding the controls once the widget area's Customizer section is expanded: it also defers the embedding of the widget control's form until the widget is expanded, at which point the `widget-added` event also fires to allow any additional widget initialization to be done. The deferred DOM embedding can speed up initial load time by 10x or more. This DOM deferral also yields a reduction in overall memory usage in the browser process.

Includes changes to `wp_widget_control()` to facilitate separating out the widget form from the surrounding accordion container; also includes unit tests for this previously-untested function. Also included are initial QUnit tests (finally) for widgets in the Customizer.

Fixes #33901.


git-svn-id: https://develop.svn.wordpress.org/trunk@34563 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 21:01:46 +00:00
Boone Gorges 0604eff2e2 After [35461], remove 'page_comments' from database. 
* Don't set as part of initial schema.
* Delete as part of the `$unusedoptions` routine.

Props ocean90.
See #8071.

git-svn-id: https://develop.svn.wordpress.org/trunk@34562 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 20:49:47 +00:00
Boone Gorges 0b7e8399b0 Force comment pagination on single posts. 
Previously, the 'page_comments' toggle allowed users to disable comment
pagination. This toggle was only superficial, however. Even with
'page_comments' turned on, `comments_template()` loaded all of a post's
comments into memory, and passed them to `wp_list_comments()` and
`Walker_Comment`, the latter of which produced markup for only the
current page of comments. In other words, it was possible to enable
'page_comments', thereby showing only a subset of a post's comments on a given
page, but all comments continued to be loaded in the background. This technique
scaled poorly. Posts with hundreds or thousands of comments would load slowly,
or not at all, even when the 'comments_per_page' setting was set to a
reasonable number.

Recent changesets have addressed this problem through more efficient tree-
walking, better descendant caching, and more selective queries for top-level
post comments. The current changeset completes the project by addressing the
root issue: that loading a post causes all of its comments to be loaded too.

Here's the breakdown:

* Comment pagination is now forced. Setting 'page_comments' to false leads to evil things when you have many comments. If you want to avoid pagination, set 'comments_per_page' to something high.
* The 'page_comments' setting has been expunged from options-discussion.php, and from places in the codebase where it was referenced. For plugins relying on 'page_comments', we now force the value to `true` with a `pre_option` filter.
* `comments_template()` now queries for an appropriately small number of comments. Usually, this means the `comments_per_page` value.
* To preserve the current (odd) behavior for comment pagination links, some unholy hacks have been inserted into `comments_template()`. The ugliness is insulated in this function for backward compatibility and to minimize collateral damage. A side-effect is that, for certain settings of 'default_comments_page', up to 2x the value of `comments_per_page` might be fetched at a time.
* In support of these changes, a `$format` parameter has been added to `WP_Comment::get_children()`. This param allows you to request a flattened array of comment children, suitable for feeding into `Walker_Comment`.
* `WP_Query` loops are now informed about total available comment counts and comment pages by the `WP_Comment_Query` (`found_comments`, `max_num_pages`), instead of by `Walker_Comment`.

Aside from radical performance improvements in the case of a post with many
comments, this changeset fixes a bug that caused the first page of comments to
be partial (`found_comments` % `comments_per_page`), rather than the last, as
you'd expect.

Props boonebgorges, wonderboymusic.
Fixes #8071.

git-svn-id: https://develop.svn.wordpress.org/trunk@34561 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 20:39:18 +00:00
DrewAPicture 653ababa6f Docs: Improve the method docs for the `widget()`, `update()`, `form()`, and `__construct()` methods in the `WP_Widget` base class. 
See #34013. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34560 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 20:30:02 +00:00
Scott Taylor a9e30d8e94 XML-RPC: Introduce the concept of unit testing to `wp_xmlrpc_server::wp_newComment()`: 
* Don't allow comments to be created for posts that have `comment_status` set to `'closed'`
* Set some magic props on `WP_User` to vars before passing them to `wp_xmlrpc_server::escape()`

Props wonderboymusic, jesin.
Fixes #27471.


git-svn-id: https://develop.svn.wordpress.org/trunk@34559 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 20:19:19 +00:00
Weston Ruter 6db8b9279e Customizer: Fix usage of `jQuery.contains()` allowing `active` state changes to again animate control visibility. 
Aligns usage of `jQuery.contains()` in a control's `onChangeActive` method with the existing usage in the corresponding `onChangeActive` method for panels and sections.

Props nikeo.
Fixes #33509.


git-svn-id: https://develop.svn.wordpress.org/trunk@34557 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 19:54:00 +00:00
Helen Hou-Sandi 9490539e89 Shortlinks: Hide the Get Shortlink button by default. 
Shortlinks had their day in the popular usage sun before all these services moved to their own shorteners and running your own custom one became a lot easier. Shortlinks are still useful in some contexts, such as analytics or when links need to be shared verbally or copied down by hand.

If any filters are hooked onto `pre_get_shortlink` or `get_shortlink` and produce a non-empty value (with an exception described below), the button will magically reappear. This allows any custom shortlinks to keep the button without hiccups.

If you're in need of the default shortlinks, the fastest way to reenable them is `add_filter( 'pre_get_shortlink', '__return_false' )`. Note that it must return false in order to continue on to the rest of `wp_get_shortlink()`.

props grvrulz for the initial patch.
fixes #33495.


git-svn-id: https://develop.svn.wordpress.org/trunk@34556 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 19:53:28 +00:00
Weston Ruter 25c05ad6f2 Customizer: Flesh out phpdoc description for `_wp_customize_include()`. 
Also add brackets around single-statement inline `if` statement.

Fixes #33488.


git-svn-id: https://develop.svn.wordpress.org/trunk@34554 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 19:35:48 +00:00
Drew Jaynes 99e157bdd2 Docs: Add a missing summary, version, and tag descriptions to the DocBlock for `WP_Widget_Text::widget()`. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34553 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 19:23:18 +00:00
Drew Jaynes 5a6a34fa95 Widgets: Pass `$this` to the `widget_text` filter to make targeting specific widget instances easier. 
Also fixes docs errors in the type and description for the `$instance` parameter, introduced in [27697].

Fixes #24605.


git-svn-id: https://develop.svn.wordpress.org/trunk@34552 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 19:20:37 +00:00
John Blackbourn a6a00a3625 Implement 'Recently Active' functionality for network-wide plugins in the Network Admin. 
Fixes #20468
Thanks to WordCamp RI attendees for testing!


git-svn-id: https://develop.svn.wordpress.org/trunk@34551 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 19:15:08 +00:00
Boone Gorges 465ff41d1b Remove debug cruft, introduced in [34546]. 
Props ocean90.
See #8071.

git-svn-id: https://develop.svn.wordpress.org/trunk@34549 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 15:25:19 +00:00
Boone Gorges 92da083c00 Normalize whitespace in `WP_Comment_Query` documentation. 
git-svn-id: https://develop.svn.wordpress.org/trunk@34548 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 15:24:15 +00:00
Sergey Biryukov 3b9cb92c44 Plugin Editor: Don't split the strings with plugin file name and remove unnecessary context. 
Partially reverts [34341].

Fixes #31862.

git-svn-id: https://develop.svn.wordpress.org/trunk@34547 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 15:18:58 +00:00
Boone Gorges e1b44f5203 Introduce hierarchical query support to `WP_Comment_Query`. 
Comments can be threaded. Now your query can be threaded too! Bonus: it's
not totally insane.

* The new `$hierarchical` parameter for `WP_Comment_Query` accepts three values:
  * `false` - Default value, and equivalent to current behavior. No descendants are fetched for matched comments.
  * `'flat'` - `WP_Comment_Query` will fetch the descendant tree for each comment matched by the query paramaters, and append them to the flat array of comments returned. Use this when you have a separate routine for constructing the tree - for example, when passing a list of comments to a `Walker` object.
  * `'threaded'` - `WP_Comment_Query` will fetch the descendant tree for each comment, and return it in a tree structure located in the `children` property of the `WP_Comment` objects.
* `WP_Comment` now has a few utility methods for fetching the descendant tree (`get_children()`), fetching a single direct descendant comment (`get_child()`), and adding anothing `WP_Comment` object as a direct descendant (`add_child()`). Note that `add_child()` only modifies the comment object - it does not touch the database.

Props boonebgorges, wonderboymusic.
See #8071.

git-svn-id: https://develop.svn.wordpress.org/trunk@34546 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 15:12:09 +00:00
Boone Gorges 27558ed678 Improve status checks when sending comment post author notification. 
[34537] hooked `wp_new_comment_notify_postauthor()` to the
'wp_set_comment_status' when a comment had been approved. When performing
multiple actions on a comment in the same request (as happens in
`Tests_Ajax_DeleteComment::test_ajax_trash_double_action()`, and may happen
sometimes in real life too), and when one of those actions involves deleting
the comment, the `$comment_ID` passed to `wp_new_comment_notify_postauthor()`
can correspond to an already-deleted comment. The `comment_status` check should
account for this possibility.

See #14078.

git-svn-id: https://develop.svn.wordpress.org/trunk@34545 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 14:42:48 +00:00
Boone Gorges 8e955c4805 Improve pagination internals in `WP_Comment_Query`. 
`WP_Comment_Query` will now report the total number of comments matching the
query params (`comments_found`), as well as the total number of pages required
to display these comments (`max_num_pages`). Because `SQL_CALC_FOUND_ROWS`
queries can introduce a lot of overhead in some cases, we disable the feature
by default. Pass `no_found_rows=false` to `WP_Comment_Query` to enable the
count. (We use the negative parameter name 'no_found_rows' for parity with
`WP_Query`.)

Props wonderboymusic, boonebgorges.
See #8071.

git-svn-id: https://develop.svn.wordpress.org/trunk@34544 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 14:34:20 +00:00
John Blackbourn 03515ca82d Introduce a `send_update_notification_email` which controls whether an update notification email is sent for background updates. This filter allows control over each of the update types (plugin, theme, translation) and compliments the `automatic_updates_send_debug_email` and `send_core_update_notification_email` filters. 
Fixes #33932
Props ronalfy


git-svn-id: https://develop.svn.wordpress.org/trunk@34543 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 14:28:23 +00:00
Boone Gorges a453e6aa6f Store SQL clauses in `WP_Comment_Query` property. 
This small syntax change paves the way for some improvements related to #8071.

git-svn-id: https://develop.svn.wordpress.org/trunk@34542 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 14:08:50 +00:00
Scott Taylor c8f167629d Revisions: add a `'wp_prepare_revision_for_js'` filter. 
Props jtsternberg, adamsilverstein.
Fixes #28627.


git-svn-id: https://develop.svn.wordpress.org/trunk@34541 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 14:03:30 +00:00
Scott Taylor 5e95cd1db5 Profile: when clicking "Generate Password", toggling visibility, then canceling, ensure that the UI resets properly for when the "Generate Password" button is clicked again. 
Props umesh.nevase.
Fixes #33897.


git-svn-id: https://develop.svn.wordpress.org/trunk@34539 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 13:53:04 +00:00
Boone Gorges a160be35b1 Bust term query cache when modifying term meta. 
The 'last_changed' incrementor is used to invalidate the `get_terms()` query
cache. Since `get_terms()` queries may reference 'meta_query', changing term
metadata could change the results of the queries. So we invalidate the cache
on add, delete, and update.

See #10142.

git-svn-id: https://develop.svn.wordpress.org/trunk@34538 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 13:46:36 +00:00
Boone Gorges 3714a915a2 Send comment approval notification to post author via hook. 
This is part of the project of #33587.

Moving this particular message to the
'wp_set_comment_status' action has the added bonus that the notification is
sent after the comment status has been updated in the database. Previously, a
database error could lead to a case where an approval notification is sent,
but the comment status change fails for some reason.

Props mrmist, NickDuncan.
Fixes #14078.

git-svn-id: https://develop.svn.wordpress.org/trunk@34537 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 05:36:32 +00:00
Boone Gorges 93d781343a Introduce 'duplicate_comment_id' filter. 
`wp_allow_comment()` disallows a comment if it matches a comment on the same
post with the same content, author email, and parent. This new filter allows
developers to circumvent or modify this logic, making the duplicate check
more or less lenient, as they see fit.

Fixes #9775.

git-svn-id: https://develop.svn.wordpress.org/trunk@34536 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 05:22:53 +00:00
Boone Gorges 7e44a2fef7 Use `WP_Comment_Query` in `get_page_of_comment()`. 
This change allows `get_page_of_comment()` to use `WP_Comment_Query`'s native
caching mechanisms.

Props boonebgorges, Viper007Bond, wmertens, jeremyfelt.
Fixes #11334.

git-svn-id: https://develop.svn.wordpress.org/trunk@34535 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 05:10:40 +00:00
Boone Gorges 0c5bd75262 Pinking shears. 
git-svn-id: https://develop.svn.wordpress.org/trunk@34534 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 04:43:57 +00:00
Boone Gorges 4da03f3cfc Allow metadata to be attached to comment at time of creation. 
The new `$comment_meta` parameter of `wp_insert_comment()` allows an array of
key/value pairs to be passed when creating a comment. These pairs are then
stored as commentmeta when the comment has been created.

Props tellyworth, wonderboymusic.
Fixes #12431.

git-svn-id: https://develop.svn.wordpress.org/trunk@34533 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 04:40:30 +00:00
Boone Gorges 039955d5cd Introduce 'paged' parameter for `WP_User_Query`. 
This is an alternative to using 'offset', and manually calculating pagination.
Note that 'paged' works only in conjunction with 'number', the latter of which
provides the per-page value.

Props sebastian.pisula.
Fixes #25145.

git-svn-id: https://develop.svn.wordpress.org/trunk@34531 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 04:25:20 +00:00
Boone Gorges 7757f84a69 After [34529], normalize documentation for `get_terms()` and `wp_get_object_terms()`. 
See #10142.

git-svn-id: https://develop.svn.wordpress.org/trunk@34530 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 04:04:06 +00:00
Boone Gorges 3425177325 Introduce metadata for taxonomy terms. 
Adds a new table to the database schema (`wp_termmeta`), and a set of
`*_term_meta()` API functions. `get_terms()` and `wp_get_object_terms()`
now also support 'meta_query' parameters, with syntax identical to other
uses of `WP_Meta_Query`.

When fetching terms via `get_terms()` or `wp_get_object_terms()`, metadata for
matched terms is preloaded into the cache by default. Disable this behavior
by setting the new `$update_term_meta_cache` paramater to `false`.

To maximize performance, within `WP_Query` loops, the termmeta cache is *not*
primed by default. Instead, we use a lazy-loading technique: metadata for all
terms belonging to posts in the loop is loaded into the cache the first time
that `get_term_meta()` is called within the loop.

Props boonebgorges, sirzooro.
See #10142.

git-svn-id: https://develop.svn.wordpress.org/trunk@34529 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 03:58:59 +00:00
Scott Taylor a98ca8b314 Links: in `get_adjacent_post()`, add a `"get_{$adjacent}_post_excluded_terms"` filter. 
Props rmccue, Japh, MikeHansenMe.
Fixes #9571.


git-svn-id: https://develop.svn.wordpress.org/trunk@34528 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 02:37:29 +00:00
Scott Taylor 641150a87a Comments List Table: after [34179], scope the `<th>`s and `<td>`s as direct descendants of their parent row. 
Fixes #33943.


git-svn-id: https://develop.svn.wordpress.org/trunk@34527 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-25 02:20:11 +00:00
John Blackbourn 53c3cd897a Update the oEmbed endpoint URL for Photobucket. 
Fixes #33783


git-svn-id: https://develop.svn.wordpress.org/trunk@34526 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 22:02:16 +00:00
Scott Taylor 2300740fa2 Comments: In `comment_form()`, move the comment textarea to the top for logged-out users when replying, improves keyboard/focus navigation. 
Rehabilitate errant tabbing and extra unnecessary `<?php ?>` toggling.

Props afercia, adamsilverstein.
Fixes #29974.


git-svn-id: https://develop.svn.wordpress.org/trunk@34525 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 21:59:39 +00:00
Scott Taylor 3e46dd8b92 Comments: In `get_comment_statuses()`, also return `trash`. 
XML-RPC: In `wp_xmlrpc_server::wp_editComment()`, allow comments to be trashed.

Introduce unit tests for `wp_editComment` in `xmlrpc/*` #NeverForget

Props tyxla, wonderboymusic.
Fixes #30965.


git-svn-id: https://develop.svn.wordpress.org/trunk@34524 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 21:47:51 +00:00
Scott Taylor 15935e0aed Comments: in `comment_form()`, add args for `cancel_reply_before` and `cancel_reply_after` to eradicate remaining hard-coded HTML bits. 
Props MikeHansenMe.
Fixes #23797.



git-svn-id: https://develop.svn.wordpress.org/trunk@34523 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 21:32:03 +00:00
Scott Taylor 9b55d4fecb Comments: in `check_comment_flood_db()`, don't throttle moderators. If the commenter is logged in, check against their `user_id` instead of `comment_author_IP`. 
Throwback: "If you can edit comments on the post, 'Slow down Cowboy' shouldn't kick in."

Props garyc40, wonderboymusic.
Fixes #16219.


git-svn-id: https://develop.svn.wordpress.org/trunk@34522 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 21:21:16 +00:00
Dominik Schilling (ocean90) d1fbe56dfc Plugins: Don't use `_n()` for singular/plural strings which have no placeholder for a number. 
Fixes #33239.
See #28502.

git-svn-id: https://develop.svn.wordpress.org/trunk@34521 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 21:06:50 +00:00
Scott Taylor 55bb8b8c0b Comments: add a `'comment_excerpt_length'` filter to `get_comment_excerpt()`. 
Create the first ever unit tests for `get_comment_excerpt()`.

Props dannydehaan, wonderboymusic.
Fixes #27526.


git-svn-id: https://develop.svn.wordpress.org/trunk@34520 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 21:04:16 +00:00
Scott Taylor 5b5b714694 Comments List Table JS: move the dynamic count functions into closure scope so that `setCommentsList` AND `commentReply` can access them. Update counts when replying inline. 
Fixes #33403.


git-svn-id: https://develop.svn.wordpress.org/trunk@34517 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 20:15:54 +00:00
John Blackbourn 1e42aeb3c4 Add a `@since` entry for the implementation of the `$public` argument in `register_taxonomy()`. 
See #21949


git-svn-id: https://develop.svn.wordpress.org/trunk@34516 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 20:15:29 +00:00
Scott Taylor e1d433a233 Edit Post: in the logic determining whether to display the Comments meta box, check for the current post status in `get_post_stati( array( 'public' => true ) )` instead of just checking `publish` and `private`. Ensure that `private` is checked in both instances. 
Props Thaicloud, wonderboymusic.
Fixes #24486.


git-svn-id: https://develop.svn.wordpress.org/trunk@34515 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 20:01:55 +00:00
Scott Taylor 395fc15df3 Widgets: use `input[type="number"]` for the `number` prop in the Recent Posts and Recent Comments widget forms. 
Props helen, obenland, mordauk.
Fixes #22965.


git-svn-id: https://develop.svn.wordpress.org/trunk@34514 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 19:52:06 +00:00
John Blackbourn 075245d894 Convert the `$args` passed to `register_post_type()` into an array before passing them to the new `register_post_type_args` filter. 
Fixes #17447


git-svn-id: https://develop.svn.wordpress.org/trunk@34513 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 19:38:11 +00:00
Drew Jaynes 2703af7691 Docs: Clarify the summary and optional `$query` parameter description for `remove_query_arg()`. 
Props johnbillion.
Fixes #33912.


git-svn-id: https://develop.svn.wordpress.org/trunk@34512 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 19:33:07 +00:00
Drew Jaynes c406171d12 Docs: Overhaul the DocBlock for `add_query_arg()` to attempt to better explain the various call signatures it accepts. 
Also adds a couple of in-DocBlock examples illustrating single key and value, and associative array usage. Retains the note about the unescaped return value.

Props johnbillion.
See #33912.


git-svn-id: https://develop.svn.wordpress.org/trunk@34511 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 19:31:40 +00:00
Drew Jaynes a099621012 Docs: Convert the `$args` parameter description in the `register_taxonomy()` DocBlock to a hash notation. 
Also standardizes the DocBlock summary.

Props johnbillion.
Fixes #33991.


git-svn-id: https://develop.svn.wordpress.org/trunk@34510 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 19:11:53 +00:00
Drew Jaynes 45b8138b97 Docs: Improve the summary and description for the `pre_http_request` filter docs to better illustrate expected values. 
The filter explicitly expects one of three passed value types:

*  An array containing 'headers', 'body', 'response', 'cookies', and 'filename' elements
*  A `WP_Error` instance
*  Boolean false (to avoid short-circuiting the response)

Props johnbillion.
Fixes #33995.


git-svn-id: https://develop.svn.wordpress.org/trunk@34509 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 18:51:13 +00:00
Andrea Fercia 5852971d3c Comments List Table: fix the translators comment for all count after [34506]. 
See #17275.

git-svn-id: https://develop.svn.wordpress.org/trunk@34508 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 18:39:04 +00:00
John Blackbourn 133993389e Add `$depth` as a parameter in the `nav_menu_item_args` filter. 
Fixes #29417


git-svn-id: https://develop.svn.wordpress.org/trunk@34507 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 17:58:20 +00:00
Scott Taylor d7a59c4661 Comments List Table: include count for "All". Dynamically update. 
Fixes #17275.


git-svn-id: https://develop.svn.wordpress.org/trunk@34506 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 17:56:50 +00:00
John Blackbourn 3d97e9a53b Correctly present an error to the user if the nickname field is empty when updating a user profile. It's strange that this field is required, but it is, so be it. 
Fixes #33310
Props prasad-nevase, metodiew


git-svn-id: https://develop.svn.wordpress.org/trunk@34505 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 17:48:10 +00:00
Scott Taylor 821821c8b5 Comments: add `date` column to `WP_Comments_List_Table` to allow sorting and to break out the date/time from the comment content column. 
Props jshreve.
Fixes #15520.


git-svn-id: https://develop.svn.wordpress.org/trunk@34504 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 17:26:54 +00:00
Scott Taylor ba2842f326 Comments: In `comments_template()`, set `$wp_query->comments_by_type` to empty array if not separating comments. The value becomes stale otherwise. Edge case. 
Props jakub.tyrcha.
Fixes #14809.


git-svn-id: https://develop.svn.wordpress.org/trunk@34503 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 16:30:12 +00:00
Drew Jaynes 057ba76b2c Docs: Add more explicit optional parameter types and return descriptions in the DocBlocks for `is_page()`, `is_single()`, `is_singular()`. 
Also adds explicit types and return descriptions to the corresponding `WP_Query` methods: `WP_Query::is_page()`, `WP_Query::is_single()`, and `WP_Query::is_singular()`.

Props Shelob9 for the initial patch.
Fixes #33907.


git-svn-id: https://develop.svn.wordpress.org/trunk@34502 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 16:17:23 +00:00
Dominik Schilling (ocean90) 9d4d1a7572 Twenty Fifteen: Add a missing comma in rtl.css. 
Props Toro_Unit.
Fixes #33985.

git-svn-id: https://develop.svn.wordpress.org/trunk@34501 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 16:02:19 +00:00
Scott Taylor c0ebd3b5e2 Comments: update Comment counts dynamically in the Right Now widget based on moderation actions in the Activity widget. 
Fixes #10422.


git-svn-id: https://develop.svn.wordpress.org/trunk@34500 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 15:52:41 +00:00
Drew Jaynes b408cd37fb Docs: Standardize and clarify class DocBlocks for all of the Upgrade API classes. 
Standardizes summaries and tags for the following classes:

* `WP_Upgrader`
* `Plugin_Upgrader`
* `Theme_Upgrader`
* `Language_Pack_Upgrader`
* `Core_Upgrader`
* `File_Upload_Upgrader`
* `WP_Automatic_Updater`

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34499 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 14:53:46 +00:00
DrewAPicture cccd9356fe Docs: Clarify the file header for wp-admin/includes/class-wp-upgrader.php. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34498 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 14:43:02 +00:00
Drew Jaynes ad64ee866b Docs: Mark the optional `$upgrader` parameter as such and add a description in the DocBlock for `Language_Pack_Upgrader::async_upgrade()`. 
See [32655].

See #30989. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34497 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 14:34:15 +00:00
Scott Taylor 04bb8a07d7 Canonical/Rewrite: After [34492], fix `rel="canonical"` URLs for paginated posts. 
Props wonderboymusic, joostdevalk.
See #11694.


git-svn-id: https://develop.svn.wordpress.org/trunk@34496 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 14:30:00 +00:00
Drew Jaynes 02e1102a5b Docs: Add a summary, version, and parameter and return descriptions to the DocBlock for `WP_Filesystem_ftpsockets::get_contents()`. 
Also reverses the return types as `string` is expected, `false` is the outlier.

See [30978].

See #30989. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34495 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 14:21:50 +00:00
Scott Taylor 30554cccab After [34492], no need to import the global instance when we are, in fact, currently, that instance. 
See #11694.


git-svn-id: https://develop.svn.wordpress.org/trunk@34494 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 14:19:03 +00:00
Drew Jaynes 6ac2cb05e6 Docs: Add a summary, version, and parameter and return descriptions to the DocBlock for `WP_Filesystem_FTPext::get_contents()`. 
Also reverses the return types as `string` is expected, `false` is the outlier.

See [30978].

See #30989. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34493 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 14:10:47 +00:00
Scott Taylor 0111ecef55 Canonical/Rewrite: sanity check posts that are paged with `<!--nextpage-->`. Page numbers past the max number of pages are returning the last page of content and causing infinite duplicate content. 
Awesome rewrite bug: the `page` query var was being set to `'/4'` in `$wp`. When cast to `int`, it returns `0` (Bless you, PHP). `WP_Query` calls `trim( $page, '/' )` when setting its own query var. The few places that were checking `page`	before posts were queried now have sanity checks, so that these changes work without flushing rewrites.	

Adds/updates unit tests.

Props wonderboymusic, dd32.
See #11694.


git-svn-id: https://develop.svn.wordpress.org/trunk@34492 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 14:03:05 +00:00
Drew Jaynes c9093207df Docs: Add a summary, version, and `@access` tag to the property DocBlock for `Custom_Image_Header->updated`. 
See [14907] for where the property was initially introduced.
See [30187] for where the property was actually declared.

Props brentvr.
See #30224. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34491 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 13:38:03 +00:00
Drew Jaynes 00eab11256 Docs: Add a summary, version, and `@access` tag to the property DocBlock for `Custom_Background->updated`. 
See [13765] for where the property was initially introduced.
See [30186] for where the property was actually declared.

Props brentvr.
See #30224. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34490 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 13:33:18 +00:00
Drew Jaynes 72a968ca03 Docs: Add a summary, version, and `@access` tag to the property DocBlock for `WP_Locale->number_format`. 
See [5308] for where the property was initially introduced.
See [31083] for where the property was actually declared.

Props brentvr.
See #30224. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34489 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 13:25:55 +00:00
Dominik Schilling (ocean90) 15ee0a44b2 Customizer: Use the plural label for available menu item types. 
Fixes #33634.

git-svn-id: https://develop.svn.wordpress.org/trunk@34487 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 09:15:15 +00:00
Dominik Schilling (ocean90) 273bd1ed99 Edit Post: Add missing periods. 
See #31858.

git-svn-id: https://develop.svn.wordpress.org/trunk@34486 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 08:53:21 +00:00
Drew Jaynes 8e61ab359c Docs: Link up a hook reference with an inline `@see` tag in the return description for `get_locale()`. 
Missed in [34484].

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34485 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 05:50:49 +00:00
Drew Jaynes b91804e0bf Docs: Fix the summary for `get_locale()`. 
Also update the description to properly link up hook references with inline `@see` tags.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34484 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 05:49:07 +00:00
Drew Jaynes f85670cd36 Docs: Clarify the file header summary for wp-includes/l10n.php and add the version it was introduced. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34483 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 05:46:35 +00:00
Drew Jaynes 1810710798 Docs: Split the DocBlock summary for `__()` into a summary and description. 
Also, notate the default value for the optional `$domain` parameter.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34482 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 05:42:35 +00:00
Drew Jaynes 4d94ef47de Docs: Add a summary to the hook doc for the `nav_menu_item_args` filter, introduced in [34471]. 
Fixes #29417.


git-svn-id: https://develop.svn.wordpress.org/trunk@34481 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 05:08:36 +00:00
Scott Taylor 3a8f42bfe0 Post Thumbnails: In `get_the_post_thumbnail_url()`, return `false` instead of empty string when no URL is available. 
Fixes #33070.


git-svn-id: https://develop.svn.wordpress.org/trunk@34480 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 04:37:48 +00:00
Gary Pendergast e1fafc56d5 WPDB: When attempting to fall back to `ext/mysql` in `db_connect()`, return the result of the fall back. 
While it doesn't affect Core, we should also be passing the `$allow_bail` parameter, for anything that uses it differently.

Props markoheijnen, johnbillion.

Fixes #33105.



git-svn-id: https://develop.svn.wordpress.org/trunk@34478 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 04:29:40 +00:00
Scott Taylor b9ad7136d7 WP: after [34443], calling `get_queried_object()` messes up unit tests. We can just clone the `$post` prop and call it a day. 
Fixes #20226.


git-svn-id: https://develop.svn.wordpress.org/trunk@34476 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:53:39 +00:00
Scott Taylor 6ad1c1c380 Plugins: on the plugins admin screen, the "has been deleted" string needs a plural. 
Props jmayhak.
Fixes #33239.


git-svn-id: https://develop.svn.wordpress.org/trunk@34475 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:41:52 +00:00
Scott Taylor bab2316129 Date/Time: Add unit tests for `the_date()`. 
Props jubstuff.
Fixes #33750.


git-svn-id: https://develop.svn.wordpress.org/trunk@34474 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:33:21 +00:00
Scott Taylor 9d71ae4122 Edit Post: After [33666], separate the translation string for pages, avoiding HTML usage. 
Props ramiy.
Fixes #31858.


git-svn-id: https://develop.svn.wordpress.org/trunk@34473 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:27:26 +00:00
Scott Taylor d98165d1c3 Media Modal: move the translation strings for `insertIntoPost` and `uploadedToThisPost` to the `get_post_type_labels()` array as `insert_into_item` and `uploaded_to_this_item`. 
Props flixos90.
Fixes #33616.


git-svn-id: https://develop.svn.wordpress.org/trunk@34472 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:21:11 +00:00
Scott Taylor 0e81ac08de Nav Menus: Add a 'nav_menu_item_args' filter to `Walker_Nav_Menu::start_el()`. 
Props bjornjohansen.
Fixes #29417.


git-svn-id: https://develop.svn.wordpress.org/trunk@34471 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:16:44 +00:00
Scott Taylor 000b9e2fb3 Include fourth array parameter in return value doc block for `wp_get_attachment_image_src()`. 
Props kadamwhite.
Fixes #33905.


git-svn-id: https://develop.svn.wordpress.org/trunk@34470 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:13:08 +00:00
Scott Taylor c9c9e19260 After [34341], add translation strings. 
Props ramiy.
Fixes #31862.


git-svn-id: https://develop.svn.wordpress.org/trunk@34469 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 03:08:34 +00:00
Scott Taylor 21dad99c1b List Tables: add JS code to dynamically toggle the `disabled` attribute of the Bulk Actions dropdown and Apply button. 
Props wonderboymusic, pareshradadiya.
Fixes #31634.


git-svn-id: https://develop.svn.wordpress.org/trunk@34467 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 01:06:17 +00:00
Scott Taylor d92723a33f Users: in `WP_User::__unset()`, don't reset the deprecated prop `id` to `ID`. Still throw the deprecated notice. 
Update unit test.

Fixes #20043.


git-svn-id: https://develop.svn.wordpress.org/trunk@34466 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 00:48:23 +00:00
Scott Taylor c1c93f1e95 Widgets: when passing a string arg value to `dynamic_sidebar()`, don't reset `$index` when the arg's sanitized value matches the sanitized name of a sidebar. 
Adds unit test.

Props tyxla, fjarrett.
Fixes #23423.


git-svn-id: https://develop.svn.wordpress.org/trunk@34465 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 00:29:54 +00:00
Scott Taylor 9209546292 Recent Posts Widget: remove HTML fragment caching. The cache currently doesn't work cross-scheme and causes mixed content issues for links. The widget was written pre-`$split_the_query`, after which post objects can be served from the cache. 
Fixes #27565.


git-svn-id: https://develop.svn.wordpress.org/trunk@34464 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-24 00:16:16 +00:00
Scott Taylor 325a900519 Calendar Widget: remove the `title` attribute for days and replace with `aria-label`. Spruce up some of this nasty code. Delete unnecessary bits. 
Props wonderboymusic, elusiveunit, 5um17. 
Fixes #30297.


git-svn-id: https://develop.svn.wordpress.org/trunk@34463 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-23 23:56:05 +00:00
John Blackbourn 1ce18f6e95 Send a 500 HTTP response code when the server's PHP or MySQL checks fail. 
Fixes #33689
Props jeichorn


git-svn-id: https://develop.svn.wordpress.org/trunk@34462 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-23 21:56:32 +00:00
Scott Taylor a87b30da21 Comments: allow meta boxes for Discussion and Comments in extenuating circumstances. 
* Discussion: Post Type stops supporting comments, but comments and/or pings are open on a post. 
* Comments: Post is published or private, the post type has stopped supporting comments, but comments and/or pings are open on a post.

Currently, there is no way to toggle those settings off.

Props couturefreak, wonderboymusic, rachelbaker.
Fixes #28080.


git-svn-id: https://develop.svn.wordpress.org/trunk@34461 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-23 19:48:41 +00:00
Boone Gorges daadd27ed4 Allow `comment_exists()` to match based on GMT date. 
The `comment_date_gmt` field of the `wp_comments` table is indexed, which makes
`WHERE` matches against the field much faster than against the unindexed
`comment_date`. For bulk operations like data import, the speed difference can
be meaningful.

We continue to default to 'blog' for `$timezone`, to preserve compatibility
with existing uses.

Props apokalyptik.
Fixes #33871.

git-svn-id: https://develop.svn.wordpress.org/trunk@34460 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-23 18:15:39 +00:00
John Blackbourn 92748bb96e Add an entry for Cloudup to the list of oEmbed providers. 
See #26278


git-svn-id: https://develop.svn.wordpress.org/trunk@34459 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-23 15:59:42 +00:00
John Blackbourn d8a59791f0 Avoid a PHP notice if the `last_updated` property isn't present in a plugin's data from the Plugins API. 
Fixes #33024
Props icetee


git-svn-id: https://develop.svn.wordpress.org/trunk@34458 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-23 15:09:42 +00:00
Boone Gorges 4cbd2fbc55 Multisite: Don't limit site titles to 50 chars. 
This restriction dates from ye olden times, ie https://mu.trac.wordpress.org/changeset/1140.
It is no longer relevant.

Props chriscct7, theode.
Fixes #33973.

git-svn-id: https://develop.svn.wordpress.org/trunk@34455 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-23 14:23:13 +00:00
Boone Gorges e6b7c6b2d4 Bail early when invalid ID is passed to `get_comment_class()`. 
This helps to avoid PHP notices later in the function.

Props walterebert, dipesh.kakadiya, DrewAPicture.
Fixes #33947.

git-svn-id: https://develop.svn.wordpress.org/trunk@34454 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-23 14:08:47 +00:00
Scott Taylor fc3b7b20cd Links: the `esc_html()` additions in [34444] aren't very nice to screen reader `<span>`s. Revert those specific calls. 
See #14900.


git-svn-id: https://develop.svn.wordpress.org/trunk@34452 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-23 04:25:18 +00:00
Sergey Biryukov 6c63977ec2 Make the `'register_post_type_args'` filter introduced in [34242] available for built-in post types too. 
Props MikeSchinkel.
Fixes #17447.

git-svn-id: https://develop.svn.wordpress.org/trunk@34451 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 22:31:25 +00:00
Scott Taylor d416922cbf Remove some unused globals and/or their docs. 
See ##33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@34446 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 20:26:17 +00:00
Scott Taylor e2ce2d90fd After [34444​], `wp_get_shortlink()` can call `get_queried_object_id()` instead of using the `$wp_query` global. 
See #14900.


git-svn-id: https://develop.svn.wordpress.org/trunk@34445 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 20:08:49 +00:00
Scott Taylor e06ca91cd2 Links: use consistent late-escaping in some HTML link-generation functions: 
* `post_comments_feed_link()`
* `edit_post_link()`
* `edit_comment_link()`
* `edit_bookmark_link()`
* `rel_canonical()`

Props niallkennedy, wonderboymusic.
Fixes #14900.


git-svn-id: https://develop.svn.wordpress.org/trunk@34444 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 20:05:17 +00:00
Scott Taylor 23c82a270b PINGBACKS: After [34442], switch to `is_singular()` to check attachments and pages as well. 
See #20226.


git-svn-id: https://develop.svn.wordpress.org/trunk@34443 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 19:09:28 +00:00
Scott Taylor e774c95266 PINGBACKS: rather than sending the `X-Pingback` HTTP header on every single request for fun, perhaps only send it on single posts with pings open. 
See #20226.


git-svn-id: https://develop.svn.wordpress.org/trunk@34442 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 18:46:43 +00:00
Drew Jaynes 44006ff6a2 Docs: Actually, the subpackage for `Walker_Page` should be Template. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34441 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 15:08:10 +00:00
Drew Jaynes 1ea9111541 Docs: Add a file header to wp-includes/widgets/class-wp-widget-text.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Text`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34440 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 15:03:03 +00:00
Drew Jaynes fdc31fdf45 Docs: Add a file header to wp-includes/widgets/class-wp-widget-tag-cloud.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Tag_Cloud`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34439 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 15:01:24 +00:00
DrewAPicture 7aedd83be1 Docs: Add a file header to wp-includes/widgets/class-wp-widget-search.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Search`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34438 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 15:00:04 +00:00
Drew Jaynes 564fda0cf7 Docs: Add a file header to wp-includes/widgets/class-wp-widget-rss.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_RSS`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34437 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:56:14 +00:00
Drew Jaynes 6acc3944d3 Docs: Add a file header to wp-includes/widgets/class-wp-widget-recent-posts.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Recent_Posts`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34436 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:53:44 +00:00
Drew Jaynes c668d2295d Docs: Add a file header to wp-includes/widgets/class-wp-widget-recent-comments.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Recent_Comments`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34435 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:50:31 +00:00
Drew Jaynes 645c11475d Docs: Add a file header to wp-includes/widgets/class-wp-widget-pages.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Pages`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34434 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:48:54 +00:00
Drew Jaynes f78a3692d1 Docs: Add a file header to wp-includes/widgets/class-wp-widget-meta.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Meta`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34433 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:47:32 +00:00
Drew Jaynes 5697314993 Docs: Add a file header to wp-includes/widgets/class-wp-widget-links.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Links`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34432 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:46:07 +00:00
Drew Jaynes cd24102b98 Docs: Clarify the class DocBlock summary for `WP_Widget_Categories`. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34431 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:44:43 +00:00
Drew Jaynes 55d0267122 Docs: Add a file header to wp-includes/widgets/class-wp-widget-calendar.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Calendar`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34430 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:43:32 +00:00
Drew Jaynes eb53dd65c9 Docs: Add a missing file header to wp-includes/widgets/class-wp-widget-archives.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Widget_Archives`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34429 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:42:06 +00:00
Drew Jaynes e6f5ac781e Docs: Clarify the file header summary for wp-includes/widgets/class-wp-nav-menu-widget.php, introduced in [33746]. 
Also clarifies the class DocBlock summary and tags for `WP_Nav_Menu_Widget`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34428 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:40:27 +00:00
Drew Jaynes b63257accc Docs: Clarify the file header summary for wp-admin/includes/template-functions.php, introduced in [34241]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34427 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:36:43 +00:00
Drew Jaynes 015fb31933 Docs: Clarify the file header summary for wp-admin/includes/class-wp-internal-pointers.php, introduced in [34241]. 
Also adds a missing class DocBlock to `WP_Internal_Pointers`. See [19388].

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34426 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:34:55 +00:00
Drew Jaynes f05d86060b Docs: Clarify the file header summary for wp-admin/includes/class-walker-category-checklist.php, introduced in [34241]. 
Also clarifies the class DocBlock summary for `Walker_Category_Checklist`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34425 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:32:20 +00:00
Sergey Biryukov b9199cbcf7 Remove extra HTML from translatable strings in `WP_Comments_List_Table::get_views()`. 
Add a context and translator comments.

Props Tmeister for initial patch.
Fixes #31859.

git-svn-id: https://develop.svn.wordpress.org/trunk@34424 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:32:08 +00:00
Drew Jaynes 1de376cd8b Docs: Clarify the file header summary for wp-admin/includes/class-wp-post-comments-list-table.php, introduced in [34223]. 
Also clarifies the class DocBlock summary and tags for `WP_Post_Comments_List_Table`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34423 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:30:07 +00:00
Drew Jaynes b3b19607bd Docs: Clarify the class DocBlock summary for `WP_Screen`. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34422 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:27:38 +00:00
Drew Jaynes 6dfcbd07c2 Docs: Add a file header to wp-admin/includes/nav-menus.php. 
See [34168]. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34421 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:26:23 +00:00
Drew Jaynes fa11dc9c5b Docs: Clarify the file header summary and version for wp-includes/category-template.php. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34420 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:22:48 +00:00
Drew Jaynes a29f058e69 Docs: Clarify the file header summary and subpackage for wp-includes/category-functions.php, introduced in [34110]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34419 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:20:49 +00:00
Drew Jaynes 647fa83cc9 Docs: Clarify the file header for wp-includes/category.php. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34418 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:19:13 +00:00
Drew Jaynes a1595c5e85 Docs: Clarify the file header for wp-includes/class-walker-category-dropdown.php, introduced in [34110]. 
Also clarifies the class DocBlock and tags for `Walker_CategoryDropdown`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34417 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:02:32 +00:00
Drew Jaynes df9d6e6bcc Docs: Clarify the file header summary for wp-includes/class-walker-category.php, introduced in [34110]. 
Also clarifies the class DocBlock and tags for `Walker_Category`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34416 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 14:00:54 +00:00
Drew Jaynes 44c55211ce Docs: Clarify the file header subpackage for wp-includes/class-walker-page-dropdown.php, introduced in [34109]. 
Also clarifies the class DocBlock summary and tags for `Walker_PageDropdown`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34415 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:57:23 +00:00
Drew Jaynes ac613406d7 Docs: Clarify the file header summary for wp-includes/class-walker-page.php, introduced in [34109]. 
Also clarifies the class DocBlock summary for `Walker_Page`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34414 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:53:44 +00:00
Drew Jaynes 5d84cf9acc Docs: The Widgets subpackage is plural. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34413 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:47:09 +00:00
Drew Jaynes a74e215ac4 Docs: The Users subpackage is plural. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34412 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:45:48 +00:00
Drew Jaynes 00fe089f24 Docs: The Comments subpackage is plural. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34411 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:44:35 +00:00
Drew Jaynes 4e0b71390f Docs: The Comment API is singular. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34410 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:43:55 +00:00
Drew Jaynes 10278a11d3 Docs: The Comment API is singular. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34409 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:42:15 +00:00
Drew Jaynes c7dddad085 Docs: Clarify the file header summary for wp-includes/default-widgets.php, the top-level file for bringing in the core widget classes. 
Also adds inline DocBlocks for the widget classes now brought in via `require_once()` as of [33843].

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34408 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:35:41 +00:00
DrewAPicture 451534ad3b Docs: Clarify the file header summary for wp-includes/meta.php, the top-level file for the core Meta API. 
Also adds inline DocBlocks for files broken out in #33413 and now brought in via `require_once()`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34407 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:29:02 +00:00
Drew Jaynes 36885e252e Docs: Clarify the file header summary for wp-includes/meta-functions.php, introduced in [33761]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34406 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:26:47 +00:00
Drew Jaynes 55cffaf8df Docs: Add a file header to wp-includes/class-wp-meta-query.php, introduced in [33761]. 
Also clarifies the class DocBlock summary for `WP_Meta_Query`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34405 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:25:37 +00:00
Drew Jaynes 88b8113b8d Docs: Clarify the file header summary for wp-includes/taxonomy.php, the top-level file for the core Taxonomy API. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34404 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:22:38 +00:00
Drew Jaynes 1651d2cdf6 Docs: Clarify the file header summary for wp-includes/taxonomy-functions.php, introduced in [33760]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34403 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:19:59 +00:00
Drew Jaynes c8830724ce Docs: Add a file header to wp-includes/class-wp-tax-query.php, introduced in [33760]. 
Also clarifies the class DocBlock summary and description for `WP_Tax_Query`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34402 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:15:45 +00:00
Drew Jaynes 6e6e5cef2d Docs: Clarify the file header summary for wp-includes/post.php, the top-level file for the Post API. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34401 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:12:55 +00:00
Drew Jaynes 5318055735 Docs: Clarify the file header summary for wp-includes/post-functions.php, introduced in [33759]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34400 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:11:03 +00:00
Drew Jaynes 70d8db9520 Docs: Add a file header to wp-includes/class-wp-post.php, introduced in [33759]. 
Also clarifies the class DocBlock for `WP_Post`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34399 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:09:17 +00:00
Drew Jaynes 8d033c32d3 Docs: Clarify the file header summary for wp-includes/capabilities.php, which was broken up into multiple files in [33752]. 
Also adds inline DocBlocks for files now brought in via `require_once()` from this file.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34398 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:05:38 +00:00
Drew Jaynes 88a5649234 Docs: The User API is singular. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34397 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:02:25 +00:00
Drew Jaynes 7fbdd70bb0 Docs: Clarify the file header summary for wp-includes/capabilities-functions.php, introduced in [33752]. 
See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34396 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 13:00:48 +00:00
Drew Jaynes 76efb299c8 Docs: Add a file header to wp-includes/class-wp-role.php, introduced in [33752]. 
Also adjusts the class DocBlock for `WP_Role`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34395 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 12:58:11 +00:00
Drew Jaynes 9745959dc8 Docs: Add a file header to wp-includes/class-wp-roles.php, introduced in [33752]. 
Also adjusts the class DocBlock for `WP_Roles`.

See #33413. See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34394 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 12:53:15 +00:00
Drew Jaynes aabead83e6 Docs: The User API is singular. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34393 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 12:30:43 +00:00
Drew Jaynes 5e875e78f7 Docs: The Widget API is singular. 
See #33701.


git-svn-id: https://develop.svn.wordpress.org/trunk@34392 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 12:27:33 +00:00
Drew Jaynes 7193d1987e Docs: Update the file path in the duplicate hook comment for the `admin_xml_ns` hook in wp-admin/includes/template-functions.php. 
The hook was "moved" to the newly-created template-functions.php file via `svn cp` in [34241].

Props dimadin.
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34391 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 10:31:24 +00:00
Drew Jaynes 16e2ecda05 Docs: Add a missing access modifier to the declaration for the `WP_User::__unset()` magic method, introduced in [34380]. 
Also adds missing documentation to the DocBlock.

Fixes #20043.


git-svn-id: https://develop.svn.wordpress.org/trunk@34390 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 10:06:56 +00:00
Drew Jaynes 4c8a45fe8c Docs: Fix some syntactical issues and add missing parameter and return descriptions to the DocBlock for the `WP_User::__get()` magic method. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34389 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 10:01:01 +00:00
Drew Jaynes e0cef41f09 Docs: Fix some syntactical issues and add missing parameter and return descriptions to the DocBlock for the `WP_User::__isset()` magic method. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34388 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 09:58:05 +00:00
Drew Jaynes adc24d967b Docs: Add a file header to wp-includes/class-wp-user.php, created in [33752]. 
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34387 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 09:55:34 +00:00
Drew Jaynes 419bcab6d8 Docs: Add a changelog entry to `WP_Widget_Categories` for non-category support, added in [34376]. 
See #21165. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34386 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 09:49:39 +00:00
Drew Jaynes 7f2fe52e40 Docs: Add a file header to wp-includes/widgets/class-wp-widget-categories.php. 
See #33413.


git-svn-id: https://develop.svn.wordpress.org/trunk@34385 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 09:47:37 +00:00
Drew Jaynes 3696ffda21 Docs: Include 'wp-json' in the 4.4.0 changelog entry for the `subdirectory_reserved_names` filter. 
'wp-json' was appended to the reserved names list in [34375].

See #33789. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34384 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 09:43:40 +00:00
Scott Taylor 2ddc438111 List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used. 
Props wonderboymusic, Viper007Bond.
Fixes #21249.


git-svn-id: https://develop.svn.wordpress.org/trunk@34383 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 06:05:39 +00:00
Scott Taylor f543c65320 Dashboard: 2 submit buttons don't need names. 
Props garyc40, gizburdt.
Fixes #16345.


git-svn-id: https://develop.svn.wordpress.org/trunk@34382 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 05:44:45 +00:00
Scott Taylor 3a00b7c5f0 Widgets: add a `static` property to `WP_Widget_Calendar` to ensure that the `id` attribute is only output once. 
Props MikeHansenMe, wonderboymusic.
Fixes #24604.


git-svn-id: https://develop.svn.wordpress.org/trunk@34381 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 05:08:33 +00:00
Scott Taylor 0ad726ef4d Users: add `__unset` to `WP_User`. 
Adds unit tests.

Props johnjamesjacoby, MikeHansenMe, wonderboymusic.
Fixes #20043.


git-svn-id: https://develop.svn.wordpress.org/trunk@34380 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:59:35 +00:00
Scott Taylor 3f8f3ccff0 Users: clarify the docs for `WP_User::__set` to make it clear that it does save data in the database. 
Props johnpbloch.
Fixes #24255.


git-svn-id: https://develop.svn.wordpress.org/trunk@34379 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:55:50 +00:00
Scott Taylor 40b5ade751 After [34374], ensure that `$iptc` is defined. 
See #33772.


git-svn-id: https://develop.svn.wordpress.org/trunk@34378 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:48:25 +00:00
Scott Taylor fc1980e369 Sanitization: when falling back to (wait for it...) `$fallback` in `sanitize_html_class()`, sanitize it as well. 
Props MikeHansenMe, wonderboymusic.
Fixes #30967.


git-svn-id: https://develop.svn.wordpress.org/trunk@34377 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:30:11 +00:00
Scott Taylor 90fb9480d1 Widgets: Make the categories widget work with custom taxonomies. 
Props fonglh, wonderboymusic, DrewAPicture, kucrut.
Fixes #21165.


git-svn-id: https://develop.svn.wordpress.org/trunk@34376 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:24:53 +00:00
Scott Taylor 5dd7bec848 Multisite: as a precaution, make `wp-json` a reserved subdirectory name. 
Props austinginder.
Fixes #33789.


git-svn-id: https://develop.svn.wordpress.org/trunk@34375 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:20:41 +00:00
wonderboymusic 70b90490fd Media: In `wp_read_image_metadata()`, include IPTC Keywords when available in `$meta`. 
Adds unit test.

Props swissspidy, dbru, SteveHoneyNZ.
Fixes #33772.


git-svn-id: https://develop.svn.wordpress.org/trunk@34374 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:18:02 +00:00
Scott Taylor 1352d3473a Media: Add new functions, `get_the_post_thumbnail_url()` and `the_post_thumbnail_url()`. 
Adds unit tests.

Props dipesh.kakadiya, swissspidy, atomicjack.
Fixes #33070.


git-svn-id: https://develop.svn.wordpress.org/trunk@34373 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:14:15 +00:00
Scott Taylor 3c0ecff16e Media: Add a new function, `wp_get_attachment_image_url()`, which is a shortcut for `wp_get_attachment_image_src()` - same function signature, but returns just the URL based on `$size`. 
Adds unit test.

Props dipesh.kakadiya, swissspidy, sebastian.pisula.
Fixes #33878.


git-svn-id: https://develop.svn.wordpress.org/trunk@34372 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 04:12:44 +00:00
Scott Taylor 8a33422bfc Passwords: fix the markup on the Reset Password Form for `user-pass1` so the JavaScript operates properly. 
Props ldinclaux.
See #33892.
Fixes #33908.


git-svn-id: https://develop.svn.wordpress.org/trunk@34371 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 03:56:25 +00:00
Scott Taylor f9d1856805 Help Tabs: when returning help tabs, return them in order of priority, but also return the items in each priority in the order that they were added. 
Fixes #33941.


git-svn-id: https://develop.svn.wordpress.org/trunk@34370 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 03:36:27 +00:00
Scott Taylor e75c7651b2 HTTP: Add some new Cookie helper functions: 
* `wp_remote_retrieve_cookies( $response )`
* `wp_remote_retrieve_cookie( $response, $name )`
* `wp_remote_retrieve_cookie_value( $response, $name )`

Adds unit tests.

Props johnbillion.
Fixes #33711.


git-svn-id: https://develop.svn.wordpress.org/trunk@34369 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-22 03:13:13 +00:00
Drew Jaynes 782b9085c9 Docs: Move a duplicate hook comment accidentally left behind when its corresponding filter was relocated in [31765]. 
See #31443. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34368 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 23:12:35 +00:00
Konstantin Obenland 3cd12045d3 Introduce template functions for comment navigation: 
* `get_the_comments_navigation()` and `the_comments_navigation()` for navigation to the next and previous page of comments.
* `get_the_comments_pagination()` and `the_comments_pagination()` for paginated navigation between pages of comments. Uses `paginate_comments_links()`.

This reduces the need for themes to define their own sets of comment navigation
functions, like Twenty Fifteen and others.
Completes the navigation template tag API started in #29808 for posts.

Fixes #30589.



git-svn-id: https://develop.svn.wordpress.org/trunk@34367 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 16:31:19 +00:00
Scott Taylor c34e94b693 Docs: `is_main_query()`'s `_doing_it_wrong()` notice suggests using `WP_Query` statically (`WP_Query::is_main_query()`). Use an alternate syntax: `WP_Query->is_main_query()`, to not confuse. 
Props DrewAPicture, micahwave.
Fixes #25680.


git-svn-id: https://develop.svn.wordpress.org/trunk@34366 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 15:30:49 +00:00
Helen Hou-Sandi 9aaa278e02 Notices: Add styles for use against white backgrounds. 
These colored backgrounds can be accessed by adding the `.notice-alt` class to a notice.

There is also now a large version when using the `.notice-large` class, and a `.notice-title` class that is appropriate for headline text within a large notice.

props paulwilde, hugobaeta, melchoyce.
fixes #32244.


git-svn-id: https://develop.svn.wordpress.org/trunk@34365 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 15:25:37 +00:00
Scott Taylor 2b3347332e Meta Boxes: In `post_categories_meta_box()`, convert some spaces to tabs. 
Props miyauchi.
Fixes #33945.


git-svn-id: https://develop.svn.wordpress.org/trunk@34364 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 15:17:29 +00:00
Drew Jaynes 81e235444a Docs: The `$post` parameter has been passed to the `preview_post_link` since 4.0.0. 
Fixes a version mixup introduced in [34170].

Props dimadin.
See #24345.


git-svn-id: https://develop.svn.wordpress.org/trunk@34363 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 13:16:36 +00:00
Drew Jaynes f9e45047c1 Docs: Add a more complete return description for the array of data (or false) returned by `image_downsize()`. 
If not short-circuited via the `image_downsize` boolean filter, `image_downsize()` returns an array of data including the image URL, width, height, and whether the image size is intermediate, in that order. Otherwise, it returns false.

Fixes #30636.


git-svn-id: https://develop.svn.wordpress.org/trunk@34362 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 10:21:48 +00:00
Drew Jaynes 71ce9e812c Docs: Update the docs for `WP_User_Query->prepare_query()` for ordering by the value of the `include` argument, allowed since 4.1. 
Also adds a changelog entry for the additionally-accepted value.

Props danielbachhuber.
Fixes #33937.


git-svn-id: https://develop.svn.wordpress.org/trunk@34361 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-21 00:46:08 +00:00
John Blackbourn f80add733c Implement a 'Mine' link on post listing screens in the admin area for all users who have authored posts. This feature was previously only available to users who cannot edit other users' posts (namely Authors and Contributors). 
Props linuxologos, wonderboymusic
Fixes #19609


git-svn-id: https://develop.svn.wordpress.org/trunk@34360 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 17:27:35 +00:00
John Blackbourn ce126c10c0 Remove the ability to view the term editing screen for taxonomies with `show_ui` set to `false`. It is unexpected and unintended behaviour that this is allowed. 
If your plugin or site does rely on this behaviour, the arguments that are passed to `register_taxonomy()` should be altered so that `show_ui` is `true`, and arguments such as `show_in_menu` and `show_in_nav_menus` are false.

Fixes #33938


git-svn-id: https://develop.svn.wordpress.org/trunk@34359 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 17:10:55 +00:00
John Blackbourn dc7d968b19 Implement some more uses of `wp_login_url()` in places where wp-login.php is hard-coded. 
See #31495


git-svn-id: https://develop.svn.wordpress.org/trunk@34358 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 16:53:32 +00:00
John Blackbourn 2894423f19 Revisions are an exception when it comes to the editing UI. The `revision` post type cannot have its `show_ui` argument set to true because this allows access to the post type listing, creation, and editing UI, but `get_edit_post_link()` needs to return a URL for the editing UI for revisions as that's how the revisions UI works. 
Fixes #33763


git-svn-id: https://develop.svn.wordpress.org/trunk@34357 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 16:37:41 +00:00
Konstantin Obenland 050def62a3 Multisite: Make site status classes available to other elements. 
Fixes a regression introduced in [31181], where links to user's site would not
have a colored background based on their status anymore.

Fixed during WordCamp Switzerland Contributor Day.

Props psoluch.
Fixes #33595.



git-svn-id: https://develop.svn.wordpress.org/trunk@34356 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 12:52:56 +00:00
Drew Jaynes e3e91dbadc Docs: Add a description for the documented use of the `$wpdb` global in `_prime_comment_caches()`. 
See #8071. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34355 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 09:38:24 +00:00
Dominik Schilling (ocean90) ce1832f49c Login: Move the "Lost your password?" link into a separate string to reduce HTML tags in translation strings. 
Props ramiy.
Fixes #31870.

git-svn-id: https://develop.svn.wordpress.org/trunk@34354 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 09:10:59 +00:00
John Blackbourn fe80bec9ee Add `@since` docs for the `show_ui` argument in `register_post_type()`. 
See #33763


git-svn-id: https://develop.svn.wordpress.org/trunk@34353 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 09:04:21 +00:00
Dominik Schilling (ocean90) d3031d522e Upgrader: Avoid using an HTML tag in a translation string, add translator comments. 
Props ramiy for initial patch. 
Fixes #31860.

git-svn-id: https://develop.svn.wordpress.org/trunk@34352 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 08:58:27 +00:00
Dominik Schilling (ocean90) ed82c7fb75 Theme Compat: Remove two strings from `comments-popup.php`. 
`theme-compat/comments-popup.php` is a deprecated file. Instead of improving the strings in [34342] remove both superfluous paragraphs.

See #31867.

git-svn-id: https://develop.svn.wordpress.org/trunk@34351 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 08:48:28 +00:00
Sergey Biryukov 857be1862b Pass the current post object to `'page_attributes_meta_box_template'` action added in [34340]. 
Props DrewAPicture.
Fixes #33625.

git-svn-id: https://develop.svn.wordpress.org/trunk@34350 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 08:14:40 +00:00
Drew Jaynes 44c256e8d1 Docs: Use standardized vernacular in the hook doc summary for the `page_attributes_meta_box_template` filter, introduced in [34340]. 
See #33625.


git-svn-id: https://develop.svn.wordpress.org/trunk@34349 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 06:37:18 +00:00
Scott Taylor ed7d34cb13 Pass `false` as the 2nd argument to `class_exists()` to disable autoloading and to not cause problems for those who define `__autoload()`. 
Fixes #20523.


git-svn-id: https://develop.svn.wordpress.org/trunk@34348 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 03:51:55 +00:00
Scott Taylor 520a75f44e The `'get_sample_permalink_html'` filter​'s second parameter can be a post ID or a post object. This is confusing. We should pass the post ID and post object separately, for consistency with `'get_sample_permalink'` filter added in [34309]. 
Props SergeyBiryukov.	
Fixes #33927.


git-svn-id: https://develop.svn.wordpress.org/trunk@34347 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 03:25:45 +00:00
Scott Taylor 0082a438c5 MediaElement, update `wp-mediaelement.js`: 
* create a public `initialize` method on the `wp.mediaelement` namespace
* make it idempotent to prevent nasty side-effects caused by initializing media elements more than once

Props bradyvercher.	
Fixes #32423.


git-svn-id: https://develop.svn.wordpress.org/trunk@34346 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 03:16:23 +00:00
Scott Taylor 191233f2f9 WP Query: Avoid using HTML tags in translation strings, add translator strings. 
Props ramiy.	
Fixes #31868.


git-svn-id: https://develop.svn.wordpress.org/trunk@34345 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 03:03:28 +00:00
Scott Taylor df8f10ceff Plugins Admin: Avoid using HTML tags in translation strings, add translator strings. 
Props swissspidy, voldemortensen.	
Fixes #32269.


git-svn-id: https://develop.svn.wordpress.org/trunk@34344 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 03:00:57 +00:00
Scott Taylor 2161a20a68 WP Mail: Avoid using HTML tags in translation strings, add translator strings. 
Props ramiy.	
Fixes #31871.


git-svn-id: https://develop.svn.wordpress.org/trunk@34343 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 02:52:49 +00:00
Scott Taylor 067af6b9aa Theme Compat: Avoid using HTML tags in translation strings. 
Props ramiy.	
Fixes #31867.


git-svn-id: https://develop.svn.wordpress.org/trunk@34342 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 02:46:42 +00:00
Scott Taylor d624c118cb Plugin Editor: Avoid using HTML tags in translation strings and add context. 
Props ramiy.	
Fixes #31862.


git-svn-id: https://develop.svn.wordpress.org/trunk@34341 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 02:41:43 +00:00
Scott Taylor 2812cc9595 In `page_attributes_meta_box()`, add an action, `'page_attributes_meta_box_template'` to allow callbacks to be performed and HTML to be inserted after the title of the Template section. 
Props sgrant.	
Fixes #33625.


git-svn-id: https://develop.svn.wordpress.org/trunk@34340 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 02:39:31 +00:00
Scott Taylor a3cb19c52e MediaElement: apply monkey patch to include a PR which fixes a breaking change made upstream on a public interface: 
ccba8d0b6a

Props bradyvercher.
Fixes #33798.


git-svn-id: https://develop.svn.wordpress.org/trunk@34339 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 02:30:06 +00:00
Scott Taylor 2ccbc51d1e Login: apply the same margin to the top and bottom of the Back to {Blog} link. 
Props MikeHansenMe.
Fixes #29249.


git-svn-id: https://develop.svn.wordpress.org/trunk@34338 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 01:40:42 +00:00
Drew Jaynes 12ce04a95e Docs: Add descriptions for `$wp_query` global phpDoc references in wp-includes/query.php, partially documented in [32620]. 
Fixes #32139.


git-svn-id: https://develop.svn.wordpress.org/trunk@34337 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 00:04:48 +00:00
Scott Taylor b55de4e5f8 Feeds/Links: fix feed links for unattached attachments. 
Adds unit tests.

Props wonderboymusic, iworks.
Fixes #33693.


git-svn-id: https://develop.svn.wordpress.org/trunk@34336 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 20:09:05 +00:00
Scott Taylor 633b119fd3 Site Icon: for consistency, make all 4 HTML tags in `wp_site_icon()` self-closing. 
Props Corphi.
Fixes #33930.


git-svn-id: https://develop.svn.wordpress.org/trunk@34334 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 19:06:03 +00:00
Scott Taylor 0fdbaecbc6 Export: Add late-escaping to the contents of several nodes to avoid creating invalid XML and XML parse errors. 
Props westonruter.
Fixes #33732.


git-svn-id: https://develop.svn.wordpress.org/trunk@34333 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 18:52:27 +00:00
Scott Taylor f9c67159d4 Updates: in Theme list table, set `white-space` to `normal` for theme titles at appropriate breakpoint to avoid horizontal scrolling on small screens. 
Fixes #33831.


git-svn-id: https://develop.svn.wordpress.org/trunk@34332 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 18:42:45 +00:00
Scott Taylor d075313f5b Post List Table: 'All' view should be selected when appropriate for paged responses. 
Props kraftbj, wonderboymusic.
Fixes #33923.


git-svn-id: https://develop.svn.wordpress.org/trunk@34331 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 18:16:31 +00:00
Scott Taylor f4445d75c4 Add a `'menu_id'` argument to `wp_page_menu()` so that fallback menus have the same attributes as `wp_nav_menu()`. 
Props lancewillett, ocean90, wonderboymusic.
Fixes #31656.


git-svn-id: https://develop.svn.wordpress.org/trunk@34330 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 18:06:49 +00:00
Scott Taylor 1b550d9fb2 Reinstate [34327]. minus the unit test deletion. 
git-svn-id: https://develop.svn.wordpress.org/trunk@34329 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 17:48:18 +00:00
Scott Taylor 1e7832cc3b Revert [34327] to fix the accidental deletion of some unit tests. 
git-svn-id: https://develop.svn.wordpress.org/trunk@34328 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 17:45:46 +00:00
Scott Taylor 750c22abf8 Export: Add a filer, `'export_wp_filename'` to change the filename of the file to download when exporting. 
Props MikeHansenMe, wonderboymusic.
Fixes #29500.


git-svn-id: https://develop.svn.wordpress.org/trunk@34327 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 17:43:52 +00:00
Scott Taylor 3624366045 Export: allow Media to exported separately from other types. 
Props PhilipLakin.
Fixes #32230.


git-svn-id: https://develop.svn.wordpress.org/trunk@34326 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 16:46:17 +00:00
Scott Taylor d9b58bd4ac Admin: when toggling select/deselect "all" via JS - `:visible` needs to be bound to not toggle disabled inputs. 
Props tywayne.
Fixes #32309.


git-svn-id: https://develop.svn.wordpress.org/trunk@34325 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 16:40:34 +00:00
Scott Taylor 6d51562d72 Edit Post: When a post is "Pending Review", the "View Post" link should behave like ot does for drafts and generate a preview link. 
Props wpdev101.
Fixes #33541.


git-svn-id: https://develop.svn.wordpress.org/trunk@34324 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 16:31:38 +00:00
Scott Taylor 1ca6eee748 List Tables: Ensure that sorting indicators have layout when cell widths are being calculated. 
See #27743.


git-svn-id: https://develop.svn.wordpress.org/trunk@34323 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 16:14:59 +00:00
Scott Taylor 3cf5d40b9d Update Core: In `list_plugin_updates()`, when listing plugin updates related to `$core_update_version`, don't skip the check for `$info->tested`. 
Props MikeHansenMe.
Fixes #27883.


git-svn-id: https://develop.svn.wordpress.org/trunk@34322 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 16:09:40 +00:00
Konstantin Obenland bfc9fc4040 Menus: Remove whitespace between nav menu items. 
Avoids CSS hacks like floating menu items or setting the parent element's
font-size to 0 in order to display nav menus horizontally.

Props jjeaton.
Fixes #27762.



git-svn-id: https://develop.svn.wordpress.org/trunk@34321 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 11:39:39 +00:00
Weston Ruter 7bdfb4917f Customize: Flesh out phpdoc for `WP_Customize_Manager`. 
* Add missing phpdoc for class member variables.
* Supply missing `@return` descriptions from [34269].
* Add missing `@since` tags.
* Remove unused `$customized` protected class member variable.

Fixes #33898.


git-svn-id: https://develop.svn.wordpress.org/trunk@34320 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 06:39:09 +00:00
Scott Taylor 1c5f85e1a4 When applying the `'editable_slug'` filter, add a second param that provides more context. 
Props MikeSchinkel, jesin.
Fixes #31568.


git-svn-id: https://develop.svn.wordpress.org/trunk@34319 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 05:48:30 +00:00
Scott Taylor 09e3149b7a Add a `'clean_user_cache'` action at the end of `clean_user_cache()`. This is mighty similar to `clean_post_cache()`. 
Props elliott-stocks, wonderboymusic.
Fixes #31918.


git-svn-id: https://develop.svn.wordpress.org/trunk@34318 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-19 05:40:22 +00:00
Andrew Ozz 51078c32ec TinyMCE: remove `word-break: break-word;` from the default editor CSS to prevent irregular spaces when typing in RTL languages. 
Props iehsanir, alireza1375, ankit-k-gupta.
Fixes #33868.

git-svn-id: https://develop.svn.wordpress.org/trunk@34317 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 23:57:56 +00:00
Dominik Schilling (ocean90) 9b546efc1b Theme Compat: Remove commented out code. 
See #31867.

git-svn-id: https://develop.svn.wordpress.org/trunk@34316 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 21:37:09 +00:00
Dominik Schilling (ocean90) 7eb0317968 Don't use `<code>` in translation strings in `wp-admin/options.php`. 
Props ramiy, wonderboymusic.
Fixes #31861.

git-svn-id: https://develop.svn.wordpress.org/trunk@34315 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 20:42:20 +00:00
Dominik Schilling (ocean90) f5eacb71d6 Don't use `<code>` in translation strings in `wp-admin/includes/plugin.php`. 
Props ramiy.
Fixes #31856.

git-svn-id: https://develop.svn.wordpress.org/trunk@34314 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 20:28:23 +00:00
Dominik Schilling (ocean90) 0c642e4730 Use correct `@since` tag for `wp_ajax_generate_password()`. 
See #33450.

git-svn-id: https://develop.svn.wordpress.org/trunk@34313 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 20:18:22 +00:00
Scott Taylor 1299974e7d Profile: when clicking "Cancel" after clicking "Generate Password", request and generate a new password to present to the user. 
Props adamsilverstein, wonderboymusic.
Fixes #33450.


git-svn-id: https://develop.svn.wordpress.org/trunk@34312 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 20:13:34 +00:00
Scott Taylor a5f62a6cd5 Media: add a filter, `'mejs_settings'`, to allow devs to pass more config settings to MediaElement. 
Fixes #33506.


git-svn-id: https://develop.svn.wordpress.org/trunk@34311 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:59:43 +00:00
Boone Gorges 2fd81992bc Split the comment query. 
`WP_Comment_Query` now fetches comments in two stages: (1) a query to get the
IDs of comments matching the query vars, and (2) a query to populate the
objects corresponding to the matched IDs. The two queries are cached
separately, so that sites with persistent object caches will continue to have
complete cache coverage for normal comment queries.

Splitting the query allows our cache strategy to be more modest and precise, as
full comment data is only stored once per comment. It also makes it possible
to introduce logic for paginated threading, which is necessary to address
certain performance problems.

See #8071.
data is only stored once per comment, instead of along with

git-svn-id: https://develop.svn.wordpress.org/trunk@34310 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:27:39 +00:00
Scott Taylor b0b36bc346 Add a 'get_sample_permalink' filter. 
Props SergeyBiryukov, wenthemes, JustinSainton.
Fixes #22338.


git-svn-id: https://develop.svn.wordpress.org/trunk@34309 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:27:24 +00:00
Scott Taylor 27eb1ac0da Add `title_reply_before` and `title_reply_after` args to `comment_form()` to allow the "Leave a Reply" heading level to be changed. 
Props tyxla.
Fixes #33775.


git-svn-id: https://develop.svn.wordpress.org/trunk@34308 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:17:19 +00:00
Scott Taylor b862280404 After [34280], rename `menu_tag` arg to `container`, fix docs. 
Props DrewAPicture.
Fixes #10968.


git-svn-id: https://develop.svn.wordpress.org/trunk@34307 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:04:18 +00:00
Sergey Biryukov c43a62bde7 Include placeholder in translator comment. 
See #31863.

git-svn-id: https://develop.svn.wordpress.org/trunk@34306 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:02:37 +00:00
Sergey Biryukov 039ce30818 Include placeholder in translator comment. 
See #31864.

git-svn-id: https://develop.svn.wordpress.org/trunk@34305 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 19:00:20 +00:00
Sergey Biryukov 21a41c100f Include placeholders in translator comments. 
See #31857.

git-svn-id: https://develop.svn.wordpress.org/trunk@34304 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:57:01 +00:00
Scott Taylor 394e9ac21a Don't use HTML tags in translation strings in `edit-tags.php`. 
Props ramiy.
Fixes #31863.


git-svn-id: https://develop.svn.wordpress.org/trunk@34303 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:52:48 +00:00
Scott Taylor de077ac377 Don't use HTML tags in translation strings in `wp_ajax_add_user()`. 
Props ramiy.
Fixes #31864.


git-svn-id: https://develop.svn.wordpress.org/trunk@34302 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:50:04 +00:00
Sergey Biryukov 5cfdae8b2b Add missing translator comment after [34295]. 
See #31853.

git-svn-id: https://develop.svn.wordpress.org/trunk@34301 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:49:40 +00:00
Sergey Biryukov bcc165791f Add missing translator comments after [34294]. 
See #31852.

git-svn-id: https://develop.svn.wordpress.org/trunk@34300 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:45:40 +00:00
Sergey Biryukov 48c6d925cd Add missing translator comment after [34292]. 
See #31840.

git-svn-id: https://develop.svn.wordpress.org/trunk@34299 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:39:20 +00:00
Sergey Biryukov f90ee7b348 Add missing translator comments after [34293]. 
See #31851.

git-svn-id: https://develop.svn.wordpress.org/trunk@34298 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:38:54 +00:00
Scott Taylor 310dc18167 Don't use HTML tags in translation strings for "In Reply To" links for comments in the admin. 
Props ramiy.
Fixes #31857.


git-svn-id: https://develop.svn.wordpress.org/trunk@34297 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:35:16 +00:00
Scott Taylor 13889763af Don't use HTML tags in translation strings in `wp-admin/includes/update.php`. 
Props ramiy.
Fixes #31855.


git-svn-id: https://develop.svn.wordpress.org/trunk@34296 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:30:26 +00:00
Scott Taylor c10019ec70 Don't use `<code>` in translation strings in `edit-form-comment.php`. 
Props ramiy.
Fixes #31853.


git-svn-id: https://develop.svn.wordpress.org/trunk@34295 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:27:29 +00:00
Scott Taylor df149fddff Don't use `<code>` in translation strings in `options-general.php`. 
Props ramiy, SergeyBiryukov.
Fixes #31852.


git-svn-id: https://develop.svn.wordpress.org/trunk@34294 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:23:19 +00:00
Scott Taylor d2b4e0c728 Don't use `<code>` in translation strings in `wp-admin/includes/schema.php`. 
Props ramiy.
Fixes #31851.


git-svn-id: https://develop.svn.wordpress.org/trunk@34293 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:20:46 +00:00
Scott Taylor f6d2c30fa7 Network Setup: don't use `<code>` in translation strings in `wp-admin/network` files. 
Props ramiy.
Fixes #31840.


git-svn-id: https://develop.svn.wordpress.org/trunk@34292 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 18:17:26 +00:00
Aaron Jorbin 308179c232 Remove support for my-hacks.php 
For the last 10 years, my-hacks has been deprecated and has been throwing a deprecation notice. For the last six years, you haven't been able to enable my-hacks.php in the admin UI. That should be enough time to give developers notice. Plugins and themes seem like they might have staying power.

Fixes #33741
Props bobbingwide



git-svn-id: https://develop.svn.wordpress.org/trunk@34291 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 17:05:28 +00:00
Dominik Schilling (ocean90) 7f562dd69f Theme Editor: Change file descriptions of `header.php` and `footer.php`. 
`header.php` is now "Theme Header" and `footer.php` is "Theme Footer". This prevents a clash with other "Header" strings in the context of "Custom Header".

Props ramiy.
Fixes #32975.

git-svn-id: https://develop.svn.wordpress.org/trunk@34290 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 16:02:24 +00:00
Sergey Biryukov 7851406626 Network Admin: Include IDs for users and sites on their respective views. 
Props danielbachhuber, wonderboymusic.
Fixes #18661.

git-svn-id: https://develop.svn.wordpress.org/trunk@34289 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 15:57:47 +00:00
Drew Jaynes a176e78b64 Docs: Clarify the significance of the `$accepted_args` parameter value in the documentation for `add_filter()`. 
Adds a couple of examples to illustrate callbacks accepting a variable number of arguments.

Fixes #33862.


git-svn-id: https://develop.svn.wordpress.org/trunk@34288 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 14:52:37 +00:00
Drew Jaynes efc08d508e Docs: Fix some syntactical issues in the DocBlock for `set_query_var()`. 
Adds descriptions for the global `WP_Query` instance and the `$value` parameter.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34287 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 10:28:41 +00:00
Drew Jaynes e889c2e647 Docs: Fix some syntactical issues in the documentation for `get_queried_object_id()`. 
Adds descriptions for the global `WP_Query` instance and the return.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34286 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 10:26:58 +00:00
Drew Jaynes 4706230535 Docs: Fix some syntactical isses in the DocBlock for `get_queried_object()`. 
Also add descriptions for the return and the `WP_Query` global.

See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34285 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 10:20:07 +00:00
Drew Jaynes 572e3ddafb Docs: Add documentation to `get_query_var()` and `WP_Query::get()` for the optional `$default` argument, introduced in 3.9 in [27304]. 
Props swissspidy.
Fixes #33856.


git-svn-id: https://develop.svn.wordpress.org/trunk@34284 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 09:40:51 +00:00
Dion Hulse 6e6d026524 HTTP: Update the Root Certificate bundle. 
See #30434


git-svn-id: https://develop.svn.wordpress.org/trunk@34283 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 08:42:24 +00:00
Dion Hulse 09f373d582 Updates: FTP: Add a missing PCRE modifer in [34281]. 
See #16026, #33432x


git-svn-id: https://develop.svn.wordpress.org/trunk@34282 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 08:22:17 +00:00
Dion Hulse b114866bbf Updates: FTP/PemFTP Library: Remove the usage of deprecated regular expression functions (ereg replaced by PCRE). 
Props enshrined, aaroncampbell
Fixes #16026, #33432


git-svn-id: https://develop.svn.wordpress.org/trunk@34281 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 08:19:18 +00:00
Scott Taylor 30921dd396 Add an argument to `wp_page_menu()`, `'menu_tag'`, which defaults to `div` but can be overridden to allow HTML5 tags like `nav`. 
Props paulwilde, stebbiv, wonderboymusic.
Fixes #10968.


git-svn-id: https://develop.svn.wordpress.org/trunk@34280 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 06:06:17 +00:00
Weston Ruter d81ca65d4c Customize: Fix live previewing of menu changes on subdirectory installs. 
Props adamsilverstein, westonruter.
Fixes #33916.


git-svn-id: https://develop.svn.wordpress.org/trunk@34278 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 05:46:53 +00:00
Scott Taylor d5e5ca8e93 Comments: in `wp_rel_nofollow_callback()`, account for the fact that a link might already have a `rel` attribute. Currently, if a link already has a `rel`, it will result it duplicate attributes on the element with conflicting values. 
Adds unit tests.

Props junsuijin, wonderboymusic.
Fixes #9959.


git-svn-id: https://develop.svn.wordpress.org/trunk@34277 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 04:35:37 +00:00
Scott Taylor 50419ff08d List Tables: ensure that sortable list table column headers have the same padding/line-height as non-sortable headers. 
Props drozdz.
Fixes #27945.


git-svn-id: https://develop.svn.wordpress.org/trunk@34276 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 03:25:32 +00:00
Scott Taylor ace6756081 Editor: add `hide-if-no-js` class to `<td id="wp-word-count">`. Word Count no worky with no JavaScript. 
Props chriscct7.
Fixes #33379.


git-svn-id: https://develop.svn.wordpress.org/trunk@34275 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-18 02:31:23 +00:00
Scott Taylor c5963b8760 In `wp-comments-post.php`, sanity check a few of the comment inputs that are expected to be a string beford calling string-only functions on them. 
Props Kloon.
Fixes #23416.


git-svn-id: https://develop.svn.wordpress.org/trunk@34274 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 22:21:06 +00:00
Scott Taylor bec1944e44 Widgets: don't show a dropdown if there is only 1 taxonomy or zero taxonomies available to the Tag Cloud widget form. Don't output the widget if there are no terms in the selected taxonomy. 
Props GautamGupta, wonderboymusic.
Fixes #16125.


git-svn-id: https://develop.svn.wordpress.org/trunk@34273 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 22:10:46 +00:00
Scott Taylor 2a4eba2eb8 Canonical: redirect URLs that match an attachment masked on the wrong URL to the attachment link for the matched attachment. 
Props solarissmoke.
Fixes #19918.


git-svn-id: https://develop.svn.wordpress.org/trunk@34272 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 21:31:21 +00:00
Scott Taylor 73c1ac8b26 Posts List Table: Use a more robust technique for calculating `$total_items` so that pagination still appears when items are removed on the last page of results and `->max_num_pages` decreases. 
Props A5hleyRich.
Fixes #29870.


git-svn-id: https://develop.svn.wordpress.org/trunk@34271 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 21:17:16 +00:00
Boone Gorges 504deb52fc Lazy-load comment meta on single post pages. 
[34268] introduced cache priming for commentmeta, enabled by default. To
ensure performance on single post pages - where commentmeta is most likely
to cause performance issues - we disable up-front cache-priming. Instead, we
prime commentmeta caches for all comments in the loop the first time
`get_comment_meta()` is called on the page.

Props bradt, dd32, wonderboymusic, boonebgorges.
Fixes #16894.

git-svn-id: https://develop.svn.wordpress.org/trunk@34270 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 20:00:31 +00:00
Weston Ruter 5ea07785b3 Customize: Reduce peak memory usage by JSON-encoding settings and controls individually. 
When there are hundreds of settings and controls (e.g. nav menu items and widget instances) the resulting object that is JSON-encoded can become very large, and `wp_json_encode()` can consume a lot of memory to serialize it. By breaking down the serialization into multiple calls the peak memory usage can be kept in line.

Moves logic out of `wp-admin/customize.php` into the `WP_Customize_Manager` class with new methods:

 * `is_ios()`
 * `get_document_title_template()`
 * `get_preview_url()`/`set_preview_url()`
 * `get_return_url()`/`set_return_url()`
 * `get_autofocus()`/`set_autofocus()`
 * `customize_pane_settings()`

Includes unit tests for these methods, for which the logic was formerly untestable in `customize.php`.

Fixes #33898.


git-svn-id: https://develop.svn.wordpress.org/trunk@34269 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 19:41:35 +00:00
Boone Gorges 12329f5ef8 Prime comment meta caches in `WP_Comment_Query`. 
The new 'update_comment_meta_cache' parameter, which defaults to `true`, can
be used to disable this behavior.

`update_comment_cache()` has been updated to support an `$update_meta_cache`
parameter, which also updates to true; this matches the pattern we use for
priming post caches.

See #16894.

git-svn-id: https://develop.svn.wordpress.org/trunk@34268 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 19:29:46 +00:00
Boone Gorges b08a176488 Tell the `insert_user_meta` filter whether user is being updated. 
`insert_user_meta` was introduced in [33708]. This changeset passes the
`$update` parameter to it.

Props tharsheblows, geminorum.
Fixes #31549.

git-svn-id: https://develop.svn.wordpress.org/trunk@34266 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 14:34:49 +00:00
Helen Hou-Sandi 3531c0bc10 Superglobals: Revert [34059] until further notice. 
see #33837.


git-svn-id: https://develop.svn.wordpress.org/trunk@34265 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 12:32:20 +00:00
Drew Jaynes 8c65cfc7f4 Docs: Add a reminder to the DocBlock description for `add_query_arg()` mentioning that the output is not escaped by default. 
Props brentvr for the initial patch. (first props!)
See #33912. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34264 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 09:38:56 +00:00
Sergey Biryukov f9ff998d01 Revert unintended change from [34262]. 
See #33910.

git-svn-id: https://develop.svn.wordpress.org/trunk@34263 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 09:08:14 +00:00
Sergey Biryukov 45610f9464 Docs: Expand the DocBlock for `get_default_post_to_edit()`. 
Props rabmalin.
Fixes #33910.

git-svn-id: https://develop.svn.wordpress.org/trunk@34262 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 09:05:44 +00:00
Scott Taylor 8861e38966 Media: Ensure that HTML5 captions apply the `'img_caption_shortcode_width'`. 
Props joemcgill.
Fixes #31053.


git-svn-id: https://develop.svn.wordpress.org/trunk@34261 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 06:03:11 +00:00
Scott Taylor 189bc9b5aa Media: In `wp_ajax_send_attachment_to_editor()`, the fallback logic for `$html` should be tucked into an `else` statement so it isn't run needlessly and overwritten. 
Props tychay.
Fixes #32072.


git-svn-id: https://develop.svn.wordpress.org/trunk@34260 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 05:54:56 +00:00
Scott Taylor 337c87e7c7 Media: In `get_image_send_to_editor()`, allow a custom value for `$rel`. 
Props tychay.
Fixes #32074.


git-svn-id: https://develop.svn.wordpress.org/trunk@34259 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 05:45:31 +00:00
Scott Taylor 2e7277b733 Media: In `wp_prepare_attachment_for_js()`, don't call `file_exists()` and `filesize()` to retrieve `$bytes` if the data is already present in `$meta`. This is how the same code in `attachment_submitbox_metadata()` already works. 
Props polevaultweb.
Fixes #33214.


git-svn-id: https://develop.svn.wordpress.org/trunk@34258 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 05:02:52 +00:00
Scott Taylor 79656b5fdd Uploader: Fire 'wp_handle_upload' in `wp_upload_bits()`. Thusly, the filter in `wp_xmlrpc_server::mw_newMediaObject()` is redundant. 
Props dllh.
Fixes #33539.


git-svn-id: https://develop.svn.wordpress.org/trunk@34257 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 04:46:00 +00:00
Scott Taylor a1805ecada Media List Table: remove the counts from the "views" portion of the toolbar, which are inconsistent with grid view. Also reduces complexity and removes potentially expensive count query. 
Related to the toolbar view, remove the `wp_admin_canonical_url()` action in grid mode. Grid views that result from links from the list table view are lenses into the library and need to be indicated as such vs being a full attachment query.

Fixes #29744.


git-svn-id: https://develop.svn.wordpress.org/trunk@34256 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 02:29:22 +00:00
Scott Taylor 25710ecc67 In `wp_mime_type_icon()`, the length of the `$wilds` array varies depending on what is passed as `$mime`. Loop over `$wilds` instead of arbitrarily checking `$wilds[0]`. 
Adds unit tests.

Fixes #33012.



git-svn-id: https://develop.svn.wordpress.org/trunk@34255 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 00:36:12 +00:00
Scott Taylor 45c606576c Media JS: ensure that `wp.media.frame` (a static reference to the "current" `Frame`) is reset when a cached frame is opened. 
Fixes #33458.


git-svn-id: https://develop.svn.wordpress.org/trunk@34254 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 00:09:40 +00:00
Sergey Biryukov 54835433c5 Docs: Expand the `$comment_approved` argument description for `'comment_post'` action. 
Props cfinke.
Fixes #33903.

git-svn-id: https://develop.svn.wordpress.org/trunk@34253 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 22:29:15 +00:00
Boone Gorges 03ec7cc107 Improve consistency of comment notification callback signatures. 
Both `wp_new_comment_notify_moderator()` and `wp_new_comment_notify_postauthor()`
now accept a single argument: `$comment_ID`.

Props SergeyBiryukov.
Fixes #33587.

git-svn-id: https://develop.svn.wordpress.org/trunk@34252 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 22:25:07 +00:00
Boone Gorges de7c9b6015 Move new user notification emails to `add_action()` callbacks. 
When a new user is created in various places throughout the interface,
notifications are sent to the site admin and the new user. Previously, these
notifications were fired through direct calls to `wp_new_user_notification()`,
making it difficult to stop or modify the messages.

This changeset introduces a number of new action hooks in place of direct calls
to `wp_new_user_notification()`, and hooks the new wrapper function
`wp_send_new_user_notifications()` to these hooks.

Props dshanske, thomaswm, boonebgorges.
Fixes #33587.

git-svn-id: https://develop.svn.wordpress.org/trunk@34251 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 22:18:33 +00:00
Boone Gorges d26b868870 Don't notify post authors about spam comments. 
[34106] moved post author notification to a hook, and in the process, missed
the 'spam' check. This changeset restores that check.

To make unit testing easier, the notification callbacks have been refactored
to return values: false when various conditions aren't met (eg, approved
comments should not trigger moderation emails), and the return value of the
`wp_notify_*()` function otherwise.

Props cfinke, kraftbj.
See #33587.

git-svn-id: https://develop.svn.wordpress.org/trunk@34250 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 21:59:16 +00:00
Sergey Biryukov 7c9c635a04 Add a missing Oxford comma on Export screen. 
Props juhise.
Fixes #33906.

git-svn-id: https://develop.svn.wordpress.org/trunk@34249 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 21:33:29 +00:00
Boone Gorges c5f34cb4d0 Throw a notice when an invalid tax is passed to `wp_insert_post()`. 
Props jdgrimes.
Fixes #25477.

git-svn-id: https://develop.svn.wordpress.org/trunk@34248 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-16 19:24:51 +00:00